Re: [PATCH v2 00/14] Add support for parameterized events from sysfs

On Fri, Aug 15, 2014 at 12:26:09AM -0700, Sukadev Bhattiprolu wrote: From: Cody P Schafer d...@codyps.com What this patchset does: - the first patch (override sysfs in tools/perf via SYSFS_PATH) was sent out previously, but needed a resend anyhow. Having it is useful for testing the

Re: [PATCH v3 00/10] Add support for parameterized events from sysfs

] - [Jiri Olsa] Changed the event parameters are specified. If event file specifes 'param=val' make the usage 'param=123' rather than 'val=123'. (patch 1,2/10) - Shortened event names using PHYS and VCPU (patch 4/10) - Print help message if invalid parameter

Re: [PATCH v5 1/1] powerpc/perf: Adjust callchain based on DWARF debug info

On Tue, Sep 23, 2014 at 12:33:45AM +0300, Aaro Koskinen wrote: Hi, On Wed, Jun 25, 2014 at 08:49:03AM -0700, Sukadev Bhattiprolu wrote: powerpc/perf: Adjust callchain based on DWARF debug info When saving the callchain on Power, the kernel conservatively saves excess entries in the

Re: [PATCH v4 01/10] tools/perf: support parsing parameterized events

On Wed, Sep 24, 2014 at 12:27:15PM -0700, Sukadev Bhattiprolu wrote: From: Cody P Schafer c...@linux.vnet.ibm.com Enable event specification like: pmu/event_name,param1=0x1,param2=0x4/ Assuming that /sys/bus/event_source/devices/pmu/events/event_name Contains something

Re: [PATCH v4 01/10] tools/perf: support parsing parameterized events

On Thu, Sep 25, 2014 at 07:25:20PM -0700, Sukadev Bhattiprolu wrote: Jiri Olsa [jo...@redhat.com] wrote: | On Wed, Sep 24, 2014 at 12:27:15PM -0700, Sukadev Bhattiprolu wrote: | From: Cody P Schafer c...@linux.vnet.ibm.com | | Enable event specification like: | |pmu/event_name

Re: [PATCH 0/3] powerpc/perf: Enable linking with libunwind

On Wed, Mar 05, 2014 at 08:41:56PM -0800, Sukadev Bhattiprolu wrote: When we try to create backtraces (call-graphs) with the perf tool perf record -g /tmp/sprintft we get backtraces with duplicate arcs for sprintft[1]: 14.61% sprintft libc-2.18.so [.] __random

Re: [PATCH 3/3] perf: Use 64-bit value when comparing sample_regs

On Thu, Mar 06, 2014 at 12:33:32PM +0100, Gabriel Paubert wrote: On Thu, Mar 06, 2014 at 09:44:47AM +, David Laight wrote: From: Sukadev Bhattiprolu When checking whether a bit representing a register is set in sample_regs, a 64-bit mask, use 64-bit value (1LL). Signed-off-by:

Re: [PATCH 1/1] powerpc/perf: Adjust callchain based on DWARF debug

On Tue, May 20, 2014 at 06:26:44PM -0700, Sukadev Bhattiprolu wrote: SNIP + * + * The value in LR is only needed when it holds a return address. If the + * return address is on the stack, we should ignore the LR value. + * + * Further, when the return address is in the LR, if a new frame

Re: [PATCH 1/1] powerpc/perf: Adjust callchain based on DWARF debug

On Tue, May 20, 2014 at 06:26:44PM -0700, Sukadev Bhattiprolu wrote: SNIP + * TODO: + * Rather than returning an index into the callchain and have the + * caller skip that entry, we could modify the callchain in-place + * by putting a PERF_CONTEXT_IGNORE marker in the affected entry.

Re: [PATCH v4 1/2]: Allow architectures to skip a callchain entry

On Thu, Jun 05, 2014 at 08:21:09PM -0700, Sukadev Bhattiprolu wrote: SNIP index 7409ac8..3f97cf2 100644 --- a/tools/perf/util/machine.c +++ b/tools/perf/util/machine.c @@ -1288,8 +1288,10 @@ static int machine__resolve_callchain_sample(struct machine *machine, { u8 cpumode =

Re: [PATCH v5 1/1] powerpc/perf: Adjust callchain based on DWARF debug info

On Tue, Jun 24, 2014 at 05:00:52PM -0700, Sukadev Bhattiprolu wrote: [PATCH v5 1/1] powerpc/perf: Adjust callchain based on DWARF debug info superflous ^^^ When saving the callchain on Power, the kernel conservatively saves excess entries in the callchain. A few of these entries are needed

Re: [PATCH 3/4] perf/POWER7: Make event translations available in sysfs

On Wed, Nov 07, 2012 at 11:19:28AM -0800, Sukadev Bhattiprolu wrote: SNIP +struct perf_pmu_events_attr { + struct device_attribute attr; + u64 id; +}; + +extern ssize_t power_events_sysfs_show(struct device *dev, + struct device_attribute *attr, char

Re: [PATCH 4/4] perf: Create a sysfs entry for Power event format

On Wed, Nov 07, 2012 at 11:19:52AM -0800, Sukadev Bhattiprolu wrote: From bafc551c31ce23c1cba0b75d23de6c46aba90f26 Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Tue, 6 Nov 2012 16:30:28 -0800 Subject: [PATCH 4/4] perf: Create a sysfs entry for Power

Re: [PATCH 3/4] perf/POWER7: Make event translations available in sysfs

On Wed, Nov 14, 2012 at 10:20:45AM -0800, Sukadev Bhattiprolu wrote: Jiri Olsa [jo...@redhat.com] wrote: | On Wed, Nov 07, 2012 at 11:19:28AM -0800, Sukadev Bhattiprolu wrote: | | SNIP | | +struct perf_pmu_events_attr { | + struct device_attribute attr; | + u64 id

Re: [PATCH 3/4] perf/POWER7: Make event translations available in sysfs

On Fri, Nov 16, 2012 at 11:35:37AM -0800, Sukadev Bhattiprolu wrote: Jiri Olsa [jo...@redhat.com] wrote: | | Can we remove the assumption that the event id is a generic event that | has PERF_COUNT_HW_ prefix and also let the architectures pass in a show | function ? This would allow

Re: [PATCH 2/5] perf: Make EVENT_ATTR and EVENT_PTR global

On Tue, Dec 18, 2012 at 11:28:02PM -0800, Sukadev Bhattiprolu wrote: Rename EVENT_ATTR() and EVENT_PTR() PMU_EVENT_ATTR() and PMU_EVENT_PTR(). Make them global so they are available to all architectures. Further to allow architectures flexibility, have PMU_EVENT_PTR() pass in the variable

Re: [PATCH 6/6][v3] perf: Document the ABI of perf sysfs entries

On Tue, Jan 15, 2013 at 03:57:59PM -0300, Arnaldo Carvalho de Melo wrote: Em Wed, Jan 09, 2013 at 05:07:03PM -0800, Sukadev Bhattiprolu escreveu: [PATCH 6/6][v3] perf: Document the ABI of perf sysfs entries This patchset addes two new sets of files to sysfs: - generic and

Re: [PATCH 6/6][v3] perf: Document the ABI of perf sysfs entries

On Wed, Jan 16, 2013 at 10:58:16AM -0800, Sukadev Bhattiprolu wrote: Jiri Olsa [jo...@redhat.com] wrote: | On Tue, Jan 15, 2013 at 03:57:59PM -0300, Arnaldo Carvalho de Melo wrote: | Em Wed, Jan 09, 2013 at 05:07:03PM -0800, Sukadev Bhattiprolu escreveu: | [PATCH 6/6][v3] perf: Document

Re: [PATCH] perf: Fix PMU format parsing test failure

, long to) if (!to) to = from; - memset(bits, 0, BITS_TO_LONGS(PERF_PMU_FORMAT_BITS)); + memset(bits, 0, BITS_TO_BYTES(PERF_PMU_FORMAT_BITS)); for (b = from; b = to; b++) set_bit(b, bits); oops, nice catch! Acked-by: Jiri Olsa jo

Re: [PATCH] perf: Fix compile warnings in tests/attr.c

On Fri, Jan 18, 2013 at 05:30:52PM -0800, Sukadev Bhattiprolu wrote: From 4d266e5040c33103f5d226b0d16b89f8ef79e3ad Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Fri, 18 Jan 2013 11:14:28 -0800 Subject: [PATCH] perf: Fix compile warnings in tests/attr.c

Re: [PATCH] perf: Fix compile warnings in tests/attr.c

On Mon, Jan 21, 2013 at 01:38:23PM -0800, Sukadev Bhattiprolu wrote: Jiri Olsa [jo...@redhat.com] wrote: | On Fri, Jan 18, 2013 at 05:30:52PM -0800, Sukadev Bhattiprolu wrote: SNIP __u64 is 'unsigned long long' on x86 and PRIu64 is 'llu' which is fine. __u64 is 'unsigned long' on Power

Re: [PATCH 6/6][v3] perf: Document the ABI of perf sysfs entries

On Fri, Jan 18, 2013 at 09:46:54AM -0800, Sukadev Bhattiprolu wrote: Jiri Olsa [jo...@redhat.com] wrote: SNIP + +Contact: Linux kernel mailing list linux-ker...@vger.kernel.org + Linux Powerpc mailing list linuxppc-...@ozlabs.org + +Description: POWER-systems specific

Re: [PATCH v5 1/4] tools/perf: support parsing parameterized events

On Tue, Dec 02, 2014 at 06:09:35PM -0800, Sukadev Bhattiprolu wrote: From: Cody P Schafer c...@linux.vnet.ibm.com Enable event specification like: pmu/event_name,param1=0x1,param2=0x4/ Assuming that /sys/bus/event_source/devices/pmu/events/event_name Contains something

Re: [PATCH v5 1/4] tools/perf: support parsing parameterized events

On Fri, Dec 05, 2014 at 06:05:26PM -0500, Cody P Schafer wrote: On Thu, Dec 4, 2014 at 7:44 AM, Jiri Olsa jo...@redhat.com wrote: On Tue, Dec 02, 2014 at 06:09:35PM -0800, Sukadev Bhattiprolu wrote: From: Cody P Schafer c...@linux.vnet.ibm.com Enable event specification like

Re: [PATCH v5 1/4] tools/perf: support parsing parameterized events

On Sat, Dec 06, 2014 at 11:37:24PM -0800, Sukadev Bhattiprolu wrote: Jiri Olsa [jo...@redhat.com] wrote: | anyway we could assign directly to the param term name as you do, | but I think we just need to mark the term as parametrized, like: | | in /sys/bus/event_source/devices/pmu/events

Re: [PATCH v6 1/4] tools/perf: support parsing parameterized events

On Sun, Dec 21, 2014 at 11:49:24PM -0800, Sukadev Bhattiprolu wrote: SNIP + } switch (format-value) { case PERF_PMU_FORMAT_VALUE_CONFIG: @@ -592,11 +629,16 @@ static int pmu_config_term(struct list_head *formats, } /* - * XXX If we ever decide to go

Re: [PATCH v6 3/4] perf Documentation: add event parameters

On Sun, Dec 21, 2014 at 11:49:26PM -0800, Sukadev Bhattiprolu wrote: From: Cody P Schafer c...@linux.vnet.ibm.com Event parameters are a basic way for partial events to be specified in sysfs with per-event names given to the fields that need to be filled in when using a particular event.

Re: [PATCH v6 4/4] tools/perf: Document parameterized and symbolic events

On Sun, Dec 21, 2014 at 11:49:27PM -0800, Sukadev Bhattiprolu wrote: From: Cody P Schafer c...@linux.vnet.ibm.com Changelog[v6]: - [Sukadev Bhattiprolu]: Update documentation of perf-list and perf-record; Added documentation for perf-stat. CC: Haren Myneni hb...@us.ibm.com

Re: [PATCH v6 3/4] perf Documentation: add event parameters

On Mon, Dec 22, 2014 at 11:34:36AM -0800, Sukadev Bhattiprolu wrote: Jiri Olsa [jo...@redhat.com] wrote: | On Sun, Dec 21, 2014 at 11:49:26PM -0800, Sukadev Bhattiprolu wrote: | From: Cody P Schafer c...@linux.vnet.ibm.com | + In the case of the last example, a value replacing

Re: [PATCH v6 1/4] tools/perf: support parsing parameterized events

On Mon, Dec 22, 2014 at 11:30:45AM -0800, Sukadev Bhattiprolu wrote: Jiri Olsa [jo...@redhat.com] wrote: | On Sun, Dec 21, 2014 at 11:49:24PM -0800, Sukadev Bhattiprolu wrote: | | SNIP | | + } | |switch (format-value) { |case PERF_PMU_FORMAT_VALUE_CONFIG: | @@ -592,11

Re: [PATCH v7 0/4] Add support for parametrized events

On Mon, Jan 26, 2015 at 05:43:03PM -0800, Sukadev Bhattiprolu wrote: SNIP Cody P Schafer (6): perf: provide sysfs_show for struct perf_pmu_events_attr perf: add PMU_EVENT_ATTR_STRING() helper powerpc/perf/hv-24x7: parse catalog and populate sysfs with events

Re: [PATCH v7 0/4] Add support for parametrized events

On Wed, Jan 28, 2015 at 11:54:38AM +1100, Michael Ellerman wrote: On Tue, 2015-01-27 at 11:02 +0100, Jiri Olsa wrote: On Mon, Jan 26, 2015 at 05:43:03PM -0800, Sukadev Bhattiprolu wrote: SNIP Cody P Schafer (6): perf: provide sysfs_show for struct perf_pmu_events_attr

Re: [PATCH v6 1/7] perf: provide sysfs_show for struct perf_pmu_events_attr

On Sun, Dec 21, 2014 at 11:48:46PM -0800, Sukadev Bhattiprolu wrote: From: Cody P Schafer c...@linux.vnet.ibm.com (struct perf_pmu_events_attr) is defined in include/linux/perf_event.h, but the only show for it is in x86 and contains x86 specific stuff. Make a generic one for those of us

Re: [PATCH v6 2/4] tools/perf: extend format_alias() to include event parameters

'starting_index'. Changelog[v5] [Jiri Olsa, Peter Zijlstra] Use '$' to prefix parameterized events. Changelog[v4] [Jiri Olsa] If the parameter for an event in sysfs is 'param=val', have perf-list show the event as 'param=?' rather than 'val=?'. CC: Haren Myneni hb

Re: [PATCH v6 2/4] tools/perf: extend format_alias() to include event parameters

'starting_index'. Changelog[v5] [Jiri Olsa, Peter Zijlstra] Use '$' to prefix parameterized events. Changelog[v4] [Jiri Olsa] If the parameter for an event in sysfs is 'param=val', have perf-list show the event as 'param=?' rather than 'val=?'. CC: Haren Myneni hb

Re: [PATCH v6 1/4] tools/perf: support parsing parameterized events

Enable event specification like: pmu/event_name,param1=0x1,param2=0x4/ Assuming that /sys/bus/event_source/devices/pmu/events/event_name Contains something like param2=?,bar=1,param1=? Changelog[v6]: [Jiri Olsa] Add a check to make sure that sysfs entries

Re: [PATCH 1/3] perf/e6500: Make event translations available in sysfs

On Mon, Feb 09, 2015 at 11:07:38AM +0100, Ingo Molnar wrote: * Peter Zijlstra pet...@infradead.org wrote: On Fri, Feb 06, 2015 at 04:43:54PM -0600, Tom Huynh wrote: arch/powerpc/perf/e6500-events-list.h | 289 ++ That's a lot of events to stuff in

Re: [PATCH v7 0/4] Add support for parametrized events

' ... Changelog[v7] [Jiri Olsa] Nit: Add braces for clarity. [Jiri Olsa] Add a check to make sure that sysfs entries have with parameters exactly match '=?'. for the patchset: Acked-by: Jiri Olsa jo...@kernel.org thanks, jirka ___ Linuxppc-dev

Re: [RFC][PATCH 4/4] perf: Create aliases for PMU events

On Fri, May 01, 2015 at 12:05:41AM -0700, Sukadev Bhattiprolu wrote: SNIP + +static int pmu_add_cpu_aliases(char *cpustr, void *data) +{ + struct list_head *head = (struct list_head *)data; + struct perf_pmu_alias *alias; + int i; + struct perf_pmu_event *events_table,

Re: 'perf upgrade' (was: Re: [PATCH v9 00/11] Add support for JSON event files.)

On Wed, Apr 15, 2015 at 01:50:42PM -0700, Sukadev Bhattiprolu wrote: SNIP | | - to blindly follow some poorly constructed vendor format with no |high level structure, that IMHO didn't work very well when OProfile |was written, and misrepresenting it as 'symbolic event names'. |

Re: 'perf upgrade' (was: Re: [PATCH v9 00/11] Add support for JSON event files.)

On Fri, Apr 17, 2015 at 01:09:54PM -0700, Andi Kleen wrote: On Fri, Apr 17, 2015 at 05:31:26PM +0200, Jiri Olsa wrote: On Wed, Apr 15, 2015 at 01:50:42PM -0700, Sukadev Bhattiprolu wrote: SNIP | | - to blindly follow some poorly constructed vendor format with no |high

Re: 'perf upgrade' (was: Re: [PATCH v9 00/11] Add support for JSON event files.)

On Wed, Apr 15, 2015 at 01:50:42PM -0700, Sukadev Bhattiprolu wrote: SNIP | | - to add an ABI to support those vendor files | | And those are IMHO five good technical reasons to disagree with your | approach. | | My suggestion to resolve the technical objections and lift the NAK

Re: [PATCH V14 00/14] perf, tools: Add support for PMU events in JSON format

continue to build) Thanks to input from Andi Kleen, Jiri Olsa, Namhyung Kim and Ingo Molnar. These patches are available from: https://github.com:sukadev/linux.git Branch Description

Re: [PATCH v14 15/19] perf, tools: Support long descriptions with perf list

On Thu, Jun 04, 2015 at 11:27:23PM -0700, Sukadev Bhattiprolu wrote: SNIP --- tools/perf/builtin-list.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c index 3f058f7..d0f7a18 100644 ---

Re: [PATCH v14 09/19] perf, tools: Support alias descriptions

On Thu, Jun 04, 2015 at 11:27:17PM -0700, Sukadev Bhattiprolu wrote: SNIP --- tools/perf/util/pmu.c | 80 +++-- tools/perf/util/pmu.h |1 + 2 files changed, 66 insertions(+), 15 deletions(-) diff --git a/tools/perf/util/pmu.c

Re: [PATCH v14 15/19] perf, tools: Support long descriptions with perf list

On Fri, Jun 05, 2015 at 11:16:45AM -0700, Sukadev Bhattiprolu wrote: SNIP | hum, it should be 'v' , right? Good catch. Fixed. | | Yes that's right. | | Also BTW need to add the new option to the usage line a few lines below. How about we do this for consistency with 'perf stat'(and

Re: [PATCH v13 11/14] perf, tools: Support long descriptions with perf list -v

On Tue, Jun 02, 2015 at 10:12:11AM -0700, Sukadev Bhattiprolu wrote: From: Andi Kleen a...@linux.intel.com Previously we were dropping the useful longer descriptions that some events have in the event list completely. This patch makes them appear with perf list. Old perf list:

Re: [PATCH v13 04/14] perf, tools: Allow events with dot

On Tue, Jun 02, 2015 at 10:12:04AM -0700, Sukadev Bhattiprolu wrote: From: Andi Kleen a...@linux.intel.com The Intel events use a dot to separate event name and unit mask. Allow dot in names in the scanner, and remove special handling of dot as EOF. Also remove the hack in jevents to replace

Re: [PATCH v13 06/14] perf, tools: Support alias descriptions

On Tue, Jun 02, 2015 at 10:12:06AM -0700, Sukadev Bhattiprolu wrote: SNIP @@ -1033,37 +1064,49 @@ void print_pmu_events(const char *event_glob, bool name_only) event_glob continue; -

Re: [PATCH v13 03/14] perf, tools: Use pmu_events_map table to create event aliases

On Tue, Jun 02, 2015 at 10:12:03AM -0700, Sukadev Bhattiprolu wrote: SNIP +/* + * Return the CPU id as a raw string. + * + * Each architecture should provide a more precise id string that + * can be use to match the architecture's mapfile. + */ +char

Re: [PATCH v13 03/14] perf, tools: Use pmu_events_map table to create event aliases

-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Changelog[v3] [Jiri Olsa] Fix a memory leak with cpuid. Changelog[v2] [Andi Kleen] Replace the pmu_events_map-vfm field with a simple generic cpuid string and use that string to find the matching mapfile

Re: [PATCH v13 02/14] perf, tools, jevents: Program to convert JSON file to C style file

On Tue, Jun 02, 2015 at 10:12:02AM -0700, Sukadev Bhattiprolu wrote: SNIP + +static int process_mapfile(FILE *outfp, char *fpath) +{ + int n = 16384; + FILE *mapfp; + char *save; + char *line, *p; + int line_num; + char *tblname; + + pr_info(%s: Processing

Re: [PATCH v13 02/14] perf, tools, jevents: Program to convert JSON file to C style file

On Tue, Jun 02, 2015 at 10:12:02AM -0700, Sukadev Bhattiprolu wrote: SNIP + +static char *file_name_to_table_name(char *fname) +{ + unsigned int i, j; + int c; + int n = 1024; /* use max variable length? */ I think this should be at least PATH_MAX, or you might

Re: [PATCH v13 03/14] perf, tools: Use pmu_events_map table to create event aliases

On Tue, Jun 02, 2015 at 10:12:03AM -0700, Sukadev Bhattiprolu wrote: SNIP + +/* + * From the pmu_events_map, find the table of PMU events that corresponds + * to the current running CPU. Then, add all PMU events from that table + * as aliases. + */ +static int pmu_add_cpu_aliases(void

Re: [PATCH v13 03/14] perf, tools: Use pmu_events_map table to create event aliases

On Tue, Jun 02, 2015 at 10:12:03AM -0700, Sukadev Bhattiprolu wrote: SNIP @@ -225,26 +221,47 @@ static int perf_pmu__new_alias(struct list_head *list, char *dir, char *name, FI alias-unit[0] = '\0'; alias-per_pkg = false; - ret = parse_events_terms(alias-terms, buf); +

Re: [PATCH v13 02/14] perf, tools, jevents: Program to convert JSON file to C style file

On Tue, Jun 02, 2015 at 10:12:02AM -0700, Sukadev Bhattiprolu wrote: SNIP + * If we fail to locate/process JSON and map files, create a NULL mapping + * table. This would at least allow perf to build even if we can't find/use + * the aliases. + */ +static void create_empty_mapping(const

Re: [PATCH v13 12/14] perf, tools: Add support for event list topics

On Tue, Jun 02, 2015 at 12:16:41PM -0700, Sukadev Bhattiprolu wrote: SNIP [Speculative and retired macro-conditional branches] br_inst_exec.all_direct_jmp [Speculative and retired macro-unconditional branches excluding calls and indirects]

Re: [PATCH v13 13/14] perf, tools: Handle header line in mapfile

On Tue, Jun 02, 2015 at 10:12:13AM -0700, Sukadev Bhattiprolu wrote: From: Andi Kleen a...@linux.intel.com Support a header line in the mapfile.csv, to match the existing mapfiles 'Suport' means 'skip' in here jirka Signed-off-by: Andi Kleen a...@linux.intel.com Signed-off-by: Sukadev

Re: [PATCH v13 12/14] perf, tools: Add support for event list topics

On Wed, Jun 03, 2015 at 05:57:33AM -0700, Andi Kleen wrote: please split at least the jevents Topic parsing from the rest idelay also the alias update and the display change What's the point of all these splits? It's already one logical unit, not too large, and is bisectable. splitting

Re: [PATCH 04/10] perf, tools: Handle header line in mapfile

On Thu, May 28, 2015 at 10:45:06PM -0700, Sukadev Bhattiprolu wrote: Jiri Olsa [jo...@redhat.com] wrote: |if (line[0] == '#' || line[0] == '\n') |continue; | + if (!strncmp(line, Family, 6)) | + continue; | | I think we should fix

Re: [PATCH 04/10] perf, tools: Handle header line in mapfile

On Fri, May 29, 2015 at 10:49:27PM -0700, Andi Kleen wrote: On Fri, May 29, 2015 at 11:13:15AM +0200, Jiri Olsa wrote: On Thu, May 28, 2015 at 10:45:06PM -0700, Sukadev Bhattiprolu wrote: Jiri Olsa [jo...@redhat.com] wrote: |if (line[0] == '#' || line[0] == '\n

Re: [PATCH 2/4] perf: jevents: Program to convert JSON file to C style file

On Wed, May 27, 2015 at 11:59:04PM +0900, Namhyung Kim wrote: Hi Andi, On Wed, May 27, 2015 at 11:40 PM, Andi Kleen a...@linux.intel.com wrote: So we build tables of all models in the architecture, and choose matching one when compiling perf, right? Can't we do that when building the

Re: [PATCH 0/10] perf: Add support for PMU events in JSON format

some and continue the build by leaving out event aliases). - For architectures that don't have any JSON files, an empty mapping table is created and they should continue to build) Thanks to input from Andi Kleen, Jiri Olsa, Namhyung Kim and Ingo Molnar. These patches

Re: [PATCH 0/10] perf: Add support for PMU events in JSON format

jevents try to recover from some and continue the build by leaving out event aliases). - For architectures that don't have any JSON files, an empty mapping table is created and they should continue to build) Thanks to input from Andi Kleen, Jiri Olsa, Namhyung Kim and Ingo

Re: [PATCH 03/10] Use pmu_events_map table to create event aliases

On Wed, May 27, 2015 at 02:23:22PM -0700, Sukadev Bhattiprolu wrote: At run time, (i.e when perf is starting up), locate the specific events table for the current CPU and create event aliases for each of the events. Use these aliases to parse user's specified perf event. Signed-off-by:

Re: [PATCH 02/10] jevents: Program to convert JSON file to C style file

On Wed, May 27, 2015 at 02:23:21PM -0700, Sukadev Bhattiprolu wrote: SNIP $(PERF_IN): $(OUTPUT)PERF-VERSION-FILE $(OUTPUT)common-cmds.h FORCE $(Q)$(MAKE) $(build)=perf -$(OUTPUT)perf: $(PERFLIBS) $(PERF_IN) - $(QUIET_LINK)$(CC) $(CFLAGS) $(LDFLAGS) $(PERF_IN) $(LIBS) -o $@

Re: [PATCH 04/10] perf, tools: Handle header line in mapfile

On Wed, May 27, 2015 at 02:23:23PM -0700, Sukadev Bhattiprolu wrote: From: Andi Kleen a...@linux.intel.com Support a header line in the mapfile.csv, to match the existing mapfiles Signed-off-by: Andi Kleen a...@linux.intel.com --- tools/perf/pmu-events/jevents.c |2 ++ 1 file

Re: [PATCH 02/10] jevents: Program to convert JSON file to C style file

On Wed, May 27, 2015 at 02:23:21PM -0700, Sukadev Bhattiprolu wrote: SNIP diff --git a/tools/perf/pmu-events/Build b/tools/perf/pmu-events/Build new file mode 100644 index 000..7e0c85c --- /dev/null +++ b/tools/perf/pmu-events/Build @@ -0,0 +1,10 @@ +jevents-y+= json.o jsmn.o

Re: [PATCH 0/10] perf: Add support for PMU events in JSON format

On Thu, May 28, 2015 at 01:42:06PM +0200, Jiri Olsa wrote: SNIP g...@github.com:sukadev/linux.git #branch json-v11 could you please also pull in Andi's changes with x86 events? it seems to be under his tree branch perf/builtin-json-2, follwing commits: b68aa7b0d4e4 perf, tools: Add

Re: [PATCH 09/10] perf, tools: Add a --no-desc flag to perf list

On Wed, May 27, 2015 at 02:23:28PM -0700, Sukadev Bhattiprolu wrote: From: Andi Kleen a...@linux.intel.com Add a --no-desc flag to perf list to not print the event descriptions that were earlier added for JSON events. This may be useful to get a less crowded listing. It's still default to

Re: [PATCH 2/4] perf: jevents: Program to convert JSON file to C style file

On Tue, May 19, 2015 at 05:02:08PM -0700, Sukadev Bhattiprolu wrote: SNIP +int main(int argc, char *argv[]) +{ + int rc; + int flags; SNIP + + rc = uname(uts); + if (rc 0) { + printf(%s: uname() failed: %s\n, argv[0], strerror(errno)); + goto

Re: [PATCH 2/4] perf: jevents: Program to convert JSON file to C style file

On Tue, May 19, 2015 at 05:02:08PM -0700, Sukadev Bhattiprolu wrote: SNIP --- tools/perf/Build |1 + tools/perf/Makefile.perf |4 +- tools/perf/pmu-events/Build| 38 ++ tools/perf/pmu-events/README | 67

Re: [PATCH 2/4] perf: jevents: Program to convert JSON file to C style file

On Fri, May 22, 2015 at 08:58:22AM -0700, Sukadev Bhattiprolu wrote: SNIP | | there's no concetion (yet) in the new build system to trigger | another binery build as a dependency for object file.. I'd | rather do this the framework way, please check attached patch | | also currently the

Re: [PATCH] perf record: Limit --intr-regs to platforms supporting PERF_REGS

On Tue, Sep 29, 2015 at 11:06:17AM +0530, Naveen N. Rao wrote: > On 2015/09/24 10:15PM, Naveen N Rao wrote: > > On 2015/09/24 08:32AM, Stephane Eranian wrote: > > > On Thu, Sep 24, 2015 at 5:57 AM, Jiri Olsa <jo...@redhat.com> wrote: > > > > > > > >

Re: [PATCH] perf record: Limit --intr-regs to platforms supporting PERF_REGS

On Tue, Sep 29, 2015 at 01:30:10PM +0530, Naveen N. Rao wrote: SNIP > > > Suka has also posted a fix for this with a different approach [1]. Can > > > you please ack/pull one of these versions? Building perf is broken on > > > v4.3-rc due to this. > > > > I did not get any answer for

Re: [PATCH] perf record: Limit --intr-regs to platforms supporting PERF_REGS

On Tue, Sep 29, 2015 at 11:10:02AM -0700, Sukadev Bhattiprolu wrote: SNIP > > diff --git a/tools/perf/util/perf_regs.c b/tools/perf/util/perf_regs.c > index 885e8ac..6b8eb13 100644 > --- a/tools/perf/util/perf_regs.c > +++ b/tools/perf/util/perf_regs.c > @@ -6,6 +6,7 @@ const struct sample_reg

Re: [PATCH v2] perf: Fix build break on powerpc due to sample_reg_masks

for 'perf_reg_value()' function (due to the static inline version > in util/perf_regs.h). So use #ifdef HAVE_PERF_REGS_SUPPORT' around that > function. > > Signed-off-by: Sukadev Bhattiprolu <suka...@linux.vnet.ibm.com> Acked-by: Jiri Olsa <jo...@kernel.org> thanks, jirka

Re: [PATCH] perf record: Limit --intr-regs to platforms supporting PERF_REGS

On Tue, Sep 29, 2015 at 10:01:36PM +0530, Naveen N. Rao wrote: > On 2015/09/29 12:47PM, Jiri Olsa wrote: > > On Tue, Sep 29, 2015 at 01:30:10PM +0530, Naveen N. Rao wrote: > > > > SNIP > > > > > > > Suka has also posted a fix for this with a different a

Re: [PATCH v16 00/16] perf, tools: Add support for PMU events in JSON format

Source Code only > | json-files-7x86 and Powerpc datafiles only > | json-v16.1-with-dataBoth code and data (for build/test) > > Arnaldo, Ingo, > > I have not received any comments on this patch set since it was Acked by > Jiri Olsa in June. Can you please

Re: [PATCH v3 0/3] perf build: PowerPC: Fix build breakage due to libbpf

arate > them into 3 patches. Please help me test it on PowerPC. > > Cc: Arnaldo Carvalho de Melo <a...@kernel.org> > Cc: Jiri Olsa <jo...@redhat.com> > Cc: Naveen N. Rao <naveen.n@linux.vnet.ibm.com> > Cc: Sukadev Bhattiprolu <suka...@linux.vnet.ibm.com> &g

Re: [PATCH V7 3/4] tools/perf: Map the ID values with register names

On Wed, Jan 06, 2016 at 03:15:50PM +0530, Anju T wrote: SNIP > + [PERF_REG_POWERPC_GPR28] = "gpr28", > + [PERF_REG_POWERPC_GPR29] = "gpr29", > + [PERF_REG_POWERPC_GPR30] = "gpr30", > + [PERF_REG_POWERPC_GPR31] = "gpr31", > + [PERF_REG_POWERPC_NIP] = "nip", > +

Re: [PATCH V8 3/4] tools/perf: Map the ID values with register names

On Fri, Jan 08, 2016 at 02:32:30PM +0530, Anju T wrote: SNIP > +#endif /* ARCH_PERF_REGS_H */ > diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile > index 38a0853..acf0302 100644 > --- a/tools/perf/config/Makefile > +++ b/tools/perf/config/Makefile > @@ -23,6 +23,11 @@ $(call

Re: [PATCH v3] tools/perf: Fix the mask in regs_dump__printf and print_sample_iregs

On Tue, Jun 21, 2016 at 06:35:31PM +0300, Yury Norov wrote: SNIP > > index 5214974e841a..1337b1c73f82 100644 > > --- a/tools/perf/util/session.c > > +++ b/tools/perf/util/session.c > > @@ -940,8 +940,22 @@ static void branch_stack__printf(struct perf_sample > > *sample) > > static void

Re: [PATCH v2 1/2] tools include: Adopt byte ordering macros from byteorder/generic.h

On Thu, Jun 16, 2016 at 10:41:31AM +, He Kuang wrote: > From: Wang Nan > > This patch adopts the macros for byte order conversion from > "include/linux/byteorder/generic.h" to > "tools/include/linux/byteorder/generic.h" > > tools/perf/MANIFEST is also updated for 'make

Re: [PATCH v2] tools/perf: Fix the mask in regs_dump__printf and

On Mon, Jun 20, 2016 at 05:27:25PM +0800, Wangnan (F) wrote: > > > On 2016/6/20 17:18, Jiri Olsa wrote: > > On Mon, Jun 20, 2016 at 02:14:01PM +0530, Madhavan Srinivasan wrote: > > > When decoding the perf_regs mask in regs_dump__printf(), > > > we loop thro

Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf

On Thu, Jan 07, 2016 at 06:23:03PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Jan 07, 2016 at 05:39:57PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Thu, Jan 07, 2016 at 12:28:15PM +0530, Naveen N. Rao escreveu: > > > Can you please push at least the initial 3 patches of this for v4.4?

Re: [PATCH v5] tools/perf: Fix the mask in regs_dump__printf and print_sample_iregs

44 > --- a/tools/include/linux/bitmap.h > +++ b/tools/include/linux/bitmap.h > @@ -2,6 +2,7 @@ > #define _PERF_BITOPS_H > > #include > +#include this could go in the bitmap.c file, but anyway: Acked-by: Jiri Olsa <jo...@kernel.org> thanks, jirka > #include

Re: [PATCH] tools/perf: Fix the mask in regs_dump__printf

t; Suggested-by: Yury Norov <yno...@caviumnetworks.com> > Cc: Yury Norov <yno...@caviumnetworks.com> > Cc: Peter Zijlstra <pet...@infradead.org> > Cc: Ingo Molnar <mi...@redhat.com> > Cc: Arnaldo Carvalho de Melo <a...@kernel.org> > Cc: Alexander Shishki

Re: [PATCH 2/2] tools include: Fix wrong macro definitions for cpu_to_le* for big endian

On Thu, Jun 16, 2016 at 01:32:09AM +, He Kuang wrote: > From: Wang Nan > > The cpu_to_le* macros in kernel.h are defined without considering > endianese. This patch includes "byteoder/generic.h" instead to fix the > bug, and removes redundant le64_to_cpu definition in

Re: [PATCH 1/2] tools include: Sync byteorder/generic.h

On Thu, Jun 16, 2016 at 01:32:08AM +, He Kuang wrote: > From: Wang Nan > > This patch copies "include/linux/byteorder/generic.h" to > "tools/include/linux/byteorder/generic.h" to enable other libraries to > use macros in it. it's not the file copied, as the changelog

Re: [PATCH] tools/perf: Fix the mask in regs_dump__printf

On Fri, Jun 17, 2016 at 02:43:31PM +0530, Madhavan Srinivasan wrote: SNIP > > > if (data->user_regs.abi) { > - u64 mask = evsel->attr.sample_regs_user; > + u.val64 = evsel->attr.sample_regs_user; > > - sz =

Re: [PATCH 1/1] perf tools: Fix build break on powerpc

On Sat, Mar 26, 2016 at 11:01:47AM -0700, Sukadev Bhattiprolu wrote: > From 502e8236082412db1d33abfad95aaf14b539502e Mon Sep 17 00:00:00 2001 > From: Sukadev Bhattiprolu > Date: Sat, 26 Mar 2016 17:31:39 -0400 > Subject: [PATCH 1/1] perf tools: Fix build break on

Re: [PATCH v2] tools/perf: Fix the mask in regs_dump__printf and

On Mon, Jun 20, 2016 at 02:14:01PM +0530, Madhavan Srinivasan wrote: SNIP > diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c > index e3ce2f34d3ad..76d5006ebcc3 100644 > --- a/tools/perf/builtin-script.c > +++ b/tools/perf/builtin-script.c > @@ -412,11 +412,16 @@ static void

Re: [PATCH v2] tools/perf: Fix the mask in regs_dump__printf and

On Mon, Jun 20, 2016 at 02:14:01PM +0530, Madhavan Srinivasan wrote: > When decoding the perf_regs mask in regs_dump__printf(), > we loop through the mask using find_first_bit and find_next_bit functions. > "mask" is of type "u64", but sent as a "unsigned long *" to > lib functions along with

Re: [PATCH v20 00/20] perf, tools: Add support for PMU events in JSON format

On Wed, Aug 31, 2016 at 09:15:30AM -0700, Andi Kleen wrote: > > > > > > > > > > > I've already made some changes in pmu-events/* to support > > > > this hierarchy to see how bad the change would be.. and > > > > it's not that bad ;-) > > > > > > Everything has to be automated, please no manual

Re: [PATCH v20 00/20] perf, tools: Add support for PMU events in JSON format

t; > The file, 'tools/perf/pmu-events/README' in [PATCH 16/16] gives more > details. > > Note: > - All known events tables for the architecture are included in the > perf binary. > > - For architectures that don't have any JSON files, an empty mapping >

Re: [PATCH v20 00/20] perf, tools: Add support for PMU events in JSON format

On Wed, Aug 31, 2016 at 07:42:47AM -0700, Andi Kleen wrote: > > hi, > > I had discussion with Ingo about the state of this patchset > > and there's one more requirement from his side - to split > > event files into per topic files > > Thanks Jiri. > > > > I made some initial changes over latest

Re: [PATCH v21 00/20] perf, tools: Add support for PMU events in JSON format

On Thu, Sep 22, 2016 at 06:27:13PM +0200, Jiri Olsa wrote: > On Thu, Sep 22, 2016 at 05:00:22PM +0200, Jiri Olsa wrote: > > On Mon, Sep 19, 2016 at 09:28:20PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Mon, Sep 19, 2016 at 09:02:58PM -0300, Arnaldo Carvalho de Melo > >

Re: [PATCH v21 00/20] perf, tools: Add support for PMU events in JSON format

On Thu, Sep 29, 2016 at 07:19:48PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Sep 27, 2016 at 04:18:46PM +0200, Jiri Olsa escreveu: > > On Mon, Sep 26, 2016 at 09:59:54AM -0700, Andi Kleen wrote: > > > On Mon, Sep 26, 2016 at 12:03:43PM -0300, Arnaldo Carvalho de Melo wro

Re: [PATCH v21 16/19] perf, tools: Make alias matching case-insensitive

On Mon, Oct 03, 2016 at 09:47:06PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Sep 15, 2016 at 03:24:53PM -0700, Sukadev Bhattiprolu escreveu: > > From: Andi Kleen > > > > Make alias matching the events parser case-insensitive. This is useful > > with the JSON events.

  1   2   >