Re: [PATCH 1/9] powerpc/configs: Drop CONFIG_QLGE which moved to staging

2020-01-15 Thread Joel Stanley
IG_STAGING. > > It sounds like the device is obsolete, so drop the driver. > > Signed-off-by: Michael Ellerman Acked-by: Joel Stanley

Re: [PATCH 2/9] powerpc/configs: NET_CADENCE became NET_VENDOR_CADENCE

2020-01-15 Thread Joel Stanley
ned-off-by: Michael Ellerman Acked-by: Joel Stanley

Re: [RFC PATCH 8/9] powerpc/configs/skiroot: Disable xmon default & enable reboot on panic

2020-01-15 Thread Joel Stanley
. > > Similarly if we panic we should reboot, with a short timeout in case > someone is watching the console. > > Signed-off-by: Michael Ellerman Acked-by: Joel Stanley > --- > arch/powerpc/configs/skiroot_defconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-

Re: [PATCH 6/9] powerpc/configs/skiroot: Update for symbol movement only

2020-01-15 Thread Joel Stanley
On Thu, 16 Jan 2020 at 01:48, Michael Ellerman wrote: > > Signed-off-by: Michael Ellerman Acked-by: Joel Stanley

Re: [RFC PATCH 9/9] powerpc/configs/skiroot: Enable some more hardening options

2020-01-15 Thread Joel Stanley
t; SLAB_FREELIST_RANDOM, and SLUB_DEBUG_ON will add some overhead to the > SLAB allocator, but nothing that should be meaningful for skiroot. > > Signed-off-by: Michael Ellerman Acked-by: Joel Stanley > --- > arch/powerpc/configs/skiroot_defconfig | 8 > 1 file ch

[PATCH] powerpc/config: Enable secuity features in skiroot

2020-01-01 Thread Joel Stanley
This turns on HARDENED_USERCOPY with HARDENED_USERCOPY_PAGESPAN, and FORTIFY_SOURCE. It also enables SECURITY_LOCKDOWN_LSM with _EARLY and LOCK_DOWN_KERNEL_FORCE_CONFIDENTIALITY options enabled. MODULE_SIG is selected by lockdown, so it is still enabled. Signed-off-by: Joel Stanley --- arch

Re: [PATCH v5 5/5] powerpc/configs: Enable STRICT_MODULE_RWX in skiroot_defconfig

2019-10-30 Thread Joel Stanley
ell Currey Acked-by: Joel Stanley > --- > arch/powerpc/configs/skiroot_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/configs/skiroot_defconfig > b/arch/powerpc/configs/skiroot_defconfig > index 1253482a67c0..719d899081b3 100644 > --

[PATCH] powerpc/powernv: Print helpful message when cores guarded

2019-07-31 Thread Joel Stanley
Often the firmware will guard out cores after a crash. This often undesirable, and is not immediately noticeable. This adds an informative message when a CPU device tree nodes are marked bad in the device tree. Signed-off-by: Joel Stanley --- Tested on qemu 4.1 with this patch applied: https

Re: [PATCH] PPC: Set reserved PCR bits

2019-07-15 Thread Joel Stanley
et the reserved bits of the PCR as required. > > Acked-by: Alistair Popple > Signed-off-by: Jordan Niethe Tested-by: Joel Stanley I gave a powernv_defconfig build a spin in a qemu powernv machine. Cheers, Joel

[PATCH] powerpc/security: Fix build break

2019-05-14 Thread Joel Stanley
] if (!no_nospec && !cpu_mitigations_off()) ^~~ Fixes: 782e69efb3df ("powerpc/speculation: Support 'mitigations=' cmdline option") Signed-off-by: Joel Stanley --- This should be applied to the 4.14 and 4.19 trees. There is no issue wi

Re: [PATCH v2 2/2] powerpc/mm: Warn if W+X pages found on boot

2019-05-02 Thread Joel Stanley
On Thu, 2 May 2019 at 07:42, Russell Currey wrote: > > Implement code to walk all pages and warn if any are found to be both > writable and executable. Depends on STRICT_KERNEL_RWX enabled, and is > behind the DEBUG_WX config option. > > This only runs on boot and has no runtime performance

Re: [PATCH] powerpc/security: Show powerpc_security_features in debugfs

2019-04-11 Thread Joel Stanley
: Michael Ellerman Reviewed-by: Joel Stanley > --- > arch/powerpc/kernel/security.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/arch/powerpc/kernel/security.c b/arch/powerpc/kernel/security.c > index b33bafb8fcea..d6ba696d0ed0 100644 > --- a/arch/powerpc

Re: [PATCH v2] powerpc/vmlinux.lds: Drop binutils < 2.18 workarounds

2019-04-04 Thread Joel Stanley
On Fri, 29 Mar 2019 at 09:53, Segher Boessenkool wrote: > > Hi! > > On Fri, Mar 29, 2019 at 05:14:53PM +1030, Joel Stanley wrote: > > - NOTES :kernel :notes > > + NOTES > > I think this still need to be > > NOTES :kernel > > or the l

[PATCH] powerpc: config: skiroot: Add (back) MLX5 ethernet support

2019-04-02 Thread Joel Stanley
It turns out that some defconfig changes and kernel config option changes meant we accidentally dropped Ethernet support for Mellanox CLX5 cards. Reported-by: Carol L Soto Suggested-by: Carol L Soto Signed-off-by: Stewart Smith Signed-off-by: Joel Stanley --- arch/powerpc/configs

[PATCH] Documentation: powerpc: Expand the DAWR acronym

2019-04-01 Thread Joel Stanley
Those not of us not drowning in POWER might not know what this means. Signed-off-by: Joel Stanley --- Documentation/powerpc/DAWR-POWER9.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/powerpc/DAWR-POWER9.txt b/Documentation/powerpc/DAWR-POWER9.txt

[PATCH v2] powerpc/vmlinux.lds: Drop binutils < 2.18 workarounds

2019-03-29 Thread Joel Stanley
au/ for the discussion. Signed-off-by: Joel Stanley --- v2: Fix ppc64_defconfig by keeping kernel PHDRS Segher, Christophe, I did my best but to summarise your conversation. Please suggest corrections or additions to the commit message if you have any. --- arch/powerpc/ker

[PATCH] powerpc: vmlinux.lds: Drop Binutils 2.18 workarounds

2019-03-20 Thread Joel Stanley
Segher added some workarounds for GCC 4.2 and bintuils 2.18. We now set 4.6 and 2.20 as the minimum, so they can be dropped. This is mostly a revert of c6995fe4 ("powerpc: Fix build bug with binutils < 2.18 and GCC < 4.2"). Signed-off-by: Joel Stanley --- arch/powerpc/kern

[PATCH] powerpc: config: Sync skiroot defconfig

2019-03-04 Thread Joel Stanley
This updates the skiroot defconfig with the version from the OpenPower firmwre build tree. Important changes are the addition of QED and E1000E ethernet drivers. Signed-off-by: Joel Stanley --- Generated on top of next-20190304 arch/powerpc/configs/skiroot_defconfig | 11 +-- 1 file

Re: [PATCH] powerpc/configs: Enable CONFIG_USB_XHCI_HCD by default

2019-02-11 Thread Joel Stanley
to get the keyboard working in the graphical console there again, > we should now include XHCI support in the kernel by default, too. > > Signed-off-by: Thomas Huth Acked-by: Joel Stanley > --- > arch/powerpc/configs/pseries_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff

[PATCH] mtd: powernv: SPDX and comment fixups

2019-02-05 Thread Joel Stanley
This converts the powernv flash driver to use SPDX, and adds some clarifying comments that came out of a discussion on how the mtd driver works. Signed-off-by: Joel Stanley --- drivers/mtd/devices/powernv_flash.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff

[PATCH] powerpc: Use ALIGN instead of BLOCK

2019-01-11 Thread Joel Stanley
In the ld documentation under Builtin Functions: BLOCK(exp) This is a synonym for ALIGN, for compatibility with older linker scripts. Clang's linker (lld) doesn't know about BLOCK so remove this use of it. Link: https://github.com/ClangBuiltLinux/linux/issues/253 Signed-off-by: Joel

[PATCH] powerpc/vdso32: Drop -mabi=elfv1 for 32 bit objects

2019-01-09 Thread Joel Stanley
From: Daniel Axtens All 64-bit objects need to specify the flag to be compiled correctly, we just don't need it for 32-bit objects. GCC just ignored it, but clang doesn't. Link: https://github.com/ClangBuiltLinux/linux/issues/240 Signed-off-by: Daniel Axtens Signed-off-by: Joel Stanley

lockdep WARN_ON in ppc440 with -next

2018-12-13 Thread Joel Stanley
Hello, I was booting next-20181213 in qemu with lockdep enabled and saw this: spin_lock-torture:--- Start of test [debug]: nwriters_stress=2 nreaders_stress=0 stat_interval=60 verbose=1 shuffle_interval=3 stutter=5 shutdown_secs=0 onoff_interval=0 onoff_holdoff=0 spin_lock-torture: Creating

[PATCH v3 3/3] powerpc: Discard .branch_lt section

2018-12-10 Thread Joel Stanley
Signed-off-by: Joel Stanley --- v2: Discard instead of keep. Alan said "[discarding] can be a recipe for finding linker bugs", so lets go with that. --- arch/powerpc/kernel/vmlinux.lds.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/vmlinux.l

[PATCH v3 2/3] powerpc: Discard dynsym section for !PPC32

2018-12-10 Thread Joel Stanley
Alan Modra explains: > Likely you could discard .interp > and .dynstr too, and .dynsym when > !CONFIG_PPC32. Discarding of interp and dynstr happened in a previous patch. The dynsym cleanup was a bit less straightforward, so it gets it's own patch. Signed-off-by: Joel Stanley --- S

[PATCH v3 1/3] powerpc: Discard more sections in linker script

2018-12-10 Thread Joel Stanley
lookup. I imagine you don't need either section in a kernel, so > discarding both sounds reasonable. Likely you could discard .interp > and .dynstr too, and .dynsym when !CONFIG_PPC32. Reported-by: Stephen Rothwell Signed-off-by: Joel Stanley --- See https://lore.kernel.org/lkml/CACPK8X

[PATCH v3 0/3] powerpc: Add to linker script discards

2018-12-10 Thread Joel Stanley
v3 fixes up the splitting of the patches, moving the dynstr hunk from patch 2 to patch 1. v2 pulls in the branch_lt patch too. No changes to the first two patches. Joel Stanley (3): powerpc: Discard more sections in linker script powerpc: Discard dynsym section for !PPC32 powerpc: Discard

Re: [PATCH v2 2/3] powerpc: Discard dynsym section for !PPC32

2018-12-10 Thread Joel Stanley
On Wed, 5 Dec 2018 at 04:11, Segher Boessenkool wrote: > > On Tue, Dec 04, 2018 at 11:24:28AM +1030, Joel Stanley wrote: > > Alan Modra explains: > > > > > Likely you could discard .interp > and .dynstr too, and .dynsym when > > > !CONFIG_PPC32. > >

[PATCH v2 3/3] powerpc: Discard .branch_lt section

2018-12-03 Thread Joel Stanley
Signed-off-by: Joel Stanley --- v2: Discard instead of keep. Alan said "[discarding] can be a recipe for finding linker bugs", so lets go with that. --- arch/powerpc/kernel/vmlinux.lds.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/vmlinux.l

[PATCH v2 2/3] powerpc: Discard dynsym section for !PPC32

2018-12-03 Thread Joel Stanley
Alan Modra explains: > Likely you could discard .interp > and .dynstr too, and .dynsym when > !CONFIG_PPC32. Discarding of interp and dynstr happened in a previous patch. The dynsym cleanup was a bit less straightforward, so it gets it's own patch. Signed-off-by: Joel Stanley --- S

[PATCH v2 1/3] powerpc: Discard more sections in linker script

2018-12-03 Thread Joel Stanley
lookup. I imagine you don't need either section in a kernel, so > discarding both sounds reasonable. Likely you could discard .interp > and .dynstr too, and .dynsym when !CONFIG_PPC32. Reported-by: Stephen Rothwell Signed-off-by: Joel Stanley --- See https://lore.kernel.org/lkml/CACPK8X

[PATCH v2 0/3] powerpc: Add to linker script discards

2018-12-03 Thread Joel Stanley
v2 pulls in the branch_lt patch too. No changes to the first two patches. Joel Stanley (3): powerpc: Discard more sections in linker script powerpc: Discard dynsym section for !PPC32 powerpc: Discard .branch_lt section arch/powerpc/kernel/vmlinux.lds.S | 15 +-- 1 file changed

[PATCH 2/2] powerpc: Discard dynsym section for !PPC32

2018-12-03 Thread Joel Stanley
Alan Modra explains: > Likely you could discard .interp > and .dynstr too, and .dynsym when > !CONFIG_PPC32. Discarding of interp and dynstr happened in a previous patch. The dynsym cleanup was a bit less straightforward, so it gets it's own patch. Signed-off-by: Joel Stanley --- S

[PATCH 1/2] powerpc: Discard more sections in linker script

2018-12-03 Thread Joel Stanley
lookup. I imagine you don't need either section in a kernel, so > discarding both sounds reasonable. Likely you could discard .interp > and .dynstr too, and .dynsym when !CONFIG_PPC32. Reported-by: Stephen Rothwell Signed-off-by: Joel Stanley --- See https://lore.kernel.org/lkml/CACPK8X

[PATCH 0/2] powerpc: Add to linker script discards

2018-12-03 Thread Joel Stanley
Joel Stanley (2): powerpc: Discard more sections in linker script powerpc: Discard dynsym section for !PPC32 arch/powerpc/kernel/vmlinux.lds.S | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) -- 2.19.1

Re: linux-next: build warnings from Linus' tree

2018-12-03 Thread Joel Stanley
On Sun, 18 Nov 2018 at 21:52, Alan Modra wrote: > > On Wed, Nov 14, 2018 at 09:20:23PM +1100, Michael Ellerman wrote: > > Joel Stanley writes: > > > Hello Alan, > > > > > > On Tue, 12 Jun 2018 at 07:44, Stephen Rothwell > > > wrote: > > &

[PATCH v3] powerpc/math-emu: Update macros from GCC

2018-12-03 Thread Joel Stanley
260 Signed-off-by: Joel Stanley --- v1: https://lore.kernel.org/linuxppc-dev/20181102033713.31916-1-j...@jms.id.au/ v2: Instead of setting the -fheinous-gnu-extensions for clang, fix the code. v3: Sync with GCC version instead of GMP version --- arch/powerpc/include/asm/sfp-mach

Re: [PATCH v2] raid6/ppc: Fix build for clang

2018-12-03 Thread Joel Stanley
On Tue, 4 Dec 2018 at 05:15, Nick Desaulniers wrote: > > > > +ifdef CONFIG_CC_IS_CLANG > > > > +# clang ppc port does not yet support -maltivec when -msoft-float is > > > > +# enabled. A future release of clang will resolve this > > > > +# https://bugs.llvm.org/show_bug.cgi?id=31177 > > > >

Re: [PATCH v2] raid6/ppc: Fix build for clang

2018-12-03 Thread Joel Stanley
On Sat, 3 Nov 2018 at 04:04, Nick Desaulniers wrote: > > On Thu, Nov 1, 2018 at 5:45 PM Joel Stanley wrote: > > > > We cannot build these files with clang as it does not allow altivec > > instructions in assembly when -msoft-float is passed. > > > > Jinsong J

Re: [PATCH v2] powerpc/math-emu: Update macros from gmp-6.1.2

2018-11-19 Thread Joel Stanley
On Tue, 20 Nov 2018 at 05:24, Nick Desaulniers wrote: > > > > The only functional change I noticed was this in udiv_qrnnd. > > > > __r1 = (n1) % __d1; > > __q1 = (n1) / __d1; > > > > Becomes this: > > > > __q1 = (n1) / __d1; > > __r1 = (n1) - __q1 * __d1; > > > > This is

Re: [PATCH] powerpc/powernv: Remove PCI_MSI ifdef checks

2018-11-13 Thread Joel Stanley
On Wed, 14 Nov 2018 at 16:50, Oliver O'Halloran wrote: > > CONFIG_PCI_MSI was made mandatory by commit a311e738b6d8 > ("powerpc/powernv: Make PCI non-optional") so the #ifdef > checks around CONFIG_PCI_MSI here can be removed entirely. > > Signed-off-by: Oliver O'

Re: linux-next: build warnings from Linus' tree

2018-11-13 Thread Joel Stanley
Hello Alan, On Tue, 12 Jun 2018 at 07:44, Stephen Rothwell wrote: > Building Linus' tree, today's linux-next build (powerpc ppc64_defconfig) > produced these warning: > > ld: warning: orphan section `.gnu.hash' from `linker stubs' being placed in > section `.gnu.hash'. > ld: warning: orphan

[PATCH] powerpc/32: Include .branch_lt in data section

2018-11-13 Thread Joel Stanley
local symbols")[1], 32 bit targets can produce .branch_lt sections in their output. Include these symbols in the .data section as the ppc64 kernel does. [1] https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commitdiff;h=2d7ad24e8726ba4c45c9e67be08223a146a837ce Signed-off-by: Joel Stan

[PATCH v2] powerpc/math-emu: Update macros from gmp-6.1.2

2018-11-13 Thread Joel Stanley
BuiltLinux/linux/issues/260 Signed-off-by: Joel Stanley --- v1: https://lore.kernel.org/linuxppc-dev/20181102033713.31916-1-j...@jms.id.au/ v2: Instead of setting the -fheinous-gnu-extensions for clang, fix the code. arch/powerpc/include/asm/sfp-machine.h | 99 +- 1 file c

Re: [PATCH] powerpc/math-emu: Fix building with clang

2018-11-12 Thread Joel Stanley
On Sat, 3 Nov 2018 at 03:24, Nick Desaulniers wrote: > > On Thu, Nov 1, 2018 at 8:37 PM Joel Stanley wrote: > > > > make CC=clang-8 ARCH=powerpc CROSS_COMPILE=powerpc-linux-gnu- > > ppc44x_defconfig > > make CC=clang-8 ARCH=powerpc C

[PATCH v2] powerpc/32: Avoid unsupported flags with clang

2018-11-11 Thread Joel Stanley
id=39556 Link: https://bugs.llvm.org/show_bug.cgi?id=39555 Signed-off-by: Joel Stanley --- arch/powerpc/Makefile | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile index 8a2ce14d68d0..4685671dfb4f 100644 --- a/arch/powerpc/Makefi

Re: [PATCH v2 2/2] kbuild: consolidate Clang compiler flags

2018-11-11 Thread Joel Stanley
On Mon, 12 Nov 2018 at 13:59, Masahiro Yamada wrote: > > On Mon, Nov 12, 2018 at 10:05 AM Michael Ellerman wrote: > > > > Masahiro Yamada writes: > > > On Sat, Nov 10, 2018 at 3:35 AM Greg Hackmann > > > wrote: > > >> > > >> On 11/09/2018 10:29 AM, Nick Desaulniers wrote: > > >> > On Mon, Nov

[PATCH v2 2/2] powerpc/boot: Set target when cross-compiling for clang

2018-11-11 Thread Joel Stanley
Clang needs to be told which target it is building for when cross compiling. Link: https://github.com/ClangBuiltLinux/linux/issues/259 Signed-off-by: Joel Stanley --- arch/powerpc/boot/Makefile | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc

[PATCH v2 1/2] Makefile: Export clang toolchain variables

2018-11-11 Thread Joel Stanley
The powerpc makefile will use these in it's boot wrapper. Signed-off-by: Joel Stanley --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 09278330282d..840efe6eb54c 100644 --- a/Makefile +++ b/Makefile @@ -495,6 +495,7 @@ endif ifneq ($(GCC_TOOLCHAIN

[PATCH v2 0/2] powerpc/boot: Fix cross compiling with clang

2018-11-11 Thread Joel Stanley
with clang and with this patch it can cross compile too. Joel Stanley (2): Makefile: Export clang toolchain variables powerpc/boot: Set target when cross-compiling for clang Makefile | 1 + arch/powerpc/boot/Makefile | 5 + 2 files changed, 6 insertions(+) -- 2.19.1

Re: [PATCH 0/2] poewrpc/Boot: Fix cross compiling with clang

2018-11-05 Thread Joel Stanley
On Tue, 6 Nov 2018 at 09:07, Nick Desaulniers wrote: > > On Sun, Nov 4, 2018 at 3:11 PM Joel Stanley wrote: > > > > Hello, > > > > These patches allow clang to cross-compile the powerpc boot wrapper. > > The boot wrapper constructs it's own compiler flags as

Re: [PATCH] powerpc/32: Avoid unsupported flags with clang

2018-11-04 Thread Joel Stanley
On Mon, 5 Nov 2018 at 14:18, Michael Ellerman wrote: > > I considered putting these behind a cc-option test. If someone has an > > opinion on that I'm happy to change. > > -CFLAGS-$(CONFIG_PPC32) := -ffixed-r2 $(MULTIPLEWORD) > > +ifndef CONFIG_CC_IS_CLANG > > +#CFLAGS-$(CONFIG_PPC32)

[PATCH 2/2] powerpc/boot: Set target when cross-compiling for clang

2018-11-04 Thread Joel Stanley
Clang needs to be told which target it is building for when cross compiling. Link: https://github.com/ClangBuiltLinux/linux/issues/259 Signed-off-by: Joel Stanley --- arch/powerpc/boot/Makefile | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc

[PATCH 1/2] Makefile: Export clang toolchain variables

2018-11-04 Thread Joel Stanley
The powerpc makefile will use these in it's boot wrapper. Signed-off-by: Joel Stanley --- Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Makefile b/Makefile index 9aa352b38815..a2db3c885b38 100644 --- a/Makefile +++ b/Makefile @@ -495,6 +495,9 @@ endif ifneq ($(GCC_TOOLCHAIN

[PATCH 0/2] poewrpc/Boot: Fix cross compiling with clang

2018-11-04 Thread Joel Stanley
Hello, These patches allow clang to cross-compile the powerpc boot wrapper. The boot wrapper constructs it's own compiler flags as it may not be built for the same arch as the kernel. The powerpc64le kernel builds natively with clang and with this patch it can cross compile too. Joel Stanley (2

Re: [PATCH] powerpc/32: Avoid unsupported flags with clang

2018-11-01 Thread Joel Stanley
On Fri, 2 Nov 2018 at 15:09, Joel Stanley wrote: > > When building for ppc32 with clang these flags are unsupported: > > -ffixed-r2 and -mmultiple > > llvm's lib/Target/PowerPC/PPCRegisterInfo.cpp marks r2 as reserved on > when building for SVR4ABI and !ppc64: > >

[PATCH] powerpc/32: Avoid unsupported flags with clang

2018-11-01 Thread Joel Stanley
pty -append "console=ttyS0" Link: https://github.com/ClangBuiltLinux/linux/issues/261 Signed-off-by: Joel Stanley --- I considered putting these behind a cc-option test. If someone has an opinion on that I'm happy to change. arch/powerpc/Makefile | 4 +++- 1 file changed, 3 insertions(+

[PATCH] powerpc/math-emu: Fix building with clang

2018-11-01 Thread Joel Stanley
(R##_f1, R##_f0, X##_f1, X##_f0, Y##_f1, Y##_f0) ^~~ Link: https://github.com/ClangBuiltLinux/linux/issues/260 Signed-off-by: Joel Stanley --- arch/powerpc/math-emu/Makefile | 4 1 file changed, 4 insertions(+) diff --git

[PATCH v2] raid6/ppc: Fix build for clang

2018-11-01 Thread Joel Stanley
k: https://bugs.llvm.org/show_bug.cgi?id=31177 Link: https://github.com/ClangBuiltLinux/linux/issues/239 Signed-off-by: Joel Stanley --- v2: fix typo in comment, thanks Jinsong lib/raid6/Makefile | 15 +++ 1 file changed, 15 insertions(+) diff --git a/lib/raid6/Makefile b/lib/raid6/Mak

[PATCH] raid6/ppc: Fix build for clang

2018-10-30 Thread Joel Stanley
k: https://bugs.llvm.org/show_bug.cgi?id=31177 Link: https://github.com/ClangBuiltLinux/linux/issues/239 Signed-off-by: Joel Stanley --- lib/raid6/Makefile | 15 +++ 1 file changed, 15 insertions(+) diff --git a/lib/raid6/Makefile b/lib/raid6/Makefile index 2f8b61dfd9b0..3a844e6fd01

[PATCH] powerpc/xmon: Relax frame size for clang

2018-10-30 Thread Joel Stanley
strings on the stack. While this issue is investigated, bump up the frame size limit for xmon when building with clang. Link: https://github.com/ClangBuiltLinux/linux/issues/252 Signed-off-by: Joel Stanley --- arch/powerpc/xmon/Makefile | 6 ++ 1 file changed, 6 insertions(+) diff --git

Re: [PATCH v2 1/2] kbuild: replace cc-name test with CONFIG_CC_IS_CLANG

2018-10-30 Thread Joel Stanley
_IS_CLANG, instead. Thanks, I didn't know about this. > > Signed-off-by: Masahiro Yamada > Acked-by: Michael Ellerman (powerpc) Acked-by: Joel Stanley Cheers, Joel

Re: [PATCH] selftests/powerpc: Relax L1d miss targets for rfi_flush test

2018-10-25 Thread Joel Stanley
en rfi_flush is enabled, we allow ~1% lower number of cache misses. > > Reported-by: Joel Stanley > Signed-off-by: Naveen N. Rao Thanks, this now passes 10/10 runs on my Romulus machine. A log is attached below. Tested-by: Joel Stanley Cheers, Joel --- for i in `seq 1 10`; do sud

[PATCH 6/6] selftests: powerpc/pmu: Link ebb tests with -no-pie

2018-10-23 Thread Joel Stanley
it to be always off instead. Signed-off-by: Joel Stanley --- tools/testing/selftests/powerpc/pmu/ebb/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/testing/selftests/powerpc/pmu/ebb/Makefile b/tools/testing/selftests/powerpc/pmu/ebb/Makefile index bd5dfa509272..23f4caf48ffc

[PATCH 5/6] selftests: powerpc/signal: Fix signal_tm CFLAGS

2018-10-23 Thread Joel Stanley
signal_tm tries to build with -mhtm but it currently does not. The targets is modified in lib.mk to add the $(OUTPUT) prefix. The makefile needs to specify that modifying the rules, or else it does not match and we miss out on the extra flag. Signed-off-by: Joel Stanley --- tools/testing

[PATCH 4/6] selftests: powerpc/signal: Make tests build

2018-10-23 Thread Joel Stanley
According to lib.mk, TEST_PROGS is for shell scripts. It appears we need to define the programs as TEST_GEN_PROGS to ensure they are built. The definition must also happen below the inclusion of lib.mk. Signed-off-by: Joel Stanley --- tools/testing/selftests/powerpc/signal/Makefile | 7

[PATCH 3/6] selftests: powerpc/ptrace: Fix linking against pthread

2018-10-23 Thread Joel Stanley
that modifying those rules, or else they do not match and we miss out on the extra flags. Signed-off-by: Joel Stanley --- tools/testing/selftests/powerpc/ptrace/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/powerpc/ptrace/Makefile b/tools

[PATCH 2/6] selftests: powerpc/ptrace: Remove clean rule

2018-10-23 Thread Joel Stanley
in lib.mk. Signed-off-by: Joel Stanley --- tools/testing/selftests/powerpc/ptrace/Makefile | 3 --- 1 file changed, 3 deletions(-) diff --git a/tools/testing/selftests/powerpc/ptrace/Makefile b/tools/testing/selftests/powerpc/ptrace/Makefile index e9a3850aae86..58de6d4a0cf4 100644 --- a/tools

[PATCH 1/6] selftests: powerpc/ptrace: Make tests build

2018-10-23 Thread Joel Stanley
According to lib.mk, TEST_PROGS is for shell scripts. It appears we need to define the programs as TEST_GEN_PROGS to ensure they are built. Signed-off-by: Joel Stanley --- tools/testing/selftests/powerpc/ptrace/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 0/6] selftests: powerpc build fixes

2018-10-23 Thread Joel Stanley
This series fixes issues I encountered building and running the selftests on a Ubuntu Cosmic ppc64le system. Joel Stanley (6): selftests: powerpc/ptrace: Make tests build selftests: powerpc/ptrace: Remove clean rule selftests: powerpc/ptrace: Fix linking against pthread selftests: powerpc

[PATCH] selftests: powerpc: Fix warning for security subdir

2018-10-22 Thread Joel Stanley
. Note that the test program is still built. Signed-off-by: Joel Stanley --- tools/testing/selftests/powerpc/security/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/powerpc/security/Makefile b/tools/testing/selftests/powerpc/security/Makefile index

[PATCH] powerpc: Use SWITCH_FRAME_SIZE for prom and rtas entry

2018-10-11 Thread Joel Stanley
means we don't need to save the extra stack space and can use the common SWITCH_FRAME_SIZE. There were already no users of _SRR0 and _SRR1 so we can remove them too. Link: https://github.com/linuxppc/linux/issues/83 Signed-off-by: Joel Stanley --- arch/powerpc/kernel/asm-offsets.c | 9 -

[PATCH v3] powerpc/Makefile: Fix PPC_BOOK3S_64 ASFLAGS

2018-10-10 Thread Joel Stanley
the table than > other mnemonics, so they'll be seen/chosen first By explicitly setting -many we can build with Clang and GCC while retaining the -mpower4 option. Signed-off-by: Joel Stanley --- Following up on: https://lore.kernel.org/linuxppc-dev/20180914040649.1794-2-j..

Re: [PATCH 1/2] powerpc/boot: Expose Kconfig symbols to wrapper

2018-10-10 Thread Joel Stanley
On Thu, 11 Oct 2018 at 10:32, Michael Ellerman wrote: > > Michael Ellerman writes: > > Joel Stanley writes: > >> diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile > >> index 0fb96c26136f..eeed74e0dfca 100644 > >> --- a/arch/powerpc/boo

Re: [PATCH 1/2] powerpc/boot: Disable vector instructions

2018-10-10 Thread Joel Stanley
On Wed, 10 Oct 2018 at 22:41, Michael Ellerman wrote: > > Joel Stanley writes: > > > This will avoid auto-vectorisation when building with higher > > optimisation levels. > > > > We don't know if the machine can support VSX and even if it's present > >

[PATCH 2/2] powerpc/boot: Build boot wrapper with optimisations

2018-10-09 Thread Joel Stanley
from Os. Comparing zImage.epapr to the existing Os build using bloat-o-meter: Before=43401, After=56837 (13KB), chg +30.96% Before=43401, After=64305 (20KB), chg +48.16% I chose O2 for a balance between Qemu and hardware speed up. Signed-off-by: Joel Stanley --- arch/powerpc/boot/Makefile | 2

[PATCH 1/2] powerpc/boot: Disable vector instructions

2018-10-09 Thread Joel Stanley
This will avoid auto-vectorisation when building with higher optimisation levels. We don't know if the machine can support VSX and even if it's present it's probably not going to be enabled at this point in boot. Signed-off-by: Joel Stanley --- arch/powerpc/boot/Makefile | 4 ++-- 1 file

[PATCH 0/2] powerpc/boot: Build wrapper with optimisations

2018-10-09 Thread Joel Stanley
We currently build the wrapper with Os. This builds it with O2 instead, reducing boot time when decompressing a compressed kernel. See patch 2 for details. I've given this a spin with CONFIG_KERNEL_XZ on P9 and P8 as the petitboot kernel. Joel Stanley (2): powerpc/boot: Disable vector

[PATCH 2/2] powerpc/boot: Fix opal console in boot wrapper

2018-10-09 Thread Joel Stanley
("powerpc/boot: Only build OPAL code when necessary") the makefile only includes opal.c in the build if CONFIG_PPC64_BOOT_WRAPPER is set. Fixes: 10c77dba40ff ("powerpc/boot: Fix build failure in 32-bit boot wrapper") Signed-off-by: Joel Stanley --- I wrote this patch before

[PATCH 1/2] powerpc/boot: Expose Kconfig symbols to wrapper

2018-10-09 Thread Joel Stanley
to depend on configuration options. Fixes: 866bfc75f40e ("powerpc: conditionally compile platform-specific serial drivers") Signed-off-by: Joel Stanley --- arch/powerpc/boot/.gitignore | 1 + arch/powerpc/boot/Makefile | 7 ++- arch/powerpc/boot/serial.c | 1 + 3 files changed, 8

[PATCH 0/2] powerpc/boot: Fix serial output in boot wrapper

2018-10-09 Thread Joel Stanley
. Joel Stanley (2): powerpc/boot: Expose Kconfig symbols to wrapper powerpc/boot: Fix opal console in boot wrapper arch/powerpc/boot/.gitignore | 1 + arch/powerpc/boot/Makefile | 7 ++- arch/powerpc/boot/opal.c | 8 arch/powerpc/boot/serial.c | 1 + 4 files changed, 8

[PATCH v2] powerpc/perf: Quiet IMC PMU registration message

2018-10-09 Thread Joel Stanley
support registered [5.996569] nest_mba0_imc performance monitor hardware support registered [5.996631] nest_mba1_imc performance monitor hardware support registered [5.996685] nest_mba2_imc performance monitor hardware support registered Signed-off-by: Joel Stanley --- v2: patch

[PATCH] powerpc/perf: Quiet PMU registration message

2018-10-08 Thread Joel Stanley
support registered [5.996569] nest_mba0_imc performance monitor hardware support registered [5.996631] nest_mba1_imc performance monitor hardware support registered [5.996685] nest_mba2_imc performance monitor hardware support registered Signed-off-by: Joel Stanley --- arch/powerpc

[PATCH] lib/xz: Put CRC32_POLY_LE in xz_private.h

2018-09-20 Thread Joel Stanley
er. Fixes: faa16bc404d72a5 ("lib: Use existing define with polynomial") Reported-by: Meelis Roos Reported-by: kbuild test robot Suggested-by: Christophe LEROY Signed-off-by: Joel Stanley --- lib/xz/xz_crc32.c | 1 - lib/xz/xz_private.h | 4 2 files changed, 4 insertions(+), 1 del

Re: [PATCH] lib/xz: Fix powerpc build with KERNEL_XZ

2018-09-20 Thread Joel Stanley
On Wed, 19 Sep 2018 at 16:09, Krzysztof Kozlowski wrote: > > On Wed, 19 Sep 2018 at 01:08, Joel Stanley wrote: > > > > This partially reverts faa16bc404d72a5 ("lib: Use existing define with > > polynomial"). > > > > The cleanup added a depend

Re: [PATCH v2 1/5] powerpc/Makefiles: Fix clang/llvm build

2018-09-20 Thread Joel Stanley
On Sat, 15 Sep 2018 at 03:11, Nick Desaulniers wrote: > > On Thu, Sep 13, 2018 at 9:07 PM Joel Stanley wrote: > > > > From: Anton Blanchard > > > > Commit 15a3204d24a3 ("powerpc/64s: Set assembler machine type to POWER4") > > passes -mpower4 to t

Re: [PATCH v2 4/5] powerpc: Fix duplicate const clang warning in user access code

2018-09-19 Thread Joel Stanley
On Sat, 15 Sep 2018 at 03:27, Nick Desaulniers wrote: > > On Thu, Sep 13, 2018 at 9:07 PM Joel Stanley wrote: > > > > From: Anton Blanchard > > > > This re-applies b91c1e3e7a6f which was reverted in f2ca80905929 > > d466f6c5cac1 f84ed59a612d (powerpc/

[PATCH] lib/xz: Fix powerpc build with KERNEL_XZ

2018-09-18 Thread Joel Stanley
iry corner of the kernel. Even while building a 64-bit kernel it needs to build a 32-bit binary and therefore avoid including files from include/linux. Fixes: faa16bc404d7 ("lib: Use existing define with polynomial") Signed-off-by: Joel Stanley --- We need to clean up the powerpc boot decomp

Re: [PATCH] powerpc/makefile: remove check on obsolete GCC versions

2018-09-17 Thread Joel Stanley
Hey Christophe, On Tue, 18 Sep 2018 at 15:13, Christophe Leroy wrote: > > Since commit cafa0010cd51 ("Raise the minimum required gcc version > to 4.6"), it is not possible to build kernel with GCC lower than 4.6 > > This patch removes checkbin tests addressing older versions of GCC. This is the

[PATCH v2] powerpc/configs: Update skiroot defconfig

2018-09-17 Thread Joel Stanley
etc. will fail in the skiroot environment. This defconfig gets us build coverage of KERNEL_XZ, which was broken in the 4.19 merge window for powerpc. Signed-off-by: Joel Stanley --- v2: re-sync with version used in op-build --- arch/powerpc/configs/skiroot_defconfig | 154

Re: [PATCH v2 2/5] powerpc/boot: Fix crt0.S syntax for clang

2018-09-17 Thread Joel Stanley
On Tue, 18 Sep 2018 at 06:11, Nick Desaulniers wrote: > > On Fri, Sep 14, 2018 at 2:08 PM Segher Boessenkool > wrote: > > > > On Fri, Sep 14, 2018 at 10:47:08AM -0700, Nick Desaulniers wrote: > > > On Thu, Sep 13, 2018 at 9:07 PM Joel Stanley wrote: > > >

[PATCH] powerpc: Disable -Wbuiltin-requires-header when setjmp is used

2018-09-17 Thread Joel Stanley
*, long); ^ This *is* the header and we're not using the built-in setjump but rather the one in arch/powerpc/kernel/misc.S. As the compiler warning does not make sense, it for the files where setjmp is used. Signed-off-by: Joel Stanley --- We could instead disable this for all

Re: [PATCH 01/12] powerpc/64s/hash: Fix stab_rr off by one initialization

2018-09-17 Thread Joel Stanley
On Sat, 15 Sep 2018 at 01:03, Nicholas Piggin wrote: > > This causes SLB alloation to start 1 beyond the start of the SLB. > There is no real problem because after it wraps it stats behaving starts? > properly, it's just surprisig to see when looking at SLB traces. surprising > >

Re: [PATCH 2/2] powerpc/pseries: Remove VLA from lparcfg_write()

2018-09-16 Thread Joel Stanley
remove the need for kbuf_sz, thus removing the variable length array. > > Signed-off-by: Suraj Jitindar Singh Reviewed-by: Joel Stanley

Re: [PATCH 1/2] powerpc/prom: Remove VLA in prom_check_platform_support()

2018-09-16 Thread Joel Stanley
rray of constant length 8. > > This property is used to indicate the supported options of vector 5 > bytes 23-26 of the ibm,architecture.vec node. Each of these options > is a pair of bytes, thus for 4 options we have a max length of 8 bytes. > > Signed-off-by: Suraj Jitindar Singh Reviewed-by: Joel Stanley

Re: [PATCH 3/3] powerpc: avoid -mno-sched-epilog on GCC 4.9 and newer

2018-09-16 Thread Joel Stanley
On Fri, 14 Sep 2018 at 14:39, Nicholas Piggin wrote: > > Signed-off-by: Nicholas Piggin Reviewed-by: Joel Stanley I gave this a spin with clang trunk on the powernv kernel and it did the trick. Thanks! mpe, this series supersedes [v2,5/5] powerpc: Remove -mno-sched-epilog

Re: [PATCH 2/3] powerpc: consolidate -mno-sched-epilog into FTRACE flags

2018-09-16 Thread Joel Stanley
On Fri, 14 Sep 2018 at 14:39, Nicholas Piggin wrote: > > Signed-off-by: Nicholas Piggin Reviewed-by: Joel Stanley

Re: [PATCH 1/3] powerpc: remove old GCC version checks

2018-09-16 Thread Joel Stanley
On Fri, 14 Sep 2018 at 14:39, Nicholas Piggin wrote: > > GCC 4.6 is the minimum supported now. > > Signed-off-by: Nicholas Piggin Reviewed-by: Joel Stanley

[PATCH v2 5/5] powerpc: Remove -mno-sched-epilog

2018-09-13 Thread Joel Stanley
C versions, with GCC 4.6 now being the minimum. [1] https://bugzilla.kernel.org/show_bug.cgi?id=11414 Signed-off-by: Joel Stanley --- Last time this was proposed there was an issue reported: https://lists.ozlabs.org/pipermail/linuxppc-dev/2014-September/121214.html If some machines still have an

[PATCH v2 4/5] powerpc: Fix duplicate const clang warning in user access code

2018-09-13 Thread Joel Stanley
code generation. Signed-off-by: Anton Blanchard Signed-off-by: Joel Stanley --- If we don't want to apply this, other options are suppressing the warning, or wait for a fix to land in clang (https://github.com/ClangBuiltLinux/linux/issues/52). --- arch/powerpc/include/asm/uaccess.h | 6 +++--- 1

<    1   2   3   >