Re: [PATCH v3] mm: Avoid unnecessary page fault retires on shared memory types

2022-05-25 Thread Johannes Weiner
ETRY. > > I explicitly didn't touch hmm_vma_fault() and break_ksm() because they do > not handle VM_FAULT_RETRY even with existing code, so I'm literally keeping > them as-is. > > Signed-off-by: Peter Xu Acked-by: Johannes Weiner

Re: mm: Question about the use of 'accessed' flags and pte_young() helper

2020-10-20 Thread Johannes Weiner
On Tue, Oct 20, 2020 at 05:52:07PM +0200, Vlastimil Babka wrote: > On 10/8/20 11:49 AM, Christophe Leroy wrote: > > In a 10 years old commit > > (https://github.com/linuxppc/linux/commit/d069cb4373fe0d451357c4d3769623a7564dfa9f), > > powerpc 8xx has > > made the handling of PTE accessed bit

Re: linux-next: runtime warning in Linus' tree

2020-08-13 Thread Johannes Weiner
atch in linux-next up tuntil today > is different. :-( Sorry, I made a last-minute request to include these checks in that patch to make the code a bit more robust, but they trigger a false positive here. Let's remove them. --- >From de8ea7c96c056c3cbe7b93995029986a158fb9cd Mon Sep 17 00:00:00 2

Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive()

2020-04-14 Thread Johannes Weiner
ing is done by using the command sequence: > > git grep -w --name-only kzfree |\ > xargs sed -i 's/\bkzfree\b/kfree_sensitive/' > > followed by some editing of the kfree_sensitive() kerneldoc and the > use of memzero_explicit() instead of memset(). > > Suggested-by: Joe Perches > Signed-off-by: Waiman Long Looks good to me. Thanks for fixing this very old mistake. Acked-by: Johannes Weiner

Re: [PATCH 25/28] mm: remove vmalloc_user_node_flags

2020-04-13 Thread Johannes Weiner
For this to compile for the nommu case add a __vmalloc_node_range stub > > to nommu.c. > > > > Signed-off-by: Christoph Hellwig Acked-by: Johannes Weiner

Re: [PATCH v3 3/3] mm: use numa_mem_id() in alloc_pages_node()

2015-07-30 Thread Johannes Weiner
On Thu, Jul 30, 2015 at 06:34:31PM +0200, Vlastimil Babka wrote: numa_mem_id() is able to handle allocation from CPUs on memory-less nodes, so it's a more robust fallback than the currently used numa_node_id(). Won't it fall through to the next closest memory node in the zonelist anyway? Is

Re: [PATCH 6/7][TRIVIAL][resend] mm: cleanup page reclaim comment error

2012-06-15 Thread Johannes Weiner
On Fri, Jun 15, 2012 at 09:19:45PM +0800, Wanpeng Li wrote: From: Wanpeng Li l...@linux.vnet.ibm.com Since there are five lists in LRU cache, the array nr in get_scan_count should be: nr[0] = anon inactive pages to scan; nr[1] = anon active pages to scan nr[2] = file inactive pages to

Re: [PATCH] sparsemem/bootmem: catch greater than section size allocations

2012-02-29 Thread Johannes Weiner
On Tue, Feb 28, 2012 at 12:11:51PM -0800, Nishanth Aravamudan wrote: On 28.02.2012 [14:53:26 +0100], Johannes Weiner wrote: On Fri, Feb 24, 2012 at 11:33:58AM -0800, Nishanth Aravamudan wrote: While testing AMS (Active Memory Sharing) / CMO (Cooperative Memory Overcommit) on powerpc, we

Re: [PATCH v2] bootmem/sparsemem: remove limit constraint in alloc_bootmem_section

2012-02-29 Thread Johannes Weiner
(), but since we actually have HOTREMOVE defined, we'll BUG_ON() instead. A simple solution appears to be to unconditionally remove the limit condition in alloc_bootmem_section, meaning allocations are allowed to cross section boundaries (necessary for systems of this size). Johannes Weiner pointed

Re: [PATCH] sparsemem/bootmem: catch greater than section size allocations

2012-02-28 Thread Johannes Weiner
the section size. It makes sense to allow the usemaps to spill over to subsequent sections instead of panicking, so FWIW: Acked-by: Johannes Weiner han...@cmpxchg.org That being said, it would be good if check_usemap_section_nr() printed the cross-dependencies between pgdats and sections when