Re: [PATCH] Add USB support to mpc8349-mitx board port

2007-07-07 Thread John Rigby
On 7/6/07, Grant Likely [EMAIL PROTECTED] wrote: On 7/6/07, Arnd Bergmann [EMAIL PROTECTED] wrote: On Saturday 07 July 2007, Grant Likely wrote: --- a/arch/powerpc/platforms/83xx/mpc834x_itx.c +++ b/arch/powerpc/platforms/83xx/mpc834x_itx.c @@ -63,6 +63,8 @@ static void __init

[PATCH] MPC5121 FEC support

2008-06-17 Thread John Rigby
in fs_enet_main.c as described above. Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/boot/dts/mpc5121ads.dts | 24 - drivers/net/fs_enet/Kconfig | 14 ++-- drivers/net/fs_enet/fec_mpc5121.h| 64 ++ drivers/net/fs_enet

[PATCH] [Rev2] MPC5121 FEC support

2008-06-17 Thread John Rigby
fs_platform_info which is used in fs_enet_main.c as described above. Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/boot/dts/mpc5121ads.dts | 24 - drivers/net/fs_enet/Kconfig | 14 ++-- drivers/net/fs_enet/fec_mpc5121.h| 64

Re: [PATCH] [Rev2] MPC5121 FEC support

2008-06-17 Thread John Rigby
Thanks Sam, Scott already addressed most of your issues. The background that you are likely missing and I will add to the patch header is that the 5121 has an FEC core with all the same registers as 8xx except the order of the registers is scrambled. Fortunately the old FEC only exists on

[PATCH 0/2] Add MPC5121 FEC suppport

2008-06-17 Thread John Rigby
Note: This patch series assumes Kumar's Remove !CONFIG_PPC_CPM_NEW_BINDING patch has been applied. http://patchwork.ozlabs.org/linuxppc/patch?q=kumarid=18939 Addresses all comments to previous patch. Split the patch into two parts: Part 1 fixes all problems reported by checkpatch.pl and

[PATCH 2/2] fs_enet: add MPC5121 FEC support

2008-06-17 Thread John Rigby
/net/fs_enet/mii-fec.c Add a new entry to match table with compatible set to fsl,mpc5121-fec-mdio. include/linux/fs_enet_pd.h Add an new field called align_tx_packets to struct fs_platform_info which is used in fs_enet_main.c as described above. Signed-off-by: John Rigby [EMAIL

[PATCH 1/2] fs_enet: fix checkpatch.pl problems

2008-06-17 Thread John Rigby
Fixed all errors and warnings that checkpatch.pl reports if this was a new submission. Also changed instances of fec_t to struct fec in mac-fec.c and mii-fec.c. This is in preparation of adding MPC5121 support. Signed-off-by: John Rigby [EMAIL PROTECTED] --- drivers/net/fs_enet/fs_enet-main.c

Re: [PATCH] MPC5121 FEC support

2008-06-17 Thread John Rigby
On Tue, Jun 17, 2008 at 6:35 PM, Stephen Rothwell [EMAIL PROTECTED] wrote: Hi John, You should factor out the fec_t - struct fec change into an earlier patch of its own. Ok, I'll separate that from the checkpatch fixes. On Tue, 17 Jun 2008 11:48:00 -0600 John Rigby [EMAIL PROTECTED

Re: [PATCH 1/2] fs_enet: fix checkpatch.pl problems

2008-06-17 Thread John Rigby
Sorry, I thought I was doing the right thing to base the patch on Kumar's patch that removes the CONFIG_PPC_CPM_NEW_BINDING stuff. That is likely why it did not apply. On Tue, Jun 17, 2008 at 9:54 PM, Jeff Garzik [EMAIL PROTECTED] wrote: John Rigby wrote: Fixed all errors and warnings

Re: [PATCH 1/2] fs_enet: fix checkpatch.pl problems

2008-06-18 Thread John Rigby
I agree, I'll separate the fec_t - struct fec changes out. On Tue, Jun 17, 2008 at 11:20 PM, Grant Likely [EMAIL PROTECTED] wrote: On Tue, Jun 17, 2008 at 5:03 PM, John Rigby [EMAIL PROTECTED] wrote: Fixed all errors and warnings that checkpatch.pl reports if this was a new submission

Re: [PATCH] Added support for PRTLVT based boards (MPC5121)

2008-06-18 Thread John Rigby
to arch/powerpc/platforms/512x/mpc5121_generic.c index 50bd3a3..824ddbb 100644 --- a/arch/powerpc/platforms/512x/mpc5121_ads.c +++ b/arch/powerpc/platforms/512x/mpc5121_generic.c @@ -4,7 +4,7 @@ * Author: John Rigby, [EMAIL PROTECTED], Thur Mar 29 2007 * * Description: - * MPC5121 ADS

[PATCH 0/2][Rev4] Add MPC5121 FEC suppport

2008-06-18 Thread John Rigby
Changes since last patch set: This patch no longer assmues Kumar's patch that removes CONFIG_PPC_CPM_NEW_BINDING stuff. That was just confusing. No checkpatch.pl fixes. Addresses all comments to previous patch. Does not rework the Kconfig logic. More work is need than

[PATCH 1/2][Rev4] fs_enet: change fec_t to struct fec

2008-06-18 Thread John Rigby
This is in preparation of adding support for MPC5121 FEC. The 5121 patch needs to add a different struct fec because it has a different register layout. This patch allows the 5121 patch to not include a typedef fec_t which checkpatch complains about. Signed-off-by: John Rigby [EMAIL PROTECTED

Re: [U-Boot-Users] mpc5121 cache coherency

2008-06-18 Thread John Rigby
Unlike other SOCs with e300 cores the 5121 is not cache coherent. The problem is an internal bridge that the processor can not snoop across. On Wed, Jun 18, 2008 at 1:29 PM, Kenneth Johansson [EMAIL PROTECTED] wrote: I have tried to speed up u-boot by turning on I/D cache during boot. It

[PATCH 2/2][Rev4][Resend] fs_enet: add MPC5121 FEC support

2008-06-18 Thread John Rigby
/fs_enet/mii-fec.c Add a new entry to match table with compatible set to fsl,mpc5121-fec-mdio. include/linux/fs_enet_pd.h Add an new field called align_tx_packets to struct fs_platform_info which is used in fs_enet_main.c as described above. Signed-off-by: John Rigby [EMAIL

Re: [PATCH] Added support for PRTLVT based boards (MPC5121)

2008-06-20 Thread John Rigby
June 2008 17:33:48 John Rigby wrote: Hi David, Looks like your device tree is based on the beta ltib bsp. There were some changes in release 1 that you may want to incorporate: First as a convention I changed all the interrupt numbers in the tuples to be decimal. I like this better because

[PATCH 0/6] MPC5121 Updates

2008-06-20 Thread John Rigby
The following patches contain updates for MPC5121 1/6 Updates the device tree. 2/6 Adds a clock driver. 3/6 Adds support for generic boards. This is nearly identical to David Jander's patch but does not delete the ADS board option. ADS is not a candidate for generic since it

[PATCH 3/6] MPC5121 Add generic board support

2008-06-20 Thread John Rigby
Move shared code from mpc5121_ads.c to mpc512x_shared.c. Add new generic board setup mpc5121_generic.c Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/platforms/512x/Kconfig | 15 - arch/powerpc/platforms/512x/Makefile |3 +- arch/powerpc/platforms/512x

[PATCH 4/6] MPC5121 Add MPC5121ADS cpld support

2008-06-20 Thread John Rigby
Add a interrupt host for the interrupt controller in the mpc5121ads cpld. PCI interrupts are 0-7 the rest are 8-15 Touchscreen pendown irq is hardwired to irq1 All other irqs are chainged to irq0 Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/platforms/512x/Kconfig

[PATCH 6/6] MPC5121 Hide pci bridge

2008-06-20 Thread John Rigby
The class of the MPC5121 pci host bridge is PCI_CLASS_BRIDGE_OTHER while other freescale host bridges have class set to PCI_CLASS_PROCESSOR_POWERPC. This patch makes fixup_hide_host_resource_fsl match PCI_CLASS_BRIDGE_OTHER in addition to PCI_CLASS_PROCESSOR_POWERPC. Signed-off-by: John Rigby

[PATCH 2/6] MPC5121 clock driver

2008-06-20 Thread John Rigby
Implements the api defined in include/clk.h Current only getting frequencies is supported not setting. Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/platforms/512x/Makefile |1 + arch/powerpc/platforms/512x/clock.c | 729 ++ 2 files changed

[PATCH 5/6] MPC5121 Add PCI support

2008-06-20 Thread John Rigby
Copied from 83xx minus support for two busses. Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/Kconfig |2 +- arch/powerpc/platforms/512x/Kconfig |1 + arch/powerpc/platforms/512x/Makefile |1 + arch/powerpc/platforms/512x/mpc5121_ads.c

[PATCH 2/2][Rev4] fs_enet: add MPC5121 FEC support

2008-06-20 Thread John Rigby
/fs_enet/mii-fec.c Add a new entry to match table with compatible set to fsl,mpc5121-fec-mdio. include/linux/fs_enet_pd.h Add an new field called align_tx_packets to struct fs_platform_info which is used in fs_enet_main.c as described above. Signed-off-by: John Rigby [EMAIL

[PATCH 0/8][Version 2] MPC5121 Updates

2008-06-24 Thread John Rigby
The following patches contain updates for MPC5121 1/8 No change since last submission. Updates the device tree. 2/8 Adds a clock driver. Cleanup based on input from Stephen Rothwell. 3/8 No change since last submission. Adds support for generic boards. This is nearly

[PATCH 3/8][Version 2] MPC5121 Add generic board support

2008-06-24 Thread John Rigby
Move shared code from mpc5121_ads.c to mpc512x_shared.c. Add new generic board setup mpc5121_generic.c Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/platforms/512x/Kconfig | 15 - arch/powerpc/platforms/512x/Makefile |3 +- arch/powerpc/platforms/512x

[PATCH 4/8][Version 2] MPC5121 Add MPC5121ADS cpld support

2008-06-24 Thread John Rigby
Add a interrupt host for the interrupt controller in the mpc5121ads cpld. PCI interrupts are 0-7 the rest are 8-15 Touchscreen pendown irq is hardwired to irq1 All other irqs are chainged to irq0 Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/platforms/512x/Kconfig

[PATCH 2/8][Version 2] MPC5121 clock driver

2008-06-24 Thread John Rigby
Implements the api defined in include/clk.h Current only getting frequencies is supported not setting. Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/platforms/512x/Makefile |1 + arch/powerpc/platforms/512x/clock.c | 720 ++ 2 files changed

[PATCH 5/8][Version 2] powerpc: pci config cleanup

2008-06-24 Thread John Rigby
change bool PCI support if long ugly expression to bool PCI support if PPC_HAS_PCI and add select PPC_HAS_PCI to all the config nodes that were previously in the PCI if expression Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/Kconfig |9

[PATCH 7/8][Version 2] MPC5121 Add PCI support

2008-06-24 Thread John Rigby
Uses mpc83xx_add_bridge in fsl_pci.c Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/platforms/512x/Kconfig |2 ++ arch/powerpc/platforms/512x/mpc5121_ads.c | 10 ++ arch/powerpc/platforms/512x/mpc512x.h |1 + arch/powerpc/sysdev/fsl_pci.c

[PATCH 8/8][Version 2] MPC5121 Hide pci bridge

2008-06-24 Thread John Rigby
The class of the MPC5121 pci host bridge is PCI_CLASS_BRIDGE_OTHER while other freescale host bridges have class set to PCI_CLASS_PROCESSOR_POWERPC. This patch makes fixup_hide_host_resource_fsl match PCI_CLASS_BRIDGE_OTHER in addition to PCI_CLASS_PROCESSOR_POWERPC. Signed-off-by: John Rigby

[PATCH 6/8][Version 2] powerpc: Move mpc83xx_add_bridge to fsl_pci.c

2008-06-24 Thread John Rigby
This allows other platforms with the same pci block like MPC5121 to use it. Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/platforms/83xx/Kconfig |2 +- arch/powerpc/platforms/83xx/Makefile |1 - arch/powerpc/platforms/83xx/mpc831x_rdb.c |1 + arch/powerpc

[PATCH 0/2] powerpc: pci cleanup

2008-06-25 Thread John Rigby
patch 1/2 cleans up powerpc pci config patch 2/2 moves mpc83xx_add_bridge to fsl_pci.c ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH 1/2] powerpc: pci config cleanup

2008-06-25 Thread John Rigby
change bool PCI support if long ugly expression to bool PCI support if PPC_HAS_PCI and add select PPC_HAS_PCI to all the config nodes that were previously in the PCI if expression Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/Kconfig |9

[PATCH 2/2] powerpc: Move mpc83xx_add_bridge to fsl_pci.c

2008-06-25 Thread John Rigby
This allows other platforms with the same pci block like MPC5121 to use it. Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/platforms/83xx/Kconfig |2 +- arch/powerpc/platforms/83xx/Makefile |1 - arch/powerpc/platforms/83xx/mpc831x_rdb.c |1 + arch/powerpc

[Resend][PATCH 1/8][Version 2] MPC5121 Update MPC5121ADS device tree

2008-06-25 Thread John Rigby
Updated device tree for MPC5121ADS Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/boot/dts/mpc5121ads.dts | 309 - 1 files changed, 299 insertions(+), 10 deletions(-) diff --git a/arch/powerpc/boot/dts/mpc5121ads.dts b/arch/powerpc/boot/dts

Re: [PATCH 1/2] powerpc: pci config cleanup

2008-06-25 Thread John Rigby
at 14:19 -0600, John Rigby wrote: change bool PCI support if long ugly expression to bool PCI support if PPC_HAS_PCI and add select PPC_HAS_PCI to all the config nodes that were previously in the PCI if expression diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index

[PATCH 0/2] powerpc: pci cleanup [rev2]

2008-06-26 Thread John Rigby
patch 1/2 cleans up powerpc pci config Thanks to Michael Ellerman for his comments. This new version calls the new config var PPC_PCI_CHOICE instead of PPC_HAS_PCI patch 2/2 moves mpc83xx_add_bridge to fsl_pci.c This is unchanged. ___

[PATCH 1/2] powerpc: pci config cleanup [rev2]

2008-06-26 Thread John Rigby
to bool PCI support if PPC_PCI_CHOICE and adding select PPC_PCI_CHOICE to all the config nodes that were previously in the PCI if expression. Platforms with unconditional PCI support continue to just select PCI in their config nodes. Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc

[PATCH 2/2] powerpc: Move mpc83xx_add_bridge to fsl_pci.c [rev2]

2008-06-26 Thread John Rigby
This allows other platforms with the same pci block like MPC5121 to use it. Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/platforms/83xx/Kconfig |2 +- arch/powerpc/platforms/83xx/Makefile |1 - arch/powerpc/platforms/83xx/mpc831x_rdb.c |1 + arch/powerpc

Re: [Resend][PATCH 1/8][Version 2] MPC5121 Update MPC5121ADS device tree

2008-06-26 Thread John Rigby
Because get_immrbase in fsl_soc.c does not work without it. On Thu, Jun 26, 2008 at 7:42 PM, David Gibson [EMAIL PROTECTED] wrote: On Wed, Jun 18, 2008 at 02:24:46PM -0600, John Rigby wrote: Updated device tree for MPC5121ADS [snip] [EMAIL PROTECTED] { compatible = fsl

Re: [PATCH 5/6] MPC5121 Add PCI support

2008-06-29 Thread John Rigby
Yes, Kumar made the same comment. The newer patch that moves the 83xx add bridge routine to fsl_soc obsoletes this patch. On Sat, Jun 28, 2008 at 11:38 PM, Grant Likely [EMAIL PROTECTED] wrote: On Fri, Jun 20, 2008 at 10:58:38AM -0600, John Rigby wrote: Copied from 83xx minus support for two

Re: [PATCH 4/6] MPC5121 Add MPC5121ADS cpld support

2008-06-29 Thread John Rigby
On Sat, Jun 28, 2008 at 11:36 PM, Grant Likely [EMAIL PROTECTED] wrote: Minor comments below. On Fri, Jun 20, 2008 at 10:58:37AM -0600, John Rigby wrote: Add a interrupt host for the interrupt controller in the mpc5121ads cpld. PCI interrupts are 0-7 the rest are 8-15 Touchscreen pendown

Re: patches for 2.6.27...

2008-07-07 Thread John Rigby
Two pci patches that are prereq's for 5121 pci: http://patchwork.ozlabs.org/linuxppc/patch?person=518id=19299 http://patchwork.ozlabs.org/linuxppc/patch?person=518id=19300 On Wed, Jul 2, 2008 at 1:56 AM, Kumar Gala [EMAIL PROTECTED] wrote: Please point out any patches that have been posted but

[PATCH 1/4][Version 3] MPC5121 Update MPC5121ADS device tree

2008-07-09 Thread John Rigby
changing MDS to ADS. Add a compatible property of the form fsl,mpc5121-... to nodes missing one. Changed localbus compatible to fsl,mpc5121-localbus, this does not break anything because the only code that uses it finds it via the node name, not compatible. Signed-off-by: John Rigby [EMAIL

[PATCH 3/4][Version 3] MPC5121 Add generic board support

2008-07-09 Thread John Rigby
and use compatible for lookup instead of node name Add new generic board setup mpc5121_generic.c Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/platforms/512x/Kconfig| 15 - arch/powerpc/platforms/512x/Makefile |3 +- arch/powerpc

[PATCH 4/4][Version 3] MPC5121 Add MPC5121ADS cpld support

2008-07-09 Thread John Rigby
Add a interrupt host for the interrupt controller in the mpc5121ads cpld. PCI interrupts are 0-7 the rest are 8-15 Touchscreen pendown irq is hardwired to irq1 All other irqs are chained to irq0 Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/platforms/512x/Kconfig|1

[PATCH 2/4][Version 3] MPC5121 clock driver

2008-07-09 Thread John Rigby
: stubbed clk_round_rate: stubbed clk_set_parent: NULL clk_get_parent: NULL Signed-off-by: John Rigby [EMAIL PROTECTED] --- Makefile |1 + arch/powerpc/platforms/512x/Kconfig |1 + arch/powerpc/platforms/512x/Makefile |1 + arch/powerpc

Two pci patches that are prereq's for MPC5121 pci

2008-07-09 Thread John Rigby
Ben, Could you pick up these two powerpc pci patches. Grant Likely ack'd them both. No one nak'd them. powerpc: pci config cleanup [rev2] http://patchwork.ozlabs.org/linuxppc/patchcontent?id=19299 powerpc: Move mpc83xx_add_bridge to fsl_pci.c [rev2]

Re: Two pci patches that are prereq's for MPC5121 pci

2008-07-09 Thread John Rigby
On Wed, Jul 9, 2008 at 3:52 PM, Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: On Wed, 2008-07-09 at 15:07 -0600, John Rigby wrote: Ben, Could you pick up these two powerpc pci patches. Grant Likely ack'd them both. No one nak'd them. powerpc: pci config cleanup [rev2] http

[PATCH add immr alias 2/4] powerpc: 5121: Add immr alias to MPC5121 ADS device tree.

2008-08-05 Thread John Rigby
5121 u-boot uses the immr alias instead of the node name. Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/boot/dts/mpc5121ads.dts |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/boot/dts/mpc5121ads.dts b/arch/powerpc/boot/dts/mpc5121ads.dts index

[PATCH add immr alias 1/4] powerpc: Teach get_immrbase to use immr alias if it exists.

2008-08-05 Thread John Rigby
This will allow the eventual removal of device_type = soc properties in soc nodes. Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/sysdev/fsl_soc.c | 25 +++-- 1 files changed, 23 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/sysdev/fsl_soc.c b/arch

[PATCH add immr alias 3/4] powerpc: 83xx: Add immr aliases to 83xx device trees.

2008-08-05 Thread John Rigby
Now that get_immrbase knows about immr aliases. Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/boot/dts/mpc8313erdb.dts|3 ++- arch/powerpc/boot/dts/mpc8315erdb.dts|3 ++- arch/powerpc/boot/dts/mpc832x_mds.dts|3 ++- arch/powerpc/boot/dts/mpc832x_rdb.dts

[PATCH add immr alias 4/4] powerpc: 8[56]xx: Add immr aliases to 8[56]xx device trees

2008-08-05 Thread John Rigby
Now that get_immrbase knows about immr aliases. Some chip docs call this ccsr for 8[56]xx platforms but we stick with immr for consistency across 8xxx. Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/boot/dts/ksi8560.dts |3 ++- arch/powerpc/boot/dts/mpc8536ds.dts

Re: [PATCH add immr alias 2/4] powerpc: 5121: Add immr alias to MPC5121 ADS device tree.

2008-08-05 Thread John Rigby
Likely wrote: Oops, forgot to add devicetree-discuss to the cc: list g. On Tue, Aug 5, 2008 at 3:05 PM, Grant Likely [EMAIL PROTECTED] wrote: On Tue, Aug 5, 2008 at 2:13 PM, John Rigby [EMAIL PROTECTED] wrote: So get_immrbase can function without a device_type = soc property in the soc

Re: [PATCH add immr alias 2/4] powerpc: 5121: Add immr alias to MPC5121 ADS device tree.

2008-08-05 Thread John Rigby
Scott Wood wrote: John Rigby wrote: I would like to use mpc83xx_add_bridge for 5121. This is why I moved it to fsl_pci.c. It currently uses get_immrbase and adds 0x8300 and 0x8304 to it to pass to setup_indirect_pci as the cfg_addr, and cfg_data addresses. I'm more than

[PATCH 5121 pci 3/3] powerpc: pci: 5121: Hide pci bridge.

2008-08-07 Thread John Rigby
The class of the MPC5121 pci host bridge is PCI_CLASS_BRIDGE_OTHER while other freescale host bridges have class set to PCI_CLASS_PROCESSOR_POWERPC. This patch makes fixup_hide_host_resource_fsl match PCI_CLASS_BRIDGE_OTHER in addition to PCI_CLASS_PROCESSOR_POWERPC. Signed-off-by: John Rigby

Re: [PATCH 5121 pci 1/3] powerpc: 83xx: pci: Remove need for get_immrbase from mpc83xx_add_bridge.

2008-08-13 Thread John Rigby
Grant Likely wrote: On Thu, Aug 07, 2008 at 11:36:25AM -0600, John Rigby wrote: Modify mpc83xx_add_bridge to get config space register base address from the device tree instead of immr + hardcoded offset. 83xx pci nodes have these changes: register properties now contain two address

Re: [PATCH 5121 pci 1/3] powerpc: 83xx: pci: Remove need for get_immrbase from mpc83xx_add_bridge.

2008-08-13 Thread John Rigby
Grant Likely wrote: On Wed, Aug 13, 2008 at 10:06 AM, John Rigby [EMAIL PROTECTED] wrote: On Thu, Aug 07, 2008 at 11:36:25AM -0600, John Rigby wrote: Can you use something like 'fsl,primary-pci-bridge' instead? 'primary' is a little too generic for my taste. Also, the purpose

[PATCH 5121 pci rev2 1/3] powerpc: 83xx: pci: Remove need for get_immrbase from mpc83xx_add_bridge.

2008-08-13 Thread John Rigby
Signed-off-by: John Rigby [EMAIL PROTECTED] --- .../powerpc/dts-bindings/fsl/83xx-512x-pci.txt | 40 ++ arch/powerpc/boot/dts/mpc8313erdb.dts |3 +- arch/powerpc/boot/dts/mpc8315erdb.dts |3 +- arch/powerpc/boot/dts/mpc832x_mds.dts

[PATCH 5121 pci rev2 3/3] powerpc: pci: 5121: Hide pci bridge.

2008-08-13 Thread John Rigby
The class of the MPC5121 pci host bridge is PCI_CLASS_BRIDGE_OTHER while other freescale host bridges have class set to PCI_CLASS_PROCESSOR_POWERPC. This patch makes fixup_hide_host_resource_fsl match PCI_CLASS_BRIDGE_OTHER in addition to PCI_CLASS_PROCESSOR_POWERPC. Signed-off-by: John Rigby

[PATCH 5121 pci rev2 2/3] powerpc: 5121: Add PCI support.

2008-08-13 Thread John Rigby
Uses mpc83xx_add_bridge in fsl_pci.c Adds second register tuple to pci node register property as done for 83xx device trees in a previous patch. Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/boot/dts/mpc5121ads.dts |3 ++- arch/powerpc/platforms/512x/Kconfig |2

[PATCH 3/3] powerpc: pci: 5121: Hide pci bridge.

2008-10-07 Thread John Rigby
The class of the MPC5121 pci host bridge is PCI_CLASS_BRIDGE_OTHER while other freescale host bridges have class set to PCI_CLASS_PROCESSOR_POWERPC. This patch makes fixup_hide_host_resource_fsl match PCI_CLASS_BRIDGE_OTHER in addition to PCI_CLASS_PROCESSOR_POWERPC. Signed-off-by: John Rigby

[PATCH 0/3] MPC5121 add pci support

2008-10-07 Thread John Rigby
The following three patches add pci support for MPC5121 These got no NACKs back in August but they were not picked up by anyone either. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH 1/3] powerpc: 83xx: pci: Remove need for get_immrbase from mpc83xx_add_bridge.

2008-10-07 Thread John Rigby
Signed-off-by: John Rigby [EMAIL PROTECTED] --- .../powerpc/dts-bindings/fsl/83xx-512x-pci.txt | 40 ++ arch/powerpc/boot/dts/mpc8313erdb.dts |3 +- arch/powerpc/boot/dts/mpc8315erdb.dts |3 +- arch/powerpc/boot/dts/mpc832x_mds.dts

[PATCH 2/3] powerpc: 5121: Add PCI support.

2008-10-07 Thread John Rigby
Uses mpc83xx_add_bridge in fsl_pci.c Adds second register tuple to pci node register property as done for 83xx device trees in a previous patch. Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/boot/dts/mpc5121ads.dts |3 ++- arch/powerpc/platforms/512x/Kconfig |2

[PATCH 2/3] powerpc: 5121: Add PCI support.

2008-10-07 Thread John Rigby
Uses mpc83xx_add_bridge in fsl_pci.c Adds second register tuple to pci node register property as done for 83xx device trees in a previous patch. Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/boot/dts/mpc5121ads.dts |3 ++- arch/powerpc/platforms/512x/Kconfig |2

[PATCH 0/7] mpc5121 support

2008-01-08 Thread John Rigby
The following series adds basic support for mpc5121. I'm hoping that this can get reviewed quickly so it can get into the for-2.6.25 tree. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH 5/7] Separate MPC52xx PSC FIFO registers from rest of PSC

2008-01-08 Thread John Rigby
This is in preparation for the addition of MPC512x PSC support. The main difference in the 512x is in the fifo registers. Signed-off-by: John Rigby [EMAIL PROTECTED] --- drivers/serial/mpc52xx_uart.c | 10 ++ include/asm-powerpc/mpc52xx_psc.h |3 +++ include/asm-ppc

[PATCH 3/7] Basic Freescale MPC512x support

2008-01-08 Thread John Rigby
/platforms/512x/* Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/Kconfig |2 +- arch/powerpc/platforms/512x/Kconfig | 20 ++ arch/powerpc/platforms/512x/Makefile |4 + arch/powerpc/platforms/512x/mpc5121_ads.c | 90

[PATCH 1/7] mpc5121: Add IPIC config option

2008-01-08 Thread John Rigby
IPIC is not just for 83xx anymore so make it a separate config option. Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/platforms/Kconfig |5 + arch/powerpc/sysdev/Makefile |2 +- 2 files changed, 6 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/platforms

[PATCH 4/7] Device tree for MPC5121 ADS

2008-01-08 Thread John Rigby
Bare minimum tree containing only what is currently supported. Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/boot/dts/mpc5121ads.dts | 102 ++ 1 files changed, 102 insertions(+), 0 deletions(-) create mode 100644 arch/powerpc/boot/dts

[PATCH 2/7] Add mpc512x ipic support

2008-01-08 Thread John Rigby
Added ipic_info entries for vectors used by 512x that were previously unused by 83xx. Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/sysdev/ipic.c | 62 1 files changed, 62 insertions(+), 0 deletions(-) diff --git a/arch/powerpc

[PATCH 6/7] Add mpc512x_find_ips_freq

2008-01-08 Thread John Rigby
Added mpc512x_find_ips_freq needed by the following serial driver patch. It is basically a renamed mpc512x_find_ipd_freq from 52xx. Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/platforms/512x/mpc5121_ads.c | 28 include/asm-powerpc/mpc512x.h

[PATCH 7/7] Add MPC512x PSC serial driver

2008-01-08 Thread John Rigby
mpc512x_uart.c is based on mpc52xx_uart.c with names changed arch/ppc support removed 512x psc fifo support added shares mpc52xx_psc.h with 52xx driver Signed-off-by: John Rigby [EMAIL PROTECTED] --- drivers/serial/Kconfig| 18 + drivers/serial/Makefile

Re: [PATCH 3/7] Basic Freescale MPC512x support

2008-01-08 Thread John Rigby
Olof Johansson wrote: Hi, diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 66a3d8c..81c3f05 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -470,7 +470,7 @@ config PCI bool PCI support if 40x || CPM2 || PPC_83xx || PPC_85xx || PPC_86xx \

Re: [PATCH 3/7] Basic Freescale MPC512x support

2008-01-08 Thread John Rigby
@@ -229,7 +229,7 @@ config NR_CPUS config NOT_COHERENT_CACHE bool -depends on 4xx || 8xx || E200 +depends on 4xx || 8xx || E200 || PPC_512x default y Why do you need this, when 5200 doesn't? Because the 5121 cache is not coherent. The 5121 is not

Re: [PATCH 3/7] Basic Freescale MPC512x support

2008-01-08 Thread John Rigby
Arnd Bergmann wrote: On Tuesday 08 January 2008, John Rigby wrote: obj-$(CONFIG_PPC_CHRP) += chrp/ obj-$(CONFIG_40x) += 40x/ obj-$(CONFIG_44x) += 44x/ +obj-$(CONFIG_PPC_512x) += 512x/ obj-$(CONFIG_PPC_MPC52xx) += 52xx/ obj

Re: [PATCH 7/7] Add MPC512x PSC serial driver

2008-01-08 Thread John Rigby
Thanks for the quick feedback Grant. Grant Likely wrote: Exactly *how* different is the 5121 PSC from the 5200 PSC? If it is really different, then it makes sense to clone. The fifo handling has completely changed that is the main difference. In fact; I'd duplicate the mpc52xx_psc.h file

Generic desktop/server/laptop lable is confusing [Was Re: [PATCH 3/7] Basic Freescale MPC512x support]

2008-01-08 Thread John Rigby
It may work, but it pulls in code like prom_init.c that is not needed on non-OF boards. It's also quite confusing to have an embedded board's checkbox only show up when you say yes to Generic desktop/server/laptop. I have to agree with this, I have been confused by this myself. Perhaps

[Add mpc5121 support PATCH v2 0/8]

2008-01-16 Thread John Rigby
This is a new improved set of patches based on the comments that I received in response to the previous set. I believe I addressed all the concerns raised but I'm sure there will be new ones. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org

[Add mpc5121 support PATCHES v3 0/8]

2008-01-17 Thread John Rigby
This is a new improved set of patches based on the comments that I received in response to the previous set. Changes since v2: 1/8 Add-IPIC-config-option.patch 2/8 Add-mpc512x-ipic-support.patch No changes. These two are in galak's queue for submission. 3/8

[Add mpc5121 support PATCH v3 1/8] Add IPIC config option

2008-01-17 Thread John Rigby
IPIC is not just for 83xx anymore so make it a separate config option. Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/platforms/Kconfig |5 + arch/powerpc/sysdev/Makefile |2 +- 2 files changed, 6 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/platforms

[Add mpc5121 support PATCH v3 4/8] Device tree for MPC5121 ADS

2008-01-17 Thread John Rigby
Minimal tree for mpc5121 ads. port-number property in uart nodes will go away after the driver learns to use aliases Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/boot/dts/mpc5121ads.dts | 120 ++ 1 files changed, 120 insertions(+), 0 deletions

[Add mpc5121 support PATCH v3 3/8] Basic Freescale MPC512x support

2008-01-17 Thread John Rigby
/platforms/512x/* include/asm-powerpc/mpc512x.h Signed-off-by: John Rigby [EMAIL PROTECTED] Acked-by: Grant Likely [EMAIL PROTECTED] --- arch/powerpc/Kconfig |2 +- arch/powerpc/platforms/512x/Kconfig | 20 ++ arch/powerpc/platforms/512x/Makefile |4

[Add mpc5121 support PATCH v3 7/8] Factor out 52xx dependencies from 52xx psc driver

2008-01-17 Thread John Rigby
PSCs change from 5200 to 5121 this patch localizes the differences in preparation for adding 5121 support Signed-off-by: John Rigby [EMAIL PROTECTED] --- drivers/serial/mpc52xx_uart.c | 256 ++-- 1 files changed, 192 insertions(+), 64 deletions(-) diff --git

[Add mpc5121 support PATCH v3 8/8] Add MPC512x support to MPC52xx psc driver

2008-01-17 Thread John Rigby
Add 512x support using the psc_ops framework established with the previous patch. All 512x PSCs share the same interrupt so add IRQF_SHARED to irq flags. Signed-off-by: John Rigby [EMAIL PROTECTED] --- drivers/serial/Kconfig| 12 ++-- drivers/serial/mpc52xx_uart.c | 177

[Add mpc5121 support PATCH v3 6/8] Cleanup checkpatch.pl problems in mpc52xx_uart.c

2008-01-17 Thread John Rigby
In preparation of adding MPC5121 support cleanup some things that checkpatch.pl complains about also some minor fixes suggested by Stephen Rothwell. Signed-off-by: John Rigby [EMAIL PROTECTED] --- drivers/serial/mpc52xx_uart.c | 204 ++--- 1 files changed

Re: [RFC/PATCH 1/2] [POWERPC] mpc5200: normalize compatible property bindings

2008-01-18 Thread John Rigby
Looks fine to me. Grant Likely wrote: From: Grant Likely [EMAIL PROTECTED] Update MPC5200 drivers to also look for compatible properties in the form fsl,mpc5200-* to better conform to open firmware generic names recommended practice as published here:

[POWERPC] mpc5200: Factor out 52xx dependencies from 52xx psc driver

2008-01-22 Thread John Rigby
This version fixes the problem of no output in userland on efika and liteb. PSCs change from 5200 to 5121 this patch localizes the differences in preparation for adding 5121 support Signed-off-by: John Rigby [EMAIL PROTECTED] --- drivers/serial/mpc52xx_uart.c | 256

[Add mpc5121 support PATCH v4 2/4] Device tree for MPC5121 ADS

2008-01-28 Thread John Rigby
Minimal /dts-v1/ device tree for mpc5121 ads. port-number property in uart nodes will go away after the driver learns to use aliases Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/boot/dts/mpc5121ads.dts | 122 ++ 1 files changed, 122 insertions

[Add mpc5121 support PATCH v4 1/4] Basic Freescale MPC512x support

2008-01-28 Thread John Rigby
/platforms/512x/* include/asm-powerpc/mpc512x.h Signed-off-by: John Rigby [EMAIL PROTECTED] Acked-by: Grant Likely [EMAIL PROTECTED] Conflicts: arch/powerpc/Kconfig --- arch/powerpc/Kconfig |2 +- arch/powerpc/platforms/512x/Kconfig | 20 ++ arch

[Add mpc5121 support PATCH v4 3/4] Factor out 5200 dependencies from 52xx psc driver

2008-01-28 Thread John Rigby
PSCs change from 5200 to 5121 this patch localizes the differences in preparation for adding 5121 support Signed-off-by: John Rigby [EMAIL PROTECTED] --- drivers/serial/mpc52xx_uart.c | 256 ++-- 1 files changed, 192 insertions(+), 64 deletions(-) diff --git

[Add mpc5121 support PATCH v4 0/4] Basic Freescale MPC512x support

2008-01-28 Thread John Rigby
New patches set hopefully for 2.6.25 Changes since v3 First four patches have already gone in via Grant and Kumar 1/4 Basic-Freescale-MPC512x-support.patch Previously Acked-by: Grant Likely [EMAIL PROTECTED] 2/4 Device-tree-for-MPC5121-ADS.patch Updated to /dts-v1/ 3/4 Factor out 5200

[Add mpc5121 support PATCH v4 4/4] Add MPC512x support to MPC52xx psc driver

2008-01-28 Thread John Rigby
Add 512x support using the psc_ops framework established with the previous patch. All 512x PSCs share the same interrupt so add IRQF_SHARED to irq flags. Signed-off-by: John Rigby [EMAIL PROTECTED] --- drivers/serial/Kconfig| 12 ++-- drivers/serial/mpc52xx_uart.c | 177

Re: [PATCH 02/12] fs_enet: Add MPC5121 FEC support.

2009-05-07 Thread John Rigby
Wolfgang, Welcome to my world and why I gave up on this months ago. Everyone else, One thing to consider here is a rewrite with the goal of a new improved fec driver that would work on both 5121 and the various mx platforms that also have this same fec core. Also don't forget that the register

Re: [PATCH 05/04] *** NOT FOR RELEASE *** HACK *** Work around MII clock issue ***

2009-05-07 Thread John Rigby
I think the fec's parent clock is the ipb clock not the ppc core clock. Could that be the problem? On Wed, May 6, 2009 at 2:21 PM, Wolfgang Denk w...@denx.de wrote: Signed-off-by: Wolfgang Denk w...@denx.de Cc: Grant Likely grant.lik...@secretlab.ca Cc: John Rigby jcri...@gmail.com

Re: [PATCH 08/12] mpc5121: Added I2C support.

2009-05-07 Thread John Rigby
Ok, the interrupt enabling should happen in the driver. Should it key off compatible or should a new property be added like the existing 5200 clocking property? On Wed, May 6, 2009 at 8:41 PM, Grant Likely grant.lik...@secretlab.cawrote: On Wed, May 6, 2009 at 4:51 PM, Grant Likely

Re: [PATCH 06/12] mpc5121: Added NAND Flash Controller driver.

2009-05-07 Thread John Rigby
On Wed, May 6, 2009 at 2:59 PM, Grant Likely grant.lik...@secretlab.cawrote: diff --git a/arch/powerpc/platforms/512x/mpc512x_shared.c b/arch/powerpc/platforms/512x/mpc512x_shared.c index d8cd579..7135d89 100644 --- a/arch/powerpc/platforms/512x/mpc512x_shared.c +++

Re: [PATCH 03/12] fs_enet: Add FEC TX Alignment workaround for MPC5121.

2009-05-07 Thread John Rigby
I was having deja-vu with this and realized that I have fixed at least some of the objections to this patch. Wolfgang you may want to look at the patch in my 5121 git tree here: http://git.denx.de/?p=linux-mpc512x.git;a=commit;h=2950be3be42af7449941c3340998c27ef918f10f It does runtime tx packet

Re: [rtc-linux] Re: [PATCH 10/12] mpc5121: Add MPC5121 Real time clock driver.

2009-05-07 Thread John Rigby
wrote: From: John Rigby jri...@freescale.com Based on Domen Puncer's rtc driver for 5200 posted to the ppclinux mailing list: http://patchwork.ozlabs.org/linuxppc-embedded/patch?id=11675 but never commited anywhere. Changes to Domen's original: Changed filenames/routine

  1   2   >