nce
management.
Signed-off-by: Andra Danciu
Signed-off-by: Mark Brown
---
sound/soc/fsl/imx-es8328.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/sound/soc/fsl/imx-es8328.c b/sound/soc/fsl/imx-es8328.c
index 9953438086e4..c9d8739b04a9 100644
--- a/sound/soc/
nce
management.
Signed-off-by: Andra Danciu
Signed-off-by: Mark Brown
---
sound/soc/fsl/imx-mc13783.c | 22 --
1 file changed, 8 insertions(+), 14 deletions(-)
diff --git a/sound/soc/fsl/imx-mc13783.c b/sound/soc/fsl/imx-mc13783.c
index 9d19b808f634..545815a27074 100644
--
nce
management.
Signed-off-by: Andra Danciu
Signed-off-by: Mark Brown
---
sound/soc/fsl/imx-pcm-fiq.c | 21 -
1 file changed, 8 insertions(+), 13 deletions(-)
diff --git a/sound/soc/fsl/imx-pcm-fiq.c b/sound/soc/fsl/imx-pcm-fiq.c
index 0578f3486847..c49aea4fba56 100644
--- a/so
nce
management.
Signed-off-by: Andra Danciu
Signed-off-by: Mark Brown
---
sound/soc/fsl/imx-spdif.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/sound/soc/fsl/imx-spdif.c b/sound/soc/fsl/imx-spdif.c
index 797d66e43d49..4f7f210beb18 100644
--- a/sound/soc/fsl/
ent.
Signed-off-by: Andra Danciu
Signed-off-by: Mark Brown
---
sound/soc/fsl/imx-ssi.c | 57 ++---
sound/soc/fsl/imx-ssi.h | 6 +
2 files changed, 26 insertions(+), 37 deletions(-)
diff --git a/sound/soc/fsl/imx-ssi.c b/sound/soc/fsl/imx-ssi.c
in
nce
management.
Signed-off-by: Andra Danciu
Signed-off-by: Mark Brown
---
sound/soc/fsl/mpc5200_dma.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/sound/soc/fsl/mpc5200_dma.c b/sound/soc/fsl/mpc5200_dma.c
index c1a4544eb16b..4396442c2fdd 100644
--- a/sound/soc/
nse compliance
management.
Signed-off-by: Andra Danciu
Signed-off-by: Mark Brown
---
sound/soc/fsl/mpc5200_psc_ac97.c | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/sound/soc/fsl/mpc5200_psc_ac97.c b/sound/soc/fsl/mpc5200_psc_ac97.c
index 07ee355ee
nse compliance
management.
Signed-off-by: Andra Danciu
Signed-off-by: Mark Brown
---
sound/soc/fsl/mpc5200_psc_i2s.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/sound/soc/fsl/mpc5200_psc_i2s.c b/sound/soc/fsl/mpc5200_psc_i2s.c
index d8232943ccb6..6de97461ba25 100
nce
management.
Signed-off-by: Andra Danciu
Signed-off-by: Mark Brown
---
sound/soc/fsl/mpc8610_hpcd.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/sound/soc/fsl/mpc8610_hpcd.c b/sound/soc/fsl/mpc8610_hpcd.c
index a639b52c16f6..f6261a3eeb0f 100644
--
nse compliance
management.
Signed-off-by: Andra Danciu
Signed-off-by: Mark Brown
---
sound/soc/fsl/mx27vis-aic32x4.c | 29 +++--
1 file changed, 7 insertions(+), 22 deletions(-)
diff --git a/sound/soc/fsl/mx27vis-aic32x4.c b/sound/soc/fsl/mx27vis-aic32x4.c
index d7ec3d200
nce
management.
Signed-off-by: Andra Danciu
Signed-off-by: Mark Brown
---
sound/soc/fsl/p1022_ds.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/sound/soc/fsl/p1022_ds.c b/sound/soc/fsl/p1022_ds.c
index 41c623c55c16..80384f70878d 100644
--- a/sound/soc/
nce
management.
Signed-off-by: Andra Danciu
Signed-off-by: Mark Brown
---
sound/soc/fsl/p1022_rdk.c | 32 ++--
1 file changed, 14 insertions(+), 18 deletions(-)
diff --git a/sound/soc/fsl/p1022_rdk.c b/sound/soc/fsl/p1022_rdk.c
index 4afbdd610bfa..1c32c2d8c6b0 100644
--
ase license compliance
management.
Signed-off-by: Andra Danciu
Signed-off-by: Mark Brown
---
sound/soc/fsl/pcm030-audio-fabric.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/sound/soc/fsl/pcm030-audio-fabric.c
b/sound/soc/fsl/pcm030-audio-fabric.c
in
nce
management.
Signed-off-by: Andra Danciu
Signed-off-by: Mark Brown
---
sound/soc/fsl/phycore-ac97.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/sound/soc/fsl/phycore-ac97.c b/sound/soc/fsl/phycore-ac97.c
index 66fb6c4614d2..fe7ba6db7c96 100644
--- a/so
nce
management.
Signed-off-by: Andra Danciu
Signed-off-by: Mark Brown
---
sound/soc/fsl/wm1133-ev1.c | 21 -
1 file changed, 8 insertions(+), 13 deletions(-)
diff --git a/sound/soc/fsl/wm1133-ev1.c b/sound/soc/fsl/wm1133-ev1.c
index 2f80b21b2921..aad24ccbef90 100644
--- a/sound/
ld always set registers of Tx which relate with the
bit clock and frame clock generation (TCCR, TCR, ECR), even
there is only Rx is working.
Signed-off-by: Shengjiu Wang
Acked-by: Nicolin Chen
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_esai.c | 21 ++---
1 file changed,
On Mon, Apr 01, 2019 at 10:11:44PM +1100, Michael Ellerman wrote:
> Anyway I think what you've done in next, make the code depend on
> COMMON_CLOCK, is the best option. If anyone cares about that driver on
> powerpc platforms that don't support COMMON_CLOCK they should speak up.
It's probably fin
g"
There is a spelling mistake in a dev_err message. Fix this.
Signed-off-by: Colin Ian King
Reviewed-by: Mukesh Ojha
Acked-by: Viorel Suman
Signed-off-by: Mark Brown
---
sound/soc/fsl/imx-audmix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/imx-audmix.
man
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_audmix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl_audmix.c b/sound/soc/fsl/fsl_audmix.c
index 3356cb617713..dabde0342c95 100644
--- a/sound/soc/fsl/fsl_audmix.c
+++ b/sound/soc/fsl/fsl_audmix.c
@@ -90,7 +9
On Wed, Mar 27, 2019 at 03:29:55PM +1100, Michael Ellerman wrote:
> Mark Brown writes:
> > Hrm, seems PowerPC is still not using the common clock API - is there
> > any plan for that? There are some ASoC PowerPC uses so it's going to be
> > a bit of an issue as we e
The Audio Mixer is a on-chip functional module that allows mixing of
two audio streams into a single audio stream.
Audio Mixer datasheet is available here:
https://www.nxp.com/docs/en/reference-manual/IMX8DQXPRM.pdf
Signed-off-by: Viorel Suman
Signed-off-by: Mark Brown
---
sound/soc/fsl/Kcon
ver.
Signed-off-by: Viorel Suman
Signed-off-by: Mark Brown
---
.../devicetree/bindings/sound/fsl,audmix.txt | 54 +++
1 file changed, 54 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/fsl,audmix.txt
diff --git a/Documentation/devicetree/bindings/sound/
r the channel number setting on the
asrc of older version (e.g. imx35), the channel number should
be even, odd number isn't valid.
So add this constraint when the asrc of older version is used.
Acked-by: Nicolin Chen
Signed-off-by: Shengjiu Wang
Signed-off-by: Mark Brown
---
sound/soc/f
driver")
Cc:
Reviewed-by: Fabio Estevam
Acked-by: Nicolin Chen
Signed-off-by: Shengjiu Wang
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_esai.c | 47 +++-
1 file changed, 37 insertions(+), 10 deletions(-)
diff --git a/sound/soc/fsl/fsl_esai.c b
On Tue, Mar 19, 2019 at 02:08:20AM +, S.j. Wang wrote:
> Hi Mark
>
> Can this patch be accepted? Or need I do any update?
Please don't send content free pings and please allow a reasonable time
for review. People get busy, go on holiday, attend conferences and so
on so unless there is
On Fri, Mar 01, 2019 at 06:55:25AM +, S.j. Wang wrote:
> > Alternatively, I feel instead of error-out at here, should we add a HW
> > constraint or at least fence it off at the beginning of the hw_params()?
> > This
> > is actually nothing specific to the pair-request function but a hardware
0.c:177:1-7: ERROR: missing put_device;
call of_find_device_by_node on line 105, but without a corresponding
object release within this function.
Signed-off-by: Wen Yang
Cc: Timur Tabi
Cc: Nicolin Chen
Cc: Xiubo Li
Cc: Fabio Estevam
Cc: Liam Girdwood
Cc: Mark Brown
Cc: Jaroslav Kysela
Cc: Taka
nge. Use a proper type to handle sysclk_df.
Signed-off-by: Viorel Suman
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_spdif.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
index a26686e7281c..4842e6df9a2d 100
nge. Use a proper type to handle sysclk_df.
Signed-off-by: Viorel Suman
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_spdif.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
index a26686e7281c..4842e6df9a2d 100
ned-off-by: Mark Brown
---
sound/soc/fsl/fsl_spdif.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl_spdif.h b/sound/soc/fsl/fsl_spdif.h
index 7666dabaccfd..e6c61e07bc1a 100644
--- a/sound/soc/fsl/fsl_spdif.h
+++ b/sound/soc/fsl/fsl_spdif.h
@@ -152,7 +152,7 @@ e
The of_find_device_by_node() takes a reference to the underlying device
structure, we should release that reference.
Signed-off-by: Wen Yang
Cc: Timur Tabi
Cc: Nicolin Chen
Cc: Xiubo Li
Cc: Fabio Estevam
Cc: Liam Girdwood
Cc: Mark Brown
Cc: Jaroslav Kysela
Cc: Takashi Iwai
Cc: alsa-de...@alsa-project.org
Nicolin Chen
Cc: Xiubo Li
Cc: Fabio Estevam
Cc: Liam Girdwood
Cc: Mark Brown
Cc: Jaroslav Kysela
Cc: Takashi Iwai
Cc: alsa-de...@alsa-project.org
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Rob Herring
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl-asoc-card.c | 6 +++---
sound/s
On Tue, Nov 06, 2018 at 08:56:39AM -0600, Pierre-Louis Bossart wrote:
> > However, looking at what else can enable SND_HDA, I think it should be
> > select SND_SOC_HDAC_HDA if SND_PCI || ARCH_TEGRA
> This codec can only be used by the Skylake driver (and the upcoming SOF
> one). For Tegra t
On Tue, Sep 04, 2018 at 12:15:23AM +0200, Henrik Austad wrote:
> This is a respin with a wider audience (all that get_maintainer returned)
> and I know this spams a *lot* of people. Not sure what would be the correct
> way, so my apologies for ruining your inbox.
Acked-by: M
On Tue, Aug 28, 2018 at 10:44:28AM -0500, Rob Herring wrote:
> In preparation to remove the node name pointer from struct device_node,
> convert printf users to use the %pOFn format specifier.
Please don't send new patches in reply to existing threads, it makes it
harder to follow what the current
t-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 1222121 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_esai.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/fsl
txclk_df * 64
Addresses-Coverity-ID: 1222129 ("Unintentional integer overflow")
Signed-off-by: Gustavo A. R. Silva
Acked-by: Nicolin Chen
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_spdif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl_
On Tue, Jun 19, 2018 at 04:29:35PM +, York Sun wrote:
> Joakim,
>
> I am not the maintainer for this driver. Adding Mark Brown.
>
> York
>
> On 06/19/2018 09:23 AM, Joakim Tjernlund wrote:
> > espi does not look for a OF cell-index property which
> > mak
an actual
input clock or a desired frequency of an output clock for HCKT/R.
It should never be passed 0. This might cause Division-by-zero.
So this patch adds a check to fix it.
Signed-off-by: Nicolin Chen
Reviewed-by: Fabio Estevam
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_esai.c
setting from
the set_dai_fmt().
Reported-by: Mika Penttilä
Signed-off-by: Nicolin Chen
Tested-by: Mika Penttilä
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_ssi.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/
fix could be just to set PM directly instead of going
into the loop-search.
Reported-by: Marek Vasut
Signed-off-by: Nicolin Chen
Tested-by: Marek Vasut
Reviewed-by: Fabio Estevam
Signed-off-by: Mark Brown
Cc: sta...@vger.kernel.org
---
sound/soc/fsl/fsl_esai.c | 7 +++
1 file changed
leb Crome
Tested-by: Maciej S. Szmigiero
Reviewed-by: Maciej S. Szmigiero
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_ssi.c | 4
sound/soc/fsl/fsl_ssi.h | 3 ---
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index 24f
y: Nicolin Chen
Tested-by: Caleb Crome
Tested-by: Maciej S. Szmigiero
Reviewed-by: Maciej S. Szmigiero
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_ssi.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_s
cation. It also removes masking SSIEN from scr value
since it's handled later by regmap_update_bits() to set this
scr value back.
Signed-off-by: Nicolin Chen
Tested-by: Caleb Crome
Tested-by: Maciej S. Szmigiero
Reviewed-by: Maciej S. Szmigiero
Signed-off-by: Mark Brown
---
sound/soc/fs
a variable to log the active
streams manually.
Signed-off-by: Nicolin Chen
Tested-by: Caleb Crome
Tested-by: Maciej S. Szmigiero
Reviewed-by: Maciej S. Szmigiero
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_ssi.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff
bisects fsl_ssi_disable_val into two macros of two
corresponding steps and then shortens its parameter names. It also
updates callers in the fsl_ssi_config() accordingly.
Signed-off-by: Nicolin Chen
Tested-by: Caleb Crome
Tested-by: Maciej S. Szmigiero
Reviewed-by: Maciej S. Szmigiero
Signed-off-by: Ma
Reviewed-by: Maciej S. Szmigiero
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_ssi.c | 256 +++-
1 file changed, 122 insertions(+), 134 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index d276b78684e4..9f024a9afaa5 100644
d-off-by: Mark Brown
---
sound/soc/fsl/fsl_ssi.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index 9f024a9afaa5..fc5768d243d1 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -90,
ges:
1) Moving DBG bits to the first lines.
2) Setting SSIE, RE/TE as default and cleaning it for AC97
Signed-off-by: Nicolin Chen
Tested-by: Caleb Crome
Tested-by: Maciej S. Szmigiero
Reviewed-by: Maciej S. Szmigiero
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_ssi.c | 17 ++---
ame time.
Signed-off-by: Nicolin Chen
Tested-by: Caleb Crome
Tested-by: Maciej S. Szmigiero
Reviewed-by: Maciej S. Szmigiero
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_ssi.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/f
ity.
Signed-off-by: Nicolin Chen
Tested-by: Caleb Crome
Tested-by: Maciej S. Szmigiero
Reviewed-by: Maciej S. Szmigiero
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_ssi.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ss
y: Caleb Crome
Tested-by: Maciej S. Szmigiero
Reviewed-by: Maciej S. Szmigiero
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_ssi.c | 74 +++--
1 file changed, 35 insertions(+), 39 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/f
j S. Szmigiero
Reviewed-by: Maciej S. Szmigiero
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_ssi.c | 219 +++-
1 file changed, 124 insertions(+), 95 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index b58fabe77c6f..5bc67ad80
the cpu_dai_drv is a bit implicit,
so this patch adds a bool synchronous instead.
Signed-off-by: Nicolin Chen
Tested-by: Caleb Crome
Tested-by: Maciej S. Szmigiero
Reviewed-by: Maciej S. Szmigiero
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_ssi.c | 13 -
1 file changed, 8 insertions(+)
eing updated along with SCR register and
its SSIEN bit, it's simpler to use it instead.
Signed-off-by: Nicolin Chen
Tested-by: Caleb Crome
Tested-by: Maciej S. Szmigiero
Reviewed-by: Maciej S. Szmigiero
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_ssi.c | 7 +--
1 file changed,
r Roeck
Acked-by: Nicolin Chen
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_dma.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/fsl/fsl_dma.c b/sound/soc/fsl/fsl_dma.c
index 0c11f434a374..8c2981b70f64 100644
--- a/sound/soc/fsl/fsl_dma.c
+++ b/sound/soc/f
nes.
Signed-off-by: Nicolin Chen
Tested-by: Maciej S. Szmigiero
Reviewed-by: Maciej S. Szmigiero
Acked-by: Timur Tabi
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_ssi.c | 456 +++-
1 file changed, 220 insertions(+), 236 deletions(-)
diff --gi
e some space to have more print info or save
some wrapped lines.
Signed-off-by: Nicolin Chen
Tested-by: Maciej S. Szmigiero
Reviewed-by: Maciej S. Szmigiero
Acked-by: Timur Tabi
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_ssi.c | 64 -
1
-by: Maciej S. Szmigiero
Reviewed-by: Maciej S. Szmigiero
Acked-by: Timur Tabi
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_ssi.c | 383
sound/soc/fsl/fsl_ssi.h | 67 +++-
sound/soc/fsl/fsl_ssi_dbg.c | 12 +-
3 files changed, 208 inserti
and SSI_xxx_yyy style.
It also slightly reduces the length of them to save some space.
Signed-off-by: Nicolin Chen
Tested-by: Maciej S. Szmigiero
Reviewed-by: Maciej S. Szmigiero
Acked-by: Timur Tabi
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_ssi.c |
off-by: Nicolin Chen
Tested-by: Maciej S. Szmigiero
Reviewed-by: Maciej S. Szmigiero
Acked-by: Timur Tabi
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_ssi.c | 239 +---
sound/soc/fsl/fsl_ssi.h | 2 +-
sound/soc/fsl/fsl_ssi_dbg.c | 3 +-
3 fi
mat.
It also reduces the length of one line and adds spaces to an operator.
Signed-off-by: Nicolin Chen
Tested-by: Maciej S. Szmigiero
Reviewed-by: Maciej S. Szmigiero
Acked-by: Timur Tabi
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_ssi.c | 16
1 file changed, 8 insertions(+)
err outputs.
Signed-off-by: Nicolin Chen
Tested-by: Maciej S. Szmigiero
Reviewed-by: Maciej S. Szmigiero
Acked-by: Timur Tabi
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_ssi.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/sound/soc/
-by: Nicolin Chen
Tested-by: Maciej S. Szmigiero
Reviewed-by: Maciej S. Szmigiero
Acked-by: Timur Tabi
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_ssi.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
in
ith the name "vals"
to get rid of the name "reg" -- could be confusing with "regs"
in the private struct for regmap.
Signed-off-by: Nicolin Chen
Tested-by: Maciej S. Szmigiero
Reviewed-by: Maciej S. Szmigiero
Acked-by: Timur Tabi
Signed-off-by: Mark Brown
ave it in the name. This patch also adds its MASK define.
Signed-off-by: Nicolin Chen
Tested-by: Maciej S. Szmigiero
Reviewed-by: Maciej S. Szmigiero
Acked-by: Timur Tabi
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_ssi.c | 24
sound/soc/fsl/fsl_ssi.h | 1 +
2 fi
it.
Signed-off-by: Nicolin Chen
Tested-by: Maciej S. Szmigiero
Reviewed-by: Maciej S. Szmigiero
Acked-by: Timur Tabi
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_ssi.c | 27 +++
sound/soc/fsl/fsl_ssi.h | 4
2 files changed, 15 insertions(+), 16 deletions(-)
d
On Mon, Dec 04, 2017 at 12:46:34PM -0800, Nicolin Chen wrote:
> struct device is defined in system level header files any way.
> As long as fsl_ssi.h is included after those header files, it
> should be safe to remove this line.
It's better practice to either directly include those headers or have
On Wed, Nov 29, 2017 at 10:23:23PM +0100, Takashi Iwai wrote:
> Mark, I already took this into my tree, as it's a change in ALSA core
> stuff. As mentioned in another mail, the branch was exposed to
> topic/pcm-20bit branch, so that you can pull cleanly.
That's what this is reporting - the resul
The patch
ALSA: pcm: add SNDRV_PCM_FORMAT_{S,U}20
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus
erent bit widths in playback and capture
in AC'97 mode so allow this, too.
Signed-off-by: Maciej S. Szmigiero
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_ssi.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
ind
orthy and extra channel slots enabled
mean ruined playback let's play safe here and make sure that no extra
slots are enabled in SACCST every time a playback is started.
Signed-off-by: Maciej S. Szmigiero
Acked-by: Nicolin Chen
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_ssi.c | 52 ++
s.
Signed-off-by: Maciej S. Szmigiero
Acked-by: Nicolin Chen
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_ssi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index 9e97a0529f37..939d1b8894dc 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/soun
driver takes 100us+ let's
use a mutex for this.
Use this opportunity to also change a default value returned from AC'97
register read function from -1 to 0, since that's what AC'97 specs require
to be returned when unknown / undefined registers are read.
Signed-off-by: Maci
g up
on failure
AC'97 ops (register read / write) need SSI regmap and clock, so they have
to be set after them.
We also need to set these ops back to NULL if we fail the probe.
Signed-off-by: Maciej S. Szmigiero
Acked-by: Nicolin Chen
Signed-off-by: Mark Brown
Cc: sta...@vger.kernel.org
giero
Acked-by: Nicolin Chen
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_ssi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index 424bafaf51ef..9e97a0529f37 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@
Hi all,
Today's linux-next merge of the powerpc tree got a conflict in:
arch/powerpc/kvm/powerpc.c
between commit:
ac64115a66c1 ("KVM: PPC: Fix oops when checking KVM_CAP_PPC_HTM")
from Linus' tree and commit:
2a3d6553cbd7 ("KVM: PPC: Tie KVM_CAP_PPC_HTM to the user-visible TM feature")
ust check its return value.
Signed-off-by: Arvind Yadav
Acked-by: Peter Ujfalusi
Signed-off-by: Mark Brown
---
sound/soc/davinci/davinci-mcasp.c | 12
1 file changed, 12 insertions(+)
diff --git a/sound/soc/davinci/davinci-mcasp.c
b/sound/soc/davinci/davinci-mcasp.c
index 40be08cec
we must check its return value.
Signed-off-by: Arvind Yadav
Signed-off-by: Mark Brown
---
sound/soc/omap/omap-hdmi-audio.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/soc/omap/omap-hdmi-audio.c b/sound/soc/omap/omap-hdmi-audio.c
index 3e9cc4842a1d..8eeac7cab1c1 100644
--- a/sound/
ust check its return value.
Signed-off-by: Arvind Yadav
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl-asoc-card.c | 4
1 file changed, 4 insertions(+)
diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c
index 3772abbdd7b7..1225e0399de8 100644
--- a/sound/soc/fsl/
On Thu, Sep 21, 2017 at 10:50:03AM +0530, Arvind Yadav wrote:
> devm_kasprintf() can fail here and we must check its return value.
This is patch 2/3 but you've only sent me this one patch. This is
missing the point of numbering a series, the only reason for the
numbering is to provide ordering wi
his
patch changes the driver to calculate the bit clock rate using the
slot number and the slot width from the via set_tdm_slot().
The patch also removes an obsolete comment of the dir parameter.
Signed-off-by: Nicolin Chen
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_ssi.c |
_set_tdm_slot()
in the soc-core.c will return -ENOTSUPP if there is no function
implementation for them in the dai and component drivers.
So this patch tries to ignore this errno.
Signed-off-by: Nicolin Chen
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl-asoc-card.c | 10 +-
1 fi
On Tue, Sep 05, 2017 at 10:45:29AM -0700, Nicolin Chen wrote:
> The ipg clock is merely used to access registers, and has nothing
> (directly) to do with external clock outputs. The driver shall not
> change the ipg clock as the system ipg clock (its parent clock)
> might be messed and even system
On Tue, Sep 05, 2017 at 10:19:05AM +0200, Łukasz Majewski wrote:
> On 09/05/2017 09:52 AM, Nicolin Chen wrote:
> > Can you elaborate why you set ipg clock as bclk? I don't remember SSI could
> > derive bitclock from ipg clock.
> Just to be clear:
> What clock shall be set with:
> struct snd_soc
_spdif.o
Signed-off-by: Colin Ian King
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_spdif.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
index 7e6cc4da0088..4f7469c1864c 100644
--- a/sound/soc/fsl/fsl_spdif.c
+++
DT
full_name changes, just remove it.
Signed-off-by: Rob Herring
Cc: Timur Tabi
Cc: Nicolin Chen
Cc: Xiubo Li
Cc: Fabio Estevam
Cc: Liam Girdwood
Cc: Mark Brown
Cc: Jaroslav Kysela
Cc: Takashi Iwai
Cc: alsa-de...@alsa-project.org
Cc: linuxppc-dev@lists.ozlabs.org
Reviewed-by: Fabio Estevam
Sig
ion snd_soc_set_runtime_hwparams, which is const or used
in a copy operation.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
Signed-off-by: Mark Brown
---
sound/soc/qcom/lpass-platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/qcom/lpass-platform.c b/sound/
ion snd_soc_set_runtime_hwparams, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
Signed-off-by: Mark Brown
---
sound/soc/sh/dma-sh7760.c | 2 +-
sound/soc/sh/fsi.c| 2 +-
sound/soc/sh/rcar/core.c | 2 +-
sound/soc/sh/siu_dai.c| 2 +-
4 files changed, 4 insertions(+)
to the
function snd_soc_set_runtime_hwparams, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
Signed-off-by: Mark Brown
---
sound/soc/intel/skylake/skl-pcm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/skylake/skl-pcm.c
b/sound/soc/in
ing Coccinelle.
Signed-off-by: Bhumika Goyal
Signed-off-by: Mark Brown
---
sound/soc/intel/atom/sst-mfld-platform-pcm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/atom/sst-mfld-platform-pcm.c
b/sound/soc/intel/atom/sst-mfld-platform-pcm.c
index b272df5ce
the function snd_soc_set_runtime_hwparams, which is const or used in
a copy operation.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
Signed-off-by: Mark Brown
---
sound/soc/kirkwood/kirkwood-dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/kirkwood/kirkwood-dma.c
ion snd_soc_set_runtime_hwparams, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_asrc_dma.c | 2 +-
sound/soc/fsl/imx-pcm-fiq.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/fsl/fsl_asrc_dma.c b/so
ier, convert users of
full_name to use %pOF instead. This is preparation to remove storing
of the full path string for each node.
Signed-off-by: Rob Herring
Acked-by: Nicolin Chen
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_dma.c| 4 ++--
sound/soc/fsl/imx-audmux.c | 16
2 fi
ops field of a snd_soc_dai_driver
structure. That field is declared const, so snd_soc_dai_ops structures
that have this property can be declared as const also.
Signed-off-by: Gustavo A. R. Silva
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_spdif.c | 2 +-
1 file changed, 1 insertion(+
ps field of a snd_soc_dai_driver
structure. That field is declared const, so snd_soc_dai_ops structures
that have this property can be declared as const also.
Signed-off-by: Gustavo A. R. Silva
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_esai.c | 2 +-
1 file changed, 1 insertion(+), 1 dele
ps field of a snd_soc_dai_driver
structure. That field is declared const, so snd_soc_dai_ops structures
that have this property can be declared as const also.
Signed-off-by: Gustavo A. R. Silva
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_asrc.c | 2 +-
1 file changed, 1 insertion(+), 1 dele
On Fri, Jul 14, 2017 at 04:08:21AM -0700, Joe Perches wrote:
> On Fri, 2017-07-14 at 12:02 +0100, Mark Brown wrote:
> > On Thu, Jul 13, 2017 at 11:18:11AM -0700, Joe Perches wrote:
> > > I don't it's better.
> > > It's not that confusing if the 0/n p
On Thu, Jul 13, 2017 at 11:18:11AM -0700, Joe Perches wrote:
> I don't it's better.
> It's not that confusing if the 0/n patch cover letter is cc'd
> to all the appropriate mailing lists and all the [1..n]/n
> patches are sent with in-reply-to of the cover letter and
> send to the maintainers and
On Thu, Jul 13, 2017 at 09:32:41AM +0200, Takashi Iwai wrote:
> please stop posting in this style. It's really annoying to see
> spontaneously popping-up almost same patch for more than two hours
> long.
> If you have a series of the same fix patches, send them as a patch
> set in a shot with a
501 - 600 of 961 matches
Mail list logo