Re: [PATCH] ASoC: fsl_ssi: Don't try to round-up for PM divisor calculation

On Wed, Mar 04, 2015 at 09:05:04PM -0800, Nicolin Chen wrote: According to i.MX6 Series Reference Manual, the formula to calculate the sys clock is Applied, thanks. signature.asc Description: Digital signature ___ Linuxppc-dev mailing list

Re: [PATCH] mtd/spi: support en25s64 device

On Fri, Mar 27, 2015 at 05:38:30PM +0800, Shengzhou Liu wrote: Add support for EON en25s64 spi device. Signed-off-by: Shengzhou Liu shengzhou@freescale.com --- drivers/mtd/spi-nor/spi-nor.c | 1 + 1 file changed, 1 insertion(+) This is a MTD driver, not a SPI driver - you need to send

Re: [PATCH] spi: fsl-spi: fix devm_ioremap_resource() error case

On Thu, Apr 23, 2015 at 02:11:47PM +0200, Christophe Leroy wrote: devm_ioremap_resource() doesn't return NULL but an ERR_PTR on error. Applied, thanks. signature.asc Description: Digital signature ___ Linuxppc-dev mailing list

Re: [PATCH v3] spi: fsl-spi: use devm_ioremap_resource() to map parameter ram on CPM1

On Wed, Apr 22, 2015 at 04:28:20PM +0200, Christophe Leroy wrote: On CPM2, the SPI parameter RAM is dynamically allocated in the dualport RAM whereas in CPM1, it is statically allocated to a default address with capability to relocate it somewhere else via the use of CPM micropatch. The

Re: [PATCH 3/4] ASoC: fsl: Constify platform_device_id

On Sat, May 02, 2015 at 01:00:13AM +0900, Krzysztof Kozlowski wrote: The platform_device_id is not modified by the driver and core uses it as const. Applied, thanks. signature.asc Description: Digital signature ___ Linuxppc-dev mailing list

Re: [PATCH 4/4] ASoC: samsung: Constify platform_device_id

On Sat, May 02, 2015 at 01:00:14AM +0900, Krzysztof Kozlowski wrote: The platform_device_id is not modified by the driver and core uses it as const. Applied, thanks. signature.asc Description: Digital signature ___ Linuxppc-dev mailing list

Re: [PATCH 1/4] ASoC: au1x: Constify platform_device_id

On Sat, May 02, 2015 at 01:00:11AM +0900, Krzysztof Kozlowski wrote: The platform_device_id is not modified by the driver and core uses it as const. Applied, thanks. signature.asc Description: Digital signature ___ Linuxppc-dev mailing list

Re: [PATCH 2/4] ASoC: bt-sco: Constify platform_device_id

On Sat, May 02, 2015 at 01:00:12AM +0900, Krzysztof Kozlowski wrote: The platform_device_id is not modified by the driver and core uses it as const. Applied, thanks. signature.asc Description: Digital signature ___ Linuxppc-dev mailing list

Re: [alsa-devel][PATCH v2 1/3] ASoC: fsl_sai: add sai master mode support

On Wed, May 13, 2015 at 03:12:59PM +0800, Zidan Wang wrote: When sai works on master mode, set its bit clock and frame clock. SAI has 4 MCLK source, bus clock, MCLK1, MCLK2 and MCLK3. fsl_sai_set_bclk will select proper MCLK source, then calculate and set the bit clock divider. This looks

Re: [PATCH 1/3] ASoC: fsl_sai: add sai master mode support

On Mon, May 11, 2015 at 06:24:41PM +0800, Zidan Wang wrote: When sai works on master mode, set its bit clock and frame clock. SAI has 4 MCLK source, bus clock, MCLK1, MCLK2 and MCLK3. fsl_sai_set_bclk will select proper MCLK source, then calculate and set the bit clock divider. Applied,

Re: [PATCH 2/3] ASoC: fsl_sai: Add tdm slots operation for SAI master mode

On Mon, May 11, 2015 at 06:24:42PM +0800, Zidan Wang wrote: if (!sai-is_slave_mode) { + slot_width = sai-slot_width; ret = fsl_sai_set_bclk(cpu_dai, tx, - 2 * word_width * params_rate(params)); + sai-slots *

Re: [PATCH 3/3] ASoC: fsl_sai: add 12kHz, 24kHz, 176.4kHz and 192kHz sample rate support

On Mon, May 11, 2015 at 06:24:43PM +0800, Zidan Wang wrote: Normally we don't support 12kHz, 24kHz in audio driver, alsa didn't have formal definition of 12kHz, 24kHz, but alsa supply a way to support these sample rates. And add 176.4kHz and 192kHz support. Applied, thanks. signature.asc

Re: [alsa-devel][PATCH] ASoC: fsl: add imx-wm8960 machine driver

On Wed, Jun 10, 2015 at 04:26:27PM +0800, Zidan Wang wrote: + - hp-det : ADCLRC/GPIO1, LINPUT3/JD2 and RINPUT3/JD3 pins can + be selected as headphone jack detect inputs to + automatically disable the speaker output and enable +

Re: [patch] ASoC: fsl: add an error check

On Wed, Jun 10, 2015 at 06:37:23PM +0300, Dan Carpenter wrote: My static checker complains that: sound/soc/fsl/imx-wm8962.c:196 imx_wm8962_probe() warn: we tested 'ret' before and it was 'false' Applied, thanks. signature.asc Description: Digital signature

Re: [PATCH] ASoC: fsl_spdif: Don't try to round-up for clock divisor calculation

On Sun, May 24, 2015 at 01:12:41AM -0700, Nicolin Chen wrote: As commit 6c8ca30eec7b (ASoC: fsl_ssi: Don't try to round-up for PM divisor calculation) mentioned that there's no more need to use a round up work around to get a better divisor since the clk-divider driver has been refined a lot.

Re: [PATCH 6/6 v2] ASoC: fsl_ssi: adjust set DAI format in AC'97 mode

On Mon, Aug 03, 2015 at 12:44:11AM +0200, Maciej S. Szmigiero wrote: Adjust set DAI format function in fsl_ssi driver so it doesn't fail and clears RXDIR in AC'97 mode. Changes from v1: fix indentation to be consistent with rest of the driver. Inter version changelogs go after the --- as

Re: [PATCH 6/6 v2] ASoC: fsl_ssi: adjust set DAI format in AC'97 mode

On Tue, Aug 04, 2015 at 12:42:48AM +0200, Maciej S. Szmigiero wrote: In cases like this where only one patch of six patch series is updated should other ones be resubmitted as well to keep the full patch series together? Yes, any unapplied patches should be resubmitted. signature.asc

Re: [PATCH] spi: mpc512x-psc: add support for Freescale MPC5125

On Tue, Jul 14, 2015 at 11:19:56AM +0200, Uwe Kleine-König wrote: static const struct of_device_id mpc512x_psc_spi_of_match[] = { - { .compatible = fsl,mpc5121-psc-spi, }, + { .compatible = fsl,mpc5121-psc-spi, .data = (void *)TYPE_MPC5121 }, + { .compatible =

Re: [PATCH] spi: mpc512x-psc: add support for Freescale MPC5125

On Wed, Jul 15, 2015 at 09:40:19AM +0200, Uwe Kleine-König wrote: On Tue, Jul 14, 2015 at 10:54:42AM +0100, Mark Brown wrote: static const struct of_device_id mpc512x_psc_spi_of_match[] = { - { .compatible = fsl,mpc5121-psc-spi, }, + { .compatible = fsl,mpc5121-psc-spi, .data = (void

Re: [PATCH] [media] move media platform data to linux/platform_data/media

On Tue, Nov 17, 2015 at 07:15:59AM -0200, Mauro Carvalho Chehab wrote: > Now that media has its own subdirectory inside platform_data, > let's move the headers that are already there to such subdir. Acked-by: Mark Brown <broo...@kernel.org> signature.asc Description: P

Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults

On Mon, Jan 11, 2016 at 07:23:54PM -0600, Timur Tabi wrote: > Mark Brown wrote: > >regcache handles this fine, it's perfectly happy to just go and allocate > >the cache as registers get used (this is why the code that's doing the > >allocation exists...). What is

Re: [PATCH 1/2] ASoC: fsl: imx-sgtl5000: make audmux optional for imx sound driver

On Tue, Jan 12, 2016 at 07:13:30PM +0100, Lothar Waßmann wrote: > i.MX6UL does not have the audio multiplexer (AUDMUX) like e.g. i.MX6Q, > but apart from that can use the same audio driver. Make audmux > optional for the imx-sgtl5000 driver, so it can be used on i.MX6UL > too. Also i.MX6UL

Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults

On Mon, Jan 11, 2016 at 09:45:37AM -0600, Timur Tabi wrote: > Ok, I'm confused. Granted, all of this regcache stuff was added after I > stopped working on this driver, so I'm out of the loop. But it appears that > the regcache cannot properly handle an uninitialized cache. I would expect > it

Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults

On Mon, Jan 11, 2016 at 10:10:56AM -0200, Fabio Estevam wrote: > On Mon, Jan 11, 2016 at 10:04 AM, Fabio Estevam wrote: > > [2.526984] [ cut here ] > > [2.531632] WARNING: CPU: 1 PID: 1 at kernel/locking/lockdep.c:2755 > >

Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults

On Mon, Jan 11, 2016 at 03:10:20PM +0100, Maciej S. Szmigiero wrote: > On 11.01.2016 15:00, Mark Brown wrote: > > I suspect not, it looks like the driver is using the cache for > > suspend/resume handling. I've dropped the patch for now. Either the > > driver sh

Re: [PATCH] ASoC: fsl_ssi: remove explicit register defaults

On Mon, Feb 01, 2016 at 05:58:06PM +0100, Maciej S. Szmigiero wrote: > Looks like a possible solution would be to change > regmap_raw_read() to do read using _regmap_read in > case the cache is bypassed and there is no ->read > callback defined for regmap implementation. No, that's completely

Re: [PATCH] ASoC: fsl_ssi: remove explicit register defaults

On Mon, Feb 01, 2016 at 10:30:53PM +0100, Maciej S. Szmigiero wrote: > On 01.02.2016 22:10, Mark Brown wrote: > > No, that's completely broken. We can't do a raw read from a regmap that > > doesn't offer raw access and we shouldn't pretend to do so. If the > > caller is ca

Re: [PATCH 1/1] ASoC: fsl_ssi: add CCSR_SSI_SOR to volatile register list

On Mon, Apr 25, 2016 at 10:50:24AM -0700, Caleb Crome wrote: > Due to caching, SOR wasn't written when it should have been. This > patch simply adds SOR to the volatile list. Could you expand on when it wasn't written and why it needed to be please? signature.asc Description: PGP signature

Applied "ASoC: fsl_ssi: add CCSR_SSI_SOR to volatile register list" to the asoc tree

Reviewed-by: Fabio Estevam <fabio.este...@nxp.com> Acked-by: Nicolin Chen <nicoleots...@gmail.com> Signed-off-by: Mark Brown <broo...@kernel.org> --- sound/soc/fsl/fsl_ssi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c ind

Re: [PATCH] ASoC: fsl_spdif: fix spelling mistake: "receivce" -> "receive"

On Tue, Jun 28, 2016 at 01:47:59PM +0100, Colin King wrote: > From: Colin Ian King Please fix things so that your mail configuration matches your git configuration, it makes things harder to review since it looks like you've got a non-author signoff with a missing

Applied "ASoC: fsl_spdif: fix spelling mistake: "receivce" -> "receive"" to the asoc tree

t;receivce" -> "receive" trivial fix to spelling mistake in dev_err message Signed-off-by: Colin Ian King <colin.k...@canonical.com> Signed-off-by: Mark Brown <broo...@kernel.org> --- sound/soc/fsl/fsl_spdif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

Re: [PATCH 35/35] sound/soc: Convert remaining uses of pr_warning to pr_warn

On Fri, Feb 17, 2017 at 04:20:47PM -0800, Joe Perches wrote: > If or when you apply it, you should > fix it up to suit. To repeat, I don't have this patch so someone will need to send it to me. > $ git log -1000 --pretty=oneline --no-merges sound/soc | \ > cut -f2- -d" " | cut -f1 -d":" |sort

Re: [PATCH 35/35] sound/soc: Convert remaining uses of pr_warning to pr_warn

On Fri, Feb 17, 2017 at 12:28:44PM -0800, Nicolin Chen wrote: > On Thu, Feb 16, 2017 at 11:11:48PM -0800, Joe Perches wrote: > > To enable eventual removal of pr_warning > > > > This makes pr_warn use consistent for sound/soc > > > > Prior to this patch, there were 5 uses of pr_warning and > >

Applied "ASoC: constify snd_soc_ops structures" to the asoc tree

0 844371155 sound/soc/fsl/imx-wm8962.o Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Mark Brown <broo...@kernel.org> --- sound/soc/fsl/fsl-asoc-card.c | 2 +- sound/soc/fsl/imx-wm8962.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --gi

Applied "ASoC: davinci-mcbsp: DT fix s/interrupts-names/interrupt-names/" to the asoc tree

upt-names/ Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Acked-by: Rob Herring <r...@kernel.org> Signed-off-by: Mark Brown <broo...@kernel.org> --- Documentation/devicetree/bindings/sound/davinci-mcbsp.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] fsl_ssi: set fifo watermark to more reliable value

On Wed, Jan 04, 2017 at 10:31:42AM -0800, ccrome wrote: > The subject should be > > [PATCH] ASoC: fsl_ssi: set fifo watermark to more reliable value > > Correct? Yes. > Should I re-submit? No, it's fine - if I'm sending one of those mails it'll be fine as I've actually seen the mail to reply

Applied "ASoC: fsl_ssi: set fifo watermark to more reliable value" to the asoc tree

a 15-deep fifo get the new behavior. I suspect a new fifo depth setting could be optimized on the older chips too, but I have not tested. Signed-off-by: Caleb Crome <ca...@crome.org> Reviewed-by: Fabio Estevam <fabio.este...@nxp.com> Signed-off-by: Mark Brown <broo...@kernel.org> -

Re: [PATCH] fsl_ssi: set fifo watermark to more reliable value

On Tue, Jan 03, 2017 at 10:22:57AM -0800, Caleb Crome wrote: > From: Caleb Crome > > The fsl_ssi fifo watermark is by default set to 2 free spaces (i.e. > activate DMA on FIFO when only 2 spaces are left.) This means the Please submit patches using subject lines reflecting the

Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup

On Tue, Mar 28, 2017 at 12:53:06PM +0100, Charles Keepax wrote: > On Tue, Mar 28, 2017 at 01:47:04PM +0300, Daniel Baluta wrote: > > >> - codec_clk = devm_clk_get(_dev->dev, NULL); > > >> + codec_clk = clk_get(_dev->dev, NULL); > > is different from _dev->dev. > I get that they are

Applied "ASoC: imx-wm8962: Fix codec_clk cleanup" to the asoc tree

latform's device dev. Reported-by: Nicolin Chen <nicoleots...@gmail.com> Signed-off-by: Daniel Baluta <daniel.bal...@nxp.com> Signed-off-by: Mark Brown <broo...@kernel.org> --- sound/soc/fsl/imx-wm8962.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/s

Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup

On Wed, Mar 29, 2017 at 02:38:23PM +0300, Daniel Baluta wrote: > If I read the code correctly, both machine and codec driver are doing: > * codec_clk = clk_get(...) > I guess that the codec driver is the first to be loaded and it will call: > * __clk_create_clk > which will do the allocation.

Applied "ASoC: imx-wm8962: Let codec driver enable/disable its MCLK" to the asoc tree

needs its MCLK when powerup in wm8962_resume(). Thus it's better to control the MCLK in codec driver. Thus remove the clock enable in machine driver accordingly. While at it, get rid of imx_wm8962_remove function since it is now empty. Signed-off-by: Daniel Baluta <daniel.bal...@nxp.com> Sign

Applied "ASoC: fsl: constify snd_soc_ops structures" to the asoc tree

al <bhumi...@gmail.com> Signed-off-by: Mark Brown <broo...@kernel.org> --- sound/soc/fsl/eukrea-tlv320.c | 2 +- sound/soc/fsl/imx-mc13783.c | 2 +- sound/soc/fsl/mpc8610_hpcd.c| 2 +- sound/soc/fsl/mx27vis-aic32x4.c | 2 +- sound/soc/fsl/p1022_ds.c| 2 +- sound/soc/fsl/

Applied "ASoC: fsl_asrc_dma: use correct direction enum type" to the asoc tree

type enum dma_transfer_direction, and not enum dma_data_direction. The enumeration values are the same so this did not had an effect in practise. Signed-off-by: Stefan Agner <ste...@agner.ch> Acked-by: Nicolin Chen <nicoleots...@gmail.com> Signed-off-by: Mark Brown <broo...@kernel

Applied "ASoC: fsl: Remove unneeded init of static variable" to the asoc tree

kpatch.pl Signed-off-by: Alin Grigorean <alin.gri...@gmail.com> Acked-by: Nicolin Chen <nicoleots...@gmail.com> Signed-off-by: Mark Brown <broo...@kernel.org> --- sound/soc/fsl/imx-pcm-fiq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/imx-pc

Applied "ASoC: fsl_asrc: constify snd_soc_dai_ops structure" to the asoc tree

s structure is only stored in the ops field of a snd_soc_dai_driver structure. That field is declared const, so snd_soc_dai_ops structures that have this property can be declared as const also. Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> Signed-off-by: Mark Brown <broo...@ke

Applied "ASoC: fsl_esai: constify snd_soc_dai_ops structure" to the asoc tree

s structure is only stored in the ops field of a snd_soc_dai_driver structure. That field is declared const, so snd_soc_dai_ops structures that have this property can be declared as const also. Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> Signed-off-by: Mark Brown <broo...@ke

Applied "ASoC: fsl_spdif: constify snd_soc_dai_ops structure" to the asoc tree

s structure is only stored in the ops field of a snd_soc_dai_driver structure. That field is declared const, so snd_soc_dai_ops structures that have this property can be declared as const also. Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> Signed-off-by: Mark Brown <broo...@ke

Re: [alsa-devel] [PATCH] ASoC: fsl_asrc: constify snd_soc_dai_ops structure

On Thu, Jul 13, 2017 at 09:32:41AM +0200, Takashi Iwai wrote: > please stop posting in this style. It's really annoying to see > spontaneously popping-up almost same patch for more than two hours > long. > If you have a series of the same fix patches, send them as a patch > set in a shot with a

Re: [alsa-devel] [PATCH] ASoC: fsl_asrc: constify snd_soc_dai_ops structure

On Fri, Jul 14, 2017 at 04:08:21AM -0700, Joe Perches wrote: > On Fri, 2017-07-14 at 12:02 +0100, Mark Brown wrote: > > On Thu, Jul 13, 2017 at 11:18:11AM -0700, Joe Perches wrote: > > > I don't it's better. > > > It's not that confusing if the 0/n patch cover

Re: [alsa-devel] [PATCH] ASoC: fsl_asrc: constify snd_soc_dai_ops structure

On Thu, Jul 13, 2017 at 11:18:11AM -0700, Joe Perches wrote: > I don't it's better. > It's not that confusing if the 0/n patch cover letter is cc'd > to all the appropriate mailing lists and all the [1..n]/n > patches are sent with in-reply-to of the cover letter and > send to the maintainers

Applied "ASoC: imx-ssi: add check on platform_get_irq return value" to the asoc tree

value Check return value from call to platform_get_irq(), so in case of failure print error message and propagate the return value. Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> Acked-by: Nicolin Chen <nicoleots...@gmail.com> Signed-off-by: Mark Brown <broo...@kernel

Applied "ASoC: fsl: Convert to using %pOF instead of full_name" to the asoc tree

tf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node. Signed-off-by: Rob Herring <r...@kernel.org> Acked-by: Nicolin Chen <nicoleots...@gmail.com> Signed-off-by: Mark Brown <broo...@kernel

Applied "ASoC: Intel: Atom: make snd_pcm_hardware const" to the asoc tree

in a copy operation. Done using Coccinelle. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> Signed-off-by: Mark Brown <broo...@kernel.org> --- sound/soc/intel/atom/sst-mfld-platform-pcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/atom/sst-m

Applied "ASoC: qcom: make snd_pcm_hardware const" to the asoc tree

argument to the function snd_soc_set_runtime_hwparams, which is const or used in a copy operation. Done using Coccinelle. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> Signed-off-by: Mark Brown <broo...@kernel.org> --- sound/soc/qcom/lpass-platform.c | 2 +- 1 file changed, 1 ins

Re: [PATCH] ALSA: declare snd_kcontrol_new structures as const

; Done using Coccinelle: Acked-by: Mark Brown <broo...@kernel.org> signature.asc Description: PGP signature

Applied "ASoC: fsl-asoc-card: Don't error out if ENOTSUPP" to the asoc tree

et_sysclk() and snd_soc_dai_set_tdm_slot() in the soc-core.c will return -ENOTSUPP if there is no function implementation for them in the dai and component drivers. So this patch tries to ignore this errno. Signed-off-by: Nicolin Chen <nicoleots...@gmail.com> Signed-off-by: Mark Brown <

Applied "ASoC: fsl_ssi: Caculate bit clock rate using slot number and width" to the asoc tree

override the bit clock rate, this patch changes the driver to calculate the bit clock rate using the slot number and the slot width from the via set_tdm_slot(). The patch also removes an obsolete comment of the dir parameter. Signed-off-by: Nicolin Chen <nicoleots...@gmail.com> Signed-off-by: M

Applied "ASoC: fsl-asoc-card: Handle return value of devm_kasprintf" to the asoc tree

kasprintf() can fail here and we must check its return value. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> Signed-off-by: Mark Brown <broo...@kernel.org> --- sound/soc/fsl/fsl-asoc-card.c | 4 1 file changed, 4 insertions(+) diff --git a/sound/soc/fsl/fsl-asoc-card.c b/s

Re: [PATCH v2 2/3] ASoC: fsl-asoc-card: Handle return value of devm_kasprintf

On Thu, Sep 21, 2017 at 10:50:03AM +0530, Arvind Yadav wrote: > devm_kasprintf() can fail here and we must check its return value. This is patch 2/3 but you've only sent me this one patch. This is missing the point of numbering a series, the only reason for the numbering is to provide ordering

Applied "ASoC: omap-hdmi-audio: Handle return value of devm_kasprintf" to the asoc tree

kasprintf devm_kasprintf() can fail here and we must check its return value. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> Signed-off-by: Mark Brown <broo...@kernel.org> --- sound/soc/omap/omap-hdmi-audio.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/omap/omap-hdmi-aud

Applied "ASoC: davinci-mcasp: Handle return value of devm_kasprintf" to the asoc tree

kasprintf() can fail here and we must check its return value. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> Acked-by: Peter Ujfalusi <peter.ujfal...@ti.com> Signed-off-by: Mark Brown <broo...@kernel.org> --- sound/soc/davinci/davinci-mcasp.c | 12 1 file chan

Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq

On Tue, Sep 05, 2017 at 10:19:05AM +0200, Łukasz Majewski wrote: > On 09/05/2017 09:52 AM, Nicolin Chen wrote: > > Can you elaborate why you set ipg clock as bclk? I don't remember SSI could > > derive bitclock from ipg clock. > Just to be clear: > What clock shall be set with: > struct

Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq

On Tue, Sep 05, 2017 at 10:45:29AM -0700, Nicolin Chen wrote: > The ipg clock is merely used to access registers, and has nothing > (directly) to do with external clock outputs. The driver shall not > change the ipg clock as the system ipg clock (its parent clock) > might be messed and even

Applied "ASoC: kirkwood: make snd_pcm_hardware const" to the asoc tree

s the 2nd argument to the function snd_soc_set_runtime_hwparams, which is const or used in a copy operation. Done using Coccinelle. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> Signed-off-by: Mark Brown <broo...@kernel.org> --- sound/soc/kirkwood/kirkwood-dma.c | 2 +- 1 file chang

Applied "ASoC: sh: make snd_pcm_hardware const" to the asoc tree

argument to the function snd_soc_set_runtime_hwparams, which is const. Done using Coccinelle. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> Signed-off-by: Mark Brown <broo...@kernel.org> --- sound/soc/sh/dma-sh7760.c | 2 +- sound/soc/sh/fsi.c| 2 +- sound/soc/sh/rcar/core.c

Applied "ASoC: fsl: make snd_pcm_hardware const" to the asoc tree

argument to the function snd_soc_set_runtime_hwparams, which is const. Done using Coccinelle. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> Signed-off-by: Mark Brown <broo...@kernel.org> --- sound/soc/fsl/fsl_asrc_dma.c | 2 +- sound/soc/fsl/imx-pcm-fiq.c | 2 +- 2 files change

Applied "ASoC: Intel: Skylake: make snd_pcm_hardware const" to the asoc tree

ly passed as the 2nd argument to the function snd_soc_set_runtime_hwparams, which is const. Done using Coccinelle. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> Signed-off-by: Mark Brown <broo...@kernel.org> --- sound/soc/intel/skylake/skl-pcm.c | 2 +- 1 file changed, 1 insertion(+)

Applied "ASoC: fsl_spdif: make const arrays rate static" to the asoc tree

98515 sound/soc/fsl/fsl_spdif.o Signed-off-by: Colin Ian King <colin.k...@canonical.com> Signed-off-by: Mark Brown <broo...@kernel.org> --- sound/soc/fsl/fsl_spdif.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/

Applied "ASoC: fsl_dma: remove dma_object path member" to the asoc tree

t to work with DT full_name changes, just remove it. Signed-off-by: Rob Herring <r...@kernel.org> Cc: Timur Tabi <ti...@tabi.org> Cc: Nicolin Chen <nicoleots...@gmail.com> Cc: Xiubo Li <xiubo@gmail.com> Cc: Fabio Estevam <fabio.este...@nxp.com> Cc: Liam Girdwo

Applied "ASoC: fsl_ssi: remove duplicated flag setting in fsl_ssi_setup_reg_vals()" to the asoc tree

Signed-off-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Acked-by: Nicolin Chen <nicoleots...@gmail.com> Signed-off-by: Mark Brown <broo...@kernel.org> --- sound/soc/fsl/fsl_ssi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ss

Applied "ASoC: fsl_ssi: serialize AC'97 register access operations" to the asoc tree

iej S. Szmigiero <m...@maciej.szmigiero.name> Signed-off-by: Mark Brown <broo...@kernel.org> --- sound/soc/fsl/fsl_ssi.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index c3a83ed0297e..424bafaf

Applied "ASoC: fsl_ssi: only enable proper channel slots in AC'97 mode" to the asoc tree

extra channel slots enabled mean ruined playback let's play safe here and make sure that no extra slots are enabled in SACCST every time a playback is started. Signed-off-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Acked-by: Nicolin Chen <nicoleots...@gmail.com> Signed-off-by:

Applied "ASoC: fsl_ssi: call _fsl_ssi_set_dai_fmt() just once in AC'97 mode" to the asoc tree

values. Signed-off-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Acked-by: Nicolin Chen <nicoleots...@gmail.com> Signed-off-by: Mark Brown <broo...@kernel.org> --- sound/soc/fsl/fsl_ssi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound

Applied "ASoC: fsl_ssi: add 20-bit sample format for AC'97 and use it for capture" to the asoc tree

widths in playback and capture in AC'97 mode so allow this, too. Signed-off-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Signed-off-by: Mark Brown <broo...@kernel.org> --- sound/soc/fsl/fsl_ssi.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/soun

Applied "ALSA: pcm: add SNDRV_PCM_FORMAT_{S,U}20" to the asoc tree

The patch ALSA: pcm: add SNDRV_PCM_FORMAT_{S,U}20 has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to

Applied "ASoC: fsl_ssi: AC'97 ops need regmap, clock and cleaning up on failure" to the asoc tree

n <nicoleots...@gmail.com> Signed-off-by: Mark Brown <broo...@kernel.org> Cc: sta...@vger.kernel.org --- sound/soc/fsl/fsl_ssi.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index f2f51e06e22c..c3

Re: [alsa-devel] Applied "ALSA: pcm: add SNDRV_PCM_FORMAT_{S, U}20" to the asoc tree

On Wed, Nov 29, 2017 at 10:23:23PM +0100, Takashi Iwai wrote: > Mark, I already took this into my tree, as it's a change in ALSA core > stuff. As mentioned in another mail, the branch was exposed to > topic/pcm-20bit branch, so that you can pull cleanly. That's what this is reporting - the

Applied "ASoC: fsl_ssi: Rename registers and fields macros" to the asoc tree

t; Acked-by: Timur Tabi <ti...@tabi.org> Signed-off-by: Mark Brown <broo...@kernel.org> --- sound/soc/fsl/fsl_ssi.c | 374 +-- sound/soc/fsl/fsl_ssi.h | 376 ++-- sound/soc/fsl/fsl_ssi_dbg.c | 44

Applied "ASoC: fsl_ssi: Refine all comments" to the asoc tree

igned-off-by: Nicolin Chen <nicoleots...@gmail.com> Tested-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Acked-by: Timur Tabi <ti...@tabi.org> Signed-off-by: Mark Brown <broo...@kernel.org>

Applied "ASoC: fsl_ssi: Rename scr_val to scr" to the asoc tree

character line. Signed-off-by: Nicolin Chen <nicoleots...@gmail.com> Tested-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Acked-by: Timur Tabi <ti...@tabi.org> Signed-off-by: Mark Brown <broo...@kern

Applied "ASoC: fsl_ssi: Refine printk outputs" to the asoc tree

Acked-by: Timur Tabi <ti...@tabi.org> Signed-off-by: Mark Brown <broo...@kernel.org> --- sound/soc/fsl/fsl_ssi.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index ed9ac758e35d..eb9ac847bda3 100644

Applied "ASoC: fsl_ssi: Rename fsl_ssi_private to fsl_ssi" to the asoc tree

structure to save some wrapped lines. Signed-off-by: Nicolin Chen <nicoleots...@gmail.com> Tested-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Acked-by: Timur Tabi <ti...@tabi.org> Signed-off-by: Mark Brown &l

Applied "ASoC: fsl_ssi: Refine indentations and wrappings" to the asoc tree

y unifies the coding style. Signed-off-by: Nicolin Chen <nicoleots...@gmail.com> Tested-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Acked-by: Timur Tabi <ti...@tabi.org> Signed-off-by: Mark Brown <broo...@kern

Applied "ASoC: fsl_ssi: Rename cpu_dai parameter to dai" to the asoc tree

ave space, useful for dev_err outputs. Signed-off-by: Nicolin Chen <nicoleots...@gmail.com> Tested-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Acked-by: Timur Tabi <ti...@tabi.org> Signed-off-by: Mark Brow

Applied "ASoC: fsl_ssi: Cache pdev->dev pointer" to the asoc tree

: Timur Tabi <ti...@tabi.org> Signed-off-by: Mark Brown <broo...@kernel.org> --- sound/soc/fsl/fsl_ssi.c | 64 - 1 file changed, 31 insertions(+), 33 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index 84d2f

Applied "ASoC: fsl_ssi: Define ternary macros to simplify code" to the asoc tree

ode looks redudant. So simplify it. Signed-off-by: Nicolin Chen <nicoleots...@gmail.com> Tested-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Acked-by: Timur Tabi <ti...@tabi.org> Signed-off-by: Mark Brown <br

Applied "ASoC: fsl_ssi: Rename i2smode to i2s_net" to the asoc tree

abi <ti...@tabi.org> Signed-off-by: Mark Brown <broo...@kernel.org> --- sound/soc/fsl/fsl_ssi.c | 24 sound/soc/fsl/fsl_ssi.h | 1 + 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index aef014c46d

Applied "ASoC: fsl_ssi: Replace fsl_ssi_rxtx_reg_val with fsl_ssi_regvals" to the asoc tree

igiero.name> Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Acked-by: Timur Tabi <ti...@tabi.org> Signed-off-by: Mark Brown <broo...@kernel.org> --- sound/soc/fsl/fsl_ssi.c | 79 +++-- sound/soc/fsl/fsl_ssi.h | 3 ++ 2 files c

Re: [PATCH 01/10] ASoC: fsl_ssi: Remove unused struct device

On Mon, Dec 04, 2017 at 12:46:34PM -0800, Nicolin Chen wrote: > struct device is defined in system level header files any way. > As long as fsl_ssi.h is included after those header files, it > should be safe to remove this line. It's better practice to either directly include those headers or

linux-next: manual merge of the powerpc tree with Linus' tree

Hi all, Today's linux-next merge of the powerpc tree got a conflict in: arch/powerpc/kvm/powerpc.c between commit: ac64115a66c1 ("KVM: PPC: Fix oops when checking KVM_CAP_PPC_HTM") from Linus' tree and commit: 2a3d6553cbd7 ("KVM: PPC: Tie KVM_CAP_PPC_HTM to the user-visible TM

Applied "ASoC: fsl_ssi: Fix build error" to the asoc tree

Roeck <li...@roeck-us.net> Acked-by: Nicolin Chen <nicoleots...@gmail.com> Signed-off-by: Mark Brown <broo...@kernel.org> --- sound/soc/fsl/fsl_dma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/fsl/fsl_dma.c b/sound/soc/fsl/fsl_dma.c in

Applied "ASoC: fsl_ssi: Clean up _fsl_ssi_set_dai_fmt()" to the asoc tree

: Nicolin Chen <nicoleots...@gmail.com> Tested-by: Caleb Crome <ca...@crome.org> Tested-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Signed-off-by: Mark Brown <broo...@kernel.or

Applied "ASoC: fsl_ssi: Set xFEN0 and xFEN1 together" to the asoc tree

TX or RX at the same time. Signed-off-by: Nicolin Chen <nicoleots...@gmail.com> Tested-by: Caleb Crome <ca...@crome.org> Tested-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Signed-off-by: Mark Brown <br

Applied "ASoC: fsl_ssi: Clean up fsl_ssi_setup_regvals()" to the asoc tree

e> Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Signed-off-by: Mark Brown <broo...@kernel.org> --- sound/soc/fsl/fsl_ssi.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c

Applied "ASoC: fsl_ssi: Use ssi->streams instead of reading register" to the asoc tree

Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Signed-off-by: Mark Brown <broo...@kernel.org> --- sound/soc/fsl/fsl_ssi.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index 5bc67ad8000f..0823b08923b5 1006

Applied "ASoC: fsl_ssi: Add bool synchronous to mark synchronous mode" to the asoc tree

-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Signed-off-by: Mark Brown <broo...@kernel.org> --- sound/soc/fsl/fsl_ssi.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index ed9102d91cf5..b58fabe77c6f 100644 --

Applied "ASoC: fsl_ssi: Move DT related code to a separate probe()" to the asoc tree

..@gmail.com> Tested-by: Caleb Crome <ca...@crome.org> Tested-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Signed-off-by: Mark Brown <broo...@kernel.org> --- sound/soc/fsl/fsl_ssi.c | 219 +

Applied "ASoC: fsl_ssi: Use snd_soc_init_dma_data instead" to the asoc tree

tion, use it to help readability. Signed-off-by: Nicolin Chen <nicoleots...@gmail.com> Tested-by: Caleb Crome <ca...@crome.org> Tested-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Signed-off-by: Mark Brow

Applied "ASoC: fsl_ssi: Add DAIFMT define for AC97" to the asoc tree

@crome.org> Tested-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Signed-off-by: Mark Brown <broo...@kernel.org> --- sound/soc/fsl/fsl_ssi.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff

<    1   2   3   4   5   6   7   8   9   >