[RFC/PATCH 4/4] Simplify xics direct/lpar irq_host setup

2008-04-01 Thread Michael Ellerman
The xics code currently has a direct and lpar variant of xics_host_map, the only difference being which irq_chip they use. If we remember which irq_chip we're using we can combine these two routines. That also allows us to have a single irq_host_ops instead of two. Signed-off-by: Michael Ellerman

Re: [PATCH] Make #include sysdev/foo.h work for 64-bit powerpc

2008-04-01 Thread Michael Ellerman
On Tue, 2008-04-01 at 08:18 -0500, Kumar Gala wrote: On Apr 1, 2008, at 1:54 AM, Stephen Rothwell wrote: Hi Michael, On Tue, 1 Apr 2008 17:39:11 +1100 (EST) Michael Ellerman [EMAIL PROTECTED] wrote: We currently have inconsistent settings between 32 64-bit which means 32

Re: [BUG] 2.6.25-rc8-mm1 kernel panic while bootup on powerpc

2008-04-02 Thread Michael Ellerman
the same kernel panic is seen. Can you enable DEBUG_LOW in arch/powerpc/platforms/pseries/lpar.c, that should show what's happening in hpte_insert(). cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We

[PATCH 1/2] Move prototype for find_udbg_vterm() into a header file

2008-04-15 Thread Michael Ellerman
Move the prototype for find_udbg_vterm() into pseries.h, removing it from setup.c Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/platforms/pseries/lpar.c|1 + arch/powerpc/platforms/pseries/pseries.h |2 ++ arch/powerpc/platforms/pseries/setup.c |3 --- 3

[PATCH 2/2] Always add preferred consoles in platforms/pseries/lpar.c

2008-04-15 Thread Michael Ellerman
, then foo will be set as the preferred console when the command line is parsed in start_kernel(), much later than the pseries code, and so the latter setting will take effect. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/platforms/pseries/lpar.c |9 ++--- 1 files changed

Re: More patches pushed to powerpc.git master and powerpc-next branches (second try)

2008-04-17 Thread Michael Ellerman
BenH might want to Ack them. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person signature.asc

Re: [PATCH 1/2] Add thread_info_cache_init() to all archs

2008-04-17 Thread Michael Ellerman
) thread_info_cache_init(void) s/weak)/weak))/ There's also a #define of this called __weak if you like, less typing and less ugly. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from

Re: [RFC/PATCH 3/4] Use pseries_setup_i8259_cascade() in pseries_mpic_init_IRQ()

2008-04-17 Thread Michael Ellerman
On Fri, 2008-04-18 at 14:15 +1000, Benjamin Herrenschmidt wrote: On Tue, 2008-04-01 at 17:42 +1100, Michael Ellerman wrote: pseries_mpic_init_IRQ() implements the same logic as the xics code did to find the i8259 cascade irq. Now that we've pulled that logic out

[PATCH 01/11] Set udbg_console index to 0

2008-04-18 Thread Michael Ellerman
(). Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/kernel/udbg.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/kernel/udbg.c b/arch/powerpc/kernel/udbg.c index 7aad620..9ac5f3a 100644 --- a/arch/powerpc/kernel/udbg.c +++ b/arch/powerpc/kernel

[PATCH 02/11] Add udbg_console_anytime() which sets udbg console to CON_ANYTIME

2008-04-18 Thread Michael Ellerman
a bit of time and testing though, so instead of marking udbg console as CON_ANYTIME for all platforms, add a routine so that a platform can opt-in to having udbg console called early. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/kernel/udbg.c |5 + include/asm-powerpc

[PATCH 03/11] Register udbg console early on pseries LPAR

2008-04-18 Thread Michael Ellerman
to call udbg_printf() directly for early debugging. This is nice because a) it's standard, b) it goes via the printk buffer, and c) you can get printk time stamps. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/platforms/pseries/lpar.c |3 +++ 1 files changed, 3 insertions

[PATCH 04/11] Convert from DBG() to pr_debug() in platforms/pseries/setup.c

2008-04-18 Thread Michael Ellerman
Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/platforms/pseries/setup.c | 15 +-- 1 files changed, 5 insertions(+), 10 deletions(-) diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c index fccca89..5486bea 100644

[PATCH 05/11] Convert from DBG() to pr_debug() in platforms/pseries/smp.c

2008-04-18 Thread Michael Ellerman
Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/platforms/pseries/smp.c | 10 ++ 1 files changed, 2 insertions(+), 8 deletions(-) diff --git a/arch/powerpc/platforms/pseries/smp.c b/arch/powerpc/platforms/pseries/smp.c index ea4c659..e9bc2a5 100644 --- a/arch

[PATCH 06/11] Convert from DBG() to pr_debug() in platforms/pseries/firmware.c

2008-04-18 Thread Michael Ellerman
Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/platforms/pseries/firmware.c |9 ++--- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/arch/powerpc/platforms/pseries/firmware.c b/arch/powerpc/platforms/pseries/firmware.c index b765b7c..743d494 100644

[PATCH 07/11] Convert from DBG() to pr_debug() in platforms/pseries/iommu.c

2008-04-18 Thread Michael Ellerman
Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/platforms/pseries/iommu.c | 39 +++ 1 files changed, 19 insertions(+), 20 deletions(-) diff --git a/arch/powerpc/platforms/pseries/iommu.c b/arch/powerpc/platforms/pseries/iommu.c index a65c763

[PATCH 08/11] Convert from DBG() to pr_debug() in platforms/pseries/lpar.c

2008-04-18 Thread Michael Ellerman
While we're there, fix some printf specifier mismatches, and add a newline to one printk. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/platforms/pseries/lpar.c | 34 ++-- 1 files changed, 15 insertions(+), 19 deletions(-) diff --git a/arch

[PATCH 09/11] Convert from DEBUG() to pr_debug() in platforms/pseries/rtasd.c

2008-04-18 Thread Michael Ellerman
Add rtasd to some messages to make it clear where they're coming from. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/platforms/pseries/rtasd.c | 14 +- 1 files changed, 5 insertions(+), 9 deletions(-) diff --git a/arch/powerpc/platforms/pseries/rtasd.c b/arch

[PATCH 10/11] Convert from DEBUG() to pr_debug() in platforms/pseries/scanlog.c

2008-04-18 Thread Michael Ellerman
While we're at it, remove the hand-rolled runtime debugging support in there. This file has been largely unchanged for eons, if we need to debug it in future we can recompile. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/platforms/pseries/scanlog.c | 23

[PATCH 11/11] Add CONFIG_PPC_PSERIES_DEBUG to enable debugging for platforms/pseries

2008-04-18 Thread Michael Ellerman
PPC_EARLY_DEBUG enabled also. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/platforms/pseries/Kconfig |5 + arch/powerpc/platforms/pseries/Makefile|4 arch/powerpc/platforms/pseries/eeh.c |1 - arch/powerpc/platforms/pseries/eeh_cache.c |1

Re: [PATCH 2.6.26?] Raise the upper limit of NR_CPUS.

2008-04-18 Thread Michael Ellerman
|4 +- include/asm-powerpc/paca.h | 19 What happens on non prom-init platforms? cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our

Re: [PATCH 1/3] MSI driver for Freescale 83xx/85xx/86xx cpu

2008-04-21 Thread Michael Ellerman
This MSI driver can be used on 83xx/85xx/86xx board. In this driver, virtual interrupt host and chip were setup. There are 256 MSI interrupts in this host, Every 32 MSI interrupts cascaded to one IPIC/MPIC interrupt. The chip was treated as edge sensitive and some necessary functions were

Re: [PATCH 2.6.26?] Raise the upper limit of NR_CPUS.

2008-04-21 Thread Michael Ellerman
with a scheme that should work for all cases. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person

RE: [PATCH 1/3] MSI driver for Freescale 83xx/85xx/86xx cpu

2008-04-21 Thread Michael Ellerman
msi_msg msg; + struct fsl_msi *msi = fsl_msi; A couple of places you put this into a local called msi which is not the greatest name in the world IMHO :) Thank you, I'll try to use another name, Do you have any suggestion? Oh I dunno, maybe msi_data or msi_state ? cheers -- Michael

Re: Question on MPC83xx interrupts

2008-04-22 Thread Michael Ellerman
-internal construct. You can see the mapping between virq and hwirq numbers by turning on CONFIG_VIRQ_DEBUG and looking in /sys/kernel/debug/powerpc/virq_mapping (after mounting debugfs). cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61

Re: [PATCH 1/3 v3] Raise the upper limit of NR_CPUS.

2008-04-22 Thread Michael Ellerman
. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person signature.asc Description: This is a digitally

Re: [PATCH 02/11] Add udbg_console_anytime() which sets udbg console to CON_ANYTIME

2008-04-22 Thread Michael Ellerman
On Fri, 2008-04-18 at 18:20 +1000, Benjamin Herrenschmidt wrote: On Fri, 2008-04-18 at 17:54 +1000, Michael Ellerman wrote: In theory the udbg console should be safe to call basically at any time after boot. It does not need any per-cpu resources or for the cpu to be online, as long

Re: [PATCH 04/11] Convert from DBG() to pr_debug() in platforms/pseries/setup.c

2008-04-22 Thread Michael Ellerman
On Tue, 2008-04-22 at 08:31 -0500, Olof Johansson wrote: On Fri, Apr 18, 2008 at 05:54:36PM +1000, Michael Ellerman wrote: Signed-off-by: Michael Ellerman [EMAIL PROTECTED] I know it's fun to see yourself in the changeset statistics, but this is silly. Please bake together all the simple

Re: [PATCH 1/3] MSI driver for Freescale 83xx/85xx/86xx cpu

2008-04-22 Thread Michael Ellerman
= ((hwirq / 32) 5) | ((hwirq % 32) 0x1F) Which doesn't seem to actually do anything? It's not a no-op, because hwirq is signed. It probably should be unsigned, like most things. You'll have to draw me a picture. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http

Re: [PATCH 2/2 v2] mpic_u3msi: mpic_u3msi: failed allocation unnoticed

2008-04-23 Thread Michael Ellerman
imagine a driver that does something magic to allow it to put something bigger than a u32 in the MSI message, but I doubt it. So I think mpic_msi_alloc_hwirqs() should return a long, which allows it to return a full u32 plus the negative error values. cheers -- Michael Ellerman OzLabs, IBM

[PATCH] Discourage people from fiddling with kernel data from prom_init

2008-04-23 Thread Michael Ellerman
to prom_init.c # which has side effects on other parts of the kernel. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/kernel/Makefile |9 + arch/powerpc/kernel/prom_init_check.sh | 58 2 files changed, 67 insertions(+), 0

[PATCH] Use of_get_next_parent() in platforms/cell/axon_msi.c

2008-04-23 Thread Michael Ellerman
Replace two open-coded occurences of the of_get_next_parent() logic. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- The function touched by the first chunk still needs the tmp variable. arch/powerpc/platforms/cell/axon_msi.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions

[PATCH 1/5] Set udbg_console index to 0

2008-04-23 Thread Michael Ellerman
(). Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/kernel/udbg.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/kernel/udbg.c b/arch/powerpc/kernel/udbg.c index 7aad620..9ac5f3a 100644 --- a/arch/powerpc/kernel/udbg.c +++ b/arch/powerpc/kernel

[PATCH 2/5] Mark udbg console as CON_ANYTIME, ie. callable early in boot

2008-04-23 Thread Michael Ellerman
The udbg console should be safe to call basically at any time after boot. It does not need any per-cpu resources or for the cpu to be online, as long as there is a udbg_putc routine hooked up it should work. So mark it as CON_ANYTIME. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch

[PATCH 3/5] Register udbg console early on pseries LPAR

2008-04-23 Thread Michael Ellerman
to call udbg_printf() directly for early debugging. This is nice because a) it's standard, b) it goes via the printk buffer, and c) you can get printk time stamps. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/platforms/pseries/lpar.c |2 ++ 1 files changed, 2 insertions

[PATCH 4/5] Convert from DBG() to pr_debug() in platforms/pseries/

2008-04-23 Thread Michael Ellerman
for eons, if we need to debug it in future we can recompile. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/platforms/pseries/firmware.c |9 +- arch/powerpc/platforms/pseries/iommu.c| 39 ++--- arch/powerpc/platforms/pseries/lpar.c

[PATCH 5/5] Add CONFIG_PPC_PSERIES_DEBUG to enable debugging for platforms/pseries

2008-04-23 Thread Michael Ellerman
PPC_EARLY_DEBUG enabled also. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/platforms/pseries/Kconfig |5 + arch/powerpc/platforms/pseries/Makefile|4 arch/powerpc/platforms/pseries/eeh.c |1 - arch/powerpc/platforms/pseries/eeh_cache.c |1

Re: LMB regression...

2008-04-24 Thread Michael Ellerman
fixed previously. Sounds like we need a test suite :) cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person

Re: [PATCH] fix showing xmon help

2007-07-12 Thread Michael Ellerman
string. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person signature.asc Description

Re: possible dead CONFIG-related content under arch/powerpc

2007-07-16 Thread Michael Ellerman
be CONFIG_SPU_BASE? Yes, ouch. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person signature.asc

Re: [PATCH 1/3] Add a new member name to structure irq_host

2007-07-23 Thread Michael Ellerman
. And all of the newer irq_host implementations do, with the exception of PS3 and celleb - which are special. cheers [1] Yes I counted :) -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit

[PATCH 2/5] Invert null match behaviour for irq_hosts

2007-07-25 Thread Michael Ellerman
. This in itself isn't very useful, but will allow us to provide a default match implementation in a subsequent patch. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/kernel/irq.c |2 +- arch/powerpc/platforms/celleb/interrupt.c |7 +++ arch/powerpc

Re: [PATCH] Fix ibmvscsi client for multiplatform iSeries+pSeries kernel.

2007-07-25 Thread Michael Ellerman
-$(CONFIG_PPC_ISERIES) += iseries_vscsi.o -endif ibmvscsic-$(CONFIG_PPC_PSERIES) += rpa_vscsi.o obj-$(CONFIG_SCSI_IBMVSCSIS) += ibmvstgt.o -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do

[PATCH 1/1] Fix parse_drconf_memory() for 64-bit start addresses

2007-07-31 Thread Michael Ellerman
in a BUG() in free_bootmem_core(). Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/mm/numa.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c index de45aa8..c12adc3 100644 --- a/arch/powerpc/mm/numa.c

Re: [patch 0/3] PS3 bugfix patches for 2.6.23

2007-08-08 Thread Michael Ellerman
/cell/spu_base.c:681: undefined reference to `.spu_devnode' Ben pointed out patch [PATCH v2] cell: move SPU affinity init to spu_management_of_ops to me. Can someone please merge it! :) -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2

Re: [PATCH v2] powerpc: add setmaskedbits macros

2007-08-15 Thread Michael Ellerman
more useful and have it check that the value and the mask match, ie: (v ~m == 0) Final random thought, you could make the size/endian an argument: #define setmaskedbits(a, v, m, s) out_##s((a), (in_##s(a) ~(m) | (v)) cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb

[PATCH 1/5] Add an optional device_node pointer to the irq_host

2007-08-28 Thread Michael Ellerman
The majority of irq_host implementations (3 out of 4) are associated with a device_node, and need to stash it somewhere. Rather than having it somewhere different for each host, add an optional device_node pointer to the irq_host structure. Signed-off-by: Michael Ellerman [EMAIL PROTECTED

[PATCH 2/5] Invert null match behaviour for irq_hosts

2007-08-28 Thread Michael Ellerman
. This in itself isn't very useful, but will allow us to provide a default match implementation in a subsequent patch. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/kernel/irq.c |2 +- arch/powerpc/platforms/celleb/interrupt.c |7 +++ arch/powerpc

[PATCH 3/5] Provide a default irq_host match, which matches on an exact of_node

2007-08-28 Thread Michael Ellerman
The most common match semantic is an exact match based on the device node. So provide a default implementation that does this, and hook it up if no match routine is specified. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/kernel/irq.c | 10 +- arch

[PATCH 4/5] Initialise hwirq for legacy irqs

2007-08-28 Thread Michael Ellerman
Although no one uses the hwirq value for legacy irqs at the moment, we should really setup the correct value in the irq_map. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/kernel/irq.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/powerpc

Re: [PATCH 1/5] Add an optional device_node pointer to the irq_host

2007-08-28 Thread Michael Ellerman
On Tue, 2007-08-28 at 18:47 +1000, Michael Ellerman wrote: The majority of irq_host implementations (3 out of 4) are associated with a device_node, and need to stash it somewhere. Rather than having it somewhere different for each host, add an optional device_node pointer to the irq_host

[PATCH 5/5] Export virq mapping via debugfs

2007-08-28 Thread Michael Ellerman
This patch adds a debugfs file powerpc/virq_mapping, which shows the virtual to real mapping of irq numbers. Enable it with CONFIG_VIRQ_DEBUG. Signed-off-by: Zhang Wei [EMAIL PROTECTED] Signed-off-by: Chen Gong [EMAIL PROTECTED] Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc

Re: [PATCH 3/3] powerpc: setup_64 comment cleanup.

2007-09-06 Thread Michael Ellerman
changelog says. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person signature.asc Description

Re: SYSFS: need a noncaching read

2007-09-11 Thread Michael Ellerman
) was the trendy way to do this these days? Documentation/filesystems/relay.txt cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our

[PATCH 01/15] Extract the file descriptor search logic in SPU coredump code

2007-09-12 Thread Michael Ellerman
Extract the logic for searching through the file descriptors for spu contexts into a separate routine, coredump_next_context(), so we can use it elsewhere in future. In the process we flatten the for loop, and move the NOSCHED test into coredump_next_context(). Signed-off-by: Michael Ellerman

[PATCH 02/15] Remove ctx_info and ctx_info_list

2007-09-12 Thread Michael Ellerman
Remove the ctx_info struct entirely, and also the ctx_info_list. This fixes a race where two processes can clobber each other's ctx_info structs. Instead of using the list, we just repeat the search through the file descriptor table. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch

[PATCH 03/15] Call spu_acquire_saved() before calculating the SPU note sizes

2007-09-12 Thread Michael Ellerman
It makes sense to stop the SPU processes as soon as possible. Also if we dont acquire_saved() I think there's a possibility that the value in csa.priv2.spu_lslr_RW won't be accurate. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/platforms/cell/spufs/coredump.c |2 ++ 1

[PATCH 04/15] Use computed sizes/#defines rather than literals in SPU coredump code

2007-09-12 Thread Michael Ellerman
, or in the case of spufs_mem_read() the #define LS_SIZE. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/platforms/cell/spufs/file.c | 21 +++-- 1 files changed, 11 insertions(+), 10 deletions(-) diff --git a/arch/powerpc/platforms/cell/spufs/file.c b/arch/powerpc

[PATCH 05/15] Write some SPU coredump values as ASCII

2007-09-12 Thread Michael Ellerman
, that way we know the result will be 19 bytes. do_coredump_read() doesn't take a __user buffer, so remove the annotation, and because we know that it's safe to just snprintf() directly to it. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/platforms/cell/spufs/coredump.c |8

[PATCH 06/15] Correctly calculate the size of the local-store to dump

2007-09-12 Thread Michael Ellerman
The routine to dump the local store, __spufs_mem_read(), does not take the spu_lslr_RW value into account - so we shouldn't check it when we're calculating the size either. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/platforms/cell/spufs/coredump.c | 16

[PATCH 07/15] Don't return -ENOSYS as extra notes size if spufs is not loaded

2007-09-12 Thread Michael Ellerman
note size of -38 bytes. This leads to a corrupt core dump. If spufs is not loaded there will be no SPU ELF notes to write, and so the extra notes size will be == 0. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/platforms/cell/spu_coredump.c |8 ++-- 1 files changed, 6

[PATCH 08/15] Use spufs_coredump_num_notes everywhere, and don't NULL terminate

2007-09-12 Thread Michael Ellerman
The spufs_coredump_read array is NULL terminated, and we also store the size. We only need one or the other, and storing the size should save a teensy bit of memory vs NULL terminating, so do that. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/platforms/cell/spufs/coredump.c

[PATCH 09/15] Internal __spufs_get_foo() routines should take a spu_context *

2007-09-12 Thread Michael Ellerman
The SPUFS attribute get routines take a void * because the generic attribute code doesn't know what sort of data it's passing around. However our internal __spufs_get_foo() routines can take a spu_context * directly, which saves plonking it in and out of a void * again. Signed-off-by: Michael

[PATCH 10/15] Add contents of npc file to SPU coredumps

2007-09-12 Thread Michael Ellerman
Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/platforms/cell/spufs/file.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/platforms/cell/spufs/file.c b/arch/powerpc/platforms/cell/spufs/file.c index d19220f..52f020a 100644

[PATCH 11/15] Combine spufs_coredump_calls with spufs_calls

2007-09-12 Thread Michael Ellerman
are in spufs_coredump_calls. In both cases the logic for registering/unregistering is essentially the same, so we can simplify things by combining the two. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/platforms/cell/Makefile |2 +- arch/powerpc/platforms/cell

[PATCH 12/15] Cleanup ELF coredump extra notes logic

2007-09-12 Thread Michael Ellerman
-f_pos (so that writing to a pipe works). So pass foffset to the write routine, and for now just set it to file-f_pos at the end of writing. It should also be possible for the write routine to fail, so change it to return int and treat a non-zero return as failure. Signed-off-by: Michael Ellerman

[PATCH 13/15] Handle errors in SPU coredump code, and support coredump to a pipe

2007-09-12 Thread Michael Ellerman
written. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/platforms/cell/spu_syscalls.c |8 +-- arch/powerpc/platforms/cell/spufs/coredump.c | 89 ++ arch/powerpc/platforms/cell/spufs/spufs.h|2 +- include/asm-powerpc/spu.h

[PATCH 14/15] Respect RLIMIT_CORE in spu coredump code

2007-09-12 Thread Michael Ellerman
Currently the spu coredump code doesn't respect the ulimit, it should. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/platforms/cell/spufs/coredump.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/platforms/cell/spufs/coredump.c b

[PATCH 15/15] Add DEFINE_SPUFS_ATTRIBUTE()

2007-09-12 Thread Michael Ellerman
) inside the macro foo. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/platforms/cell/spufs/file.c | 216 +++--- 1 files changed, 76 insertions(+), 140 deletions(-) diff --git a/arch/powerpc/platforms/cell/spufs/file.c b/arch/powerpc/platforms/cell/spufs

Re: [PATCH 15/15] Add DEFINE_SPUFS_ATTRIBUTE()

2007-09-12 Thread Michael Ellerman
On Wed, 2007-09-12 at 17:43 +1000, Michael Ellerman wrote: This patch adds DEFINE_SPUFS_ATTRIBUTE(), a wraper around DEFINE_SIMPLE_ATTRIBUTE which does the specified locking for the get routine for us. Unfortunately we need two get routines (a locked and unlocked version) to support

Re: [PATCH 15/15] Add DEFINE_SPUFS_ATTRIBUTE()

2007-09-12 Thread Michael Ellerman
On Wed, 2007-09-12 at 10:47 +0200, Arnd Bergmann wrote: On Wednesday 12 September 2007, Michael Ellerman wrote: On Wed, 2007-09-12 at 17:43 +1000, Michael Ellerman wrote: This patch adds DEFINE_SPUFS_ATTRIBUTE(), a wraper around DEFINE_SIMPLE_ATTRIBUTE which does the specified locking

[PATCH] Allow sysfs_remove_group() to be called on non-added groups

2007-09-12 Thread Michael Ellerman
a BUG_ON() in sysfs_remove_group() which hits if the attributes were never added. As discussed here ... http://ozlabs.org/pipermail/cbe-oss-dev/2007-July/002774.html .. we should just return in that case instead of BUG'ing. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- fs/sysfs/group.c |3

[PATCH] Make sure to of_node_get() the result of pci_device_to_OF_node()

2007-09-17 Thread Michael Ellerman
pci_device_to_OF_node() returns the device node attached to a PCI device, but doesn't actually grab a reference - we need to do it ourselves. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/platforms/cell/axon_msi.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions

[PATCH 1/7] Store the base address in dcr_host_t

2007-09-17 Thread Michael Ellerman
In its current form, dcr_map() doesn't remember the base address you passed it, which means you need to store it somewhere else. Rather than adding the base to another struct it seems simpler to store it in the dcr_host_t. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/sysdev

[PATCH 2/7] Update mpic to use dcr_host_t.base

2007-09-17 Thread Michael Ellerman
Now that dcr_host_t contains the base address, we can use that in the mpic code, rather than storing it separately. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/sysdev/mpic.c | 28 +++- include/asm-powerpc/mpic.h |6 -- 2 files changed, 11

[PATCH 3/7] Use dcr_host_t.base in ibm_emac_mal

2007-09-17 Thread Michael Ellerman
This requires us to do a sort-of fake dcr_map(), so that base is set properly. This will be fixed/removed when the device-tree-aware emac driver is merged. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- drivers/net/ibm_emac/ibm_emac_mal.c |5 - drivers/net/ibm_emac/ibm_emac_mal.h

[PATCH 4/7] Update axon_msi to use dcr_host_t.base

2007-09-17 Thread Michael Ellerman
Now that dcr_host_t contains the base address, we can use that in the axon_msi code, rather than storing it separately. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/platforms/cell/axon_msi.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git

[PATCH 5/7] Add dcr_host_t.base in dcr_read()/dcr_write()

2007-09-17 Thread Michael Ellerman
Now that all users of dcr_read()/dcr_write() add the dcr_host_t.base, we can save them the trouble and do it in dcr_read()/dcr_write(). Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/platforms/cell/axon_msi.c |4 ++-- arch/powerpc/sysdev/mpic.c |4

[PATCH 6/7] Add dcr_map_reg() helper

2007-09-17 Thread Michael Ellerman
Add a helper routine to map dcr's based on the dcr-reg property of a device node. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/sysdev/dcr.c | 17 + include/asm-powerpc/dcr.h |1 + 2 files changed, 18 insertions(+), 0 deletions(-) diff --git a/arch

[PATCH 7/7] Remove msic_dcr_read() and use dcr_map_reg() in axon_msi.c

2007-09-17 Thread Michael Ellerman
msic_dcr_read() doesn't really do anything useful, just replace it with direct calls to dcr_read(). Use dcr_map_reg() in the axon_msi setup code, rather than essentially doing it by hand. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/platforms/cell/axon_msi.c | 22

Re: [PATCH] [POWERPC] Support setting affinity for U3/U4 MSI sources

2007-09-20 Thread Michael Ellerman
-by: Michael Ellerman [EMAIL PROTECTED] cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person signature.asc

[PATCH 1/4] Simplify error logic in u3msi_setup_msi_irqs()

2007-09-20 Thread Michael Ellerman
u3msi_setup_msi_irqs() doesn't need to call teardown() itself, the generic code will do this for us as long as we return a non zero value. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/sysdev/mpic_u3msi.c | 11 ++- 1 files changed, 2 insertions(+), 9 deletions

[PATCH 2/4] Simplify error logic in rtas_setup_msi_irqs()

2007-09-20 Thread Michael Ellerman
rtas_setup_msi_irqs() doesn't need to call teardown() itself, the generic code will do this for us as long as we return a non zero value. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/platforms/pseries/msi.c | 17 +++-- 1 files changed, 3 insertions(+), 14

[PATCH 3/4] Simplify rtas_change_msi() error semantics

2007-09-20 Thread Michael Ellerman
by RTAS is equal to what we requested - and return an error otherwise. This makes the return semantics match the usual 0 for success, something else for error. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/platforms/pseries/msi.c | 18 +++--- 1 files changed, 11

[PATCH 4/4] Inline u3msi_compose_msi_msg()

2007-09-20 Thread Michael Ellerman
In the MPIC U3 MSI code, we call u3msi_compose_msi_msg() once for each MSI. This is overkill, as the address is per pci device, not per MSI. So setup the address once, and just set the data per MSI. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/sysdev/mpic_u3msi.c | 24

Re: [Cbe-oss-dev] [patch 0/8] PS3 AV Settings Driver patches for 2.6.24

2007-09-26 Thread Michael Ellerman
pretty important that it works 100%. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person signature.asc

Re: [PATCH] add Altivec/VMX state to coredumps

2007-09-26 Thread Michael Ellerman
for the primary thread that's doing the coredump, not for each thread. Perhaps there's a way to adapt it though. I think the easiest solution for now is just to make the note type a #define and create a new value for Altivec. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http

Re: [PATCH v4] Make instruction dumping work in real mode.

2007-09-27 Thread Michael Ellerman
of the IMMU, and if necessary converts PC into a virtual address. IMMU ? cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children

Re: [PATCH] add Altivec/VMX state to coredumps

2007-09-27 Thread Michael Ellerman
++, - LINUX, NT_PRXFPREG, sizeof(*xfpu), xfpu); + LINUX, ELF_CORE_XFPREGS_TYPE, sizeof(*xfpu), xfpu); #endif fs = get_fs(); cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183

Re: [Cbe-oss-dev] [patch 0/8] PS3 AV Settings Driver patches for 2.6.24

2007-09-28 Thread Michael Ellerman
On Thu, 2007-09-27 at 10:23 -0700, Geoff Levand wrote: Michael Ellerman wrote: On Wed, 2007-09-26 at 18:33 +0200, Geert Uytterhoeven wrote: Hi, Here are some new patches for the PS3 AV Settings Driver (ps3av), which is used in close collaboration with the PS3 Virtual Frame Buffer

Re: [PATCH 6/7] Add dcr_map_reg() helper

2007-10-01 Thread Michael Ellerman
On Tue, 2007-10-02 at 15:19 +1000, Benjamin Herrenschmidt wrote: On Mon, 2007-09-17 at 16:05 +1000, Michael Ellerman wrote: Add a helper routine to map dcr's based on the dcr-reg property of a device node. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] Wouldn't it be more

Re: [PATCH 3/4] Simplify rtas_change_msi() error semantics

2007-10-01 Thread Michael Ellerman
On Tue, 2007-10-02 at 15:23 +1000, Benjamin Herrenschmidt wrote: On Thu, 2007-09-20 at 16:36 +1000, Michael Ellerman wrote: Currently rtas_change_msi() returns either the error code from RTAS, or if the RTAS call succeeded the number of irqs that were configured by RTAS. This makes checking

Re: [PATCH 3/4] Simplify rtas_change_msi() error semantics

2007-10-02 Thread Michael Ellerman
On Tue, 2007-10-02 at 16:24 +1000, Benjamin Herrenschmidt wrote: On Tue, 2007-10-02 at 15:58 +1000, Michael Ellerman wrote: Looks allright, just a question tho... what do we do if it fails ? Do we try to fallback to a lower number of MSIs ? Or what ? Dead device ? That's all up

Re: 2.6.23-rc7-mm1 -- powerpc rtas panic

2007-10-02 Thread Michael Ellerman
+ * anything */ + I realise it'll make the patch bigger, but this doesn't seem like a particularly good name for the variable anymore. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70

Re: 2.6.23-rc7-mm1 -- powerpc rtas panic

2007-10-02 Thread Michael Ellerman
On Wed, 2007-10-03 at 11:19 +1000, Tony Breeds wrote: On Wed, Oct 03, 2007 at 10:30:16AM +1000, Michael Ellerman wrote: I realise it'll make the patch bigger, but this doesn't seem like a particularly good name for the variable anymore. Sure, what about? Better .. but .. :D diff

[PATCH] Fail early in lmb_remove_region()

2007-10-02 Thread Michael Ellerman
-cnt. However there's the potential for a bug if a caller got that wrong. So to avoid such a bug in future we should fail in lmb_remove_region() if the r value is out of range. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/mm/lmb.c |2 ++ 1 files changed, 2 insertions(+), 0

Re: Fix regression. Make hot unlplug of CPU0 work again.

2007-10-05 Thread Michael Ellerman
to the drawing board for 2.6.24? Making sure we address the initial problem (which was exposed by kexec I think) and that we don't break cpu hotplug on the way. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183

Re: [PATCH v2] Fix regression. Make hot unlplug of CPU0 work again.

2007-10-11 Thread Michael Ellerman
anything about it. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person signature.asc Description

Re: [PATCH] [POWERPC] Use PAGE_OFFSET to tell if an address is user/kernel in SW TLB handlers

2007-10-14 Thread Michael Ellerman
of the theoretical 3-way branch when touching this code, even if it can be reduced to 2-way branch in practice. There's a construct involving the characters / and * which I believe can solve this problem. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http

[PATCH 1/5] Update ibm_newemac to use dcr_host_t.base

2007-10-15 Thread Michael Ellerman
Now that dcr_host_t contains the base address, we can use that in the ibm_newemac code, rather than storing it separately. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- drivers/net/ibm_newemac/mal.c |9 + drivers/net/ibm_newemac/mal.h |5 ++--- 2 files changed, 7

[PATCH 2/5] Use dcr_host_t.base in ibm_emac_mal

2007-10-15 Thread Michael Ellerman
This requires us to do a sort-of fake dcr_map(), so that base is set properly. This will be fixed/removed when the device-tree-aware emac driver is merged. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- drivers/net/ibm_emac/ibm_emac_mal.c |5 - drivers/net/ibm_emac/ibm_emac_mal.h

<    1   2   3   4   5   6   7   8   9   10   >