...@linux.vnet.ibm.com
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/smp.h |2 +-
arch/powerpc/kernel/smp.c | 12 +---
arch/powerpc/platforms/cell/interrupt.c |2 +-
arch/powerpc/platforms/ps3/smp.c|2 +-
4 files changed, 8
makes use of the timer offload
framework that the patches Patch[1/5] to Patch[4/5] build.
---
Preeti U Murthy (3):
cpuidle/ppc: Add timer offload framework to support deep idle states
cpuidle/ppc: CPU goes tickless if there are no arch-specific constraints
cpuidle/ppc: Add longnap
efficiently.
Signed-off-by: Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/smp.h |3 ++-
arch/powerpc/kernel/smp.c | 19 +++
arch/powerpc/platforms/cell/interrupt.c |2
. On
a broadcast ipi the event handler for a timer interrupt is called on the cpu
in deep idle state to handle the local events.
The current design and implementation of the timer offload framework supports
the ONESHOT tick mode but not the PERIODIC mode.
Signed-off-by: Preeti U. Murthy pre
disables tickless idle,
is a system wide setting. Hence resort to an arch specific call to check if a
cpu
can go into tickless idle.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/kernel/time.c |5 +
kernel/time/tick-sched.c |7 +++
2 files changed, 12
-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/platforms/powernv/processor_idle.c | 48 +++
1 file changed, 47 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/powernv/processor_idle.c
b/arch/powerpc/platforms/powernv/processor_idle.c
index
Hi Frederic,
On 07/25/2013 07:00 PM, Frederic Weisbecker wrote:
On Thu, Jul 25, 2013 at 02:33:02PM +0530, Preeti U Murthy wrote:
In the current design of timer offload framework, the broadcast cpu should
*not* go into tickless idle so as to avoid missed wakeups on CPUs in deep
idle states
Hi Frederic,
On 07/25/2013 07:00 PM, Frederic Weisbecker wrote:
On Thu, Jul 25, 2013 at 02:33:02PM +0530, Preeti U Murthy wrote:
In the current design of timer offload framework, the broadcast cpu should
*not* go into tickless idle so as to avoid missed wakeups on CPUs in deep
idle states
Hi Paul,
On 07/26/2013 08:49 AM, Paul Mackerras wrote:
On Fri, Jul 26, 2013 at 08:09:23AM +0530, Preeti U Murthy wrote:
Hi Frederic,
On 07/25/2013 07:00 PM, Frederic Weisbecker wrote:
Hi Preeti,
I'm not exactly sure why you can't enter the broadcast CPU in dynticks idle
mode.
I read
Hi Frederic,
I apologise for the confusion. As Paul pointed out maybe the usage of
the term lapic is causing a large amount of confusion. So please see the
clarification below. Maybe it will help answer your question.
On 07/26/2013 08:09 AM, Preeti U Murthy wrote:
Hi Frederic,
On 07/25/2013
makes use of the timer offload
framework that the patches Patch[1/5] to Patch[4/5] build.
This patch series is being resent to clarify certain ambiguity in the patch
descriptions from the previous post. Discussion around this:
https://lkml.org/lkml/2013/7/25/754
---
Preeti U Murthy (3):
cpuidle
efficiently.
Signed-off-by: Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/smp.h |3 ++-
arch/powerpc/kernel/smp.c | 19 +++
arch/powerpc/platforms/cell/interrupt.c |2
is called on the cpu
in deep idle state to handle the local events.
The current design and implementation of the timer offload framework supports
the ONESHOT tick mode but not the PERIODIC mode.
Signed-off-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/time.h
-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/platforms/powernv/processor_idle.c | 48 +++
1 file changed, 47 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/powernv/processor_idle.c
b/arch/powerpc/platforms/powernv/processor_idle.c
index
...@linux.vnet.ibm.com
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/smp.h |2 +-
arch/powerpc/kernel/smp.c | 12 +---
arch/powerpc/platforms/cell/interrupt.c |2 +-
arch/powerpc/platforms/ps3/smp.c|2 +-
4 files changed, 8
disables tickless idle,
is a system wide setting. Hence resort to an arch specific call to check if a
cpu
can go into tickless idle.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/kernel/time.c |5 +
kernel/time/tick-sched.c |7 +++
2 files changed, 12
Hi Li,
On 07/26/2013 03:35 PM, Li Yang-R58472 wrote:
-Original Message-
From: linux-pm-ow...@vger.kernel.org [mailto:linux-pm-
ow...@vger.kernel.org] On Behalf Of Preeti U Murthy
Sent: Thursday, July 25, 2013 5:03 PM
To: b...@kernel.crashing.org; paul.gortma...@windriver.com
Hi Ben,
On 07/27/2013 12:00 PM, Benjamin Herrenschmidt wrote:
On Fri, 2013-07-26 at 08:09 +0530, Preeti U Murthy wrote:
*The lapic of a broadcast CPU is active always*. Say CPUX, wants the
broadcast CPU to wake it up at timeX. Since we cannot program the lapic
of a remote CPU, CPUX will need
Hi,
On 07/29/2013 10:58 AM, Vaidyanathan Srinivasan wrote:
* Preeti U Murthy pre...@linux.vnet.ibm.com [2013-07-27 13:20:37]:
Hi Ben,
On 07/27/2013 12:00 PM, Benjamin Herrenschmidt wrote:
On Fri, 2013-07-26 at 08:09 +0530, Preeti U Murthy wrote:
*The lapic of a broadcast CPU is active
, but
the low level handling of the entry into idle states should be taken
care of by the architecture.
Your recent patch :
cpuidle: add freescale e500 family porcessors idle support IMO should
hook onto the backend cpuidle driver that this patchset provides.
Regards
Preeti U Murthy
Hi Dongsheng,
On 07/31/2013 11:16 AM, Wang Dongsheng-B40534 wrote:
Hi Preeti,
-Original Message-
From: Preeti U Murthy [mailto:pre...@linux.vnet.ibm.com]
Sent: Wednesday, July 31, 2013 12:00 PM
To: Wang Dongsheng-B40534
Cc: Deepthi Dharwar; b...@kernel.crashing.org; daniel.lezc
notifiers from
other architectures into the cpuidle framework as well?
Regards
Preeti U Murthy
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
on powernv
Patch[5/6]: Dynamically pick a broadcast CPU
Patch[6/6]: Remove the constraint of having to disable tickless idle on the
broadcast cpu, by queueing a hrtimer exclusively to do broadcast handling.
---
Preeti U Murthy (4):
cpuidle/ppc: Add timer offload framework to support deep idle
efficiently.
Signed-off-by: Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/smp.h |3 ++-
arch/powerpc/kernel/smp.c | 19 +++
arch/powerpc/platforms/cell/interrupt.c |2
...@linux.vnet.ibm.com
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/smp.h |2 +-
arch/powerpc/kernel/smp.c | 12 +---
arch/powerpc/platforms/cell/interrupt.c |2 +-
arch/powerpc/platforms/ps3/smp.c|2 +-
4 files changed, 8
interrupt is called on the cpu
in deep idle state to handle the local events.
The current design and implementation of the timer offload framework supports
the ONESHOT tick mode but not the PERIODIC mode.
Signed-off-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/time.h
sleep on ppc.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/platforms/powernv/processor_idle.c | 48 +++
1 file changed, 47 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/powernv/processor_idle.c
b/arch/powerpc/platforms
-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/time.h |1
arch/powerpc/kernel/time.c | 10 ++--
arch/powerpc/platforms/powernv/processor_idle.c | 56 +++
3 files changed, 53 insertions(+), 14 deletions
In the current design we were depending on the timer interrupt on the
bc_cpu to trigger broadcast handling. In tickless idle, timer interrupts
could be many ticks away which could result in missed wakeups on CPUs in deep
idle states. Disabling tickless idle on the bc_cpu is not good for
Hi Ben
On 08/22/2013 08:40 AM, Benjamin Herrenschmidt wrote:
On Wed, 2013-08-14 at 17:26 +0530, Preeti U Murthy wrote:
-static irqreturn_t unused_action(int irq, void *data)
+static irqreturn_t timer_action(int irq, void *data)
{
- /* This slot is unused and hence available for use
Hi Ben,
On 08/22/2013 08:57 AM, Benjamin Herrenschmidt wrote:
On Wed, 2013-08-14 at 17:26 +0530, Preeti U Murthy wrote:
static irqreturn_t timer_action(int irq, void *data)
{
-timer_interrupt();
+decrementer_timer_interrupt();
return IRQ_HANDLED;
}
I don't completely
Hi Ben,
On 08/22/2013 08:58 AM, Benjamin Herrenschmidt wrote:
On Wed, 2013-08-14 at 17:26 +0530, Preeti U Murthy wrote:
This patch hooks into the existing broadcast framework along with the support
that this patchset introduces for ppc, and the cpuidle driver backend
for powernv(posted out
...@linux.vnet.ibm.com
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/smp.h |2 +-
arch/powerpc/kernel/smp.c | 12 +---
arch/powerpc/platforms/cell/interrupt.c |2 +-
arch/powerpc/platforms/ps3/smp.c|2 +-
4 files changed, 8
for all their comments and suggestions so far.
---
Preeti U Murthy (4):
cpuidle/ppc: Split timer_interrupt() into timer handling and interrupt
handling routines
cpuidle/ppc: Add basic infrastructure to support the broadcast framework
on ppc
cpuidle/ppc: Introduce the deep idle
() into routines performed during regular
interrupt handling and __timer_interrupt(), which takes care of running local
timers and collecting time related stats. Now on a broadcast ipi, call
__timer_interrupt().
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/kernel/time.c
-off-by: Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com
[Changelog modified by pre...@linux.vnet.ibm.com]
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/smp.h |3 ++-
arch/powerpc/include/asm/time.h |1 +
arch/powerpc/kernel/smp.c
the broadcast ipi, set the
decrementers_next_tb
to now before calling __timer_interrupt().
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/Kconfig|1 +
arch/powerpc/include/asm/time.h |1 +
arch/powerpc/kernel/time.c | 69
was about to fire on it. Therefore the newly nominated broadcast cpu
should set the broadcast hrtimer on itself to expire immediately so as to not
miss wakeups under such scenarios.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/time.h |1 +
arch
cycle repeats.
Protect the region of nomination,de-nomination and check for existence of
broadcast
cpu with a lock to ensure synchronization between them.
[1] tick_handle_oneshot_broadcast() or tick_handle_periodic_broadcast().
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch
-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
___
Linuxppc-dev mailing list
Linuxppc-dev
() should be called in the reboot path generically. The
latter might not be an enticing option for other platforms.
Regards
Preeti U Murthy
Now the deal is how do we move to nominal frequency on reboot..
@Rafael: Any suggestions? How do we ensure that governors
are stopped on these notifiers
() to smp_call_function_single() in
Patch[2/2]
---
Preeti U Murthy (2):
cpufreq: Allow stop CPU callback to be used by all cpufreq drivers
powernv/cpufreq: Set the pstate of the last hotplugged out cpu in
policy-cpus to minimum
drivers/cpufreq/cpufreq.c |2 +-
drivers/cpufreq/powernv-cpufreq.c
.
The assumption is if the drivers find the GOV_STOP path to be a suitable
way of implementing what they want to do with the freq of the cpu
going offine,they will not implement the stop CPU callback at all.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
drivers/cpufreq/cpufreq.c |2
gets hotplugged out.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
drivers/cpufreq/powernv-cpufreq.c |9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/cpufreq/powernv-cpufreq.c
b/drivers/cpufreq/powernv-cpufreq.c
index 379c083..5a628f1 100644
--- a/drivers
Today the procfs interface /proc/sys/kernel/powersave-nap is used to control
entry into deep idle states beyond snooze. Check for the value of this
parameter before entering fastsleep. We already do this check for nap in
power7_idle().
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
On 09/15/2014 12:29 PM, Michael Ellerman wrote:
On Fri, 2014-09-12 at 16:31 +0530, Preeti U Murthy wrote:
Today the procfs interface /proc/sys/kernel/powersave-nap is used to control
entry into deep idle states beyond snooze. Check for the value of this
parameter before entering fastsleep. We
have the trace points usable, and it would
hopefully result in less duplicated logic.
I agree, this is perhaps the better approach.
Regards
Preeti U Murthy
cheers
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https
thread has restored it
anyway. So we are safe. We will certainly add a comment there.
Thanks
Regards
Preeti U Murthy
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
...@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org
Cc: Michael Ellerman m...@ellerman.id.au
Cc: Benjamin Herrenschmidt b...@kernel.crashing.org
Signed-off-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
Signed-off-by: Shreyas B. Prabhu shre...@linux.vnet.ibm.com
---
drivers/cpuidle/cpuidle-powernv.c | 27
. This does not look right to me.
Regards
Preeti U Murthy
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
it?
+ return 0;
+}
#endif /* CONFIG_HOTPLUG_CPU */
Note that xics_migrate_irqs_away() is defined under CONFIG_CPU_HOTPLUG.
But we will need this option on PowerKVM even when hotplug is not
configured in.
Regards
Preeti U Murthy
#ifdef CONFIG_SMP
are busy, scheduling ticks will fire and try to schedule a new task on them.
Regards
Preeti U Murthy
Introduce a kthread (anti_tickless) on primary, so when there is only
one vcpu thread on primary, the secondary can resort to anti_tickless
to keep the primary out of tickless mode.
(I thought
at compile time, we resolve the flag.
While booting, we look at the flag and decide whether to get the
secondaries online. So we get the current behavior if we have not
configured KVM_PPC_ENABLE_SECONDARY. Will this achieve the purpose of
this patch?
Regards
Preeti U Murthy
as I can see with having a b . after nap. I
mentioned that in one of my earlier replies to this patch.
Regards
Preeti U Murthy
+
+/* enter with vmode */
+kvmppc_secondary_stopper_exit:
+ /* fixme, restore the stack which we store on lpaca */
+
+ ld r0, 112+PPC_LR_STKOFF(r1
to host. This cannot be
trivially solved unless we can isolate these threads in some way.
Regards
Preeti U Murthy
Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/kvm_host.h | 3 +++
arch/powerpc/kernel/asm-offsets.c | 3 +++
arch/powerpc/kvm
have not taken care to migrate
timers or tasks before entering guest as far as I observed. Hence we
cannot just turn off time base like this and expect to handle the above
mentioned events the next time the primary thread decides to exit to the
host.
Regards
Preeti U Murthy
+
/* prevent us
the rest :) The top patches won't
compile without this one. Every patch in the patchset should be able to
compile successfully without the aid of the patches that come after it.
Regards
Preeti U Murthy
___
Linuxppc-dev mailing list
Linuxppc-dev
with reality except
for the first entry.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
Do we still need this workaround? Or can we get rid of the check
on powersave_nap altogether?
---
drivers/cpuidle/cpuidle-powernv.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
’ defined but not used [-Wunused-variable]
static struct of_device_id ehea_module_device_table[] = {
Thanks
Regards
Preeti U Murthy
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
. As far as I see besides explaining the
bits of core_idle_state structure and the purpose of lock bit the rest
of the comments is redundant. A git-blame will let people know why all
this is needed. The comment section should not be used up for this
purpose IMO.
Regards
Preeti U Murthy
Commit dcb18694 Fix ipi on palmeto disabled fastsleep at boot time.
Revert this commit since we no longer need this fix. However we can
continue to use powersave_nap parameter to control entry into deep
idle states beyond snooze.
Signed-off-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
Hi Joel,
On 11/19/2014 08:04 AM, Joel Stanley wrote:
Hey Preeti,
On Tue, Nov 18, 2014 at 5:26 PM, Preeti U Murthy
pre...@linux.vnet.ibm.com wrote:
Commit dcb18694 Fix ipi on palmeto disabled fastsleep at boot time.
I couldn't find this commit in any tree; upstream, mpe's next, nor
. The power numbers have very little
variation between the runs with and without the patchset.
Thanks
Regards
Preeti U Murthy
On 11/25/2014 04:47 PM, Shreyas B. Prabhu wrote:
Deep idle states like sleep and winkle are per core idle states. A core
enters these states only when all the threads enter
get_mp_bus_to_node(int busnum);
extern void set_mp_bus_to_node(int busnum, int node);
Reviewed-by: Preeti U Murthy pre...@linux.vnet.ibm.com
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
));
+ }
rc = cpufreq_register_driver(powernv_cpufreq_driver);
return rc;
Reviewed-by: Preeti U Murthy pre...@linux.vnet.ibm.com
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
struct freq_attr *powernv_cpu_freq_attr[] = {
cpufreq_freq_attr_scaling_available_freqs,
NULL,
Reviewed-by: Preeti U Murthy pre...@linux.vnet.ibm.com
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org
-by: Preeti U Murthy pre...@linux.vnet.ibm.com
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
is aimed at ensuring that the runlatch bits are consisten with the
utilization of a CPU under all circumstances.
---
Preeti U Murthy (3):
ppc/powernv: Set the runlatch bits correctly for offline cpus
ppc/kvm: Set the runlatch bit of a CPU just before starting guest
ppc/kvm: Clear
is aimed at ensuring that the runlatch bits are consisten with the
utilization of a CPU under all circumstances.
---
Preeti U Murthy (3):
ppc/powernv: Set the runlatch bits correctly for offline cpus
ppc/kvm: Set the runlatch bit of a CPU just before starting guest
ppc/kvm: Clear
to be cleared to indicate an unused CPU. Hence this patch has the
runlatch bit cleared for an offline CPU just before entering an idle state
and sets it immediately after it exits the idle state.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
Acked-by: Paul Mackerras pau...@samba.org
to be set to indicate that they
are busy. The primary thread has its runlatch bit set though, but there is no
harm in setting this bit once again. Hence set the runlatch bit for all
threads before they start guest.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
Acked-by: Paul Mackerras pau
When the guest cedes the vcpu or the vcpu has no guest to
run it naps. Clear the runlatch bit of the vcpu before
napping to indicate an idle cpu.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
Acked-by: Paul Mackerras pau...@samba.org
Reviewed-by: Srivatsa S. Bhat srivatsa.b
Commit 32e45ff43eaf5c17f changed the default value of
RECLAIM_DISTANCE to 30. However the comment around arch
specifc definition of RECLAIM_DISTANCE is not updated to
reflect the same. Correct the value mentioned in the comment.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
Cc: Anton
loop? This will ensure that no
matter what, before exiting timer interrupt handler we check for pending
irq work.
Regards
Preeti U Murthy
Signed-off-by: Anton Blanchard an...@samba.org
Cc: sta...@vger.kernel.org # 3.14+
---
diff --git a/arch/powerpc/kernel/time.c b/arch/powerpc/kernel/time.c
On 05/10/2014 09:56 AM, Benjamin Herrenschmidt wrote:
On Fri, 2014-05-09 at 15:22 +0530, Preeti U Murthy wrote:
in __timer_interrupt() outside the _else_ loop? This will ensure that no
matter what, before exiting timer interrupt handler we check for pending
irq work.
We still need to make
On 05/11/2014 03:55 AM, Benjamin Herrenschmidt wrote:
On Sat, 2014-05-10 at 21:06 +0530, Preeti U Murthy wrote:
On 05/10/2014 09:56 AM, Benjamin Herrenschmidt wrote:
On Fri, 2014-05-09 at 15:22 +0530, Preeti U Murthy wrote:
in __timer_interrupt() outside the _else_ loop? This will ensure
On 05/11/2014 02:07 PM, Benjamin Herrenschmidt wrote:
On Sun, 2014-05-11 at 13:45 +0530, Preeti U Murthy wrote:
+ /* Don't adjust the decrementer if some irq work is pending
*/
+ if (!test_irq_work_pending())
+ set_dec(evt);
+ else
On 05/11/2014 02:33 PM, Benjamin Herrenschmidt wrote:
On Sun, 2014-05-11 at 14:13 +0530, Preeti U Murthy wrote:
Isn't this patch required too?
@@ -503,12 +503,13 @@ void __timer_interrupt(void)
now = *next_tb - now;
if (now = DECREMENTER_MAX
Fast sleep is a deep idle state on Power8. The support for the state was
added in commit 0d94873011. Today the idle threads in the host can
potentially be put to fast sleep. But when we launch guests using kvm,
the secondary threads are required to be offline and the offline threads
are put to
S. Bhat srivatsa.b...@linux.vnet.ibm.com
[ Changelog added by pre...@linux.vnet.ibm.com ]
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/processor.h |4
drivers/cpuidle/cpuidle-powernv.c|7 +++
2 files changed, 7 insertions(+), 4
...@linux.vnet.ibm.com ]
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/processor.h |8 +
arch/powerpc/kernel/idle.c | 52 ++
arch/powerpc/platforms/powernv/smp.c | 12 +++-
3 files changed, 71
, add this check in the fastsleep wakeup path as well.
Signed-off-by: Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com
[ Changelog added by pre...@linux.vnet.ibm.com ]
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/kernel/exceptions-64s.S | 30
power savings in a KVM scenario as well
when an entire cpu core is idle.
As a precursor, consolidate the code common across all idle states.
Signed-off-by: Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com
[ Changelog added by pre...@linux.vnet.ibm.com ]
Signed-off-by: Preeti U Murthy pre
srivatsa.b...@linux.vnet.ibm.com
[ Changelog added by pre...@linux.vnet.ibm.com ]
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/kvm/book3s_hv_rmhandlers.S | 73 ---
1 file changed, 65 insertions(+), 8 deletions(-)
diff --git a/arch/powerpc
. Today they go back to nap by default.
Signed-off-by: Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com
[ Changelog added by pre...@linux.vnet.ibm.com ]
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/kernel/exceptions-64s.S | 21 +++--
arch/powerpc/kernel
this, the following line which clears the wakeup from external
interrupt bit can be removed as well, since we are not clearing it anyway ?
new_lpcr |= LPCR_PECE0
^^^
Regards
Preeti U Murthy
___
Linuxppc-dev mailing list
Linuxppc-dev
Commit 8d6f7c5a: powerpc/powernv: Make it possible to skip the IRQHAPPENED
check in power7_nap() added code that prevents even cores which enter sleep
on idle, from checking for pending interrupts. Fix this.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/kernel
IPI complaining that the sleeping cpu is stuck.
This patch fixes these issues by ensuring that cpus check for pending interrupts
just before entering any idle state as long as they are not in the path of split
core operations.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
Acked
fixes ths issue by ensuring that cpus check for pending interrupts
just before entering any idle state as long as they are not in the path of split
core operations.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
Chanes in V2: https://lkml.org/lkml/2014/7/1/3
Modified the changelog
machine, there will be a CPU domain encompassing the
socket and the MC domain will encompass a core. nohz_idle load balancer
will kick in if both the threads in the core have tasks running on them.
This is fair enough because the threads share the resources of the core.
Regards
Preeti U Murthy
the scalability issue. We also don't need to get to
sd-parent to get the nr_busy parameter for the sake of nohz_kick_needed().
What do you think?
Regards
Preeti U Murthy
This nohz stuff really needs to be re-thought and made more scalable --
its a royal pain :/
kernel/sched/core.c | 4
On 10/23/2013 09:30 AM, Preeti U Murthy wrote:
Hi Peter,
On 10/23/2013 03:41 AM, Peter Zijlstra wrote:
On Mon, Oct 21, 2013 at 05:14:42PM +0530, Vaidyanathan Srinivasan wrote:
kernel/sched/fair.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git
. sd_busy therefore is irrelevant for asymmetric load
balancing.
Regards
Preeti U Murthy
START_PATCH---
sched: Fix nohz_kick_needed()
---
kernel/sched/core.c |4
kernel/sched/fair.c | 40 ++--
kernel/sched
this a thought and get back.
Regards
Preeti U Murthy
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Hi Vincent,
I have addressed your comments and below is the fresh patch. This patch
applies on PATCH 2/3 posted in this thread.
Regards
Preeti U Murthy
sched:Remove un-necessary iterations over sched domains to update/query
nr_busy_cpus
From: Preeti U Murthy pre...@linux.vnet.ibm.com
this just at the SIBLINGS level? Having the hyper
threads busy due to the scenario described in the changelog is bad for
performance.
Regards
Preeti U Murthy
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo
Hi Peter,
On 10/28/2013 07:20 PM, Peter Zijlstra wrote:
On Thu, Oct 24, 2013 at 01:37:38PM +0530, Preeti U Murthy wrote:
kernel/sched/core.c |5 +
kernel/sched/fair.c | 38 --
kernel/sched/sched.h |1 +
3 files changed, 26 insertions
Hi Peter,
On 10/28/2013 09:23 PM, Peter Zijlstra wrote:
On Mon, Oct 21, 2013 at 05:15:02PM +0530, Vaidyanathan Srinivasan wrote:
From: Preeti U Murthy pre...@linux.vnet.ibm.com
The current logic in load balance is such that after picking the
busiest group, the load is attempted to be moved
domain-sd_busy where it is relevant.
3. Introduce sd_asym to represent the sched domain where asymmetric load
balancing has to be done.
---
Preeti U Murthy (1):
sched: Remove un-necessary iteration over sched domains to update
nr_busy_cpus
Vaidyanathan Srinivasan (1):
sched: Fix
nr_busy_cpus parameter is used by nohz_kick_needed() to find out the number
of busy cpus in a sched domain which has SD_SHARE_PKG_RESOURCES flag set.
Therefore instead of updating nr_busy_cpus at every level of sched domain,
since it is irrelevant, we can update this parameter only at the parent
1 - 100 of 279 matches
Mail list logo
