Re: [PATCH] powerpc/pseries: fix accuracy of stolen time

2024-02-12 Thread Srikar Dronamraju
ARAVIRT_TIME_ACCOUNTING") > Signed-off-by: Shrikanth Hegde Looks good to me. Reviewed-by: Srikar Dronamraju -- Thanks and Regards Srikar Dronamraju

[PATCH v5 5/5] powerpc/smp: Dynamically build Powerpc topology

2023-12-14 Thread Srikar Dronamraju
dynamically then the code is simpler and there are greater chances of avoiding degenerations. Note: Even X86 builds its sched topologies dynamically and proposed changes are very similar to the way X86 is building its topologies. Signed-off-by: Srikar Dronamraju --- Changelog: v3 -> v4: - Confl

[PATCH v5 3/5] powerpc/smp: Add __ro_after_init attribute

2023-12-14 Thread Srikar Dronamraju
There are some variables that are only updated at boot time. So add __ro_after_init attribute to such variables Signed-off-by: Srikar Dronamraju --- Changelog: v2 -> v3: Use __ro_after_init instead of __read_mostly Suggested by : Peter Zijlstra and Michael Ellerman arch/powerpc/kernel/sm

[PATCH v5 4/5] powerpc/smp: Avoid asym packing within thread_group of a core

2023-12-14 Thread Srikar Dronamraju
groups of the same core. Signed-off-by: Srikar Dronamraju --- arch/powerpc/kernel/smp.c | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c index aea149627209..9d8bb9a084bd 100644 --- a/arch/powerpc/kernel/smp.c +++ b/arch/powerpc

[PATCH v5 2/5] powerpc/smp: Disable MC domain for shared processor

2023-12-14 Thread Srikar Dronamraju
Like L2-cache info, coregroup information which is used to determine MC sched domains is only present on dedicated LPARs. i.e PowerVM doesn't export coregroup information for shared processor LPARs. Hence disable creating MC domains on shared LPAR Systems. Signed-off-by: Srikar Dronamraju

[PATCH v5 0/5] powerpc/smp: Topology and shared processor optimizations

2023-12-14 Thread Srikar Dronamraju
rman Cc: Nicholas Piggin Cc: "Paul E. McKenney" Cc: Peter Zijlstra (Intel) Cc: Rohan McLure Cc: Valentin Schneider Cc: Vincent Guittot CC: Aneesh Srikar Dronamraju (5): powerpc/smp: Enable Asym packing for cores on shared processor powerpc/smp: Disable MC domain for shared

[PATCH v5 1/5] powerpc/smp: Enable Asym packing for cores on shared processor

2023-12-14 Thread Srikar Dronamraju
level when the system is running in shared processor mode and has big cores. Signed-off-by: Srikar Dronamraju --- Changelog: v4 -> v5: - commit msg update v3 -> v4: - Dont use splpar_asym_pack with SMT - Conflict resolution due to rebase (DIE changed to PKG) v2 -> v3: - Handle comm

Re: [PATCH v4 0/5] powerpc/smp: Topology and shared processor optimizations

2023-12-10 Thread Srikar Dronamraju
* Srikar Dronamraju [2023-11-09 11:19:28]: Hi Michael, > PowerVM systems configured in shared processors mode have some unique > challenges. Some device-tree properties will be missing on a shared > processor. Hence some sched domains may not make sense for shared processor

Re: [PATCH v4 1/5] powerpc/smp: Enable Asym packing for cores on shared processor

2023-11-15 Thread Srikar Dronamraju
* Aneesh Kumar K.V [2023-11-15 12:05:22]: > Srikar Dronamraju writes: > > > > > arch/powerpc/kernel/smp.c | 37 + > > 1 file changed, 29 insertions(+), 8 deletions(-) > > > > diff --git a/arch/powerpc/kernel/smp.c b

Re: [PATCH v4 0/5] powerpc/smp: Topology and shared processor optimizations

2023-11-14 Thread Srikar Dronamraju
* Aneesh Kumar K.V [2023-11-15 11:24:59]: > Srikar Dronamraju writes: > > > PowerVM systems configured in shared processors mode have some unique > > challenges. Some device-tree properties will be missing on a shared > > processor. Hence some sched domains may n

Re: [PATCH v4 1/5] powerpc/smp: Enable Asym packing for cores on shared processor

2023-11-14 Thread Srikar Dronamraju
* Aneesh Kumar K.V [2023-11-15 10:57:08]: > Srikar Dronamraju writes: > > > If there are shared processor LPARs, underlying Hypervisor can have more > > virtual cores to handle than actual physical cores. > > > > Starting with Power 9, a big core (aka SMT8 core

Re: [PATCH] powerpc/sched: Cleanup vcpu_is_preempted()

2023-11-14 Thread Srikar Dronamraju
* Aneesh Kumar K V [2023-11-14 15:45:35]: > On 11/14/23 3:16 PM, Srikar Dronamraju wrote: > > * Aneesh Kumar K.V [2023-11-14 12:42:19]: > > > >> No functional change in this patch. A helper is added to find if > >> vcpu is dispatched by hypervisor. Use that

Re: [PATCH] powerpc/sched: Cleanup vcpu_is_preempted()

2023-11-14 Thread Srikar Dronamraju
if If we are introducing vcpu_is_dispatched, we should remove yield_count_of() and use vcpu_is_dispatched everwhere No point in having yield_count_of() and vcpu_is_dispatched, since yield_count_of() is only used to check if we are running in OS or not. -- Thanks and Regards Srikar Dronamraju

[PATCH v4 4/5] powerpc/smp: Avoid asym packing within thread_group of a core

2023-11-08 Thread Srikar Dronamraju
groups of the same core. Signed-off-by: Srikar Dronamraju --- arch/powerpc/kernel/smp.c | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c index 65a6f988374a..a84931c37246 100644 --- a/arch/powerpc/kernel/smp.c +++ b/arch/powerpc

[PATCH v4 5/5] powerpc/smp: Dynamically build Powerpc topology

2023-11-08 Thread Srikar Dronamraju
dynamically then the code is simpler and there are greater chances of avoiding degenerations. Note: Even X86 builds its sched topologies dynamically and proposed changes are very similar to the way X86 is building its topologies. Signed-off-by: Srikar Dronamraju --- Changelog: v3 -> v4: - Confl

[PATCH v4 3/5] powerpc/smp: Add __ro_after_init attribute

2023-11-08 Thread Srikar Dronamraju
There are some variables that are only updated at boot time. So add __ro_after_init attribute to such variables Signed-off-by: Srikar Dronamraju --- Changelog: v2 -> v3: Use __ro_after_init instead of __read_mostly Suggested by : Peter Zijlstra and Michael Ellerman arch/powerpc/kernel/sm

[PATCH v4 0/5] powerpc/smp: Topology and shared processor optimizations

2023-11-08 Thread Srikar Dronamraju
: Rohan McLure Cc: Valentin Schneider Cc: Vincent Guittot Srikar Dronamraju (5): powerpc/smp: Enable Asym packing for cores on shared processor powerpc/smp: Disable MC domain for shared processor powerpc/smp: Add __ro_after_init attribute powerpc/smp: Avoid asym packing within thread_g

[PATCH v4 1/5] powerpc/smp: Enable Asym packing for cores on shared processor

2023-11-08 Thread Srikar Dronamraju
in shared processor mode and has big cores. Signed-off-by: Srikar Dronamraju --- Changelog: v3 -> v4: - Dont use splpar_asym_pack with SMT - Conflict resolution due to rebase (DIE changed to PKG) v2 -> v3: - Handle comments from Michael Ellerman. - Rework using existing cpu_has_fe

[PATCH v4 2/5] powerpc/smp: Disable MC domain for shared processor

2023-11-08 Thread Srikar Dronamraju
Like L2-cache info, coregroup information which is used to determine MC sched domains is only present on dedicated LPARs. i.e PowerVM doesn't export coregroup information for shared processor LPARs. Hence disable creating MC domains on shared LPAR Systems. Signed-off-by: Srikar Dronamraju

[PATCH v3 5/5] powerpc/smp: Dynamically build Powerpc topology

2023-10-26 Thread Srikar Dronamraju
dynamically then the code is simpler and there are greater chances of avoiding degenerations. Note: Even X86 builds its sched topologies dynamically and proposed changes are very similar to the way X86 is building its topologies. Signed-off-by: Srikar Dronamraju --- arch/powerpc/kernel/smp.c | 78

[PATCH v3 4/5] powerpc/smp: Avoid asym packing within thread_group of a core

2023-10-26 Thread Srikar Dronamraju
groups of the same core. Signed-off-by: Srikar Dronamraju --- arch/powerpc/kernel/smp.c | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c index 27770f7f1ae5..daede8c2abc1 100644 --- a/arch/powerpc/kernel/smp.c +++ b/arch

[PATCH v3 3/5] powerpc/smp: Add __ro_after_init attribute

2023-10-26 Thread Srikar Dronamraju
There are some variables that are only updated at boot time. So add __ro_after_init attribute to such variables Signed-off-by: Srikar Dronamraju --- Changelog: v2 -> v3: Use __ro_after_init instead of __read_mostly Suggested by : Peter Zijlstra and Michael Ellerman arch/powerpc/kernel/sm

[PATCH v3 2/5] powerpc/smp: Disable MC domain for shared processor

2023-10-26 Thread Srikar Dronamraju
Like L2-cache info, coregroup information which is used to determine MC sched domains is only present on dedicated LPARs. i.e PowerVM doesn't export coregroup information for shared processor LPARs. Hence disable creating MC domains on shared LPAR Systems. Signed-off-by: Srikar Dronamraju

[PATCH v3 1/5] powerpc/smp: Enable Asym packing for cores on shared processor

2023-10-26 Thread Srikar Dronamraju
in shared processor mode and has big cores. Signed-off-by: Srikar Dronamraju --- Changelog: v1->v2: Using Jump label instead of a variable. v2 -> v3: - Handle comments on commit message (Michael Ellerman) - Rework using existing cpu_has_features static key (Michael Ellerman) - Added a c

[PATCH v3 0/5] powerpc/smp: Topology and shared processor optimizations

2023-10-26 Thread Srikar Dronamraju
tophe Leroy Cc: linux-ker...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Cc: Mark Rutland Cc: Michael Ellerman Cc: "ndesaulni...@google.com" Cc: Nicholas Piggin Cc: "Paul E. McKenney" Cc: "Peter Zijlstra (Intel)" Cc: Rohan McLure Cc: Srikar Dronamraju

Re: [PATCH] powerpc/smp: Dynamically build powerpc topology

2023-10-20 Thread Srikar Dronamraju
* Michael Ellerman [2023-10-20 23:10:55]: > Srikar Dronamraju writes: > > Currently there are four powerpc specific sched topologies. These are > > all statically defined. However not all these topologies are used by > > all powerpc systems. > > > > T

Re: [PATCH v2 1/6] powerpc/smp: Cache CPU has Asymmetric SMP

2023-10-20 Thread Srikar Dronamraju
* Michael Ellerman [2023-10-19 15:33:16]: > Srikar Dronamraju writes: > > Currently cpu feature flag is checked whenever powerpc_smt_flags gets > > called. This is an unnecessary overhead. CPU_FTR_ASYM_SMT is set based > > on the processor and all processors will

Re: [PATCH v2 2/6] powerpc/smp: Enable Asym packing for cores on shared processor

2023-10-19 Thread Srikar Dronamraju
* Shrikanth Hegde [2023-10-19 21:26:56]: > > > On 10/18/23 10:07 PM, Srikar Dronamraju wrote: > > If there are shared processor LPARs, underlying Hypervisor can have more > > virtual cores to handle than actual physical cores. > > > > Starting with Power 9

Re: [PATCH v2 4/6] powerpc/smp: Disable MC domain for shared processor

2023-10-19 Thread Srikar Dronamraju
* Peter Zijlstra [2023-10-19 09:50:46]: > On Thu, Oct 19, 2023 at 03:48:48PM +1100, Michael Ellerman wrote: > > Srikar Dronamraju writes: > > > Like L2-cache info, coregroup information which is used to determine MC > > > sched domains is only present on dedicated

Re: [PATCH v2 4/6] powerpc/smp: Disable MC domain for shared processor

2023-10-19 Thread Srikar Dronamraju
* Michael Ellerman [2023-10-19 15:48:48]: > Srikar Dronamraju writes: > > Like L2-cache info, coregroup information which is used to determine MC > > sched domains is only present on dedicated LPARs. i.e PowerVM doesn't > > export coregroup information for shared processor

Re: [PATCH v2 3/6] powerpc/smp: Move shared_processor static key to smp.h

2023-10-19 Thread Srikar Dronamraju
* Michael Ellerman [2023-10-19 15:41:40]: > Srikar Dronamraju writes: > > The ability to detect if the system is running in a shared processor > > mode is helpful in few more generic cases not just in > > paravirtualization. > > For example: At boot time, different sc

Re: [PATCH v2 5/6] powerpc/smp: Add read_mostly attribute

2023-10-19 Thread Srikar Dronamraju
* Peter Zijlstra [2023-10-19 09:51:27]: > On Wed, Oct 18, 2023 at 10:07:45PM +0530, Srikar Dronamraju wrote: > > There are some variables that are only updated at boot time. > > So add read_mostly attribute to such variables > > You don't have __ro_after_init ? M

Re: [PATCH v2 2/6] powerpc/smp: Enable Asym packing for cores on shared processor

2023-10-19 Thread Srikar Dronamraju
* Peter Zijlstra [2023-10-19 09:48:28]: > On Thu, Oct 19, 2023 at 03:38:40PM +1100, Michael Ellerman wrote: > > Srikar Dronamraju writes: > > > If there are shared processor LPARs, underlying Hypervisor can have more > > > virtual cores to handle than actual physical

[PATCH v4] powerpc/paravirt: Improve vcpu_is_preempted

2023-10-19 Thread Srikar Dronamraju
-by: Shrikanth Hegde Signed-off-by: Srikar Dronamraju --- Changelog: v2 (http://lkml.kernel.org/r/20231018155838.2332822-1-sri...@linux.vnet.ibm.com) -> v4: Resolved comments from Michael Ellerman v1 (http://lkml.kernel.org/r/20231009051740.17683-1-sri...@linux.vnet.ibm.com) -> v2:

[PATCH v3] powerpc/paravirt: Improve vcpu_is_preempted

2023-10-19 Thread Srikar Dronamraju
-by: Shrikanth Hegde Signed-off-by: Srikar Dronamraju --- Changelog: v2 (http://lkml.kernel.org/r/20231018155838.2332822-1-sri...@linux.vnet.ibm.com) -> v3: Resolved comments from Michael Ellerman v1 (http://lkml.kernel.org/r/20231009051740.17683-1-sri...@linux.vnet.ibm.com) -> v2:

[PATCH v2 1/6] powerpc/smp: Cache CPU has Asymmetric SMP

2023-10-18 Thread Srikar Dronamraju
subsequently. This commit will help avoid a branch in powerpc_smt_flags Signed-off-by: Srikar Dronamraju --- Changelog: v1->v2: Using static keys instead of a variable. Using pr_info_once instead of printk arch/powerpc/kernel/smp.c | 15 +-- 1 file changed, 9 insertions(+), 6 deleti

[PATCH v2 2/6] powerpc/smp: Enable Asym packing for cores on shared processor

2023-10-18 Thread Srikar Dronamraju
on each LPAR would help them to perform better. This is because each of the LPAR will get 100% time to run applications and there will no switching required by the Hypervisor. To achieve this, enable SD_ASYM_PACKING flag at CACHE, MC and DIE level. Signed-off-by: Srikar Dronamraju --- Changelog

[PATCH v2 4/6] powerpc/smp: Disable MC domain for shared processor

2023-10-18 Thread Srikar Dronamraju
Like L2-cache info, coregroup information which is used to determine MC sched domains is only present on dedicated LPARs. i.e PowerVM doesn't export coregroup information for shared processor LPARs. Hence disable creating MC domains on shared LPAR Systems. Signed-off-by: Srikar Dronamraju

[PATCH v2 5/6] powerpc/smp: Add read_mostly attribute

2023-10-18 Thread Srikar Dronamraju
There are some variables that are only updated at boot time. So add read_mostly attribute to such variables Signed-off-by: Srikar Dronamraju --- arch/powerpc/kernel/smp.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc

[PATCH v2 6/6] powerpc/smp: Avoid asym packing within thread_group of a core

2023-10-18 Thread Srikar Dronamraju
groups of the same core. Signed-off-by: Srikar Dronamraju --- arch/powerpc/kernel/smp.c | 16 1 file changed, 16 insertions(+) diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c index b1eb11a66902..a710fb32a2a9 100644 --- a/arch/powerpc/kernel/smp.c +++ b/arch/powerpc

[PATCH v2 3/6] powerpc/smp: Move shared_processor static key to smp.h

2023-10-18 Thread Srikar Dronamraju
-by: Srikar Dronamraju --- arch/powerpc/include/asm/paravirt.h | 12 arch/powerpc/include/asm/smp.h | 14 ++ 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/arch/powerpc/include/asm/paravirt.h b/arch/powerpc/include/asm/paravirt.h index 0372b0093f72

[PATCH v2 0/6] powerpc/smp: Shared processor sched optimizations

2023-10-18 Thread Srikar Dronamraju
he Leroy Cc: linuxppc-dev@lists.ozlabs.org Cc: Nicholas Piggin Cc: Peter Zijlstra (Intel) Cc: Rohan McLure Cc: Valentin Schneider Srikar Dronamraju (6): powerpc/smp: Cache CPU has Asymmetric SMP powerpc/smp: Enable Asym packing for cores on shared processor powerpc/smp: Move shared_proc

[PATCH v2] powerpc/paravirt: Improve vcpu_is_preempted

2023-10-18 Thread Srikar Dronamraju
636.lelmjkyv-...@intel.com/ 2. Resolved comments from Shrikanth Tested-by: Aboorva Devarajan Reviewed-by: Shrikanth Hegde Signed-off-by: Srikar Dronamraju --- arch/powerpc/include/asm/paravirt.h | 42 ++--- 1 file changed, 39 insertions(+), 3 deletions(-) diff --git a/a

Re: [PATCH] powerpc/paravirt: Improve vcpu_is_preempted

2023-10-11 Thread Srikar Dronamraju
* Shrikanth Hegde [2023-10-11 14:33:34]: > On 10/9/23 10:47 AM, Srikar Dronamraju wrote: > > Hi Srikar. This is an interesting patch. > > > PowerVM Hypervisor dispatches on a whole core basis. In a shared LPAR, a > s/whole/big > > Can we mention that a big core

[PATCH] powerpc/paravirt: Improve vcpu_is_preempted

2023-10-08 Thread Srikar Dronamraju
: Michael Ellerman Cc: Nicholas Piggin Cc: virtualizat...@lists.linux-foundation.org Signed-off-by: Srikar Dronamraju --- arch/powerpc/include/asm/paravirt.h | 33 ++--- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/include/asm/paravirt.h b

Re: [PATCH] powerpc/smp: Dynamically build powerpc topology

2023-09-04 Thread Srikar Dronamraju
* Peter Zijlstra [2023-09-05 00:10:04]: > On Wed, Aug 30, 2023 at 05:56:14PM +0530, Srikar Dronamraju wrote: > > Currently there are four powerpc specific sched topologies. These are > > all statically defined. However not all these topologies are used by > >

[PATCH] powerpc/smp: Dynamically build powerpc topology

2023-08-30 Thread Srikar Dronamraju
1067.5 1090.03 1073.89 1076.574 9.4189347 -2.68697 Signed-off-by: Srikar Dronamraju --- arch/powerpc/kernel/smp.c | 78 ++- 1 file changed, 28 insertions(+), 50 deletions(-) diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c index 48b816

[PATCH 4/4] powerpc/smp: Disable MC domain for shared processor

2023-08-30 Thread Srikar Dronamraju
Like L2-cache info, coregroup information which is used to determine MC sched domains is only present on dedicated LPARs. i.e PowerVM doesn't export coregroup information for shared processor LPARs. Hence disable creating MC domains on shared LPAR Systems. Signed-off-by: Srikar Dronamraju

[PATCH 2/4] powerpc/smp: Move shared_processor static key to smp.h

2023-08-30 Thread Srikar Dronamraju
-by: Srikar Dronamraju --- arch/powerpc/include/asm/paravirt.h | 12 arch/powerpc/include/asm/smp.h | 14 ++ 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/arch/powerpc/include/asm/paravirt.h b/arch/powerpc/include/asm/paravirt.h index f5ba1a3c41f8

[PATCH 3/4] powerpc/smp: Enable Asym packing for cores on shared processor

2023-08-30 Thread Srikar Dronamraju
on each lpar would help them to perform better. To achieve this, enable SD_ASYM_PACKING flag at CACHE, MC and DIE level. Signed-off-by: Srikar Dronamraju --- arch/powerpc/kernel/smp.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/kernel/smp.c b

[PATCH 0/4] powerpc/smp: Shared processor sched optimizations

2023-08-30 Thread Srikar Dronamraju
on scenarios. Note: The numbers are with Uncapped + no-noise case. In the Capped and/or noise case, due to contention on the Cores, the numbers are expected to further improve. Srikar Dronamraju (4): powerpc/smp: Cache CPU has Asymmetric SMP powerpc/smp: Move shared_processor static key to smp.h p

[PATCH 1/4] powerpc/smp: Cache CPU has Asymmetric SMP

2023-08-30 Thread Srikar Dronamraju
subsequently. This commit will help avoid a branch in powerpc_smt_flags Signed-off-by: Srikar Dronamraju --- arch/powerpc/kernel/smp.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c index fbbb695bae3d

Re: [RFC v2 1/2] powerpc/cpuidle: cpuidle wakeup latency based on IPI and timer events

2023-08-29 Thread Srikar Dronamraju
4, dir, _wakeup.latency_ns); > + debugfs_create_u32("ipi_cpu_src", 0444, dir, _wakeup.src_cpu); > + > + temp = debugfs_create_file("timeout_expected_ns", 0644, dir, NULL, > _ops); > + if (!temp) { > + pr_alert("latency_test: failed to create > /sys/kernel/

Re: [PATCH v4 10/10] powerpc/pseries: Honour current SMT state when DLPAR onlining CPUs

2023-08-14 Thread Srikar Dronamraju
* Laurent Dufour [2023-07-05 16:51:43]: > From: Michael Ellerman > > Integrate with the generic SMT support, so that when a CPU is DLPAR > onlined it is brought up with the correct SMT mode. > Looks good to me. Reviewed-by: Srikar Dronamraju > Signed-off-by: Michael Eller

Re: [PATCH v4 09/10] powerpc: Add HOTPLUG_SMT support

2023-08-14 Thread Srikar Dronamraju
f-by: Michael Ellerman > [ldufour: pass current SMT level to cpu_smt_set_num_threads] > [ldufour: remove topology_smt_supported] > [ldufour: remove topology_smt_threads_supported] > [ldufour: select CONFIG_SMT_NUM_THREADS_DYNAMIC] > [ldufour: update kernel-parameters.txt] > Signed-off-

Re: [PATCH v4 08/10] powerpc/pseries: Initialise CPU hotplug callbacks earlier

2023-08-14 Thread Srikar Dronamraju
ug_init() which > can be called early from setup_arch(). The DLPAR related initialisation > can still be done later, because it needs to do allocations. > Looks good to me. Reviewed-by: Srikar Dronamraju > Signed-off-by: Michael Ellerman -- Thanks and Regards Srikar Dronamraju

Re: Probing nvme disks fails on Upstream kernels on powerpc Maxconfig

2023-05-22 Thread Srikar Dronamraju
* Michael Ellerman [2023-05-22 17:41:22]: > Srikar Dronamraju writes: > > * Alexey Kardashevskiy [2023-04-13 22:09:22]: > > > >> > > On 23.03.23 10:53, Srikar Dronamraju wrote: > >> > > > > > Hi Alexey, Michael > > > > Sorr

Re: [PATCH v3] powerpc/iommu: DMA address offset is incorrectly calculated with 2MB TCEs

2023-05-22 Thread Srikar Dronamraju
river is reporting timeout trying to ENABLE_HCA for an SR-IOV > ethernet port, when DMA window is backed by 2MB TCEs. > > Fixes: 387273118714 ("powerps/pseries/dma: Add support for 2M IOMMU page > size") > > Signed-off-by: Gaurav Batra > Works with this patch. T

Re: Probing nvme disks fails on Upstream kernels on powerpc Maxconfig

2023-05-22 Thread Srikar Dronamraju
* Alexey Kardashevskiy [2023-04-13 22:09:22]: > > > On 23.03.23 10:53, Srikar Dronamraju wrote: > > > > > > > > I am unable to boot upstream kernels from v5.16 to the latest upstream > > > > kernel on a maxconfig system. (Machine config details

Re: [PATCH 1/2] pseries/smp: export the smt level in the SYS FS.

2023-04-18 Thread Srikar Dronamraju
space applications like ppc64_cpu should > >> update the sysfs when changing the SMT level to keep the system consistent. > >> > >> Suggested-by: Srikar Dronamraju > >> Signed-off-by: Laurent Dufour > >> --- > >> arch/powerpc/platforms/pseries/pseries.h |

Probing nvme disks fails on Upstream kernels on powerpc Maxconfig

2023-03-23 Thread Srikar Dronamraju
% /tmp /dev/nvme0n1p241943040 1848684823400448 45% /boot/grub2/powerpc-ieee1275 /dev/nvme0n1p3 739098844 19459884 719638960 3% /home tmpfs 6502249856 64 6502249792 1% /run/user/1005 -- Thanks and Regards Srikar Dronamraju

Re: sched/debug: CPU hotplug operation suffers in a large cpu systems

2022-11-08 Thread Srikar Dronamraju
head for those users who are sure they don't depend on these files. We still keep the creating of the files as the default approach so that others who depend on it are not going to be impacted. > > thanks, > > greg k-h -- Thanks and Regards Srikar Dronamraju

[PATCH] scripts/faddr2line: Fix regression in name resolution on ppc64le

2022-09-27 Thread Srikar Dronamraju
/bpf/20191211160133.GB4580@calabresa/ Cc: "Naveen N. Rao" Cc: Jiri Olsa Cc: Thadeu Lima de Souza Cascardo Cc: Josh Poimboeuf Cc: Peter Zijlstra (Intel) Cc: linuxppc-dev Cc: LKML Signed-off-by: Srikar Dronamraju --- scripts/faddr2line | 7 --- 1 file changed, 4 insertions(+),

Re: [PATCH 2/2] powerpc/numa: Return the first online node if device tree mapping returns a not online node

2022-06-24 Thread Srikar Dronamraju
of_node_put(cpu); > > out_present: > - if (nid < 0 || !node_possible(nid)) > + if (nid < 0 || !node_online(nid)) > nid = first_online_node; > > /* > -- > 2.36.1 > -- Thanks and Regards Srikar Dronamraju

Re: [PATCH 1/2] powerpc/numa: Return the first online node instead of 0

2022-06-24 Thread Srikar Dronamraju
node is actually not a variable, it returns the lowest online node. Right? If lets a early_cpu_to_node() for the same CPU across a node online/offline may end up giving two different nids. Right? > } > > int of_drconf_to_nid_single(struct drmem_lmb *lmb); > -- > 2.36.1 > -- Thanks and Regards Srikar Dronamraju

Re: [PATCH] powerpc/numa: Associate numa node to its cpu earlier

2022-04-11 Thread Srikar Dronamraju
; But we do not really care, as we already now the > CPU <-> NUMA associativity back in find_and_online_cpu_nid(), > so let us make use of that and set the proper numa<->cpu mapping, > so cpu_to_node() in cpu_up() returns the right node and > try_online_node() can do its w

Re: [PATCH v2 3/4] tools/perf: Fix perf numa bench to fix usage of affinity for machines with #CPUs > 1K

2022-04-08 Thread Srikar Dronamraju
's in the system. > > Fixed all places where "bind_cpumask" which is part of "struct > thread_data" is used such that bind_cpumask works in all configuration. > > Tested-by: Disha Goel > Signed-off-by: Athira Rajeev > Reported-by: Disha Goel Looks good to me. R

Re: [PATCH v2 1/4] tools/perf: Fix perf bench futex to correct usage of affinity for machines with #CPUs > 1K

2022-04-08 Thread Srikar Dronamraju
ng all the futex benchmarks to use > CPU_ALLOC to allocate cpumask, CPU_ALLOC_SIZE for size, and > CPU_SET_S to set the mask. > > Tested-by: Disha Goel > Signed-off-by: Athira Rajeev > Reported-by: Disha Goel Looks good to me Reviewed-by: Srikar Dronamraju > --- > to

Re: [PATCH v2 4/4] tools/perf: Fix perf bench numa testcase to check if CPU used to bind task is online

2022-04-08 Thread Srikar Dronamraju
cpu_online" in > "tools/perf/util/header.c". > > Since "BIT(x)" definition will get included from header.h, remove > that from bench/numa.c > > Tested-by: Disha Goel > Signed-off-by: Athira Rajeev > Reported-by: Disha Goel Looks good to me. Rev

Re: [PATCH] powerpc/numa: Handle partially initialized numa nodes

2022-04-08 Thread Srikar Dronamraju
* Oscar Salvador [2022-04-06 18:19:00]: > On Wed, Mar 30, 2022 at 07:21:23PM +0530, Srikar Dronamraju wrote: > > arch/powerpc/mm/numa.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/nu

[PATCH] powerpc/numa: Handle partially initialized numa nodes

2022-03-30 Thread Srikar Dronamraju
f49dca570a ("mm: handle uninitialized numa nodes gracefully") Cc: linuxppc-dev@lists.ozlabs.org Cc: linux...@kvack.org Cc: Michal Hocko Cc: Michael Ellerman Reported-by: Geetika Moolchandani Signed-off-by: Srikar Dronamraju --- arch/powerpc/mm/numa.c | 2 +- 1 file changed, 1 inse

Re: [PATCH] sched: topology: add input parameter for sched_domain_flags_f()

2022-03-28 Thread Srikar Dronamraju
* Qing Wang [2022-03-28 02:53:37]: > From: Wang Qing > > sched_domain_flags_f() are statically set now, but actually, we can get a > lot of necessary information based on the cpu_map. e.g. we can know whether > its cache is shared. > > Allows custom extension without affecting current. >

Re: [PATCH v2] powerpc/smp: do not decrement idle task preempt count in CPU offline

2021-10-18 Thread Srikar Dronamraju
le preemption, so remove the > vestigial preempt_enable() from the CPU offline path. > > Tested with pseries and powernv in qemu, and pseries on PowerVM. > > Fixes: 2c669ef6979c ("powerpc/preempt: Don't touch the idle task's > preempt_count during hotplug") > Signe

Re: [PATCH v2 2/2] powerpc/paravirt: correct preempt debug splat in vcpu_is_preempted()

2021-09-29 Thread Srikar Dronamraju
x) preempt-unsafe way. > Use raw_smp_processor_id() to avoid such warnings, adding explanatory > comments. > > Signed-off-by: Nathan Lynch > Fixes: ca3f969dcb11 ("powerpc/paravirt: Use is_kvm_guest() in > vcpu_is_preempted()") Looks good to me. Reviewed-by: Srika

Re: [PATCH v2 1/2] powerpc/paravirt: vcpu_is_preempted() commentary

2021-09-29 Thread Srikar Dronamraju
* Nathan Lynch [2021-09-28 16:41:46]: > Add comments more clearly documenting that this function determines whether > hypervisor-level preemption of the VM has occurred. > > Signed-off-by: Nathan Lynch Looks good to me. Reviewed-by: Srikar Dronamraju > --- > arch/p

Re: [PATCH] powerpc: fix unbalanced node refcount in check_kvm_guest()

2021-09-29 Thread Srikar Dronamraju
lly_init_IRQ in arch/powerpc/platforms/embedded6xx/holly.c Reviewed-by: Srikar Dronamraju > Signed-off-by: Nathan Lynch > Fixes: 107c55005fbd ("powerpc/pseries: Add KVM guest doorbell restrictions") > --- > arch/powerpc/kernel/firmware.c | 7 +++ > 1 file changed, 3

Re: [PATCH] powerpc/paravirt: correct preempt debug splat in vcpu_is_preempted()

2021-09-23 Thread Srikar Dronamraju
* Michael Ellerman [2021-09-23 17:29:32]: > Nathan Lynch writes: > > Srikar Dronamraju writes: > > > >> * Nathan Lynch [2021-09-22 11:01:12]: > >> > >>> Srikar Dronamraju writes: > >>> > * Nathan Lynch [2021-09-20 22:12:1

Re: [PATCH v2 3/3] powerpc/numa: Fill distance_lookup_table for offline nodes

2021-09-23 Thread Srikar Dronamraju
* Michael Ellerman [2021-09-23 21:17:25]: > Srikar Dronamraju writes: > > * Michael Ellerman [2021-08-26 23:36:53]: > > > >> Srikar Dronamraju writes: > >> > Scheduler expects unique number of node distances to be available at > >> >

Re: [PATCH] powerpc/paravirt: correct preempt debug splat in vcpu_is_preempted()

2021-09-22 Thread Srikar Dronamraju
* Nathan Lynch [2021-09-22 11:01:12]: > Srikar Dronamraju writes: > > * Nathan Lynch [2021-09-20 22:12:13]: > > > >> vcpu_is_preempted() can be used outside of preempt-disabled critical > >> sections, yielding warnings such as: > >> > >> BUG

Re: [PATCH] powerpc/paravirt: correct preempt debug splat in vcpu_is_preempted()

2021-09-22 Thread Srikar Dronamraju
f - +#else #ifdef CONFIG_DEBUG_PREEMPT extern unsigned int debug_smp_processor_id(void); # define smp_processor_id() debug_smp_processor_id() -#else +#endif +#endif + +#ifndef smp_processor_id # define smp_processor_id() __smp_processor_id() #endif -- Thanks and Regards Srikar Dronamraju

[PATCH v3] powerpc/numa: Fill distance_lookup_table for offline nodes

2021-09-13 Thread Srikar Dronamraju
Shenoy Cc: Vincent Guittot Cc: Geetika Moolchandani Cc: Laurent Dufour Cc: kernel test robot Signed-off-by: Srikar Dronamraju --- Changelog: v2: https://lore.kernel.org/linuxppc-dev/20210821102535.169643-4-sri...@linux.vnet.ibm.com/t/#u - Updated changelog - Updated variable names - Rebased

Re: [PATCH v2 3/3] powerpc/numa: Fill distance_lookup_table for offline nodes

2021-09-01 Thread Srikar Dronamraju
* Michael Ellerman [2021-08-26 23:36:53]: > Srikar Dronamraju writes: > > Scheduler expects unique number of node distances to be available at > > boot. > > I think it needs "the number of unique node distances" ? > > > It uses node distance

[PATCH v5 1/5] powerpc/numa: Drop dbg in favour of pr_debug

2021-08-26 Thread Srikar Dronamraju
: Michael Ellerman Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Gautham R Shenoy Cc: Vincent Guittot Cc: Geetika Moolchandani Cc: Laurent Dufour Suggested-by: Michael Ellerman Signed-off-by: Srikar Dronamraju --- arch/powerpc/mm/numa.c | 22 -- 1 file

[PATCH v3 5/5] powerpc/numa: Fill distance_lookup_table for offline nodes

2021-08-26 Thread Srikar Dronamraju
Cc: kernel test robot Signed-off-by: Srikar Dronamraju --- arch/powerpc/mm/numa.c | 70 ++ 1 file changed, 70 insertions(+) Changelog: v1: https://lore.kernel.org/linuxppc-dev/20210701041552.112072-3-sri...@linux.vnet.ibm.com/t/#u [ Fixed a missing

[PATCH v3 4/5] powerpc/numa: Update cpu_cpu_map on CPU online/offline

2021-08-26 Thread Srikar Dronamraju
: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Gautham R Shenoy Cc: Vincent Guittot Cc: Geetika Moolchandani Cc: Laurent Dufour Signed-off-by: Srikar Dronamraju --- arch/powerpc/include/asm/topology.h | 12 arch/powerpc/kernel/smp.c | 3 +++ arch/powerpc/mm/

[PATCH v3 3/5] powerpc/numa: Print debug statements only when required

2021-08-26 Thread Srikar Dronamraju
Cc: Gautham R Shenoy Cc: Vincent Guittot Cc: Geetika Moolchandani Cc: Laurent Dufour Signed-off-by: Srikar Dronamraju --- arch/powerpc/mm/numa.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c index 9af38b1c618b

[PATCH v5 2/5] powerpc/numa: convert printk to pr_xxx

2021-08-26 Thread Srikar Dronamraju
uittot Cc: Geetika Moolchandani Cc: Laurent Dufour [ convert printk(KERN_ERR) to pr_warn : Suggested by Laurent Dufour ] Suggested-by: Michael Ellerman Signed-off-by: Srikar Dronamraju --- arch/powerpc/mm/numa.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --

[PATCH v3 0/5] Updates to powerpc for robust CPU online/offline

2021-08-26 Thread Srikar Dronamraju
line/offline and add/remove Update cpu_cpu_mask() on CPU online/offline too. Cc: linuxppc-dev@lists.ozlabs.org Cc: Nathan Lynch Cc: Michael Ellerman Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Gautham R Shenoy Cc: Vincent Guittot Cc: Geetika Moolchandani Cc: Laurent Duf

[PATCH v2 3/3] powerpc/smp: Enable CACHE domain for shared processor

2021-08-26 Thread Srikar Dronamraju
. Shenoy Signed-off-by: Srikar Dronamraju --- arch/powerpc/kernel/smp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c index b5bd5a4708d0..b31b8ca3ae2e 100644 --- a/arch/powerpc/kernel/smp.c +++ b/arch/powerpc/kernel/smp.c

[PATCH v2 2/3] powerpc/smp: Update cpu_core_map on all PowerPc systems

2021-08-26 Thread Srikar Dronamraju
ar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Gautham R Shenoy Cc: Vincent Guittot Fixes: 4ca234a9cbd7 ("powerpc/smp: Stop updating cpu_core_mask") Signed-off-by: Srikar Dronamraju --- Changelog : v1 -> v2: v1:https://lore.kernel.org/linuxppc-dev/20210821092419.167454-3-sri

[PATCH v2 1/3] powerpc/smp: Fix a crash while booting kvm guest with nr_cpus=2

2021-08-26 Thread Srikar Dronamraju
Aneesh Kumar K.V Debugged-by: Michael Ellerman Signed-off-by: Srikar Dronamraju --- Changelog: v1 -> v2: v1: - https://lore.kernel.org/linuxppc-dev/20210821092419.167454-2-sri...@linux.vnet.ibm.com/t/#u Handled comment from Gautham Shenoy [ Updated to use DIV_ROUND_UP instead of max to handle more

[PATCH v2 0/3] powerpc/smp: Misc fixes

2021-08-26 Thread Srikar Dronamraju
dev@lists.ozlabs.org Cc: Nathan Lynch Cc: Michael Ellerman Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Gautham R Shenoy Cc: Vincent Guittot Srikar Dronamraju (3): powerpc/smp: Fix a crash while booting kvm guest with nr_cpus=2 powerpc/smp: Update cpu_core_map on all Powe

Re: [PATCH v2 1/3] powerpc/numa: Print debug statements only when required

2021-08-25 Thread Srikar Dronamraju
* Michael Ellerman [2021-08-25 23:01:42]: > Srikar Dronamraju writes: > > * Laurent Dufour [2021-08-23 11:21:33]: > >> Le 21/08/2021 à 12:25, Srikar Dronamraju a écrit : > >> > Currently, a debug message gets printed every time an attempt to > >> > ad

Re: [FSL P50x0] lscpu reports wrong values since the RC1 of kernel 5.13

2021-08-25 Thread Srikar Dronamraju
its off by 2 here. > > Before (correct values): > > > > Core(s) per socket: 4 > > Socket(s): 1 > > -- Thanks and Regards Srikar Dronamraju

Re: [PATCH 1/3] powerpc/smp: Fix a crash while booting kvm guest with nr_cpus=2

2021-08-23 Thread Srikar Dronamraju
* Gautham R Shenoy [2021-08-23 11:41:22]: > On Sat, Aug 21, 2021 at 02:54:17PM +0530, Srikar Dronamraju wrote: > > Aneesh reported a crash with a fairly recent upstream kernel when > > booting kernel whose commandline was appended with nr_cpus=2 > > > > 1:mon> e

Re: [PATCH v2 1/3] powerpc/numa: Print debug statements only when required

2021-08-23 Thread Srikar Dronamraju
* Laurent Dufour [2021-08-23 11:21:33]: > Le 21/08/2021 à 12:25, Srikar Dronamraju a écrit : > > Currently, a debug message gets printed every time an attempt to > > add(remove) a CPU. However this is redundant if the CPU is already added > > (removed) from the node. >

Re: [PATCH v2 0/3] Updates to powerpc for robust CPU online/offline

2021-08-23 Thread Srikar Dronamraju
* Peter Zijlstra [2021-08-23 10:33:30]: > On Sat, Aug 21, 2021 at 03:55:32PM +0530, Srikar Dronamraju wrote: > > Scheduler expects unique number of node distances to be available > > at boot. It uses node distance to calculate this unique node > > distances. On Power Se

[PATCH v2 3/3] powerpc/numa: Fill distance_lookup_table for offline nodes

2021-08-21 Thread Srikar Dronamraju
Cc: kernel test robot Signed-off-by: Srikar Dronamraju --- arch/powerpc/mm/numa.c | 70 ++ 1 file changed, 70 insertions(+) Changelog: v1: https://lore.kernel.org/linuxppc-dev/20210701041552.112072-3-sri...@linux.vnet.ibm.com/t/#u [ Fixed a missing

[PATCH v2 2/3] powerpc/numa: Update cpu_cpu_map on CPU online/offline

2021-08-21 Thread Srikar Dronamraju
: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Gautham R Shenoy Cc: Vincent Guittot Cc: Geetika Moolchandani Cc: Laurent Dufour Signed-off-by: Srikar Dronamraju --- arch/powerpc/include/asm/topology.h | 12 arch/powerpc/kernel/smp.c | 3 +++ arch/powerpc/mm/

[PATCH v2 1/3] powerpc/numa: Print debug statements only when required

2021-08-21 Thread Srikar Dronamraju
Cc: Gautham R Shenoy Cc: Vincent Guittot Cc: Geetika Moolchandani Cc: Laurent Dufour Signed-off-by: Srikar Dronamraju --- arch/powerpc/mm/numa.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c index f2bf98bdcea2

  1   2   3   4   5   6   >