Re: [PATCH 2/4]: CPUIDLE: Introduce architecture independent cpuidle_pm_idle in drivers/cpuidle/cpuidle.c

2009-08-28 Thread Vaidyanathan Srinivasan
* Peter Zijlstra pet...@infradead.org [2009-08-28 09:01:12]: On Fri, 2009-08-28 at 08:48 +0200, Peter Zijlstra wrote: void cpuidle_install_idle_handler(void) { . . cpuidle_pm_idle = cpuidle_idle_call; } All I'm seeing here is a frigging

Re: [PATCH v3 0/3] cpu: pseries: Cpu offline states framework

2009-09-16 Thread Vaidyanathan Srinivasan
* Peter Zijlstra a.p.zijls...@chello.nl [2009-09-16 18:35:16]: On Wed, 2009-09-16 at 21:54 +0530, Dipankar Sarma wrote: No, for this specific case, latency isn't an issue. The issue is - how do we cede unused vcpus to hypervisor for better energy management ? Yes, it can be done by a

Re: [v6 PATCH 0/7]: cpuidle/x86/POWER: Cleanup idle power management code in x86, cleanup drivers/cpuidle/cpuidle.c and introduce cpuidle to POWER.

2009-09-25 Thread Vaidyanathan Srinivasan
* Arjan van de Ven ar...@infradead.org [2009-09-24 14:22:28]: On Thu, 24 Sep 2009 10:42:41 +0530 Arun R Bharadwaj a...@linux.vnet.ibm.com wrote: * Arun R Bharadwaj a...@linux.vnet.ibm.com [2009-09-22 16:55:27]: Hi Len, (or other acpi folks), I had a question regarding ACPI-cpuidle

Re: [PATCH v2 0/2] cpu: pseries: Offline state framework.

2009-09-25 Thread Vaidyanathan Srinivasan
* Arjan van de Ven ar...@infradead.org [2009-09-24 13:41:23]: On Thu, 24 Sep 2009 13:33:07 +0200 Peter Zijlstra a.p.zijls...@chello.nl wrote: On Thu, 2009-09-24 at 18:38 +1000, Benjamin Herrenschmidt wrote: On Thu, 2009-09-24 at 09:51 +0200, Peter Zijlstra wrote: I don't quite

Re: [PATCH v3 0/3] cpu: pseries: Cpu offline states framework

2009-09-28 Thread Vaidyanathan Srinivasan
* Peter Zijlstra a.p.zijls...@chello.nl [2009-09-25 16:48:40]: On Thu, 2009-09-24 at 10:51 +1000, Benjamin Herrenschmidt wrote: On Tue, 2009-09-15 at 14:11 +0200, Peter Zijlstra wrote: I still think its a layering violation... its the hypervisor manager that should be bothered in what

Re: [PATCH v3 0/3] cpu: pseries: Cpu offline states framework

2009-09-28 Thread Vaidyanathan Srinivasan
* Benjamin Herrenschmidt b...@kernel.crashing.org [2009-09-26 07:12:48]: On Fri, 2009-09-25 at 16:48 +0200, Peter Zijlstra wrote: On Thu, 2009-09-24 at 10:51 +1000, Benjamin Herrenschmidt wrote: On Tue, 2009-09-15 at 14:11 +0200, Peter Zijlstra wrote: I still think its a layering

Re: [PATCH v5 0/4] pseries: Add cede support for cpu-offline

2009-11-23 Thread Vaidyanathan Srinivasan
* Benjamin Herrenschmidt b...@kernel.crashing.org [2009-11-24 14:35:09]: On Fri, 2009-10-30 at 10:52 +0530, Gautham R Shenoy wrote: Hi, This is version 5 of patch series that provides a framework to choose the state a pseries CPU must be put to when it is offlined. Previous

[PATCH v6 0/2] pseries: Add cede support for cpu-offline

2009-11-26 Thread Vaidyanathan Srinivasan
Hi, This is version 6 of patch series that provides a framework to choose the state a pseries CPU must be put to when it is offlined. Previous versions can be found here: Version 5: http://lkml.org/lkml/2009/10/30/6 Version 4: http://lkml.org/lkml/2009/10/9/59 Version 3:

[PATCH v6 1/2] pseries: Add code to online/offline CPUs of a DLPAR node

2009-11-26 Thread Vaidyanathan Srinivasan
with one set of sysfs tunables namely probe and release. Signed-off-by: Gautham R Shenoy e...@in.ibm.com Signed-off-by: Nathan Fontenot nf...@austin.ibm.com Acked-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com --- arch/powerpc/platforms/pseries/dlpar.c | 101

[PATCH v6 2/2] pseries: Serialize cpu hotplug operations during deactivate Vs deallocate

2009-11-26 Thread Vaidyanathan Srinivasan
. This patch employs a mutex to provide this serialization, which is a no-op on all architectures except PPC_PSERIES Signed-off-by: Gautham R Shenoy e...@in.ibm.com Acked-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com --- arch/powerpc/platforms/pseries/dlpar.c | 45

2.6.24-rc1 on PPC64: machine check exception

2007-11-05 Thread Vaidyanathan Srinivasan
Hi, I got the following exception on a 128-way PPC64 machine while running ebizzy-0.2 benchmark. cpu 0x48: Vector: 200 (Machine Check) at [c06df1bb37c0] pc: c007a26c: .exit_robust_list+0x78/0x228 lr: c007a240: .exit_robust_list+0x4c/0x228 sp: c06df1bb3a40

Re: 2.6.24-rc1 on PPC64: machine check exception

2007-11-15 Thread Vaidyanathan Srinivasan
http://patchwork.ozlabs.org/linuxppc/patch?id=14475 Thanks for pointing me to this patch. I will try out and let you know if this fixed the problem. Hi Anton, This patch fixed the problem. I am able to run and profile ebizzy on 128-way PPC64. However this fix is not included in

Re: [PATCH] powerpc: Quieten cede latency printk

2010-02-08 Thread Vaidyanathan Srinivasan
* Balbir Singh bal...@linux.vnet.ibm.com [2010-02-08 16:37:37]: On Mon, Feb 8, 2010 at 5:22 AM, Anton Blanchard an...@samba.org wrote: The cede latency stuff is relatively new and we don't need to complain about it not working on older firmware. Signed-off-by: Anton Blanchard

[PATCH] powerpc: reset kernel stack on cpu online from cede state

2010-02-22 Thread Vaidyanathan Srinivasan
start_secondary() is called to continue the online operation. Added new function start_secondary_resume() to do the above steps. Signed-off-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com diff --git a/arch/powerpc/kernel/head_64.S b/arch/powerpc/kernel

[PATCH v2 0/3] powerpc: bug fixes in pseries_mach_cpu_die()

2010-03-01 Thread Vaidyanathan Srinivasan
http://lists.ozlabs.org/pipermail/linuxppc-dev/2010-February/080515.html Thanks, Vaidy --- Vaidyanathan Srinivasan (3): powerpc: reset kernel stack on cpu online from cede state powerpc: move checks in pseries_mach_cpu_die() powerpc: reduce printk from pseries_mach_cpu_die

[PATCH v2 1/3] powerpc: reset kernel stack on cpu online from cede state

2010-03-01 Thread Vaidyanathan Srinivasan
. Added new function start_secondary_resume() to do the above steps. Signed-off-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com Cc: Gautham R Shenoy e...@in.ibm.com --- arch/powerpc/kernel/head_64.S | 11 +++ arch/powerpc/platforms/pseries/hotplug-cpu.c

[PATCH v2 2/3] powerpc: move checks in pseries_mach_cpu_die()

2010-03-01 Thread Vaidyanathan Srinivasan
of the consistent states and not hit the run over BUG() Signed-off-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com Cc: Gautham R Shenoy e...@in.ibm.com --- arch/powerpc/platforms/pseries/hotplug-cpu.c | 30 +- 1 files changed, 15 insertions(+), 15 deletions

[PATCH v2 3/3] powerpc: reduce printk from pseries_mach_cpu_die()

2010-03-01 Thread Vaidyanathan Srinivasan
= b2802fff Timebase value = 2fa8f95035f4a cpu 62 (hwid 62) got prodded to go online cpu 58 (hwid 58) ceding for offline with hint 2 Signed-off-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com Cc: Gautham R Shenoy e...@in.ibm.com --- arch/powerpc/platforms/pseries/hotplug-cpu.c | 11

[RFC] powerpc: add support for new hcall H_BEST_ENERGY

2010-03-03 Thread Vaidyanathan Srinivasan
hints for activation and deactivation of cpus respectively. Added new driver module arch/powerpc/platforms/pseries/pseries_energy.c under new config option CONFIG_PSERIES_ENERGY Signed-off-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com --- arch/powerpc

Re: [RFC] powerpc: add support for new hcall H_BEST_ENERGY

2010-03-07 Thread Vaidyanathan Srinivasan
* Dipankar Sarma dipan...@in.ibm.com [2010-03-06 00:48:11]: On Wed, Mar 03, 2010 at 11:48:22PM +0530, Vaidyanathan Srinivasan wrote: static void __init cpu_init_thread_core_maps(int tpc) diff --git a/arch/powerpc/platforms/pseries/Kconfig b/arch/powerpc/platforms/pseries/Kconfig index

Re: [RFC] powerpc: add support for new hcall H_BEST_ENERGY

2010-03-09 Thread Vaidyanathan Srinivasan
* Dipankar Sarma dipan...@in.ibm.com [2010-03-09 00:58:26]: On Mon, Mar 08, 2010 at 12:20:06PM +0530, Vaidyanathan Srinivasan wrote: * Dipankar Sarma dipan...@in.ibm.com [2010-03-06 00:48:11]: Shouldn't we create this only for supported platforms ? Hi Dipankar, Yes we will need

[PATCH v2] powerpc: export data from new hcall H_EM_GET_PARMS

2010-03-10 Thread Vaidyanathan Srinivasan
and use. cat /proc/powerpc/lparcfg will export power mode data Signed-off-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com --- arch/powerpc/include/asm/hvcall.h |1 + arch/powerpc/kernel/lparcfg.c | 12 +++- 2 files changed, 12 insertions(+), 1 deletions(-) diff

Re: [PATCH v2] powerpc: export data from new hcall H_EM_GET_PARMS

2010-03-22 Thread Vaidyanathan Srinivasan
* Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com [2010-03-10 17:49:25]: Hi Ben, I have cleaned up the code from the previous post: http://lists.ozlabs.org/pipermail/linuxppc-dev/2010-February/080630.html Changes from v1: * Removed redundant return statements and rearranged code

[PATCH v2 repost] powerpc: export data from new hcall H_EM_GET_PARMS

2010-04-01 Thread Vaidyanathan Srinivasan
for administrative tools to interpret and use. cat /proc/powerpc/lparcfg will export power mode data Signed-off-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com --- arch/powerpc/include/asm/hvcall.h |1 + arch/powerpc/kernel/lparcfg.c | 12 +++- 2 files

Re: [RFC] powerpc: add support for new hcall H_BEST_ENERGY

2010-04-06 Thread Vaidyanathan Srinivasan
* Benjamin Herrenschmidt b...@kernel.crashing.org [2010-04-07 12:04:49]: On Wed, 2010-03-03 at 23:48 +0530, Vaidyanathan Srinivasan wrote: Hi, diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c index 03dd6a2..fbd93e3 100644 --- a/arch/powerpc/kernel

[RFC PATCH v2 0/2] powerpc: add support for new hcall H_BEST_ENERGY

2010-05-07 Thread Vaidyanathan Srinivasan
and whitespace cleanups Please review and let me know your comments. I will post the next version ready for inclusion into powerpc/next tree along with test reports. The current patch series is on 2.6.34-rc6. Thanks, Vaidy --- Vaidyanathan Srinivasan (2): powerpc: cleanup APIs for cpu/thread/core

[RFC PATCH v2 1/2] powerpc: cleanup APIs for cpu/thread/core mappings

2010-05-07 Thread Vaidyanathan Srinivasan
cpu_thread_to_core() to cpu_core_of_thread(int cpu) Made API changes to few callers. Exported symbols for use in modules. Signed-off-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com --- arch/powerpc/include/asm/cputhreads.h | 15 +-- arch/powerpc/kernel/smp.c | 17

[RFC PATCH v2 2/2] powerpc: add support for new hcall H_BEST_ENERGY

2010-05-07 Thread Vaidyanathan Srinivasan
/pseries_(de)activate_hint will provide hints for activation and deactivation of cpus respectively. Added new driver module arch/powerpc/platforms/pseries/pseries_energy.c under new config option CONFIG_PSERIES_ENERGY Signed-off-by: Vaidyanathan Srinivasan

Re: [RFC PATCH v2 1/2] powerpc: cleanup APIs for cpu/thread/core mappings

2010-05-09 Thread Vaidyanathan Srinivasan
* Paul Mackerras pau...@samba.org [2010-05-10 09:05:22]: On Fri, May 07, 2010 at 05:18:42PM +0530, Vaidyanathan Srinivasan wrote: These APIs take logical cpu number as input Change cpu_first_thread_in_core() to cpu_leftmost_thread_sibling() Change cpu_last_thread_in_core

Re: [RFC PATCH v2 1/2] powerpc: cleanup APIs for cpu/thread/core mappings

2010-05-17 Thread Vaidyanathan Srinivasan
* Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com [2010-05-10 11:18:01]: * Paul Mackerras pau...@samba.org [2010-05-10 09:05:22]: On Fri, May 07, 2010 at 05:18:42PM +0530, Vaidyanathan Srinivasan wrote: These APIs take logical cpu number as input Change cpu_first_thread_in_core

Re: [PATCH 1/5] sched: fix capacity calculations for SMT4

2010-06-01 Thread Vaidyanathan Srinivasan
* Peter Zijlstra pet...@infradead.org [2010-05-31 10:33:16]: On Fri, 2010-04-16 at 15:58 +0200, Peter Zijlstra wrote: Hrmm, my brain seems muddled but I might have another solution, let me ponder this for a bit.. Right, so the thing I was thinking about is taking the group

[PATCH v3 0/2] powerpc: add support for new hcall H_BEST_ENERGY

2010-06-23 Thread Vaidyanathan Srinivasan
availability This patch series will apply on 2.6.35-rc3 as well as powerpc/next tree. Thanks, Vaidy --- Vaidyanathan Srinivasan (2): powerpc: cleanup APIs for cpu/thread/core mappings powerpc: add support for new hcall H_BEST_ENERGY arch/powerpc/include/asm/cputhreads.h | 15

[PATCH v3 1/2] powerpc: cleanup APIs for cpu/thread/core mappings

2010-06-23 Thread Vaidyanathan Srinivasan
cpu_first_thread_of_core(1) = 4 cpu_core_of_thread() is used in cpu_to_drc_index() in the module and cpu_first_thread_of_core() is used in drc_index_to_cpu() in the module. Made API changes to few callers. Exported symbols for use in modules. Signed-off-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com

[PATCH v3 2/2] powerpc: add support for new hcall H_BEST_ENERGY

2010-06-23 Thread Vaidyanathan Srinivasan
/pseries_(de)activate_hint will provide hints for activation and deactivation of cpus respectively. Added new driver module arch/powerpc/platforms/pseries/pseries_energy.c under new config option CONFIG_PSERIES_ENERGY Signed-off-by: Vaidyanathan Srinivasan

Re: [PATCH v3 2/2] powerpc: add support for new hcall H_BEST_ENERGY

2010-06-27 Thread Vaidyanathan Srinivasan
. Other comments below. Signed-off-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com --- arch/powerpc/include/asm/hvcall.h |3 arch/powerpc/platforms/pseries/Kconfig | 10 + arch/powerpc/platforms/pseries/Makefile |1 arch/powerpc/platforms

[PATCH v4 0/2] powerpc: add support for new hcall H_BEST_ENERGY

2010-07-21 Thread Vaidyanathan Srinivasan
in powerpc/next tree for further testing. I could incrementally reduce some of the error checks as suggested by Michael Neuling as next steps. Thanks, Vaidy --- Vaidyanathan Srinivasan (2): powerpc: cleanup APIs for cpu/thread/core mappings powerpc: add support for new hcall H_BEST_ENERGY

[PATCH v4 1/2] powerpc: cleanup APIs for cpu/thread/core mappings

2010-07-21 Thread Vaidyanathan Srinivasan
cpu_first_thread_of_core(1) = 4 cpu_core_of_thread() is used in cpu_to_drc_index() in the module and cpu_first_thread_of_core() is used in drc_index_to_cpu() in the module. Made API changes to few callers. Exported symbols for use in modules. Signed-off-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com

[PATCH v4 2/2] powerpc: add support for new hcall H_BEST_ENERGY

2010-07-21 Thread Vaidyanathan Srinivasan
Signed-off-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com --- arch/powerpc/include/asm/hvcall.h |3 arch/powerpc/platforms/pseries/Kconfig | 10 + arch/powerpc/platforms/pseries/Makefile |1 arch/powerpc/platforms/pseries/pseries_energy.c | 326

Re: [PATCH v3 2/2] powerpc: add support for new hcall H_BEST_ENERGY

2010-07-21 Thread Vaidyanathan Srinivasan
* Michael Neuling mi...@neuling.org [2010-06-28 16:11:06]: [snip] These hints are abstract number given by the hypervisor based on the extended knowledge the hypervisor has regarding the current system topology and resource mappings. The activate and the deactivate part is for the two

Re: [PATCH] powerpc: ONLINE to OFFLINE CPU state transition during removal

2010-07-22 Thread Vaidyanathan Srinivasan
* Robert Jennings r...@linux.vnet.ibm.com [2010-07-22 21:43:44]: If a CPU remove is attempted using the 'release' interface on hardware which supports extended cede, the CPU will be put in the INACTIVE state rather than the OFFLINE state due to the default preferred_offline_state in that

Re: [PATCH][RFC] preempt_count corruption across H_CEDE call with CONFIG_PREEMPT on pseries

2010-07-22 Thread Vaidyanathan Srinivasan
* Darren Hart dvh...@us.ibm.com [2010-07-22 21:44:04]: On 07/22/2010 04:57 PM, Darren Hart wrote: On 07/22/2010 03:25 PM, Benjamin Herrenschmidt wrote: On Thu, 2010-07-22 at 11:24 -0700, Darren Hart wrote: 1) How can the preempt_count() get mangled across the H_CEDE hcall? 2) Should we

Re: [PATCH][RFC] preempt_count corruption across H_CEDE call with CONFIG_PREEMPT on pseries

2010-07-23 Thread Vaidyanathan Srinivasan
* Benjamin Herrenschmidt b...@kernel.crashing.org [2010-07-23 15:11:00]: On Fri, 2010-07-23 at 10:38 +0530, Vaidyanathan Srinivasan wrote: Yes. extended_cede_processor() will return with interrupts enabled in the cpu. (This is done by the hypervisor). Under normal cases we cannot

Re: [PATCH v4 1/2] powerpc: cleanup APIs for cpu/thread/core mappings

2010-08-05 Thread Vaidyanathan Srinivasan
* Benjamin Herrenschmidt b...@kernel.crashing.org [2010-08-03 14:44:13]: On Thu, 2010-07-22 at 06:27 +0530, Vaidyanathan Srinivasan wrote: These APIs take logical cpu number as input Change cpu_first_thread_in_core() to cpu_leftmost_thread_sibling() Change cpu_last_thread_in_core

Re: [PATCH][RFC] preempt_count corruption across H_CEDE call with CONFIG_PREEMPT on pseries

2010-08-05 Thread Vaidyanathan Srinivasan
* Darren Hart dvh...@us.ibm.com [2010-08-04 21:45:51]: On 07/23/2010 12:07 AM, Vaidyanathan Srinivasan wrote: * Benjamin Herrenschmidtb...@kernel.crashing.org [2010-07-23 15:11:00]: On Fri, 2010-07-23 at 10:38 +0530, Vaidyanathan Srinivasan wrote: Yes. extended_cede_processor

Re: [PATCH] powerpc: ONLINE to OFFLINE CPU state transition during removal

2010-08-05 Thread Vaidyanathan Srinivasan
* Nathan Fontenot nf...@austin.ibm.com [2010-07-26 14:13:35]: On 07/22/2010 11:13 PM, Vaidyanathan Srinivasan wrote: * Robert Jennings r...@linux.vnet.ibm.com [2010-07-22 21:43:44]: If a CPU remove is attempted using the 'release' interface on hardware which supports extended cede

Re: [PATCH][RFC] preempt_count corruption across H_CEDE call with CONFIG_PREEMPT on pseries

2010-08-05 Thread Vaidyanathan Srinivasan
* Darren Hart dvh...@us.ibm.com [2010-08-05 19:19:00]: On 07/22/2010 10:09 PM, Benjamin Herrenschmidt wrote: On Thu, 2010-07-22 at 21:44 -0700, Darren Hart wrote: suggestion I updated the instrumentation to display the local_save_flags and irqs_disabled_flags: Jul 22 23:36:58

[PATCH v5 0/2] powerpc: add support for new hcall H_BEST_ENERGY

2010-10-06 Thread Vaidyanathan Srinivasan
. This patch series is conservative and has more error checking in device tree parsing and drc index matching code than what may be required. Thanks, Vaidy --- Vaidyanathan Srinivasan (2): powerpc: cleanup APIs for cpu/thread/core mappings powerpc: add support for new hcall H_BEST_ENERGY

[PATCH v5 1/2] powerpc: cleanup APIs for cpu/thread/core mappings

2010-10-06 Thread Vaidyanathan Srinivasan
cpu_first_thread_of_core(1) = 4 cpu_core_index_of_thread() is used in cpu_to_drc_index() in the module and cpu_first_thread_of_core() is used in drc_index_to_cpu() in the module. Make API changes to few callers. Export symbols for use in modules. Signed-off-by: Vaidyanathan Srinivasan sva

[PATCH v5 2/2] powerpc: add support for new hcall H_BEST_ENERGY

2010-10-06 Thread Vaidyanathan Srinivasan
Signed-off-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com --- arch/powerpc/include/asm/hvcall.h |3 arch/powerpc/platforms/pseries/Kconfig | 10 + arch/powerpc/platforms/pseries/Makefile |1 arch/powerpc/platforms/pseries/pseries_energy.c | 326

Re: [RFC PATCH 4/5] cpuidle/ppc: CPU goes tickless if there are no arch-specific constraints

2013-07-28 Thread Vaidyanathan Srinivasan
* Benjamin Herrenschmidt b...@kernel.crashing.org [2013-07-27 16:30:05]: On Fri, 2013-07-26 at 08:09 +0530, Preeti U Murthy wrote: *The lapic of a broadcast CPU is active always*. Say CPUX, wants the broadcast CPU to wake it up at timeX. Since we cannot program the lapic of a remote CPU,

Re: [RFC PATCH 4/5] cpuidle/ppc: CPU goes tickless if there are no arch-specific constraints

2013-07-28 Thread Vaidyanathan Srinivasan
* Preeti U Murthy pre...@linux.vnet.ibm.com [2013-07-27 13:20:37]: Hi Ben, On 07/27/2013 12:00 PM, Benjamin Herrenschmidt wrote: On Fri, 2013-07-26 at 08:09 +0530, Preeti U Murthy wrote: *The lapic of a broadcast CPU is active always*. Say CPUX, wants the broadcast CPU to wake it up at

[PATCH] powerpc: default arch idle could cede processor on pseries

2013-09-04 Thread Vaidyanathan Srinivasan
cpuidle in initialized. Reported-by: Paul Mackerras pau...@samba.org Signed-off-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com Acked-by: Deepthi Dharwar deep...@linux.vnet.ibm.com diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c

[PATCH v2] powerpc: Default arch idle could cede processor on pseries

2013-09-05 Thread Vaidyanathan Srinivasan
-by: Paul Mackerras pau...@samba.org Signed-off-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com Acked-by: Deepthi Dharwar deep...@linux.vnet.ibm.com Signed-off-by: Benjamin Herrenschmidt b...@kernel.crashing.org diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc

Re: Kernel crash caused by cpufreq

2014-07-28 Thread Vaidyanathan Srinivasan
* Michael Ellerman m...@ellerman.id.au [2014-07-28 17:03:10]: On Fri, 2014-07-25 at 11:07 +1000, Gavin Shan wrote: I'm tracing one LSI interrupt issue on P8 box, and eventually into the following kernel crash. Not sure if there is one fix against this? :-) Vaidy wrote that I'm pretty sure

[PATCH] powerpc/cpuidle: Fix parsing of idle state flags from device-tree

2014-08-03 Thread Vaidyanathan Srinivasan
Flags from device-tree need to be parsed with accessors for interpreting correct value in little-endian. Signed-off-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com --- drivers/cpuidle/cpuidle-powernv.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

[PATCH] powerpc/cpufreq: Add pr_warn() on OPAL firmware failures

2014-08-03 Thread Vaidyanathan Srinivasan
. Signed-off-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com --- Tested on powernv and pseries platforms with v3.16-rc7 kernel. drivers/cpufreq/powernv-cpufreq.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/powernv-cpufreq.c b

[BUG][PATCH] powerpc: fix numa distance for form0 device tree

2013-03-22 Thread Vaidyanathan Srinivasan
as form0. Signed-off-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c index bba87ca..6a252c4 100644 --- a/arch/powerpc/mm/numa.c +++ b/arch/powerpc/mm/numa.c @@ -201,7 +201,7 @@ int __node_distance(int a, int b) int distance

Re: [BUG][PATCH] powerpc: fix numa distance for form0 device tree

2013-03-22 Thread Vaidyanathan Srinivasan
* Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com [2013-03-22 21:19:35]: [snip] Prior to the above commit: #define node_distance(from,to) ((from) == (to) ? LOCAL_DISTANCE : REMOTE_DISTANCE) Restoring compatible behavior with this patch for old powerpc systems

Re: [PATCH v3 1/5] powernv: cpufreq driver for powernv platform

2014-03-21 Thread Vaidyanathan Srinivasan
* Gautham R Shenoy e...@linux.vnet.ibm.com [2014-03-21 16:13:17]: Hi Viresh, On Fri, Mar 21, 2014 at 02:11:32PM +0530, Viresh Kumar wrote: On Thu, Mar 20, 2014 at 5:40 PM, Gautham R. Shenoy e...@linux.vnet.ibm.com wrote: From: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com Hi

Re: [PATCH v4] powernv, cpufreq: cpufreq driver for powernv platform

2014-03-27 Thread Vaidyanathan Srinivasan
* Gautham R Shenoy e...@linux.vnet.ibm.com [2014-03-27 15:00:50]: [snip] + u32 len_ids, len_freqs; + + power_mgt = of_find_node_by_path(/ibm,opal/power-mgt); + if (!power_mgt) { + pr_warn(power-mgt node not found\n); + return

[PATCH 0/3] sched: Fixes for task placement in SMT threads

2013-10-21 Thread Vaidyanathan Srinivasan
. This series applies on v3.12-rc6 and tested on x86 and powerpc. --Vaidy --- Preeti U Murthy (2): sched: Fix nohz_kick_needed to consider the nr_busy of the parent domain's group sched: Aggressive balance in domains whose groups share package resources Vaidyanathan Srinivasan (1

[PATCH 1/3] sched: Fix nohz_kick_needed to consider the nr_busy of the parent domain's group

2013-10-21 Thread Vaidyanathan Srinivasan
for SD_SHARE_PKG_RESOURCE comes before the check for ASYM_PACKING. Priority is given to avoid more than one busy thread in a core as much as possible before attempting asymmetric packing. Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com Signed-off-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com

[PATCH 2/3] sched: Fix asymmetric scheduling for POWER7

2013-10-21 Thread Vaidyanathan Srinivasan
if this domain has no idle cpu. Hence, nr_busy check against group weight can be removed. Reported-by: Michael Neuling michael.neul...@au1.ibm.com Signed-off-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com --- kernel/sched/fair.c |4

[PATCH 3/3] sched: Aggressive balance in domains whose groups share package resources

2013-10-21 Thread Vaidyanathan Srinivasan
for other cpus in the same group. Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com Signed-off-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com --- kernel/sched/fair.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index

[PATCH v1 0/2] powernv: cpufreq support for IBM POWERNV platform

2014-02-10 Thread Vaidyanathan Srinivasan
): powernv, cpufreq: Add per-core locking to serialize frequency transitions Vaidyanathan Srinivasan (1): powernv: cpufreq driver for powernv platform arch/powerpc/include/asm/reg.h|4 + drivers/cpufreq/Kconfig.powerpc |9 + drivers/cpufreq/Makefile |1 drivers

[PATCH v1 2/2] powernv, cpufreq: Add per-core locking to serialize frequency transitions

2014-02-10 Thread Vaidyanathan Srinivasan
-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com --- drivers/cpufreq/powernv-cpufreq.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c index ea3b630..8240e90 100644 --- a/drivers/cpufreq

[PATCH v1 1/2] powernv: cpufreq driver for powernv platform

2014-02-10 Thread Vaidyanathan Srinivasan
non-virtualized platforms. PState table is obtained from OPAL v3 firmware through device tree. powernv_cpufreq back-end driver would parse the relevant device-tree nodes and initialise the cpufreq subsystem on powernv platform. Signed-off-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com

Re: [PATCH] powerpc: fix VMX fix for memcpy case

2012-10-06 Thread Vaidyanathan Srinivasan
memcpy match usercopy and not use cr1. Signed-off-by: Nishanth Aravamudan n...@us.ibm.com Tested-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com --- I've not tested this fix yet, but I think it's logically correct. Probably needs to go to 3.6-stable as well. diff --git a/arch

Re: [PATCH 0/3] cpu: idle state framework for offline CPUs.

2009-08-05 Thread Vaidyanathan Srinivasan
* Shaohua Li shaohua...@intel.com [2009-08-06 09:58:55]: Hi, On Wed, Aug 05, 2009 at 10:25:53PM +0800, Gautham R Shenoy wrote: In this patch-series, we propose to extend the CPU-Hotplug infrastructure and allow the system administrator to choose the desired state the CPU should go to

Re: [PATCH 0/3] cpu: idle state framework for offline CPUs.

2009-08-09 Thread Vaidyanathan Srinivasan
* Rafael J. Wysocki r...@sisk.pl [2009-08-09 15:22:02]: On Sunday 09 August 2009, Pavel Machek wrote: Hi! Also, approaches such as [1] can make use of this extended infrastructure instead of putting the CPU to an arbitrary C-state when it is offlined, thereby providing the

Re: [PATCH] cpuidle: powernv/pseries: Decrease the snooze residency

2015-06-03 Thread Vaidyanathan Srinivasan
* Benjamin Herrenschmidt b...@au1.ibm.com [2015-05-30 20:38:22]: On Sat, 2015-05-30 at 11:31 +0530, Vaidyanathan Srinivasan wrote: In shared lpar case, spinning in guest context may potentially take away cycles from other lpars waiting to run on the same physical cpu. So the policy

[PATCH] powerpc/powernv: Fix vma page prot flags in opal-prd driver

2015-06-21 Thread Vaidyanathan Srinivasan
in the driver This fix resolves the page accounting warning shown below: BUG: Bad rss-counter state mm:c007d34ac600 idx:1 val:19 The above warning is triggered since _PAGE_SPECIAL was incorrectly being set for the normal kernel COW pages. Signed-off-by: Vaidyanathan Srinivasan sva

Re: [PATCH] powerpc/powernv: Fix vma page prot flags in opal-prd driver

2015-06-25 Thread Vaidyanathan Srinivasan
* Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com [2015-06-25 11:45:46]: [snip] Hi Ben, remap_pfn_range() is the correct method to map the firmware pages because we will not have struct page associated with this RAM area. We do a memblock_reserve() in early boot and take out

Re: [PATCH] powerpc/powernv: Fix vma page prot flags in opal-prd driver

2015-06-25 Thread Vaidyanathan Srinivasan
* Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com [2015-06-21 23:56:16]: opal-prd driver will mmap() firmware code/data area as private mapping to prd user space daemon. Write to this page will trigger COW faults. The new COW pages are normal kernel RAM pages accounted by the kernel

Re: [PATCH] cpuidle: powernv/pseries: Decrease the snooze residency

2015-05-30 Thread Vaidyanathan Srinivasan
* Preeti U Murthy pre...@linux.vnet.ibm.com [2015-05-29 19:17:17]: [snip] + if (max_idle_state 1) { + snooze_timeout_en = true; + snooze_timeout = cpuidle_state_table[1].target_residency * +tb_ticks_per_usec; + } Any idea why we

[RESEND PATCH] powerpc/powernv: Fix vma page prot flags in opal-prd driver

2015-06-28 Thread Vaidyanathan Srinivasan
in the driver This fix resolves the page accounting warning shown below: BUG: Bad rss-counter state mm:c007d34ac600 idx:1 val:19 The above warning is triggered since _PAGE_SPECIAL was incorrectly being set for the normal kernel COW pages. Signed-off-by: Vaidyanathan Srinivasan sva

Re: [PATCH] powernv: Load correct TOC pointer while waking up from winkle.

2016-08-08 Thread Vaidyanathan Srinivasan
* Benjamin Herrenschmidt [2016-08-06 08:38:53]: > On Fri, 2016-08-05 at 19:13 +0530, Mahesh J Salgaonkar wrote: > > From: Mahesh Salgaonkar > > > > The function pnv_restore_hyp_resource() loads the TOC into r2 from > > the invalid PACA

Re: [PATCH] powernv: Load correct TOC pointer while waking up from winkle.

2016-08-08 Thread Vaidyanathan Srinivasan
king up from winkle. Hence, the last bit of HSPRG0(r13) > needs to be clear before accessing it as PACA to avoid loading invalid > values from invalid PACA pointer. > > Fix this by loading TOC after r13 register is corrected. > > Signed-off-by: Mahesh Salgaonkar <mah...@linux.vnet

powerpc: Enable cpuhotplug with ESL=1 on POWER9

2017-02-23 Thread Vaidyanathan Srinivasan
The attached patch enables ESL=1 STOP2 for cpuhotplug. This is a debug patch that we could carry now until STOP states are discovered from device tree. Test run: [ 151.670021] CPU8 going offline with request psscr 003f0332 [ 151.719856] CPU 8 offline: Remove Rx thread [ 189.200410]

[PATCH 2/2] powerpc/cpuhotplug: print psscr and srr1 value for debug

2017-02-23 Thread Vaidyanathan Srinivasan
This is a debug patch that helps trace various STOP state transitions and look at srr1 and psscr at wakeup. Signed-off-by: Vaidyanathan Srinivasan <sva...@linux.vnet.ibm.com> --- arch/powerpc/platforms/powernv/smp.c | 4 1 file changed, 4 insertions(+) diff --git a/arch/powerpc/pla

[PATCH 1/2] powerpc/cpuhotplug: Force ESL=1 for offline cpus

2017-02-23 Thread Vaidyanathan Srinivasan
From: Gautham R. Shenoy <e...@linux.vnet.ibm.com> ESL=1 losses some HYP SPR context and not idea for cpuidle, however can be used for offline cpus. Signed-off-by: Vaidyanathan Srinivasan <sva...@linux.vnet.ibm.com> Signed-off-by: Gautham R. Shenoy <e...@linux.vnet.ibm.com>

[PATCH] powerpc/xics: Adjust interrupt receive priority for offline cpus

2017-02-23 Thread Vaidyanathan Srinivasan
-by: Vaidyanathan Srinivasan <sva...@linux.vnet.ibm.com> --- arch/powerpc/sysdev/xics/xics-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/sysdev/xics/xics-common.c b/arch/powerpc/sysdev/xics/xics-common.c index 69d858e..c674a9d 100644 --- a/arch/powerpc/

Re: [PATCH] powerpc: cmp -> cmpd for 64-bit

2016-10-12 Thread Vaidyanathan Srinivasan
* Segher Boessenkool [2016-10-12 08:26:48]: > On Wed, Oct 12, 2016 at 02:05:19PM +1100, Michael Ellerman wrote: > > Segher Boessenkool writes: > > [snip] > > > > --- a/arch/powerpc/include/asm/cpuidle.h > > > +++

[PATCH v1 0/2] cpuidle: Fixes in cpuidle driver

2017-03-23 Thread Vaidyanathan Srinivasan
ess incorrect address and crash. The following patch series fixes the cpuidle-powernv driver and also adds additional checks in cpuidle_add_sysfs() This patch set is against v4.11-rc3. Changed from v1: Updated commit message and comments. Signed-off-by: Vaidyanathan Srinivasan <sva...@linux.vnet.ibm.com>

Re: [PATCH v2 1/2] powerpc/powernv/cpuidle: Pass correct drv->cpumask for registration

2017-03-23 Thread Vaidyanathan Srinivasan
* Rafael J. Wysocki <raf...@kernel.org> [2017-03-23 16:28:31]: > On Thu, Mar 23, 2017 at 4:22 PM, Vaidyanathan Srinivasan > <sva...@linux.vnet.ibm.com> wrote: > > drv->cpumask defaults to cpu_possible_mask in __cpuidle_driver_init(). > > On PowerNV platfo

[PATCH v2 1/2] powerpc/powernv/cpuidle: Pass correct drv->cpumask for registration

2017-03-23 Thread Vaidyanathan Srinivasan
e30] c000b564 ret_from_kernel_thread+0x5c/0x78 This patch fixes the bug by passing correct cpumask from powernv-cpuidle driver. Signed-off-by: Vaidyanathan Srinivasan <sva...@linux.vnet.ibm.com> --- drivers/cpuidle/cpuidle-powernv.c | 18 ++ 1 file changed, 18 insertions(+) d

[PATCH v2 2/2] cpuidle: Validate cpu_dev in cpuidle_add_sysfs

2017-03-23 Thread Vaidyanathan Srinivasan
] Registration of powernv driver failed. Signed-off-by: Vaidyanathan Srinivasan <sva...@linux.vnet.ibm.com> --- drivers/cpuidle/sysfs.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/cpuidle/sysfs.c b/drivers/cpuidle/sysfs.c index c5adc8c..f2c3bce 100644 --- a/drivers/c

Re: [PATCH v2 2/2] cpuidle: Validate cpu_dev in cpuidle_add_sysfs

2017-03-23 Thread Vaidyanathan Srinivasan
* Rafael J. Wysocki <raf...@kernel.org> [2017-03-23 16:27:31]: > On Thu, Mar 23, 2017 at 4:22 PM, Vaidyanathan Srinivasan > <sva...@linux.vnet.ibm.com> wrote: > > If a given cpu is not in cpu_present and cpu hotplug > > is disabled, arch can skip setting up the

Re: [PATCH] powerpc/powernv/cpuidle: Pass correct drv->cpumask for registration

2017-03-22 Thread Vaidyanathan Srinivasan
* Michael Ellerman <m...@ellerman.id.au> [2017-03-22 21:55:50]: > Vaidyanathan Srinivasan <sva...@linux.vnet.ibm.com> writes: > > * Michael Ellerman <m...@ellerman.id.au> [2017-03-20 14:05:39]: > >> Vaidyanathan Srinivasan <sva...@linux.vnet.ibm.com>

[PATCH] powerpc/powernv/cpuidle: Pass correct drv->cpumask for registration

2017-03-17 Thread Vaidyanathan Srinivasan
12c [c00ff1503e30] c000b564 ret_from_kernel_thread+0x5c/0x78 This patch fixes the issue by passing correct cpumask from powernv-cpuidle driver. Signed-off-by: Vaidyanathan Srinivasan <sva...@linux.vnet.ibm.com> --- drivers/cpuidle/cpuidle-powernv.c | 22 +

[PATCH] cpuidle: Validate cpu_dev in cpuidle_add_sysfs

2017-03-18 Thread Vaidyanathan Srinivasan
. Signed-off-by: Vaidyanathan Srinivasan <sva...@linux.vnet.ibm.com> --- drivers/cpuidle/sysfs.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/cpuidle/sysfs.c b/drivers/cpuidle/sysfs.c index c5adc8c..19dcf32 100644 --- a/drivers/cpuidle/sysfs.c +++ b/drivers/c

Re: [PATCH] powerpc/powernv/cpuidle: Pass correct drv->cpumask for registration

2017-03-19 Thread Vaidyanathan Srinivasan
* Michael Ellerman <m...@ellerman.id.au> [2017-03-20 14:05:39]: > Vaidyanathan Srinivasan <sva...@linux.vnet.ibm.com> writes: > > > * Michael Neuling <mi...@neuling.org> [2017-03-18 16:28:02]: > > > >> Vaidy, > >> > >

Re: [PATCH] powerpc/powernv/cpuidle: Pass correct drv->cpumask for registration

2017-03-18 Thread Vaidyanathan Srinivasan
* Michael Neuling [2017-03-18 16:28:02]: > Vaidy, > > Thanks for fixing this. > > > drv->cpumask defaults to cpu_possible_mask in __cpuidle_driver_init(). > > This breaks cpuidle on powernv where sysfs files are not created for > > cpus in cpu_possible_mask that cannot be

Re: [PATCH 1/3] cpuidle: powernv: Don't bounce between low and very low thread priority

2017-04-03 Thread Vaidyanathan Srinivasan
* Nicholas Piggin [2017-04-04 09:52:07]: > On Tue, 4 Apr 2017 07:54:12 +1000 > Anton Blanchard wrote: > > > From: Anton Blanchard > > > > The core of snooze_loop() continually bounces between low and very > > low thread priority.

Re: [PATCH 1/3] cpuidle: powernv: Don't bounce between low and very low thread priority

2017-04-03 Thread Vaidyanathan Srinivasan
tively impact other threads on a core. > > All CPUs that can run PowerNV support very low priority, so we can > avoid the change completely. > > Signed-off-by: Anton Blanchard <an...@samba.org> Reviewed-by: Vaidyanathan Srinivasan <sva...@linux.vnet.ibm.com> > --- >

Re: [PATCH 2/3] cpuidle: powernv: Don't continually set thread priority in snooze_loop()

2017-04-03 Thread Vaidyanathan Srinivasan
it once on entry and once exit. > > Signed-off-by: Anton Blanchard <an...@samba.org> Reviewed-by: Vaidyanathan Srinivasan <sva...@linux.vnet.ibm.com> > --- > drivers/cpuidle/cpuidle-powernv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a

Re: [PATCH 3/3] cpuidle: powernv: Avoid a branch in the core snooze_loop() loop

2017-04-03 Thread Vaidyanathan Srinivasan
avoid the branch and be a little nicer to the > other non idle threads on the core. > > Signed-off-by: Anton Blanchard <an...@samba.org> Reviewed-by: Vaidyanathan Srinivasan <sva...@linux.vnet.ibm.com> > --- > drivers/cpuidle/cpuidle-powernv.c | 2 +- > 1 file c

Re: [PATCH] powerpc/pseries: energy driver only print message when LPAR guest

2017-07-20 Thread Vaidyanathan Srinivasan
ot significant for debugging. > > Remove it. > > Signed-off-by: Nicholas Piggin <npig...@gmail.com> Reviewed-by: Vaidyanathan Srinivasan <sva...@linux.vnet.ibm.com> > --- > arch/powerpc/platforms/pseries/pseries_energy.c | 7 +++ > 1 file changed, 3 inse

Re: [PATCH] powerpc/pseries: energy driver only print message when LPAR guest

2017-07-21 Thread Vaidyanathan Srinivasan
* Michael Ellerman <m...@ellerman.id.au> [2017-07-21 16:33:07]: > Vaidyanathan Srinivasan <sva...@linux.vnet.ibm.com> writes: > > * Nicholas Piggin <npig...@gmail.com> [2017-07-21 11:16:44]: > >> diff --git a/arch/powerpc/platforms/pseries/pseries_energy.c &

Re: [PATCH] POWER9 PMU stops after idle workaround

2017-07-19 Thread Vaidyanathan Srinivasan
* Nicholas Piggin <npig...@gmail.com> [2017-07-20 11:53:22]: > POWER9 DD2 PMU can stop after a state-loss idle in some conditions. > > A solution is to set then clear MMCRA[60] after wake from state-loss > idle. > > Signed-off-by: Nicholas Piggin <npig...@gmail.com&

  1   2   >