Re: [PATCH] module: set __jump_table alignment to 8

ers.pl will indicate that Jessica Yu and Rusty Russell be CCed on things like this in the future? On Wed, 1 Mar 2017 14:04:53 -0800 David Daney <david.da...@cavium.com> wrote: For powerpc the __jump_table section in modules is not aligned, this causes a WARN_ON() splat when load

[PATCH] module: set __jump_table alignment to 8

which uses the two least significant bits of pointers to __jump_table elements. Fix by forcing __jump_table to 8, which is the same alignment used for this section in the kernel proper. Signed-off-by: David Daney <david.da...@cavium.com> Tested-by: Sachin Sant <sach...@linux.vnet.ibm.com&g

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

On 03/01/2017 12:02 PM, Jason Baron wrote: On 03/01/2017 11:40 AM, David Daney wrote: On 02/28/2017 10:34 PM, Michael Ellerman wrote: Jason Baron <jba...@akamai.com> writes: ... I also checked all the other .ko files and they were properly aligned. So I think this should hopefull

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

On 02/28/2017 10:34 PM, Michael Ellerman wrote: Jason Baron writes: ... I also checked all the other .ko files and they were properly aligned. So I think this should hopefully work, and I like that its not a per-arch fix. Sachin, sorry to bother you again, but I'm hoping

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

On 02/28/2017 11:34 AM, Jason Baron wrote: On 02/28/2017 02:22 PM, David Daney wrote: On 02/28/2017 11:05 AM, David Daney wrote: On 02/28/2017 10:39 AM, Jason Baron wrote: [...] I suspect that the alignment of the __jump_table section in the .ko files is not correct, and you are seeing

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

On 02/28/2017 11:05 AM, David Daney wrote: On 02/28/2017 10:39 AM, Jason Baron wrote: [...] I suspect that the alignment of the __jump_table section in the .ko files is not correct, and you are seeing some sort of problem due to that. Hi, Yes, if you look at the trace that Sachin sent

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

On 02/28/2017 10:39 AM, Jason Baron wrote: On 02/28/2017 01:16 PM, David Daney wrote: On 02/28/2017 08:21 AM, Steven Rostedt wrote: On Tue, 28 Feb 2017 10:25:46 +0530 Sachin Sant <sach...@linux.vnet.ibm.com> wrote: File: ./net/ipv4/xfrm4_input.o [12] __jump_table PR

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

On 02/28/2017 08:21 AM, Steven Rostedt wrote: On Tue, 28 Feb 2017 10:25:46 +0530 Sachin Sant wrote: File: ./net/ipv4/xfrm4_input.o [12] __jump_table PROGBITS 000639 18 18 WAM 0 0 1 File: ./net/ipv4/udplite.o File:

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

On 02/27/2017 02:50 PM, Jason Baron wrote: On 02/27/2017 05:45 PM, David Daney wrote: On 02/27/2017 02:36 PM, Steven Rostedt wrote: On Mon, 27 Feb 2017 14:21:21 -0800 David Daney <dda...@caviumnetworks.com> wrote: See attached for mips. It seems to do the right thing. I

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

On 02/27/2017 02:36 PM, Steven Rostedt wrote: On Mon, 27 Feb 2017 14:21:21 -0800 David Daney <dda...@caviumnetworks.com> wrote: See attached for mips. It seems to do the right thing. I leave it as an exercise to the reader to fix the other architectures. Consult your own binutils e

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

On 02/27/2017 02:09 PM, Steven Rostedt wrote: On Mon, 27 Feb 2017 13:41:13 -0800 David Daney <dda...@caviumnetworks.com> wrote: On 02/27/2017 01:06 PM, Steven Rostedt wrote: On Mon, 27 Feb 2017 11:59:50 -0800 David Daney <dda...@caviumnetworks.com> wrote: For

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

On 02/27/2017 01:06 PM, Steven Rostedt wrote: On Mon, 27 Feb 2017 11:59:50 -0800 David Daney <dda...@caviumnetworks.com> wrote: For me the size is not the important issue, it is the alignment of the struct jump_entry entries in the table. I don't understand how your patch helps, and I

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

On 02/27/2017 11:18 AM, Jason Baron wrote: On 02/27/2017 01:57 PM, David Daney wrote: On 02/27/2017 10:49 AM, Jason Baron wrote: The core jump_label code makes use of the 2 lower bits of the static_key::[type|entries|next] field. Thus, ensure that the jump_entry table is at least 4-byte

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

t already properly aligned, this change will add padding, which is probably not what we want. Have you ever seen a problem with misalignment in the real world? If so, I think a better approach might be to set properties on the __jump_table section to force the proper alignment, or do something in the linker script. David Daney

[PATCH 2/2] numa, mm, cleanup: remove redundant NODE_DATA macro from asm header files.

arni <gkulka...@caviumnetworks.com> Signed-off-by: David Daney <david.da...@cavium.com> --- arch/arm64/include/asm/mmzone.h | 4 +--- arch/m32r/include/asm/mmzone.h| 4 +--- arch/metag/include/asm/mmzone.h | 4 +--- arch/powerpc/include/asm/mmzone.h | 8 ++-- arch/s390/incl

[PATCH 1/2] topology, cleanup: Avoid redefinition of cpumask_of_pcibus in asm header files.

<rrich...@cavium.com> Signed-off-by: Ganapatrao Kulkarni <gkulka...@caviumnetworks.com> Signed-off-by: David Daney <david.da...@cavium.com> --- arch/arm64/include/asm/topology.h | 3 --- arch/ia64/include/asm/topology.h| 4 arch/metag/include/asm/topology.h | 3 ---

[PATCH 0/2] NUMA related header file cleanups.

From: David Daney <david.da...@cavium.com> Refactor many architectures' cpumask_of_pcibus and NODE_DATA definitions by moving them to asm-generic. Tested on arm64. Build tested on ia64, m32r, powerpc, s390, sh, sparc(64), tile, x86 This patch set (arm64 portion) depends on this one:

Re: [PATCH v9 5/6] PCI: generic: Make pci-host-generic driver numa aware

On 01/18/2016 08:36 AM, Ganapatrao Kulkarni wrote: update numa_node of device associated with pci bus. moved down devm_kzalloc to allocate from node memory. Signed-off-by: Ganapatrao Kulkarni --- drivers/pci/host/pci-host-generic.c | 9 ++--- 1 file

Re: [PATCH v9 4/6] arm64, dt, thunderx: Add initial dts for Cavium Thunderx in 2 node topology.

should consider not merging these files, and removing the likewise useless thunder-88xx.dts thunder-88xx.dtsi David Daney [...] ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] Fix offset2lib issue for x86*, ARM*, PowerPC and MIPS

On 02/26/2015 02:38 PM, Andrew Morton wrote: [...] From: Andrew Mortona...@linux-foundation.org Subject: fix-offset2lib-issue-for-x86-arm-powerpc-and-mips-fix Consolidate randomize_et_dyn() implementations into fs/binfmt_elf.c. There doesn't seem to be a compile-time way of making

Re: [PATCH 05/44] mfd: as3722: Drop reference to pm_power_off from devicetree bindings

that, although documented in the kernel source tree, cannot be changed in incompatible ways as time progresses. David Daney ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

with gpios still requested\n); panic? NACK to the patch for this reason. The strongest thing you should do here is WARN. That said, I am not sure why we need this whole patch set in the first place. David Daney Is this likely to happen? Gr{oetje,eeting}s

Re: [PATCH] gpio: removes all usage of gpiochip_remove retval

On 05/29/2014 02:54 PM, abdoulaye berthe wrote: Did you forget a changelog explaining why this is either needed, or even a good idea? I joined the conversation late and don't know why you are doing this. Thanks, David Daney Signed-off-by: abdoulaye berthe berthe...@gmail.com --- arch

Re: [PATCH 25/45] staging/octeon: Use get/put_online_cpus_atomic() to prevent CPU offline

question that wasn't asked is: Will the code work at all if a CPU is taken offline even if the race, the patch eliminates, is avoided? I doubt it. As far as the patch goes: Acked-by: David Daney david.da...@cavium.com David Daney Honestly, I don't know. Let's CC the author of that code (David

Re: [PATCH] MIPS: fix bug.h MIPS build regression

it is needed. David Daney ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 03/27] smpboot: Define and use cpu_state per-cpu variable in generic code

-by: David Daney david.da...@cavium.com FWIW, the rest looks good too. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v6 0/3] netdev/of/phy: MDIO bus multiplexer support.

On 05/24/2012 11:28 AM, Timur Tabi wrote: David Daney wrote: Yes. You may note in the DTS file I attached in the parent (sorry for the fubar mime types), that there are two, almost identical, MDIO masters. smi0 has two directly attached PHYs. smi1 goes to the mux, and each child of the mux

Re: [PATCH v6 0/3] netdev/of/phy: MDIO bus multiplexer support.

On 05/24/2012 12:03 PM, Timur Tabi wrote: David Daney wrote: Well, the MDIO bus must have an associated device tree node. For my OCTEON code, the MDIO bus device is created as a result of the call to of_platform_bus_probe(), which takes care of filling in all the device tree nodes

Re: [PATCH 1/3] of: Add prefix parameter to of_modalias_node().

On 05/19/2012 11:08 PM, Grant Likely wrote: On Sat, 19 May 2012 23:54:36 -0600, Grant Likelygrant.lik...@secretlab.ca wrote: On Fri, 11 May 2012 15:05:21 -0700, David Daneyddaney.c...@gmail.com wrote: From: David Daneydavid.da...@cavium.com When generating MODALIASes, it is convenient to

Re: [PATCH 1/3] of: Add prefix parameter to of_modalias_node().

thread. David Daney ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v6 0/3] netdev/of/phy: MDIO bus multiplexer support.

. A sane person would implement a separate MDIO STA controller for each bus, in which case you wouldn't use the multiplexer driver. Only people dealing with insane hardware need the multiplexer. The patch in net-next has a nice ASCII art picture of such an insane design. David Daney ebb6600.dts

Re: [PATCH v6 0/3] netdev/of/phy: MDIO bus multiplexer support.

On 05/18/2012 03:09 PM, Timur Tabi wrote: David Daney wrote: I'm not sure what the parent MDIO bus node is supposed to represent. Is that that device that actually controls the muxing hardware No. It is the device that implements the master 802.3 clause {22,45} MDIO Station Management

Re: linux-next: Tree for May 10 (net/phy)

submitter a hard time about getting the dependencies right. :-/ Indeed, how embarrassing. It looks like Bjørn may have already posted a fix. I will try to verify that it works, and take appropriate action. Sorry about the screw up, David Daney

Re: [PATCH] net: of/phy: fix build error when phylib is built as a module

On 05/11/2012 08:47 AM, Bjørn Mork wrote: CONFIG_OF_MDIO is tristate and will be m if PHYLIB is m. Use IS_ENABLED macro to prevent build error: ERROR: of_mdio_find_bus [drivers/net/phy/mdio-mux.ko] undefined! Reported-by: Randy Dunlaprdun...@xenotime.net Cc: David

[PATCH 1/3] of: Add prefix parameter to of_modalias_node().

From: David Daney david.da...@cavium.com When generating MODALIASes, it is convenient to add things like spi: or i2c: to the front of the strings. This allows the standard modprobe to find the right driver when automatically populating bus children from the device tree structure. Add a prefix

Re: [PATCH 3/7] serial/8250: move UPIO_TSI to powerpc

vaguely familiar: https://lkml.org/lkml/2008/10/6/297 So just for the hell of it... Acked-by: David Daney david.da...@cavium.com ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 2/7] PowerPC: add unlikely() to BUG_ON()

the powerpc maintainers weigh in on it, but my opinion is that, as with MIPS, BUG_ON() is expanded to a single machine instruction, and this unlikely() business will not change the generated code in any useful way. It is thus gratuitous code churn and complexification. David Daney #define

Re: [PATCH 2/7] PowerPC: add unlikely() to BUG_ON()

from using the trap instruction[1], and there doesn't seem to be a better-defined way to make GCC generate trap instructions intelligently. This is good in theory, however powerpc has this _EMIT_BUG_ENTRY business that wouldn't work with __builtin_trap(). David Daney -Scott [1] A more

Re: [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule()

+++ [...] Peter, You will also have to patch the mailbox_interrupt() function in arch/mips/cavium-octeon/smp.c David Daney. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: RFC: Mega rename of device tree routines from of_*() to dt_*()

as well. David Daney ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: Mega rename of device tree routines from of_*() to dt_*()

is particularly annoying to me. David Daney ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 1/5] of: Add support for linking device tree blobs into vmlinux

On 11/16/2010 10:14 PM, Dirk Brandewie wrote: On 11/16/2010 06:58 PM, Grant Likely wrote: On Tue, Nov 16, 2010 at 7:21 PM, Dirk Brandewie dirk.brande...@gmail.com wrote: On 11/16/2010 04:39 PM, David Daney wrote: Thanks for doing this. However I have a few comments... On 11/16/2010 02:41

Re: [PATCH 1/5] of: Add support for linking device tree blobs into vmlinux

$@ + cmd_dtc = $(DTC) -O dtb -o $(obj)/$*.dtb -b 0 $(DTS_FLAGS) $(src)/dts/$*.dts + +$(obj)/%.dtb: $(src)/dts/%.dts + $(call if_changed,dtc) Do all the generated files get cleaned up? I will try it tomorrow to see for sure. Thanks, David Daney

[PATCH] OF device tree: Move of_get_mac_address() to a common source file.

There are two identical implementations of of_get_mac_address(), one each in arch/powerpc/kernel/prom_parse.c and arch/microblaze/kernel/prom_parse.c. Move this function to a new common file of_net.{c,h} and adjust all the callers to include the new header. Signed-off-by: David Daney dda

Re: [PATCH V5 9/9] Add Synopsys DesignWare HS USB OTG driver kernel configuration and Makefile.

in a similar manner. David Daney + select NOP_USB_XCEIV + select USB_OTG_UTILS + tristate Synopsys DWC OTG Controller + default USB_GADGET + help + This driver provides USB Device Controller support for the + Synopsys DesignWare USB OTG Core used

Re: [PATCH 0/2 v1.04] Add support for DWC OTG driver.

all see the patch? Thanks, David Daney ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 1/2 v1.03] Add support for DWC OTG HCD function.

with the original Synopsys license, without tacking on this GPL bit? David Daney ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 1/9 v1.02] Add Synopsys DesignWare HS USB OTG Controller driver.

-mipsm=125502126531841w=2 Thanks, David Daney ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 4/9] Add Synopsys DesignWare HS USB OTG Controller driver.

/otg/dwc_otg_hcd.h Why are you posting this old driver version without trying to sync against our tree which includes a number of fixes - you should know about these. This could be a question with an obvious answer, but which tree are you referring to when you say 'our tree'? David Daney

Re: [PATCH 1/9] Add Synopsys DesignWare HS USB OTG Controller driver.

for chips not targeted by the initial patch set. David Daney arch/powerpc/boot/dts/kilauea.dts | 15 + Also, please provide a clean patch that only includes the driver, and split PPC hooks into a separate patch. -- To unsubscribe from this list: send the line unsubscribe linux-usb

[PATCH 0/5] More unreachable() conversions.

, they seem plausible. I don't plan on pushing these things out any more, so if you like them please merge them via your architecture trees. I will reply with the 5 patches. David Daney (5): mn10300: Convert BUG() to use unreachable() parisc: Convert BUG() to use unreachable() powerpc

[PATCH 3/5] powerpc: Convert BUG() to use unreachable()

Use the new unreachable() macro instead of for(;;); Signed-off-by: David Daney dda...@caviumnetworks.com CC: Benjamin Herrenschmidt b...@kernel.crashing.org CC: Paul Mackerras pau...@samba.org CC: linuxppc-...@ozlabs.org --- arch/powerpc/include/asm/bug.h |2 +- 1 files changed, 1 insertions

Re: [PATCH 01/10] Add support for GCC-4.5's __builtin_unreachable() to compiler.h

Geert Uytterhoeven wrote: On Fri, Sep 11, 2009 at 17:58, David Daneydda...@caviumnetworks.com wrote: Michael Buesch wrote: On Friday 11 September 2009 01:56:42 David Daney wrote: +/* Unreachable code */ +#ifndef unreachable +# define unreachable() do { for (;;) ; } while (0) +#endif # define

[PATCH 00/11] Add support for GCC's __builtin_unreachable() and use it in BUG (v2).

for !CONFIG_BUG case. This one may be a little controversial as it will end up making code slightly larger when !CONFIG_BUG and you are using a pre-GCC-4.5 compiler. I will reply with the 11 patches. David Daney (11): Add support for GCC-4.5's __builtin_unreachable() to compiler.h (v2) x86

[PATCH 07/11] powerpc: Convert BUG() to use unreachable()

Use the new unreachable() macro instead of for(;;); Signed-off-by: David Daney dda...@caviumnetworks.com CC: Benjamin Herrenschmidt b...@kernel.crashing.org CC: Paul Mackerras pau...@samba.org CC: linuxppc-...@ozlabs.org --- arch/powerpc/include/asm/bug.h |2 +- 1 files changed, 1 insertions

Re: [PATCH 01/10] Add support for GCC-4.5's __builtin_unreachable() to compiler.h

Michael Buesch wrote: On Friday 11 September 2009 01:56:42 David Daney wrote: +/* Unreachable code */ +#ifndef unreachable +# define unreachable() do { for (;;) ; } while (0) +#endif # define unreachable() do { } while (1) ? :) Clearly I was not thinking clearly when I wrote that part

[PATCH 00/10] Add support for GCC's __builtin_unreachable() and use it in BUG.

macros to use it instead of for(;;) or while(1) loops. I will reply with the 10 patches. The architecture specific patches I will send to a smaller set of people. David Daney (10): Add support for GCC-4.5's __builtin_unreachable() to compiler.h x86: Convert BUG() to use unreachable() MIPS

[PATCH 01/10] Add support for GCC-4.5's __builtin_unreachable() to compiler.h

()' that will expand to either __builtin_unreachable() or an endless loop depending on the compiler version. Signed-off-by: David Daney dda...@caviumnetworks.com CC: Thomas Gleixner t...@linutronix.de CC: Ingo Molnar mi...@redhat.com CC: H. Peter Anvin h...@zytor.com CC: x...@kernel.org CC: r...@linux

[PATCH 07/10] powerpc: Convert BUG() to use unreachable()

Use the new unreachable() macro instead of for(;;); Signed-off-by: David Daney dda...@caviumnetworks.com CC: Benjamin Herrenschmidt b...@kernel.crashing.org CC: Paul Mackerras pau...@samba.org CC: linuxppc-...@ozlabs.org --- arch/powerpc/include/asm/bug.h |2 +- 1 files changed, 1 insertions