Re: rename ->make_request_fn and move it to the block_device_operations v2

2020-07-01 Thread Jens Axboe
he > path to issue to blk-mq, removing the need for the direct_make_request > bypass. Thanks, I'll try this again. -- Jens Axboe

Re: rename ->make_request_fn and move it to the block_device_operations

2020-06-30 Thread Jens Axboe
On 6/30/20 12:21 PM, Jens Axboe wrote: > On 6/30/20 12:19 PM, Christoph Hellwig wrote: >> On Tue, Jun 30, 2020 at 09:43:31AM -0600, Jens Axboe wrote: >>> On 6/30/20 7:57 AM, Jens Axboe wrote: >>>> On 6/29/20 1:39 PM, Christoph Hellwig wrote: >>>&g

Re: rename ->make_request_fn and move it to the block_device_operations

2020-06-30 Thread Jens Axboe
On 6/30/20 12:19 PM, Christoph Hellwig wrote: > On Tue, Jun 30, 2020 at 09:43:31AM -0600, Jens Axboe wrote: >> On 6/30/20 7:57 AM, Jens Axboe wrote: >>> On 6/29/20 1:39 PM, Christoph Hellwig wrote: >>>> Hi Jens, >>>> >>>> this series moves t

Re: rename ->make_request_fn and move it to the block_device_operations

2020-06-30 Thread Jens Axboe
On 6/30/20 7:57 AM, Jens Axboe wrote: > On 6/29/20 1:39 PM, Christoph Hellwig wrote: >> Hi Jens, >> >> this series moves the make_request_fn method into block_device_operations >> with the much more descriptive ->submit_bio name. It then also gives >> generic_

Re: rename ->make_request_fn and move it to the block_device_operations

2020-06-30 Thread Jens Axboe
he > path to issue to blk-mq, removing the need for the direct_make_request > bypass. Looks good to me, and it's a nice cleanup as well. Applied. -- Jens Axboe

Re: [PATCH 11/20] fs: remove a weird comment in submit_bh_wbc

2020-06-30 Thread Jens Axboe
the IO was purely bio based, not buffer_heads. Anyway, totally agree that it should just die, it's not that interesting or useful anymore. -- Jens Axboe

Re: Build failure on latest powerpc/merge (311ae9e159d8 io_uring: fix dead-hung for non-iter fixed rw)

2019-11-29 Thread Jens Axboe
On 11/29/19 10:07 AM, Pavel Begunkov wrote: On 29/11/2019 20:16, Jens Axboe wrote: On 11/29/19 8:14 AM, Christophe Leroy wrote: Reverting commit 311ae9e159d8 ("io_uring: fix dead-hung for non-iter fixed rw") clears the failure. Most likely an #include is missing. Huh weird how

Re: Build failure on latest powerpc/merge (311ae9e159d8 io_uring: fix dead-hung for non-iter fixed rw)

2019-11-29 Thread Jens Axboe
On 11/29/19 8:14 AM, Christophe Leroy wrote: Le 29/11/2019 à 17:04, Jens Axboe a écrit : On 11/29/19 6:53 AM, Christophe Leroy wrote: CC fs/io_uring.o fs/io_uring.c: In function ‘loop_rw_iter’: fs/io_uring.c:1628:21: error: implicit declaration of function ‘kmap’ [-Werror=implicit

Re: Build failure on latest powerpc/merge (311ae9e159d8 io_uring: fix dead-hung for non-iter fixed rw)

2019-11-29 Thread Jens Axboe
ring.c b/fs/io_uring.c index 2c2e8c25da01..745eb005fefe 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -69,6 +69,7 @@ #include #include #include +#include #define CREATE_TRACE_POINTS #include -- Jens Axboe

Re: [PATCH v6 15/24] fs/io_uring: set FOLL_PIN via pin_user_pages()

2019-11-19 Thread Jens Axboe
user_pages() to pin_user_pages(). > > Reviewed-by: Jan Kara > Signed-off-by: John Hubbard You dropped my reviewed-by now... Given the file, you'd probably want to keep that. -- Jens Axboe

Re: [PATCH 10/19] fs/io_uring: set FOLL_PIN via pin_user_pages()

2019-11-01 Thread Jens Axboe
On 10/30/19 4:49 PM, John Hubbard wrote: > Convert fs/io_uring to use the new pin_user_pages() call, which sets > FOLL_PIN. Setting FOLL_PIN is now required for code that requires > tracking of pinned pages, and therefore for any code that calls > put_user_page(). Reviewed-by

Re: [PATCH] block/ps3vram: Use %llu to format sector_t after LBDAF removal

2019-06-13 Thread Jens Axboe
s/block/ps3vram.c: In function ‘ps3vram_probe’: > drivers/block/ps3vram.c:770:23: warning: format ‘%lu’ expects argument > of type ‘long unsigned int’, but argument 4 has type ‘sector_t {aka long long > unsigned int}’ [-Wformat=] > > Fix this by using "%llu" instead. Applied, thanks. -- Jens Axboe

Re: [PATCH 2/2] arch: add pidfd and io_uring syscalls everywhere

2019-04-03 Thread Jens Axboe
On 4/3/19 9:49 AM, Will Deacon wrote: > On Wed, Apr 03, 2019 at 09:39:52AM -0600, Jens Axboe wrote: >> On 4/3/19 9:19 AM, Will Deacon wrote: >>> On Wed, Apr 03, 2019 at 07:49:26AM -0600, Jens Axboe wrote: >>>> On 4/3/19 5:11 AM, Will Deacon wrote: >>

Re: [PATCH 2/2] arch: add pidfd and io_uring syscalls everywhere

2019-04-03 Thread Jens Axboe
On 4/3/19 9:19 AM, Will Deacon wrote: > Hi Jens, > > On Wed, Apr 03, 2019 at 07:49:26AM -0600, Jens Axboe wrote: >> On 4/3/19 5:11 AM, Will Deacon wrote: >>> will@autoplooker:~/liburing/test$ ./io_uring_register >>> RELIMIT_MEMLOCK: 67108864 (67108864) >>&

Re: [PATCH 2/2] arch: add pidfd and io_uring syscalls everywhere

2019-04-03 Thread Jens Axboe
odules linked in: > [ 35.485311] CPU: 113 PID: 3973 Comm: io_uring_regist Not tainted > 5.1.0-rc3-00012-g40b114779944 #1 > [ 35.486712] Hardware name: linux,dummy-virt (DT) > [ 35.487450] pstate: 2045 (nzCv daif +PAN -UAO) > [ 35.488228] pc : link_pwq+0x10/0x60 > [ 35.488794] lr : apply_wqattrs_commit+0xe0/0x118 > [ 35.489550] sp : 17e2bbc0 Huh, this looks odd, it's crashing inside the wq setup. -- Jens Axboe

Re: [PATCH] block/swim3: Fix regression on PowerBook G3

2018-12-31 Thread Jens Axboe
request_irq() error path. Move the memset() to fix this bug. > > BTW, the request_irq() failure for the left mediabay floppy (fd1) is not > a regression. I don't know why it happens. The right media bay floppy > (fd0) works fine however. Applied, thanks. -- Jens Axboe

Re: [PATCH] block/swim3: Fix -EBUSY error when re-opening device after unmount

2018-12-31 Thread Jens Axboe
ethod. Applied, thanks. -- Jens Axboe

Re: [PATCH] block/swim3: Remove dead return statement

2018-12-31 Thread Jens Axboe
On 12/30/18 10:44 PM, Finn Thain wrote: > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: Finn Thain Applied, thanks. -- Jens Axboe

Re: [Intel-wired-lan] [PATCH V2] mm: Replace all open encodings for NUMA_NO_NODE

2018-11-26 Thread Jens Axboe
-off-by: Anshuman Khandual > > For the 'ixgbe' driver changes. > > Acked-by: Jeff Kirsher Lost the original, but for mtip32xx: Acked-by: Jens Axboe -- Jens Axboe

Re: System not booting since dm changes? (was Linux 4.20-rc1)

2018-11-05 Thread Jens Axboe
sn't boot any more, bisect points at one of: >>> >>> cef6f55a9fb4 Mike Snitzer dm table: require that request-based DM >>> be layered on blk-mq devices >>> 953923c09fe8 Mike Snitzer dm: rename DM_TYPE_MQ_REQUEST_BASED to >>> DM_TYPE_REQU

Re: [PATCH] [RFC v2] Drop all 00-INDEX files from Documentation/

2018-09-04 Thread Jens Axboe
w them out. > > A short status yields the following _outdated_ 00-INDEX files, first > counter is files listed in 00-INDEX but missing in the directory, last > is files present but not listed in 00-INDEX. For the block related bits: Reviewed-by: Jens Axboe -- Jens Axboe

Re: Oops in kmem_cache_free() via bioset_exit() (was Re: [next-20180601][nvme][ppc] Kernel Oops is triggered when creating lvm snapshots on nvme disks)

2018-06-28 Thread Jens Axboe
mempool_free_slab, (void *) kc); } diff --git a/mm/mempool.c b/mm/mempool.c index b54f2c20e5e0..060f44acd0df 100644 --- a/mm/mempool.c +++ b/mm/mempool.c @@ -508,7 +508,9 @@ EXPORT_SYMBOL(mempool_alloc_slab); void mempool_free_slab(void *element, void *pool_data) { struct kmem_cache *mem = pool_data; - kmem_cache_free(mem, element); + + if (!WARN_ON(!mem)) + kmem_cache_free(mem, element); } EXPORT_SYMBOL(mempool_free_slab); -- Jens Axboe

Re: Constant ata messages on console with commit 28361c403683 ("libata: add extra internal command") (was Re: [GIT PULL 2/2] libata changes for v4.18-rc1)

2018-06-19 Thread Jens Axboe
On 6/19/18 5:35 PM, Michael Ellerman wrote: > Jens Axboe writes: >> On 6/19/18 1:29 AM, Michael Ellerman wrote: >>> Jens Axboe writes: >>>> On 6/18/18 1:33 AM, Michael Ellerman wrote: >>>>> Tejun Heo writes: >>>>> ... >>>&

Re: Constant ata messages on console with commit 28361c403683 ("libata: add extra internal command") (was Re: [GIT PULL 2/2] libata changes for v4.18-rc1)

2018-06-19 Thread Jens Axboe
On 6/19/18 1:29 AM, Michael Ellerman wrote: > Jens Axboe writes: >> On 6/18/18 1:33 AM, Michael Ellerman wrote: >>> Tejun Heo writes: >>> ... >>>> Jens Axboe (10): >>>> libata: introduce notion of separate hardware tags >>&g

Re: Constant ata messages on console with commit 28361c403683 ("libata: add extra internal command") (was Re: [GIT PULL 2/2] libata changes for v4.18-rc1)

2018-06-19 Thread Jens Axboe
On 6/19/18 1:29 AM, Michael Ellerman wrote: > Jens Axboe writes: >> On 6/18/18 1:33 AM, Michael Ellerman wrote: >>> Tejun Heo writes: >>> ... >>>> Jens Axboe (10): >>>> libata: introduce notion of separate hardware tags >>&g

Re: Constant ata messages on console with commit 28361c403683 ("libata: add extra internal command") (was Re: [GIT PULL 2/2] libata changes for v4.18-rc1)

2018-06-18 Thread Jens Axboe
On 6/18/18 1:33 AM, Michael Ellerman wrote: > Tejun Heo writes: > ... >> Jens Axboe (10): >> libata: introduce notion of separate hardware tags >> libata: convert core and drivers to ->hw_tag usage >> libata: bump ->qc_active t

Re: Fwd: [powerpc/Baremetal]Kernel OOPS while executing memory hotplug on Power8 baremetal

2018-06-07 Thread Jens Axboe
On 6/7/18 8:45 AM, Jens Axboe wrote: > On 6/7/18 4:37 AM, vrbagal1 wrote: >> On 2018-06-07 13:12, Bart Van Assche wrote: >>> On Thu, 2018-06-07 at 12:56 +0530, Venkat Rao B wrote: >>>> On Thursday 07 June 2018 12:46 PM, Bart Van Assche wrote: >>>>> On T

Re: Fwd: [powerpc/Baremetal]Kernel OOPS while executing memory hotplug on Power8 baremetal

2018-06-07 Thread Jens Axboe
dm driver is involved. An >> important fix >> for the dm driver went upstream recently, namely d37753540568 ("dm: Use >> kzalloc >> for all structs with embedded biosets/mempools"). Can you double check >> whether >> that commit it present in your tree?

Re: make a few block drivers highmem safe

2018-05-11 Thread Jens Axboe
On 5/9/18 7:59 AM, Christoph Hellwig wrote: > Hi all, > > this series converts a few random block drivers to be highmem safe, > in preparation of eventually getting rid of the block layer bounce > buffering support. Applied, thanks. -- Jens Axboe

Re: make a few block drivers highmem safe

2018-05-09 Thread Jens Axboe
On 5/9/18 7:59 AM, Christoph Hellwig wrote: > Hi all, > > this series converts a few random block drivers to be highmem safe, > in preparation of eventually getting rid of the block layer bounce > buffering support. Series looks good to me. -- Jens Axboe

Re: [linux-next][XFS][trinity] WARNING: CPU: 32 PID: 31369 at fs/iomap.c:993

2017-09-18 Thread Jens Axboe
On 09/18/2017 09:43 AM, Al Viro wrote: > On Mon, Sep 18, 2017 at 05:39:47PM +0200, Christoph Hellwig wrote: >> On Mon, Sep 18, 2017 at 09:28:55AM -0600, Jens Axboe wrote: >>> If it's expected, why don't we kill the WARN_ON_ONCE()? I get it all >>> the time running x

Re: [linux-next][XFS][trinity] WARNING: CPU: 32 PID: 31369 at fs/iomap.c:993

2017-09-18 Thread Jens Axboe
a problematic workload - which > may be triggered by a fuzzer. If it's expected, why don't we kill the WARN_ON_ONCE()? I get it all the time running xfstests as well. -- Jens Axboe

Re: [PATCH 0/3] Minor updates for PS3

2017-08-08 Thread Jens Axboe
On 08/08/2017 04:16 AM, Michael Ellerman wrote: > Geoff Levand <ge...@infradead.org> writes: > >> Hi Michael, >> >> A few very minor updates for PS3. Please apply. > > Jens do you want to take the block ones, or should I just take the lot? Up to you, I'm fine either way. -- Jens Axboe

Re: blk_mq_sched_insert_request: inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage

2017-08-01 Thread Jens Axboe
On 08/01/2017 12:55 AM, Michael Ellerman wrote: > Jens Axboe <ax...@kernel.dk> writes: > ... >> >> Can you try the below fix? Should be more palatable than the previous >> one. Brian, maybe you can take a look at the IRQ issue mentioned above? > > Given th

Re: blk_mq_sched_insert_request: inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage

2017-07-28 Thread Jens Axboe
On 07/28/2017 09:13 AM, Bart Van Assche wrote: > On Fri, 2017-07-28 at 08:25 -0600, Jens Axboe wrote: >> On 07/28/2017 12:19 AM, Michael Ellerman wrote: >>> OK, so the resolution is "fix it in IPR" ? >> >> I'll leave that to the SCSI crew. But at least one b

Re: blk_mq_sched_insert_request: inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage

2017-07-28 Thread Jens Axboe
On 07/28/2017 12:19 AM, Michael Ellerman wrote: > Jens Axboe <ax...@kernel.dk> writes: >> On 07/27/2017 08:47 AM, Bart Van Assche wrote: >>> On Thu, 2017-07-27 at 08:02 -0600, Jens Axboe wrote: >>>> The bug looks like SCSI running the queue inline from IRQ

Re: blk_mq_sched_insert_request: inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage

2017-07-27 Thread Jens Axboe
On 07/27/2017 08:47 AM, Bart Van Assche wrote: > On Thu, 2017-07-27 at 08:02 -0600, Jens Axboe wrote: >> The bug looks like SCSI running the queue inline from IRQ >> context, that's not a good idea. Can you confirm the below works for >> you? >> >> >> diff --

Re: blk_mq_sched_insert_request: inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage

2017-07-27 Thread Jens Axboe
The bug looks like SCSI running the queue inline from IRQ context, that's not a good idea. Can you confirm the below works for you? diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c index f6097b89d5d3..78740ebf966c 100644 --- a/drivers/scsi/scsi_lib.c +++ b/drivers/scsi/scsi_lib.c @@ -

Re: linux-next: build failure after merge of the block tree

2017-06-28 Thread Jens Axboe
On 06/28/2017 08:01 AM, Jens Axboe wrote: > On 06/28/2017 06:43 AM, Jens Axboe wrote: >> On 06/28/2017 02:04 AM, Stephen Rothwell wrote: >>> Hi Jens, >>> >>> After merging the block tree, today's linux-next build (powerpc >>> allnoconfig) failed like th

Re: linux-next: build failure after merge of the block tree

2017-06-28 Thread Jens Axboe
On 06/28/2017 06:43 AM, Jens Axboe wrote: > On 06/28/2017 02:04 AM, Stephen Rothwell wrote: >> Hi Jens, >> >> After merging the block tree, today's linux-next build (powerpc >> allnoconfig) failed like this: >> >> fs/fcntl.o: In function `do_fcntl': >&g

Re: linux-next: build failure after merge of the block tree

2017-06-28 Thread Jens Axboe
r > than "unsigned long" i.e. 32 bits on 32 bit powerpc. > > This has been discussed before (and, I think, a fix attempted). Gah, thanks for letting me know. I'll test your patch and queue it up to fix this issue. -- Jens Axboe

Re: [linux-next][bock] WARNING: CPU: 22 PID: 0 at block/blk-core.c:2655 .blk_update_request+0x4f8/0x500

2017-05-08 Thread Jens Axboe
On 05/08/2017 01:13 AM, Abdul Haleem wrote: > On Fri, 2017-05-05 at 08:02 -0600, Jens Axboe wrote: >> On 05/05/2017 12:25 AM, Abdul Haleem wrote: >>> Hi, >>> >>> 4.11.0 Linus mainline booted with Warnings on PowerPC. >>> >>> We did not se

Re: [linux-next][bock] WARNING: CPU: 22 PID: 0 at block/blk-core.c:2655 .blk_update_request+0x4f8/0x500

2017-05-05 Thread Jens Axboe
On 05/05/2017 12:25 AM, Abdul Haleem wrote: > Hi, > > 4.11.0 Linus mainline booted with Warnings on PowerPC. > > We did not see this on next-20170407 but on next-20170410 and later. Have you tried current Linus -git? Both of the -next versions you list are rather old. -- Jens Axboe

Re: 4.11.0-rc1 boot resulted in WARNING: CPU: 14 PID: 1722 at fs/sysfs/dir.c:31 .sysfs_warn_dup+0x78/0xb0

2017-03-11 Thread Jens Axboe
>>>> Hi, >>>> >>>> Today's mainline (4.11.0-rc1) booted with warnings on Power7 LPAR. >>>> >>>> Issue is not reproducible all the time. Is that still the case with -git as of yesterday? Check that you have this merge: 34bbce9e344b47e8871273409632f525973afad4 in your tree. -- Jens Axboe

Re: [PATCH] axonram: Fix gendisk handling

2017-03-08 Thread Jens Axboe
by put_disk(). Add that call where > needed. Applied, thanks. -- Jens Axboe

Re: [PATCH] direct-io: don't introduce another read of inode->i_blkbits

2017-01-10 Thread Jens Axboe
ease test this to ensure this still fixes your problem? > > This patch fixes the failure, > > Tested-by: Chandan Rajendra <chan...@linux.vnet.ibm.com> > I've updated the patch, thanks guys. -- Jens Axboe

Re: [PATCH] direct-io: don't introduce another read of inode->i_blkbits

2017-01-09 Thread Jens Axboe
m > description and reproducer. > > Fixes: 20ce44d545844 > Signed-off-by: Jeff Moyer <jmo...@redhat.com> > > --- > Chandan, can you please test this to ensure this still fixes your problem? Please, that would be great. And if so, then let's fold the two. -- Jens Axboe

Re: [PATCH] do_direct_IO: Use inode->i_blkbits to compute block count to be cleaned

2017-01-09 Thread Jens Axboe
ts to compute the > number of blocks to be cleaned. Thanks, added for 4.10. -- Jens Axboe

Re: ext4 filesystem corruption with 4.10-rc2 on ppc64le

2017-01-04 Thread Jens Axboe
> Jens, could you expedite a pull request to Linus? This is affecting > ext4 on 1k block file systems on x86/x86_64, so this is not a ppc-only > regression. Yes, it'll go out this morning. -- Jens Axboe

Re: ext4 filesystem corruption with 4.10-rc2 on ppc64le

2017-01-04 Thread Jens Axboe
to clean bdev aliases under a bh and use it") > ce98321bf7d2 ("fs: Remove unmap_underlying_metadata") > > Backing these patches out fixes the issue. Fix is going out today, I see Chandan already pointed you at it. For the other reporter, it's not an LE vs BE thing, it's a fs blocksize < page size problem. -- Jens Axboe

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

2015-12-04 Thread Jens Axboe
fore that, so I hit this twice today. Update to the tree as-of yesterday (or today) and it should work. 25364a9e54fb8296 doesn't include the latest block fixes that were sent in yesterday, that should fix it. You need commit a88d32af18b8 or newer. -- Jens Axboe

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

2015-11-25 Thread Jens Axboe
lready, so how is the above making it any different? In general, NOMERGE being set or not should not make a difference. It's only a hint that we need not check further if we should be merging on this request, since we already tried it once, found we'd exceed various limits, then set NOMERGE

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

2015-11-25 Thread Jens Axboe
On 11/25/2015 12:10 PM, Hannes Reinecke wrote: On 11/25/2015 06:56 PM, Jens Axboe wrote: On 11/25/2015 02:04 AM, Hannes Reinecke wrote: On 11/20/2015 04:28 PM, Ewan Milne wrote: On Fri, 2015-11-20 at 15:55 +0100, Hannes Reinecke wrote: Can't we have a joint effort here? I've been spending

Re: [PATCH 2/3] block/ps3vram: Remove obsolete reference to MTD

2015-06-11 Thread Jens Axboe
of unrelated changes for 3 patches. If you are targeting the next release and don't depend on existing block changes, then your base should be 4.0. If you are dependent on changes in the block tree, the block tree should be your base. -- Jens Axboe

Re: [PATCH 0/3] block/ps3vram: Minor updates and fixes

2015-06-10 Thread Jens Axboe
regarding it. Please apply, thanks. Applied to for-4.2/drivers, thanks. -- Jens Axboe ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] block/ps3: Remove obsolete reference to MTD

2014-01-02 Thread Jens Axboe
@@ /* - * ps3vram - Use extra PS3 video ram as MTD block device. + * ps3vram - Use extra PS3 video ram as block device. * * Copyright 2009 Sony Corporation * Looks good. Jens, could you please apply. Acked-by: Geoff Levand ge...@infradead.org Yup will do, thanks. -- Jens Axboe

Re: [PATCH 0/7] powerpc: remove the legacy iSeries platform specific drivers

2012-03-08 Thread Jens Axboe
On 03/08/2012 05:28 AM, Stephen Rothwell wrote: It would probably be easiest if all these patches were merged via the powerpc tree to eliminate any dependencies between them. Their impact on generic code is very small. Go ahead, no point in doing otherwise. -- Jens Axboe

Re: [PATCH] block/swim3: Locking fixes

2011-12-12 Thread Jens Axboe
with a floppy drive (the machine ships only with one), so nobody cares... While at it, add a little fix to clear up stale interrupts when loading the driver or plugging a floppy drive in a bay. Applied for current for-linus branch. -- Jens Axboe

Re: [regression] 2.6.39-rc[1-3] fail to boot on G5 PowerMac

2011-04-17 Thread Jens Axboe
|= IDE_DFLAG_MEDIA_CHANGED; in drivers/ide/ide-cd.c:cdrom_saw_media_change() and see if it boots. -- Jens Axboe ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [patch] ps3disk: passing wrong variable to bvec_kunmap_irq()

2010-10-17 Thread Jens Axboe
On 2010-10-16 21:39, Geert Uytterhoeven wrote: On Mon, Oct 11, 2010 at 21:42, Jens Axboe jax...@fusionio.com wrote: On 2010-10-11 21:13, Dan Carpenter wrote: This should pass buf to bvec_kunmap_irq() instead of bv. The api is like kmap_atomic() instead of kmap(). Signed-off-by: Dan

Re: [patch] ps3disk: passing wrong variable to bvec_kunmap_irq()

2010-10-11 Thread Jens Axboe
); - bvec_kunmap_irq(bvec, flags); + bvec_kunmap_irq(buf, flags); i++; } } Thanks applied, that bug is all too common. -- Jens Axboe ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https

Re: Oops while running fs_racer test on a POWER6 box against latest git

2010-07-09 Thread Jens Axboe
the inputs. Thanks Divya Hi All, From the git bisect,seems like the commit 57439f878afafefad8836ebf5c49da2a0a746105 is the corrupt for the above issue. CC'ing Nick and Al. -- Jens Axboe ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org

Re: Warning in block code

2009-06-16 Thread Jens Axboe
it -1UL now. -- Jens Axboe ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 05/33] block: Add bio_list_peek()

2009-06-14 Thread Jens Axboe
on the list being empty or not. Leaving that one (and the next one) out for now until Jens Ack them. You can add my acked-by, this one is trivial and a good addition. Cheers, Ben. Signed-off-by: Geert Uytterhoeven geert.uytterhoe...@sonycom.com Cc: Jens Axboe ax...@kernel.dk

Re: [CFQ/OOPS] rb_erase with April 9 next tree

2009-04-09 Thread Jens Axboe
.SyS_read+0x58/0xa0 [c000d6cf7e30] c00084ac syscall_exit+0x0/0x40 Just ran into this myself, too. I'll pull that bad patch from -next asap. I wont be able to fix this before next week. -- Jens Axboe ___ Linuxppc-dev mailing list Linuxppc-dev

Re: [CFQ/OOPS] rb_erase with April 9 next tree

2009-04-09 Thread Jens Axboe
On Thu, Apr 09 2009, Jens Axboe wrote: On Thu, Apr 09 2009, Sachin Sant wrote: I had Next 09 booted on a powerpc box and was compiling a kernel. That's when i ran into this oops. Unable to handle kernel paging request for data at address 0x0010. Faulting instruction address

Re: [PATCH] ps3vram: Replace mutex by spinlock + list

2009-04-03 Thread Jens Axboe
patches, thanks Geert. -- Jens Axboe ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: Next March 25: Boot failure on powerpc [recursive locking detected]

2009-03-27 Thread Jens Axboe
, but forgot to update akpm/next branches. -- Jens Axboe ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH/RFC] ps3/block: Add ps3vram-ng driver for accessing video RAM as block device

2009-03-09 Thread Jens Axboe
On Mon, Mar 09 2009, Geert Uytterhoeven wrote: On Fri, 6 Mar 2009, Jens Axboe wrote: On Fri, Mar 06 2009, Geert Uytterhoeven wrote: On Fri, 6 Mar 2009, Jens Axboe wrote: On Fri, Mar 06 2009, Geert Uytterhoeven wrote: On Fri, 6 Mar 2009, Jens Axboe wrote: On Thu, Mar 05 2009

Re: [PATCH/RFC] ps3/block: Add ps3vram-ng driver for accessing video RAM as block device

2009-03-09 Thread Jens Axboe
On Mon, Mar 09 2009, Jens Axboe wrote: On Mon, Mar 09 2009, Geert Uytterhoeven wrote: On Fri, 6 Mar 2009, Jens Axboe wrote: On Fri, Mar 06 2009, Geert Uytterhoeven wrote: On Fri, 6 Mar 2009, Jens Axboe wrote: On Fri, Mar 06 2009, Geert Uytterhoeven wrote: On Fri, 6 Mar 2009

Re: [PATCH/RFC] ps3/block: Add ps3vram-ng driver for accessing video RAM as block device

2009-03-09 Thread Jens Axboe
On Mon, Mar 09 2009, Geert Uytterhoeven wrote: On Mon, 9 Mar 2009, Jens Axboe wrote: On Mon, Mar 09 2009, Jens Axboe wrote: On Mon, Mar 09 2009, Geert Uytterhoeven wrote: On Fri, 6 Mar 2009, Jens Axboe wrote: On Fri, Mar 06 2009, Geert Uytterhoeven wrote: On Fri, 6 Mar 2009

Re: [PATCH/RFC] ps3/block: Add ps3vram-ng driver for accessing video RAM as block device

2009-03-06 Thread Jens Axboe
On Fri, Mar 06 2009, Geert Uytterhoeven wrote: On Fri, 6 Mar 2009, Jens Axboe wrote: On Thu, Mar 05 2009, Geert Uytterhoeven wrote: But then I noticed ps3vram_make_request() may be called concurrently, so I had to add a mutex to avoid data corruption. This slows the driver down

Re: [PATCH] Fix Xilinx SystemACE driver to handle empty CF slot

2009-03-06 Thread Jens Axboe
to consider that for a future patch. -- Jens Axboe ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH/RFC] ps3/block: Add ps3vram-ng driver for accessing video RAM as block device

2009-03-05 Thread Jens Axboe
mapping for the bio, since I gather that isn't an issue on that platform. You may want to detail that in a comment above the page_addres() thing at the top of the loop, though. -- Jens Axboe ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https

Re: [PATCH/RFC] ps3/block: Add ps3vram-ng driver for accessing video RAM as block device

2009-03-05 Thread Jens Axboe
On Thu, Mar 05 2009, Geert Uytterhoeven wrote: Hi Jens, On Thu, 5 Mar 2009, Jens Axboe wrote: On Wed, Mar 04 2009, Geert Uytterhoeven wrote: Below is the rewrite of the PS3 Video RAM Storage Driver as a plain block device, as requested by Arnd Bergmann. The MTD-based PS3

Re: [PATCH/RFC] ps3/block: Add ps3vram-ng driver for accessing video RAM as block device

2009-03-05 Thread Jens Axboe
On Thu, Mar 05 2009, Geert Uytterhoeven wrote: On Thu, 5 Mar 2009, Jens Axboe wrote: On Thu, Mar 05 2009, Geert Uytterhoeven wrote: On Thu, 5 Mar 2009, Jens Axboe wrote: On Wed, Mar 04 2009, Geert Uytterhoeven wrote: Below is the rewrite of the PS3 Video RAM Storage Driver

Re: [PATCH/RFC] ps3/block: Add ps3vram-ng driver for accessing video RAM as block device

2009-03-04 Thread Jens Axboe
like integrating drivers later, I'll ask Linus opinion on this one. Linus ? What do you reckon ? Maybe a better option is just to remove ps3nvram from .29 and merge the new one in .30 ? It's an isolated driver for a special purpose platform, I would have zero problems merging it :-) -- Jens

Re: [PATCH 07/13] powerpc/ps3: printing fixups for l64 to ll64 conversion: drivers/block

2009-01-13 Thread Jens Axboe
On Wed, Jan 14 2009, Stephen Rothwell wrote: Signed-off-by: Stephen Rothwell s...@canb.auug.org.au --- drivers/block/ps3disk.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) Jens, if its OK by you, this could go in via the PowerPC tree. Of course. -- Jens

Re: [PATCH] powerpc/iseries: viodasd needs to depend on CONFIG_BLOCK

2008-12-17 Thread Jens Axboe
system and you want to use virtual disks created and managed by OS/400, say Y. -- 1.6.0.5 Indeed, looks good. I trust the ppc folks will carry this one? If so, feel free to add my acked-by to this. -- Jens Axboe ___ Linuxppc-dev mailing list

Re: [RESEND] [PATCH] powerpc: remove dead BIO_VMERGE_BOUNDARY definition

2008-12-14 Thread Jens Axboe
old -- 1.5.5.GIT -- Jens Axboe ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: linux-next: spinlock lockup with next-20081118 on powerpc

2008-11-19 Thread Jens Axboe
On Wed, Nov 19 2008, Stephen Rothwell wrote: Hi Jens, On Wed, 19 Nov 2008 10:16:28 +0100 Jens Axboe [EMAIL PROTECTED] wrote: Strange, so it gets stuck on the timer lock, very weird. You don't happen to have output showing that the other CPU is up to at that point? Unfortunately

Re: linux-next: spinlock lockup with next-20081118 on powerpc

2008-11-19 Thread Jens Axboe
This was on a Power5 partition. I am attempting to reproduce the problem. Any clues? Strange, so it gets stuck on the timer lock, very weird. You don't happen to have output showing that the other CPU is up to at that point? -- Jens Axboe

Re: linux-next: spinlock lockup with next-20081118 on powerpc

2008-11-19 Thread Jens Axboe
On Thu, Nov 20 2008, Stephen Rothwell wrote: Hi Jens, On Wed, 19 Nov 2008 14:34:09 +0100 Jens Axboe [EMAIL PROTECTED] wrote: Are you removing devices or modules? We have a bug there it seems, does this help? This is early in boot (we are waiting for the root device while running

Re: linux-next: generic-ipi tree build failure

2008-07-03 Thread Jens Axboe
'smp_call_function' I applied the patch below. Thanks Stephen, I've verified that the patch is correct! -- Jens Axboe ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] [POWERPC] iSeries: remove unused mail address

2008-05-23 Thread Jens Axboe
+- drivers/char/viotape.c |2 +- 4 files changed, 4 insertions(+), 4 deletions(-) Jens, I assume that this is trivial enough that it can be sent via the powerpc tree. Of course :-) -- Jens Axboe ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org

Re: [BUG] Linux 2.6.25-rc2 - Regression from 2.6.24-rc1-git1 softlockup while bootup on powerpc

2008-02-21 Thread Jens Axboe
On Thu, Feb 21 2008, Andrew Morton wrote: On Tue, 19 Feb 2008 09:36:34 +0100 Jens Axboe [EMAIL PROTECTED] wrote: But I think the radix 'scan over entire tree' is a bit fragile. eek, it had better not be. Was this an error in the caller? Hope so. The cfq use of it, not the radix tree

Re: [BUG] Linux 2.6.25-rc2 - Regression from 2.6.24-rc1-git1 softlockup while bootup on powerpc

2008-02-19 Thread Jens Axboe
On Tue, Feb 19 2008, KAMEZAWA Hiroyuki wrote: On Sun, 17 Feb 2008 20:29:13 +0100 Jens Axboe [EMAIL PROTECTED] wrote: It's odd stuff. Could you perhaps try and add some printks to block/cfq-iosched.c:call_for_each_cic(), like dumping the 'nr' return from radix_tree_gang_lookup

Re: [BUG] Linux 2.6.25-rc2 - Regression from 2.6.24-rc1-git1 softlockup while bootup on powerpc

2008-02-19 Thread Jens Axboe
On Tue, Feb 19 2008, KAMEZAWA Hiroyuki wrote: On Tue, 19 Feb 2008 09:58:38 +0100 Jens Axboe [EMAIL PROTECTED] wrote: when I inserted printk here == for (i = 0; i nr; i++) func(ioc, cics[i]); printk(%d %lx\n, nr, index); == index was always 1 and nr was always

Re: [BUG] Linux 2.6.25-rc2 - Regression from 2.6.24-rc1-git1 softlockup while bootup on powerpc

2008-02-19 Thread Jens Axboe
On Tue, Feb 19 2008, KAMEZAWA Hiroyuki wrote: On Tue, 19 Feb 2008 09:36:34 +0100 Jens Axboe [EMAIL PROTECTED] wrote: On Tue, Feb 19 2008, KAMEZAWA Hiroyuki wrote: On Sun, 17 Feb 2008 20:29:13 +0100 Jens Axboe [EMAIL PROTECTED] wrote: It's odd stuff. Could you perhaps try

Re: [BUG] Linux 2.6.25-rc2 - Regression from 2.6.24-rc1-git1 softlockup while bootup on powerpc

2008-02-19 Thread Jens Axboe
On Tue, Feb 19 2008, KAMEZAWA Hiroyuki wrote: On Tue, 19 Feb 2008 09:36:34 +0100 Jens Axboe [EMAIL PROTECTED] wrote: On Tue, Feb 19 2008, KAMEZAWA Hiroyuki wrote: On Sun, 17 Feb 2008 20:29:13 +0100 Jens Axboe [EMAIL PROTECTED] wrote: It's odd stuff. Could you perhaps try

Re: [PATCH] [POWERPC] iSeries: fix section mismatch in viocd

2008-02-05 Thread Jens Axboe
files changed, 1 insertions(+), 1 deletions(-) Jens, can this go in through the powerpc tree? Certainly -- Jens Axboe ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] compat_ioctl: fix block device compat ioctl regression

2007-10-27 Thread Jens Axboe
, added for swift inclusion. -- Jens Axboe ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] fix powerpc breakage in sg chaining code (again)

2007-10-24 Thread Jens Axboe
something that should be fixed, did you try 2.6.24-rc1? -- Jens Axboe ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] fix powerpc breakage in sg chaining code (again)

2007-10-24 Thread Jens Axboe
On Wed, Oct 24 2007, Johannes Berg wrote: On Wed, 2007-10-24 at 11:14 +0200, Jens Axboe wrote: I lost track - which kernel are you booting? This looks like something that should be fixed, did you try 2.6.24-rc1? No, it came out after I pulled, I was on v2.6.23-6815-g0895e91. I'll give

Re: IB/ehca: Fix sg_page() fallout

2007-10-23 Thread Jens Axboe
scatterlist' has no member named 'page' Signed-off-by: Olof Johansson [EMAIL PROTECTED] --- On Tue, Oct 23, 2007 at 07:05:12AM +0200, Jens Axboe wrote: On Mon, Oct 22 2007, Olof Johansson wrote: More fallout from sg_page changes, found with powerpc allyesconfig: drivers

Re: powerpc: Fix fallout from sg_page() changes

2007-10-23 Thread Jens Axboe
: In function 'fetch_to_dev_buffer': drivers/scsi/ps3rom.c:150: error: 'struct scatterlist' has no member named 'page' Applied. -- Jens Axboe ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] [POWERPC] Fix fallout from sg_page changes

2007-10-23 Thread Jens Axboe
On Tue, Oct 23 2007, Dale Farnsworth wrote: Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] --- include/asm-powerpc/dma-mapping.h | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) Should already be merged in Linus' current tree. -- Jens Axboe

Re: [PATCH] Use the new sg_page() helper

2007-10-23 Thread Jens Axboe
that didn't already get fixed? As is, the patch won't apply for me, since it touches many different parts and some of them are fixed. Looks like just the mmc and xtensa bits, I've merged those up. -- Jens Axboe ___ Linuxppc-dev mailing list Linuxppc-dev

Re: IB/ehca: Fix sg_page() fallout

2007-10-22 Thread Jens Axboe
/ehca_mrmw.c:1870: error: 'struct scatterlist' has no member named 'page' Thanks a lot Olof, applied both fixups! -- Jens Axboe ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [bug] block subsystem related crash on Legacy iSeries viodasd.c

2007-10-21 Thread Jens Axboe
/scsi/scsi_lib.c commit a3bec5c5aea0da263111c4d8f8eabc1f8560d7bf Author: Jens Axboe [EMAIL PROTECTED] Date: Wed Oct 17 19:33:05 2007 +0200 Revert [SCSI] Remove full sg table memset() git log block/ll_rw_blk.c commit ba951841ceb7fa5b06ad48caa5270cc2ae17941e Author: Jens Axboe [EMAIL

  1   2   >