Hello,
[...]
> > > I confirmed that the uintptr_t fixed the issue.
> >
> > We declined a similar fix in the past[1] ...
> >
> > > I also think that adding a new struct with the mode is overkill.
> >
> > ... with the hopes that a driver could drop the switch statements in place
> > of using the
Hello,
[...]
> > > Now, while you are looking at things, can you also take care about the
> > > following:
> > >
> > > drivers/pci/controller/dwc/pcie-rcar-gen4.c:439:15: warning: cast to
> > > smaller integer type 'enum dw_pcie_device_mode'
> > from 'const void *'
Hi Yoshihiro!
> This patch series is based on the latest pci.git / next branch.
[...]
Thank you for following up to tidy things up! Much appreciated.
Now, while you are looking at things, can you also take care about the
following:
drivers/pci/controller/dwc/pcie-rcar-gen4.c:439:15:
Hello,
> Correct many spelling errors in Documentation/ as reported by codespell.
>
> Maintainers of specific kernel subsystems are only Cc-ed on their
> respective patches, not the entire series.
>
> These patches are based on linux-next-20230209.
>
[...]
> [PATCH 13/24] Documentation: PCI:
ttps://lore.kernel.org/r/20221114115953.40236-1-mika.westerb...@linux.intel.com
>
> Changelog v3:
> - rebased on top of v2 by Mika, see above
> - added tag to pcmcia patch (Dominik)
[...]
Thank you Andy for all the improvements and Mika for the idea!
For the whole series:
Reviewed-by: Kr
Hello,
[...]
> > > -
> > > - for (i = 0; i < PCI_BRIDGE_RESOURCE_NUM; i++) {
> > > - res = s->cb_dev->bus->resource[i];
> > > -#else
> > > - pci_bus_for_each_resource(s->cb_dev->bus, res, i) {
> > > #endif
> > > +
> > > + pci_bus_for_each_resource_p(s->cb_dev->bus, res) {
> > >
Hello Zhuo,
> Use pcie_aer_is_native() in place of "host->native_aer ||
> pcie_ports_native" to judge whether OS has native control of AER
> in aer_root_reset() and pcie_do_recovery().
>
> Replace "dev->aer_cap && (pcie_ports_native || host->native_aer)" in
> get_port_device_capability() with
T _AC(0x4000, ULL)
>
> #endif /* __LINUX_SIZES_H__ */
Thank you!
Reviewed-by: Krzysztof Wilczyński
Krzysztof
[+CC Adding Robert for visibility]
Hi Arnd,
Thank you looking at this! Much appreciated.
> > > You could attach the kernel config there, too, since it didn't make it
> > > to the mailing list (vger may discard them -- see
> > > http://vger.kernel.org/majordomo-info.html).
> >
> > Bjorn and I
[+CC Adding Jens and Damien to get their opinion about the problem at hand]
Hello Jens and Damien,
Sorry to bother both of you, but we are having a problem that most
definitely requires someone with an extensive expertise in storage,
as per the quoted message from Christian below:
> > > The
the direct use of enum pcie_reset_state in function
arguments and replace it with pcie_reset_state_t type so that the
argument type matches the type used in enum pcie_reset_state.
Signed-off-by: Krzysztof Wilczyński
---
drivers/pci/pci.c | 4 ++--
include/linux/pci.h | 5 ++---
2 files
the direct use of enum pcie_reset_state in function
arguments and replace it with pcie_reset_state_t type so that the
argument type matches the type used in enum pcie_reset_state.
Signed-off-by: Krzysztof Wilczyński
---
arch/powerpc/kernel/eeh.c | 2 +-
1 file changed, 1 insertion(+), 1 deletio
Hi Wesley,
> Replace "It" with "If", since it is a conditional statement.
>
[...]
Nice catch!
> -cycle) and then call slot_reset() again. It the device still can't
> +cycle) and then call slot_reset() again. If the device still can't
[...]
Thank you!
R
Hi Logan,
> > The sysfs_emit() and sysfs_emit_at() functions were introduced to make
> > it less ambiguous which function is preferred when writing to the output
> > buffer in a device attribute's "show" callback [1].
> >
> > Convert the PCI sysfs object "show" functions from sprintf(),
Hi Joe,
[...]
> > if (entry)
> > - return sprintf(buf, "%s\n",
> > - entry->msi_attrib.is_msix ? "msix" : "msi");
> > + return sysfs_emit(buf, "%s\n",
> > + entry->msi_attrib.is_msix ? "msix" : "msi");
> >
> >
> >
Hi Joe,
[...]
> Ideally, the additional newline check below this would use sysfs_emit_at
>
> drivers/pci/pci.c- /*
> drivers/pci/pci.c: * When set by the command line,
> resource_alignment_param will not
> drivers/pci/pci.c- * have a trailing line feed, which is ugly. So
>
Hello,
[...]
> Reviewed-by: Logan Gunthorpe
Please disregard this "Reviewed-by" from Logan for this version, as I've
forgotten to remove it before sending v2 after pulling patches using b4.
Apologies.
Krzysztof
Only expose the value of the "driver_override" variable through the
corresponding sysfs object when a value is actually set.
Signed-off-by: Krzysztof Wilczyński
---
drivers/pci/pci-sysfs.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/pci-sysfs.c
To fix this, append a newline character in the show() function.
Signed-off-by: Krzysztof Wilczyński
---
drivers/pci/pci-sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
index beb8d1f4fafe..5d63df7c1820 100644
--- a/drivers/p
reviously set using either a command-line
argument or through the sysfs object to be cleared at run-time.
Fixes: e499081da1a2 ("PCI: Force trailing new line to resource_alignment_param
in sysfs")
Signed-off-by: Krzysztof Wilczyński
---
drivers/pci/pci.c | 31 +--
PCI/sysfs: Use sysfs_emit() and sysfs_emit_at() in
"show" functions")
Signed-off-by: Krzysztof Wilczyński
---
drivers/pci/hotplug/shpchp_sysfs.c | 38 +-
1 file changed, 21 insertions(+), 17 deletions(-)
diff --git a/drivers/pci/hotplug/shpchp_sysfs.c
b/
PCI/sysfs: Use sysfs_emit() and sysfs_emit_at() in
"show" functions")
Signed-off-by: Krzysztof Wilczyński
---
drivers/pci/hotplug/pci_hotplug_core.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/pci/hotplug/pci_hotplug_core.c
b/drivers/pci/hotpl
PCI/sysfs: Use sysfs_emit() and sysfs_emit_at() in
"show" functions")
Signed-off-by: Krzysztof Wilczyński
---
drivers/pci/hotplug/rpadlpar_sysfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/hotplug/rpadlpar_sysfs.c
b/drivers/pci/hotplug/rpadlpar_sysfs.c
PCI/sysfs: Use sysfs_emit() and sysfs_emit_at() in
"show" functions")
Signed-off-by: Krzysztof Wilczyński
---
drivers/pci/switch/switchtec.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switchtec.c
PCI/sysfs: Use sysfs_emit() and sysfs_emit_at() in
"show" functions")
Signed-off-by: Krzysztof Wilczyński
---
drivers/pci/pcie/aspm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
index ac0557a305af..013a47f587ce 10
PCI/sysfs: Use sysfs_emit() and sysfs_emit_at() in
"show" functions")
Signed-off-by: Krzysztof Wilczyński
---
drivers/pci/p2pdma.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c
index 196382630363..a1351b3e2c4c 100644
---
PCI/sysfs: Use sysfs_emit() and sysfs_emit_at() in
"show" functions")
Signed-off-by: Krzysztof Wilczyński
---
drivers/pci/iov.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c
index afc06e6ce115..a71258347323 100644
--- a/d
PCI/sysfs: Use sysfs_emit() and sysfs_emit_at() in
"show" functions")
Signed-off-by: Krzysztof Wilczyński
---
drivers/pci/msi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index 217dc9f0231f..dbfec59dfe41 100644
--- a/drivers/pci
strlen() used later
to calculate the length of the buffer can be removed as it would no
longer be needed.
No functional change intended.
[1] Documentation/filesystems/sysfs.rst
Related to:
commit ad025f8e46f3 ("PCI/sysfs: Use sysfs_emit() and sysfs_emit_at() in
"show" functions&quo
PCI/sysfs: Use sysfs_emit() and sysfs_emit_at() in
"show" functions")
Signed-off-by: Krzysztof Wilczyński
---
drivers/pci/pcie/aer.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
index ec943cee5ecc..40
PCI/sysfs: Use sysfs_emit() and sysfs_emit_at() in
"show" functions")
Signed-off-by: Krzysztof Wilczyński
Reviewed-by: Logan Gunthorpe
---
drivers/pci/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index b717680377a9..5ed316ea5
Hi Logan,
[...]
> Thanks, this is a great cleanup. I've reviewed the entire series.
>
> Reviewed-by: Logan Gunthorpe
Thank you! Appreciate it!
> I agree that the new lines that are missing should be added.
While working on the simple change to add the missing new lines, I've
found that we
[+cc Joe for visibility]
[...]
> spin_lock(_alignment_lock);
> if (resource_alignment_param)
> - count = scnprintf(buf, PAGE_SIZE, "%s",
> resource_alignment_param);
> + count = sysfs_emit(buf, "%s", resource_alignment_param);
>
PCI/sysfs: Use sysfs_emit() and sysfs_emit_at() in
"show" functions")
Signed-off-by: Krzysztof Wilczyński
---
drivers/pci/hotplug/shpchp_sysfs.c | 38 +-
1 file changed, 21 insertions(+), 17 deletions(-)
diff --git a/drivers/pci/hotplug/shpchp_sysfs.c
b/
PCI/sysfs: Use sysfs_emit() and sysfs_emit_at() in
"show" functions")
Signed-off-by: Krzysztof Wilczyński
---
drivers/pci/hotplug/pci_hotplug_core.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/pci/hotplug/pci_hotplug_core.c
b/drivers/pci/hotpl
PCI/sysfs: Use sysfs_emit() and sysfs_emit_at() in
"show" functions")
Signed-off-by: Krzysztof Wilczyński
---
drivers/pci/hotplug/rpadlpar_sysfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/hotplug/rpadlpar_sysfs.c
b/drivers/pci/hotplug/rpadlpar_sysfs.c
PCI/sysfs: Use sysfs_emit() and sysfs_emit_at() in
"show" functions")
Signed-off-by: Krzysztof Wilczyński
---
drivers/pci/switch/switchtec.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switchtec.c
PCI/sysfs: Use sysfs_emit() and sysfs_emit_at() in
"show" functions")
Signed-off-by: Krzysztof Wilczyński
---
drivers/pci/pcie/aspm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
index ac0557a305af..013a47f587ce 10
PCI/sysfs: Use sysfs_emit() and sysfs_emit_at() in
"show" functions")
Signed-off-by: Krzysztof Wilczyński
---
drivers/pci/p2pdma.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c
index 196382630363..a1351b3e2c4c 100644
---
PCI/sysfs: Use sysfs_emit() and sysfs_emit_at() in
"show" functions")
Signed-off-by: Krzysztof Wilczyński
---
drivers/pci/iov.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c
index afc06e6ce115..a71258347323 100644
--- a/d
PCI/sysfs: Use sysfs_emit() and sysfs_emit_at() in
"show" functions")
Signed-off-by: Krzysztof Wilczyński
---
drivers/pci/msi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index 217dc9f0231f..dbfec59dfe41 100644
--- a/drivers/pci
PCI/sysfs: Use sysfs_emit() and sysfs_emit_at() in
"show" functions")
Signed-off-by: Krzysztof Wilczyński
---
drivers/pci/pcie/aer.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
index ec943cee5ecc..40
PCI/sysfs: Use sysfs_emit() and sysfs_emit_at() in
"show" functions")
Signed-off-by: Krzysztof Wilczyński
---
drivers/pci/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index b717680377a9..5ed316ea5831 100644
--- a/drivers/pci/
strlen() used later
to calculate the length of the buffer can be removed as it would no
longer be needed.
No functional change intended.
[1] Documentation/filesystems/sysfs.rst
Related to:
commit ad025f8e46f3 ("PCI/sysfs: Use sysfs_emit() and sysfs_emit_at() in
"show" functions&quo
Replace command with a semicolon to correct syntax and to prevent
potential unspecified behaviour and/or unintended side effects.
Related:
https://lore.kernel.org/linux-pci/20201216131944.14990-1-zhengyongj...@huawei.com/
Co-authored-by: Zheng Yongjun
Signed-off-by: Krzysztof Wilczyński
Hi,
[...]
> I would request NXP maintainers to take this patch, rewrite it as
> Bjorn requested and resend it as fast as possible, this is a very
> relevant fix.
[...]
Looking at the state of the pci-layerscape-ep.c file in Linus' tree,
this still hasn't been fixed, and it has been a while.
NXP
, and then drop said enum and the typedef pci_bus_flags_t.
This will keep PCI device-specific features as part of the struct
pci_dev and make the code that used to use flags simpler.
Suggested-by: Bjorn Helgaas
Signed-off-by: Krzysztof Wilczyński
---
Changes in v2:
Rebased against kernel 5.11
Hello Nicolas, Florian and Florian,
[...]
> -/* Configuration space read/write support */
> -static inline int brcm_pcie_cfg_index(int busnr, int devfn, int reg)
> -{
> - return ((PCI_SLOT(devfn) & 0x1f) << PCIE_EXT_SLOT_SHIFT)
> - | ((PCI_FUNC(devfn) & 0x07) <<
[+CC David for visibility]
Hi Bjorn,
Thank you for the review!
On 20-11-28 12:35:16, Bjorn Helgaas wrote:
[...]
> It's ironic that we don't use PCIE_ECAM_OFFSET in drivers/pci/ecam.c.
> We could do something like this, which would also let us drop
> .bus_shift completely in all the conforming
d as per the PCI Express Specification.
> >
> > Suggested-by: Bjorn Helgaas
> > Signed-off-by: Krzysztof Wilczyński
>
> I think Bjorn's reviewed-by still stands so I will apply it.
[...]
Thank you!
Krzysztof
Removed unused ".bus_shift" initialisers from pci-xgene.c as
xgene_pcie_map_bus() did not use these.
Suggested-by: Bjorn Helgaas
Signed-off-by: Krzysztof Wilczyński
---
drivers/pci/controller/pci-xgene.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/pci/controller/pci-
_iomem"
pointer.
Related:
https://lwn.net/Articles/102232/
Suggested-by: Bjorn Helgaas
Signed-off-by: Krzysztof Wilczyński
---
drivers/pci/controller/vmd.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/contr
is always 32 bit aligned.
Suggested-by: Bjorn Helgaas
Signed-off-by: Krzysztof Wilczyński
---
drivers/pci/controller/pcie-iproc.c | 31 -
1 file changed, 8 insertions(+), 23 deletions(-)
diff --git a/drivers/pci/controller/pcie-iproc.c
b/drivers/pci/controller/pcie
Add a custom constant for the ".bus_shit" initialiser to capture
a non-standard platform-specific ECAM bus shift value.
Standard values otherwise defined in the PCI Express Specification
are available in the include/linux/pci-ecam.h.
Suggested-by: Bjorn Helgaas
Signed-off-by:
ded values, and also correlate more strongly with the
descriptions in the aforementioned specification (see Table 7-1
"Enhanced Configuration Address Mapping", p. 677).
Suggested-by: Bjorn Helgaas
Signed-off-by: Krzysztof Wilczyński
---
Changed in v6:
Converted single patch into a seri
Signed-off-by: Krzysztof Wilczyński
---
drivers/pci/controller/dwc/pcie-al.c| 12 ++---
drivers/pci/controller/dwc/pcie-hisi.c | 2 --
drivers/pci/controller/pci-aardvark.c | 13 +++---
drivers/pci/controller/pci-host-generic.c | 1 -
drivers/pci/controller/pci-thunder-eca
elate more strongly with the
descriptions in the aforementioned specification (see Table 7-1
"Enhanced Configuration Address Mapping", p. 677).
There is no change to functionality.
Suggested-by: Bjorn Helgaas
Signed-off-by: Krzysztof Wilczyński
---
Changed in v5:
Rem
On 20-10-04 19:53:06, Florian Fainelli wrote:
Hi Florian,
Sorry for taking a long time to get back to you.
[...]
> This appears to be correct, so:
>
> Acked-by: Florian Fainelli
Thank you!
> however, I would have defined a couple of additional helper macros and do:
>
> idx =
elate more strongly with the
descriptions in the aforementioned specification (see Table 7-1
"Enhanced Configuration Address Mapping", p. 677).
There is no change to functionality.
Suggested-by: Bjorn Helgaas
Signed-off-by: Krzysztof Wilczyński
---
Changed in v4:
Removed constants relat
, and then drop said enum and the typedef pci_bus_flags_t.
This will keep PCI device-specific features as part of the struct
pci_dev and make the code that used to use flags simpler.
Related:
https://patchwork.kernel.org/patch/11772809
Suggested-by: Bjorn Helgaas
Signed-off-by: Krzysztof Wilczyński
60 matches
Mail list logo