Re: [PATCH] selftests/powerpc: Skip PROT_SAO test in guests/LPARS

[Michael Ellerman]

Sachin Sant  writes:
>> On 01-Sep-2020, at 6:16 PM, Michael Ellerman  wrote:
>> 
>> In commit 9b725a90a8f1 ("powerpc/64s: Disallow PROT_SAO in LPARs by
>> default") PROT_SAO was disabled in guests/LPARs by default. So skip
>> the test if we are running in a guest to avoid a spurious failure.
>> 
>> Signed-off-by: Michael Ellerman 
>> —
>
> Tested-by: Sachin Sant 
>
> With the fix test is skipped while running in a guest
>
> # ./prot_sao 
> test: prot-sao
> tags: git_version:unknown
> [SKIP] Test skipped on line 25
> skip: prot-sao
> #

Thanks. Sorry I missed adding your Tested-by tag.

cheers

Re: [PATCH] selftests/powerpc: Skip PROT_SAO test in guests/LPARS

[Michael Ellerman]

On Tue, 1 Sep 2020 22:46:53 +1000, Michael Ellerman wrote:
> In commit 9b725a90a8f1 ("powerpc/64s: Disallow PROT_SAO in LPARs by
> default") PROT_SAO was disabled in guests/LPARs by default. So skip
> the test if we are running in a guest to avoid a spurious failure.

Applied to powerpc/fixes.

[1/1] selftests/powerpc: Skip PROT_SAO test in guests/LPARS
  https://git.kernel.org/powerpc/c/fc1f178cdb31783ff37296ecae817a1045a1a513

cheers

Re: [PATCH] selftests/powerpc: Skip PROT_SAO test in guests/LPARS

[Sachin Sant]

> On 01-Sep-2020, at 6:16 PM, Michael Ellerman  wrote:
> 
> In commit 9b725a90a8f1 ("powerpc/64s: Disallow PROT_SAO in LPARs by
> default") PROT_SAO was disabled in guests/LPARs by default. So skip
> the test if we are running in a guest to avoid a spurious failure.
> 
> Signed-off-by: Michael Ellerman 
> —

Tested-by: Sachin Sant 

With the fix test is skipped while running in a guest

# ./prot_sao 
test: prot-sao
tags: git_version:unknown
[SKIP] Test skipped on line 25
skip: prot-sao
#

[PATCH] selftests/powerpc: Skip PROT_SAO test in guests/LPARS

[Michael Ellerman]

In commit 9b725a90a8f1 ("powerpc/64s: Disallow PROT_SAO in LPARs by
default") PROT_SAO was disabled in guests/LPARs by default. So skip
the test if we are running in a guest to avoid a spurious failure.

Signed-off-by: Michael Ellerman 
---
 tools/testing/selftests/powerpc/mm/prot_sao.c | 9 +++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/powerpc/mm/prot_sao.c 
b/tools/testing/selftests/powerpc/mm/prot_sao.c
index e0cf8ebbf8cd..30b71b1d78d5 100644
--- a/tools/testing/selftests/powerpc/mm/prot_sao.c
+++ b/tools/testing/selftests/powerpc/mm/prot_sao.c
@@ -7,6 +7,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 
@@ -18,9 +19,13 @@ int test_prot_sao(void)
 {
char *p;
 
-   /* SAO was introduced in 2.06 and removed in 3.1 */
+   /*
+* SAO was introduced in 2.06 and removed in 3.1. It's disabled in
+* guests/LPARs by default, so also skip if we are running in a guest.
+*/
SKIP_IF(!have_hwcap(PPC_FEATURE_ARCH_2_06) ||
-   have_hwcap2(PPC_FEATURE2_ARCH_3_1));
+   have_hwcap2(PPC_FEATURE2_ARCH_3_1) ||
+   access("/proc/device-tree/rtas/ibm,hypertas-functions", F_OK) 
== 0);
 
/*
 * Ensure we can ask for PROT_SAO.
-- 
2.25.1