Re: [PATCH 11/26] KVM: PPC: Make RMO a define

2010-06-29 Thread Segher Boessenkool
On PowerPC it's very normal to not support all of the physical RAM in real mode. Oh? Are you referring to real mode limit, or 32-bit implementations with more than 32 address lines, or something else? The former. Okay. In that case, the hypervisor can usually access all of physical

Re: [PATCH 11/26] KVM: PPC: Make RMO a define

2010-06-29 Thread Alexander Graf
On 29.06.2010, at 09:32, Segher Boessenkool wrote: On PowerPC it's very normal to not support all of the physical RAM in real mode. Oh? Are you referring to real mode limit, or 32-bit implementations with more than 32 address lines, or something else? The former. Okay. In that

Re: [PATCH 11/26] KVM: PPC: Make RMO a define

2010-06-29 Thread Segher Boessenkool
Also, it seems you construct the physical address by masking out bits from the effective address. Most implementations will trap or machine check if you address outside of physical address space, instead. Well the only case where I remember to have hit a real RMO case is on the PS3 -

Re: [PATCH 11/26] KVM: PPC: Make RMO a define

2010-06-29 Thread Alexander Graf
On 29.06.2010, at 09:52, Segher Boessenkool wrote: Also, it seems you construct the physical address by masking out bits from the effective address. Most implementations will trap or machine check if you address outside of physical address space, instead. Well the only case where I

Re: [PATCH 11/26] KVM: PPC: Make RMO a define

2010-06-27 Thread Alexander Graf
Am 26.06.2010 um 18:52 schrieb Segher Boessenkool seg...@kernel.crashing.org : On PowerPC it's very normal to not support all of the physical RAM in real mode. Oh? Are you referring to real mode limit, or 32-bit implementations with more than 32 address lines, or something else? The

Re: [PATCH 11/26] KVM: PPC: Make RMO a define

2010-06-26 Thread Segher Boessenkool
On PowerPC it's very normal to not support all of the physical RAM in real mode. Oh? Are you referring to real mode limit, or 32-bit implementations with more than 32 address lines, or something else? Either way, RMO is a really bad name for this, since that name is already used for a

[PATCH 11/26] KVM: PPC: Make RMO a define

2010-06-25 Thread Alexander Graf
On PowerPC it's very normal to not support all of the physical RAM in real mode. To check if we're matching on the shared page or not, we need to know the limits so we can restrain ourselves to that range. So let's make it a define instead of open-coding it. And while at it, let's also increase