Re: [PATCH 3/3] tools/perf/tests: Fix shellcheck warning in record_sideband.sh test

2023-10-05 Thread Athira Rajeev
> On 05-Oct-2023, at 10:34 AM, Namhyung Kim wrote: > > On Thu, Sep 28, 2023 at 9:11 PM Athira Rajeev > wrote: >> >> Running shellcheck on record_sideband.sh throws below >> warning: >> >>In tests/shell/record_sideband.sh line 25: >> if ! perf record -o ${perfdata} -BN

Re: [PATCH 3/3] tools/perf/tests: Fix shellcheck warning in record_sideband.sh test

2023-10-04 Thread Namhyung Kim
On Thu, Sep 28, 2023 at 9:11 PM Athira Rajeev wrote: > > Running shellcheck on record_sideband.sh throws below > warning: > > In tests/shell/record_sideband.sh line 25: > if ! perf record -o ${perfdata} -BN --no-bpf-event -C $1 true 2>&1 > >/dev/null > ^--^ SC2069:

[PATCH 3/3] tools/perf/tests: Fix shellcheck warning in record_sideband.sh test

2023-09-28 Thread Athira Rajeev
Running shellcheck on record_sideband.sh throws below warning: In tests/shell/record_sideband.sh line 25: if ! perf record -o ${perfdata} -BN --no-bpf-event -C $1 true 2>&1 >/dev/null ^--^ SC2069: To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file;