Re: [PATCH v3 3/3] powerpc/fsl: 85xx: add cache-sram support

2009-12-01 Thread Scott Wood
Mahajan Vivek-B08308 wrote: From: Wood Scott-B07421 Sent: Friday, November 20, 2009 11:09 PM Cache-sram does not have any device tree entry since it is not a hardware as such. Putting it under chosen can be another option. I think, Scott (cc'ed) was of the opinion that since 32b base address

Re: [PATCH v3 3/3] powerpc/fsl: 85xx: add cache-sram support

2009-12-01 Thread Kumar Gala
On Dec 1, 2009, at 11:04 AM, Scott Wood wrote: Mahajan Vivek-B08308 wrote: From: Wood Scott-B07421 Sent: Friday, November 20, 2009 11:09 PM Cache-sram does not have any device tree entry since it is not a hardware as such. Putting it under chosen can be another option. I think, Scott

RE: [PATCH v3 3/3] powerpc/fsl: 85xx: add cache-sram support

2009-11-30 Thread Mahajan Vivek-B08308
From: Wood Scott-B07421 Sent: Friday, November 20, 2009 11:09 PM Cache-sram does not have any device tree entry since it is not a hardware as such. Putting it under chosen can be another option. I think, Scott (cc'ed) was of the opinion that since 32b base address support is

Re: [PATCH v3 3/3] powerpc/fsl: 85xx: add cache-sram support

2009-11-20 Thread Scott Wood
On Thu, Nov 19, 2009 at 11:45:32PM -0700, Mahajan Vivek-B08308 wrote: I really don't like setting the physical address this way, can we not do this via the device tree? Cache-sram does not have any device tree entry since it is not a hardware as such. Putting it under chosen can be

Re: [PATCH v3 3/3] powerpc/fsl: 85xx: add cache-sram support

2009-11-19 Thread Kumar Gala
On Oct 21, 2009, at 7:50 AM, Vivek Mahajan wrote: This adds QorIQ based Cache-SRAM support as under:- * A small abstraction over powerpc's remote heap allocator * Exports mpc85xx_cache_sram_alloc()/free() APIs * Supports only one contiguous SRAM window * Defines FSL_85XX_CACHE_SRAM and its

Re: [PATCH v3 3/3] powerpc/fsl: 85xx: add cache-sram support

2009-11-19 Thread Kumar Gala
On Nov 19, 2009, at 8:21 AM, Kumar Gala wrote: diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/ platforms/85xx/Kconfig index d3a975e..b6f23c3 100644 --- a/arch/powerpc/platforms/85xx/Kconfig +++ b/arch/powerpc/platforms/85xx/Kconfig @@ -144,6 +144,15 @@ config SBC8560

Re: [PATCH v3 3/3] powerpc/fsl: 85xx: add cache-sram support

2009-11-19 Thread Scott Wood
On Thu, Nov 19, 2009 at 08:29:19AM -0600, Kumar Gala wrote: +config FSL_85XX_CACHE_SRAM_BASE + hex + depends on FSL_85XX_CACHE_SRAM + default 0xfff0 + I really don't like setting the physical address this way, can we not do this via the device tree? At a high level I think

Re: [PATCH v3 3/3] powerpc/fsl: 85xx: add cache-sram support

2009-11-19 Thread Kumar Gala
On Nov 19, 2009, at 11:45 AM, Scott Wood wrote: On Thu, Nov 19, 2009 at 08:29:19AM -0600, Kumar Gala wrote: +config FSL_85XX_CACHE_SRAM_BASE + hex + depends on FSL_85XX_CACHE_SRAM + default 0xfff0 + I really don't like setting the physical address this way, can we not

RE: [PATCH v3 3/3] powerpc/fsl: 85xx: add cache-sram support

2009-11-19 Thread Mahajan Vivek-B08308
From: Gala Kumar-B11780 Sent: Thursday, November 19, 2009 7:51 PM + * Cache SRAM handling for QorIQ platform should say PQ3 some QorIQ platforms Ok +config FSL_85XX_CACHE_SRAM_BASE + hex + depends on FSL_85XX_CACHE_SRAM + default 0xfff0 + I really don't like