Re: Q: a_ops-readpage() struct file

2012-06-13 Thread Peter Zijlstra
On Mon, 2012-06-11 at 21:09 +0200, Oleg Nesterov wrote: Stupid question. I'm afraid the answer is no but I'll ask anyway. Is it safe to pass filp == NULL to mapping-readpage()? In fact I do not understand why it needs struct file* and I do not see any example of actual usage. Looking at

Replacement to of_register_platform_driver ?

2012-06-13 Thread Guillaume Dargaud
Hello all, I just updated to the most recent kernel and a driver I wrote last year won't compile: xad.c:534:2: error: implicit declaration of function 'of_register_platform_driver' I see references to this function as 'obsolete' but could not find what's the new recommended way to do things.

Re: Replacement to of_register_platform_driver ?

2012-06-13 Thread Ira W. Snyder
On Wed, Jun 13, 2012 at 05:21:22PM +0200, Guillaume Dargaud wrote: Hello all, I just updated to the most recent kernel and a driver I wrote last year won't compile: xad.c:534:2: error: implicit declaration of function 'of_register_platform_driver' I see references to this function as

Re: [Cbe-oss-dev] [PATCH 05/10] powerpc/ps3: Use highmem region from repository

2012-06-13 Thread Geoff Levand
Hi Michael, On Wed, 2012-06-13 at 11:49 +1000, Michael Ellerman wrote: On Wed, 2012-04-25 at 19:19 +, Andre Heider wrote: Use any preallocated highmem region setup by the bootloader. This implementation only checks for the existance of a single region at region_index=0. This

[PATCH 1/2] drivers: crypto: move nx build to driver/crypto Makefile

2012-06-13 Thread Seth Jennings
When the nx driver was pulled, the Makefile that actually builds it is arch/powerpc/Makefile. This is unnatural. This patch moves the line that builds the nx driver from arch/powerpc/Makefile to drivers/crypto/Makefile where it belongs. Cc: Kent Yoder k...@linux.vnet.ibm.com Signed-off-by: Seth

[PATCH 2/2] drivers: crypto: fix typo in nx driver config option

2012-06-13 Thread Seth Jennings
Cc: Kent Yoder k...@linux.vnet.ibm.com Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- drivers/crypto/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig index 1092a77..b9b11a6 100644 ---

Re: [PATCH 1/2] drivers: crypto: move nx build to driver/crypto Makefile

2012-06-13 Thread Kent Yoder
On Wed, 2012-06-13 at 13:22 -0500, Seth Jennings wrote: When the nx driver was pulled, the Makefile that actually builds it is arch/powerpc/Makefile. This is unnatural. This patch moves the line that builds the nx driver from arch/powerpc/Makefile to drivers/crypto/Makefile where it

Re: [PATCH v2 1/2] uprobes: Pass probed vaddr to arch_uprobe_analyze_insn()

2012-06-13 Thread Oleg Nesterov
On 06/12, Oleg Nesterov wrote: On 06/12, Srikar Dronamraju wrote: Note also that we should move this !UPROBE_COPY_INSN from install_breakpoint() to somewhere near alloc_uprobe(). This code is called only once, it looks a bit strange to use the random mm (the first mm

Re: Q: a_ops-readpage() struct file

2012-06-13 Thread Oleg Nesterov
On 06/13, Peter Zijlstra wrote: On Mon, 2012-06-11 at 21:09 +0200, Oleg Nesterov wrote: Stupid question. I'm afraid the answer is no but I'll ask anyway. Is it safe to pass filp == NULL to mapping-readpage()? In fact I do not understand why it needs struct file* and I do not see any

Re: [Cbe-oss-dev] [PATCH 05/10] powerpc/ps3: Use highmem region from repository

2012-06-13 Thread Nathan Whitehorn
On 06/13/12 12:58, Geoff Levand wrote: Hi Michael, On Wed, 2012-06-13 at 11:49 +1000, Michael Ellerman wrote: On Wed, 2012-04-25 at 19:19 +, Andre Heider wrote: Use any preallocated highmem region setup by the bootloader. This implementation only checks for the existance of a single

Re: [PATCH 2/2] drivers: crypto: fix typo in nx driver config option

2012-06-13 Thread Kent Yoder
On Wed, 2012-06-13 at 13:22 -0500, Seth Jennings wrote: Cc: Kent Yoder k...@linux.vnet.ibm.com Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- drivers/crypto/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Kent Yoder k...@linux.vnet.ibm.com diff

[PATCH] i2c: let the core register devices from devicetree

2012-06-13 Thread Wolfram Sang
Currently, every driver has to do it on its own, but it should be done in the core, like we already do with board_info structs. Signed-off-by: Wolfram Sang w.s...@pengutronix.de --- Based on v3.5-rc2. Only build tested, I don't have a OF based device around at the moment. @Peter: Why does

Re: [PATCH] i2c: let the core register devices from devicetree

2012-06-13 Thread Benjamin Herrenschmidt
On Wed, 2012-06-13 at 23:12 +0200, Wolfram Sang wrote: Currently, every driver has to do it on its own, but it should be done in the core, like we already do with board_info structs. Signed-off-by: Wolfram Sang w.s...@pengutronix.de --- Based on v3.5-rc2. Only build tested, I don't have a

Re: [PATCH] i2c: let the core register devices from devicetree

2012-06-13 Thread Stephen Warren
On 06/13/2012 03:12 PM, Wolfram Sang wrote: Currently, every driver has to do it on its own, but it should be done in the core, like we already do with board_info structs. At least on Tegra this works fine, Tested-by: Stephen Warren swar...@wwwdotorg.org

Re: Replacement to of_register_platform_driver ?

2012-06-13 Thread Michael Ellerman
On Wed, 2012-06-13 at 17:21 +0200, Guillaume Dargaud wrote: Hello all, I just updated to the most recent kernel and a driver I wrote last year won't compile: xad.c:534:2: error: implicit declaration of function 'of_register_platform_driver' I see references to this function as 'obsolete'

Re: [PATCH 5/15] powerpc: convert to %r for all GPR usage

2012-06-13 Thread Michael Neuling
Jesse Larrew jlar...@linux.vnet.ibm.com wrote: On 06/08/2012 06:36 AM, Michael Neuling wrote: -/* General Purpose Registers (GPRs) */ +/* + * General Purpose Registers (GPRs) + * + * The lower case r0-r31 should be used in preference to the upper + * case R0-R31 as they provide

Re: [PATCH] i2c: let the core register devices from devicetree

2012-06-13 Thread Grant Likely
On Wed, 13 Jun 2012 23:12:10 +0200, Wolfram Sang w.s...@pengutronix.de wrote: Currently, every driver has to do it on its own, but it should be done in the core, like we already do with board_info structs. Signed-off-by: Wolfram Sang w.s...@pengutronix.de FWIW, and without any actual