[SLOF PATCH 0/2] fbuffer: Improve the speed of the cursor drawing

2015-07-28 Thread Thomas Huth
Greg Kurz recently already did a great work by introducing the invert-region helpers to speed up the drawing of the cursor. This made the grub2 command prompt and editor mode usable. However, the editor mode of grub2 is still sluggish - because grub2 always redraws the whole line (with cursor

[SLOF PATCH 1/2] fbuffer: Improve invert-region helper

2015-07-28 Thread Thomas Huth
The introduction of invert-region already speeded up the cursor drawing very much. But there is still space for improvement: So far invert-region is accessing the memory only byte by byte, but with some additional logic that checks the alignment of the address and the length of the area, we can

Re: [RFC PATCH] powerpc/kexec: Wait 1s for secondaries to enter OPAL

2015-07-28 Thread Benjamin Herrenschmidt
On Tue, 2015-07-28 at 16:13 +1000, Samuel Mendoza-Jonas wrote: It sounds reasonable was more or less the inspiration :) While I was going over some of the code relating to the previous kexec fix with Ben he pointed this out and suggested there wasn't much of a reason to differentiate between

Re: [PATCH v8 3/3] leds/powernv: Add driver for PowerNV platform

2015-07-28 Thread Benjamin Herrenschmidt
On Tue, 2015-07-28 at 08:38 +0200, Jacek Anaszewski wrote: +/* Register the classdev */ +rc = devm_led_classdev_register(dev, powernv_led-cdev); +if (rc) { +dev_err(dev, %s: Classdev registration failed for %s\n, +__func__, powernv_led-cdev.name); +}

Re: [PATCH] powerpc/fsl-pci: fix pcie range issue for some P1/P2 boards

2015-07-28 Thread Scott Wood
On Tue, 2015-07-28 at 21:34 -0500, Hou Zhiqiang-B48286 wrote: Hi Scott and all, Please ignore this patch! Did you figure out what was actually causing you to see CPU stalls? -Scott ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org

RE: [PATCH] powerpc/fsl-pci: fix pcie range issue for some P1/P2 boards

2015-07-28 Thread Hou Zhiqiang
Hi Scott and all, Please ignore this patch! -Original Message- From: Wood Scott-B07421 Sent: 2015年7月25日 10:48 To: Hou Zhiqiang-B48286 Cc: linuxppc-dev@lists.ozlabs.org; b...@kernel.crashing.org; pau...@samba.org; m...@ellerman.id.au; Hu Mingkai-B21284 Subject: Re: [PATCH]

Re: [PATCH v8 3/3] leds/powernv: Add driver for PowerNV platform

2015-07-28 Thread Vasant Hegde
On 07/27/2015 03:20 PM, Jacek Anaszewski wrote: Hi Vasant, On 27.07.2015 05:41, Vasant Hegde wrote: On 07/27/2015 03:11 AM, Jacek Anaszewski wrote: Hi Vasant, Hi Jacek, Two trivial details left. Please find them below. Thanks for the review/Ack. I'll fix below issues and resend

[SLOF PATCH 2/2] fbuffer: Use a smaller cursor

2015-07-28 Thread Thomas Huth
Drawing the cursor in the frame buffer memory is a very, very slow operation. So let's simply switch to a underscore cursor instead of the full block cursor to save some precious cycles. Signed-off-by: Thomas Huth th...@redhat.com --- slof/fs/fbuffer.fs | 3 ++- 1 file changed, 2 insertions(+),

Re: [PATCH V5 0/7] Allow user to request memory to be locked on page fault

2015-07-28 Thread Eric B Munson
On Tue, 28 Jul 2015, Michal Hocko wrote: [I am sorry but I didn't get to this sooner.] On Mon 27-07-15 10:54:09, Eric B Munson wrote: Now that VM_LOCKONFAULT is a modifier to VM_LOCKED and cannot be specified independentally, it might make more sense to mirror that relationship to

[PATCH 0/8] Use correctly the Xen memory terminologies in Linux

2015-07-28 Thread Julien Grall
Hi all, This patch series aims to use the memory terminologies described in include/linux/mm.h [1] for Linux xen code. Linux is using mistakenly MFN when GFN is meant, I suspect this is because the first support of Xen was for PV. This has brought some misimplementation of memory helpers on ARM

[PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-28 Thread Julien Grall
Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN is meant, I suspect this is because the first support for Xen was for PV. This brough some misimplementation of helpers on ARM and make the developper confused the expected behavior. For instance, with pfn_to_mfn, we expect to

[PATCH 7/8] hvc/xen: Further s/MFN/GFN clean-up

2015-07-28 Thread Julien Grall
HVM_PARAM_CONSOLE_PFN is used to retrieved the console PFN for HVM guest. It returns a PFN (aka GFN) and not a MFN. Furthermore, use directly virt_to_gfn for both PV and HVM domain rather than doing a special case for each of the them. Signed-off-by: Julien Grall julien.gr...@citrix.com Cc: Greg

Re: [PATCH V5 0/7] Allow user to request memory to be locked on page fault

2015-07-28 Thread Vlastimil Babka
On 07/28/2015 01:17 PM, Michal Hocko wrote: [I am sorry but I didn't get to this sooner.] On Mon 27-07-15 10:54:09, Eric B Munson wrote: Now that VM_LOCKONFAULT is a modifier to VM_LOCKED and cannot be specified independentally, it might make more sense to mirror that relationship to

Re: [PATCH v8 3/3] leds/powernv: Add driver for PowerNV platform

2015-07-28 Thread Jacek Anaszewski
On 28.07.2015 12:14, Benjamin Herrenschmidt wrote: On Tue, 2015-07-28 at 08:38 +0200, Jacek Anaszewski wrote: +/* Register the classdev */ +rc = devm_led_classdev_register(dev, powernv_led-cdev); +if (rc) { +dev_err(dev, %s: Classdev registration failed for %s\n, +

Re: [PATCH 11/11] selftests/seccomp: Add powerpc support

2015-07-28 Thread Michael Ellerman
On Mon, 2015-07-27 at 11:59 -0700, Kees Cook wrote: On Thu, Jul 23, 2015 at 3:21 AM, Michael Ellerman m...@ellerman.id.au wrote: Wire up the syscall number and regs so the tests work on powerpc. This patch begs the question: this passes everything? Doh, yes that would have been worth

Re: [PATCH V9 11/11] powerpc/powernv: compound PE for VFs

2015-07-28 Thread Wei Yang
Hi, Michael Hope you didn't take this yet. We may change this patch a little. On Fri, Jul 17, 2015 at 02:02:41PM +0800, Wei Yang wrote: When VF BAR size is larger than 64MB, we group VFs in terms of M64 BAR, which means those VFs in a group should form a compound PE. This patch links those VF

Re: [4/5] powerpc/perf: Change name type of 'pred' in power_pmu_bhrb_read

2015-07-28 Thread Michael Ellerman
On Tue, 2015-30-06 at 08:20:30 UTC, Anshuman Khandual wrote: Branch record attributes 'mispred' and 'predicted' are single bit fields as defined in the perf ABI. Hence the data type of the field 'pred' used during BHRB processing should be changed from integer to bool. This patch also changes

[PATCH] cxl: Don't ignore add_process_element result when attaching context

2015-07-28 Thread Daniel Axtens
Previously, when attaching a context in dedicated mode, we ignored the result of add_process_element, which could potentially fail. If add_process_element returns and error, pass it back to the caller. Signed-off-by: Daniel Axtens d...@axtens.net --- I'm not sure if this is worth sending to

Re: [PATCH] cxl: Don't ignore add_process_element result when attaching context

2015-07-28 Thread Daniel Axtens
On Wed, 2015-07-29 at 14:25 +1000, Michael Ellerman wrote: On Wed, 2015-07-29 at 14:07 +1000, Daniel Axtens wrote: Previously, when attaching a context in dedicated mode, we ignored Previously? You mean currently? Now is before this patch is applied. I do mean currently. Apologies for the

Re: [SLOF] [SLOF PATCH 2/2] fbuffer: Use a smaller cursor

2015-07-28 Thread Segher Boessenkool
On Wed, Jul 29, 2015 at 01:05:48PM +1000, Alexey Kardashevskiy wrote: : fb8-toggle-cursor ( -- ) line# fb8-line2addr column# fb8-columns2bytes + -char-height 0 ?DO +char-height 3 - screen-width screen-depth * * + +3 0 ?DO Why not just: - char-height 0 ?DO + 1

Re: [SLOF PATCH 2/2] fbuffer: Use a smaller cursor

2015-07-28 Thread Alexey Kardashevskiy
On 07/28/2015 08:19 PM, Thomas Huth wrote: Drawing the cursor in the frame buffer memory is a very, very slow operation. So let's simply switch to a underscore cursor instead of the full block cursor to save some precious cycles. Signed-off-by: Thomas Huth th...@redhat.com ---

Re: [PATCH] cxl: Don't ignore add_process_element result when attaching context

2015-07-28 Thread Michael Ellerman
On Wed, 2015-07-29 at 14:07 +1000, Daniel Axtens wrote: Previously, when attaching a context in dedicated mode, we ignored Previously? You mean currently? Now is before this patch is applied. the result of add_process_element, which could potentially fail. If add_process_element returns and

[PATCH] gianfar: Fix warnings when built on 64-bit

2015-07-28 Thread Scott Wood
As part of defconfig consolidation using fragments, we'd like to be able to have the same drivers enabled on 32-bit and 64-bit. Gianfar happens to only exist on 32-bit systems, and when building the resulting 64-bit kernel warnings were produced. A couple of the warnings are trivial, but the

Re: [SLOF PATCH 1/2] fbuffer: Improve invert-region helper

2015-07-28 Thread Segher Boessenkool
On Tue, Jul 28, 2015 at 12:19:54PM +0200, Thomas Huth wrote: : invert-region ( addr len -- ) - 0 ?DO dup dup rb@ -1 xor swap rb! 1+ LOOP drop -; - -: invert-region-x ( addr len -- ) - /x / 0 ?DO dup dup rx@ -1 xor swap rx! xa1+ LOOP drop + 2dup or 7 and CASE + 0 OF 3 rshift 0

Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-28 Thread David Vrabel
On 28/07/15 16:02, Julien Grall wrote: Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN is meant, I suspect this is because the first support for Xen was for PV. This brough some misimplementation of helpers on ARM and make the developper confused the expected behavior.

Re: [Xen-devel] [PATCH 7/8] hvc/xen: Further s/MFN/GFN clean-up

2015-07-28 Thread David Vrabel
On 28/07/15 16:02, Julien Grall wrote: HVM_PARAM_CONSOLE_PFN is used to retrieved the console PFN for HVM guest. It returns a PFN (aka GFN) and not a MFN. Furthermore, use directly virt_to_gfn for both PV and HVM domain rather than doing a special case for each of the them. Reviewed-by:

Re: [PATCH] ipmi/powernv: Fix potential invalid pointer dereference

2015-07-28 Thread Alistair Popple
Hi Neelesh, This fix looks reasonable to me, although Jeremy would be the best person to comment if he has time. I wonder why we bother polling at all given that our event interface should call opal_ipmi_recv() whenever a message is ready? Also the firmware fix you refer to and this fix are

Re: [PATCH V5 0/7] Allow user to request memory to be locked on page fault

2015-07-28 Thread Eric B Munson
On Tue, 28 Jul 2015, Vlastimil Babka wrote: On 07/28/2015 03:49 PM, Eric B Munson wrote: On Tue, 28 Jul 2015, Michal Hocko wrote: [...] The only remaining question I have is should we have 2 new mlockall flags so that the caller can explicitly set VM_LOCKONFAULT in the mm-def_flags vs

Re: [PATCH v8 3/3] leds/powernv: Add driver for PowerNV platform

2015-07-28 Thread Jacek Anaszewski
Vasant, On 28.07.2015 15:40, Vasant Hegde wrote: On 07/27/2015 03:20 PM, Jacek Anaszewski wrote: Hi Vasant, On 27.07.2015 05:41, Vasant Hegde wrote: On 07/27/2015 03:11 AM, Jacek Anaszewski wrote: Hi Vasant, Hi Jacek, Two trivial details left. Please find them below. Thanks for the

Re: [RFC PATCH] powerpc/kexec: Wait 1s for secondaries to enter OPAL

2015-07-28 Thread Samuel Mendoza-Jonas
On 27/07/15 15:56, Stewart Smith wrote: Samuel Mendoza-Jonas sam...@au1.ibm.com writes: Always include a timeout when waiting for secondary cpus to enter OPAL in the kexec path, rather than only when crashing. This *sounds* reasonable... but I wonder what actual worse case could be and why

Re: [PATCH v8 3/3] leds/powernv: Add driver for PowerNV platform

2015-07-28 Thread Jacek Anaszewski
Vasant, I've found one more formatting issue below. On 27.07.2015 05:41, Vasant Hegde wrote: [...] + +/* + * This function registers classdev structure for any given type of LED on + * a given child LED device node. + */ +static int powernv_led_create(struct device *dev, +

Re: [SLOF PATCH 1/2] fbuffer: Improve invert-region helper

2015-07-28 Thread Thomas Huth
Hi Segher, On 28/07/15 19:04, Segher Boessenkool wrote: On Tue, Jul 28, 2015 at 12:19:54PM +0200, Thomas Huth wrote: : invert-region ( addr len -- ) - 0 ?DO dup dup rb@ -1 xor swap rb! 1+ LOOP drop -; - -: invert-region-x ( addr len -- ) - /x / 0 ?DO dup dup rx@ -1 xor swap rx! xa1+

Re: [PATCH 0/8] Use correctly the Xen memory terminologies in Linux

2015-07-28 Thread H. Peter Anvin
On 07/28/2015 08:02 AM, Julien Grall wrote: Hi all, This patch series aims to use the memory terminologies described in include/linux/mm.h [1] for Linux xen code. Linux is using mistakenly MFN when GFN is meant, I suspect this is because the first support of Xen was for PV. This has

Re: [PATCH V5 0/7] Allow user to request memory to be locked on page fault

2015-07-28 Thread Michal Hocko
[I am sorry but I didn't get to this sooner.] On Mon 27-07-15 10:54:09, Eric B Munson wrote: Now that VM_LOCKONFAULT is a modifier to VM_LOCKED and cannot be specified independentally, it might make more sense to mirror that relationship to userspace. Which would lead to soemthing like the

Re: [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-28 Thread Boris Ostrovsky
On 07/28/2015 11:02 AM, Julien Grall wrote: Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN is meant, I suspect this is because the first support for Xen was for PV. This brough some misimplementation of helpers on ARM and make the developper confused the expected behavior.

RE: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-28 Thread Chris (Christopher) Brand
Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN is meant, I suspect this is because the first support for Xen was for PV. This brough some Typo : brought Perhaps resulted in would be better ? misimplementation of helpers on ARM and make the developper confused the

Re: [Xen-devel] [PATCH 0/8] Use correctly the Xen memory terminologies in Linux

2015-07-28 Thread Andrew Cooper
On 28/07/15 22:06, H. Peter Anvin wrote: On 07/28/2015 08:02 AM, Julien Grall wrote: Hi all, This patch series aims to use the memory terminologies described in include/linux/mm.h [1] for Linux xen code. Linux is using mistakenly MFN when GFN is meant, I suspect this is because the first