Re: [PATCH] i2c: cpm: Fix i2c_ram structure

2020-09-22 Thread Christophe Leroy
Le 22/09/2020 à 11:04, nico.vi...@gmail.com a écrit : From: Nicolas VINCENT the i2c_ram structure is missing the sdmatmp field mentionned in datasheet for MPC8272 at paragraph 36.5. With this field missing, the hardware would write past the allocated memory done through cpm_muram_alloc for

Re: [PATCH 1/9] kernel: add a PF_FORCE_COMPAT flag

2020-09-22 Thread Pavel Begunkov
On 22/09/2020 10:23, Arnd Bergmann wrote: > On Tue, Sep 22, 2020 at 8:32 AM Pavel Begunkov wrote: >> On 22/09/2020 03:58, Andy Lutomirski wrote: >>> On Mon, Sep 21, 2020 at 5:24 PM Pavel Begunkov >>> wrote: >>> I may be looking at a different kernel than you, but aren't you >>> preventing

[PATCH] i2c: cpm: Fix i2c_ram structure

2020-09-22 Thread nico . vince
From: Nicolas VINCENT the i2c_ram structure is missing the sdmatmp field mentionned in datasheet for MPC8272 at paragraph 36.5. With this field missing, the hardware would write past the allocated memory done through cpm_muram_alloc for the i2c_ram structure and land in memory allocated for the

Re: [PATCH 1/9] kernel: add a PF_FORCE_COMPAT flag

2020-09-22 Thread Arnd Bergmann
On Tue, Sep 22, 2020 at 8:32 AM Pavel Begunkov wrote: > On 22/09/2020 03:58, Andy Lutomirski wrote: > > On Mon, Sep 21, 2020 at 5:24 PM Pavel Begunkov > > wrote: > > I may be looking at a different kernel than you, but aren't you > > preventing creating an io_uring regardless of whether SQPOLL

[PATCH] cpufreq: powernv: Fix frame-size-overflow in powernv_cpufreq_reboot_notifier

2020-09-22 Thread Srikar Dronamraju
The patch avoids allocating cpufreq_policy on stack hence fixing frame size overflow in 'powernv_cpufreq_reboot_notifier' ./drivers/cpufreq/powernv-cpufreq.c: In function _powernv_cpufreq_reboot_notifier_: ./drivers/cpufreq/powernv-cpufreq.c:906:1: error: the frame size of 2064 bytes is larger

Re: [PATCH V2] powerpc/perf: Exclude pmc5/6 from the irrelevant PMU group constraints

2020-09-22 Thread Madhavan Srinivasan
On 9/21/20 12:40 PM, Athira Rajeev wrote: PMU counter support functions enforces event constraints for group of events to check if all events in a group can be monitored. Incase of event codes using PMC5 and PMC6 ( 500fa and 600f4 respectively ), not all constraints are applicable, say the

Re: [PATCH 1/9] kernel: add a PF_FORCE_COMPAT flag

2020-09-22 Thread Pavel Begunkov
On 22/09/2020 03:58, Andy Lutomirski wrote: > On Mon, Sep 21, 2020 at 5:24 PM Pavel Begunkov wrote: >>> Ah, so reading /dev/input/event* would suffer from the same issue, >>> and that one would in fact be broken by your patch in the hypothetical >>> case that someone tried to use

Re: [PATCH v3] powerpc: fix EDEADLOCK redefinition error in uapi/asm/errno.h

2020-09-22 Thread Tony Ambardar
On Mon, 21 Sep 2020 at 05:54, Sasha Levin wrote: > > Hi > > [This is an automated email] > > This commit has been processed because it contains a -stable tag. > The stable tag indicates that it's relevant for the following trees: all > > The bot has tested the following trees: v5.8.10, v5.4.66,

Re: [PATCH 1/9] kernel: add a PF_FORCE_COMPAT flag

2020-09-22 Thread Arnd Bergmann
On Tue, Sep 22, 2020 at 9:59 AM Pavel Begunkov wrote: > On 22/09/2020 10:23, Arnd Bergmann wrote: > > On Tue, Sep 22, 2020 at 8:32 AM Pavel Begunkov > > wrote: > >> On 22/09/2020 03:58, Andy Lutomirski wrote: > >>> On Mon, Sep 21, 2020 at 5:24 PM Pavel Begunkov > >>> wrote: > >>> I may be

Re: [PATCH] powerpc/64: Make VDSO32 track COMPAT on 64-bit

2020-09-22 Thread Srikar Dronamraju
* Michael Ellerman [2020-09-17 21:28:46]: > On Tue, 8 Sep 2020 22:58:50 +1000, Michael Ellerman wrote: > > When we added the VDSO32 kconfig symbol, which controls building of > > the 32-bit VDSO, we made it depend on CPU_BIG_ENDIAN (for 64-bit). > > > > That was because back then COMPAT was

Re: [PATCH v3 1/2] powerpc/64: Set up a kernel stack for secondaries before cpu_restore()

2020-09-22 Thread Jordan Niethe
On Tue, Sep 22, 2020 at 3:59 PM Christophe Leroy wrote: > > > > Le 22/09/2020 à 07:53, Jordan Niethe a écrit : > > Currently in generic_secondary_smp_init(), cur_cpu_spec->cpu_restore() > > is called before a stack has been set up in r1. This was previously fine > > as the cpu_restore() functions

Re: [PATCH v3 1/2] powerpc/64: Set up a kernel stack for secondaries before cpu_restore()

2020-09-22 Thread Christophe Leroy
Le 22/09/2020 à 07:53, Jordan Niethe a écrit : Currently in generic_secondary_smp_init(), cur_cpu_spec->cpu_restore() is called before a stack has been set up in r1. This was previously fine as the cpu_restore() functions were implemented in assembly and did not use a stack. However commit

Re: [PATCH] i2c: cpm: Fix i2c_ram structure

2020-09-22 Thread Joakim Tjernlund
On Tue, 2020-09-22 at 11:04 +0200, nico.vi...@gmail.com wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > From: Nicolas VINCENT > > the i2c_ram structure is

Re: [PATCH v2 1/2] ASoC: fsl_xcvr: Add XCVR ASoC CPU DAI driver

2020-09-22 Thread Philipp Zabel
On Mon, Sep 21, 2020 at 10:08:11PM +0300, Viorel Suman (OSS) wrote: > From: Viorel Suman > > XCVR (Audio Transceiver) is a on-chip functional module found > on i.MX8MP. It support HDMI2.1 eARC, HDMI1.4 ARC and SPDIF. > > Signed-off-by: Viorel Suman > --- > sound/soc/fsl/Kconfig| 10 + >

Re: [PATCH V2] powerpc/perf: Exclude pmc5/6 from the irrelevant PMU group constraints

2020-09-22 Thread Paul A. Clarke
Just one nit in a comment below... (and this is not worthy of tags like "reviewed-by" ;-) On Mon, Sep 21, 2020 at 03:10:04AM -0400, Athira Rajeev wrote: > PMU counter support functions enforces event constraints for group of > events to check if all events in a group can be monitored. Incase of >

Re: [PATCH v3 2/5] powerpc: apm82181: create shared dtsi for APM bluestone

2020-09-22 Thread Rob Herring
On Sat, Sep 19, 2020 at 2:23 PM Christian Lamparter wrote: > > On 2020-09-15 03:05, Rob Herring wrote: > > On Sun, Sep 06, 2020 at 12:06:12AM +0200, Christian Lamparter wrote: > >> This patch adds an DTSI-File that can be used by various device-tree > >> files for APM82181-based devices. > >> >

Re: [PATCH] ibmvfc: Protect vhost->task_set increment by the host lock

2020-09-22 Thread Martin K. Petersen
Brian, > In the discovery thread, ibmvfc does a vhost->task_set++ without any > lock held. This could result in two targets getting the same cancel > key, which could have strange effects in error recovery. The actual > probability of this occurring should be extremely small, since this >

Re: [PATCH v1] soc: fsl: rcpm: Add ACPI support

2020-09-22 Thread Li Yang
On Wed, Sep 16, 2020 at 1:12 AM Ard Biesheuvel wrote: > > On 9/16/20 3:32 AM, Ran Wang wrote: > > Hi Ard, > > > > On Tuesday, September 15, 2020 7:10 PM, Ard Biesheuvel wrote: > >> Subject: Re: [PATCH v1] soc: fsl: rcpm: Add ACPI support > >> > >> On 9/15/20 1:06 PM, kuldip dwivedi wrote: > >>>

Re: [PATCH -next] soc/qman: convert to use be32_add_cpu()

2020-09-22 Thread Li Yang
On Sun, Sep 13, 2020 at 10:56 PM Liu Shixin wrote: > > Signed-off-by: Liu Shixin > drivers/soc/fsl/qbman/qman_test_api.c--- The patch seems to be messed up here. I have fixed that, and applied for next. Thanks. > drivers/soc/fsl/qbman/qman_test_api.c | 2 +- > 1 file changed, 1

Re: [PATCH] soc: fsl: dpio: remove set but not used 'addr_cena'

2020-09-22 Thread Li Yang
On Sun, Sep 20, 2020 at 3:20 PM Krzysztof Kozlowski wrote: > > On Thu, 10 Sep 2020 at 16:57, Jason Yan wrote: > > > > This addresses the following gcc warning with "make W=1": > > > > drivers/soc/fsl/dpio/qbman-portal.c: In function > > ‘qbman_swp_enqueue_multiple_direct’: > >

Re: [PATCH -next] soc: fsl: qe: Remove unnessesary check in ucc_set_tdm_rxtx_clk

2020-09-22 Thread Li Yang
On Tue, Aug 4, 2020 at 9:04 AM Wang Hai wrote: > > Fix smatch warning: > > drivers/soc/fsl/qe/ucc.c:526 > ucc_set_tdm_rxtx_clk() warn: unsigned 'tdm_num' is never less than zero. > > 'tdm_num' is u32 type, never less than zero. > > Signed-off-by: Wang Hai Applied for next. Thanks. > --- >

Re: [PATCH] soc: fsl: qbman: Fix return value on success

2020-09-22 Thread Li Yang
On Sun, Sep 20, 2020 at 3:27 PM Krzysztof Kozlowski wrote: > > On error the function was meant to return -ERRNO. This also fixes > compile warning: > > drivers/soc/fsl/qbman/bman.c:640:6: warning: variable 'err' set but not > used [-Wunused-but-set-variable] > > Fixes: 0505d00c8dba

Re: [PATCH 1/9] kernel: add a PF_FORCE_COMPAT flag

2020-09-22 Thread Andy Lutomirski
> On Sep 22, 2020, at 2:01 AM, Arnd Bergmann wrote: > > On Tue, Sep 22, 2020 at 9:59 AM Pavel Begunkov > wrote: >>> On 22/09/2020 10:23, Arnd Bergmann wrote: >>> On Tue, Sep 22, 2020 at 8:32 AM Pavel Begunkov >>> wrote: On 22/09/2020 03:58, Andy Lutomirski wrote: > On Mon, Sep

Re: [PATCH 1/5] Documentation: dt: binding: fsl: Add 'fsl,ippdexpcr1-alt-addr' property

2020-09-22 Thread Rob Herring
On Wed, Sep 16, 2020 at 04:18:27PM +0800, Ran Wang wrote: > From: Biwen Li > > The 'fsl,ippdexpcr1-alt-addr' property is used to handle an errata A-008646 > on LS1021A > > Signed-off-by: Biwen Li > Signed-off-by: Ran Wang > --- > Documentation/devicetree/bindings/soc/fsl/rcpm.txt | 19

Re: [PATCH] KVM: PPC: Book3S: Remove redundant initialization of variable ret

2020-09-22 Thread Paul Mackerras
On Sat, Sep 19, 2020 at 03:12:30PM +0800, Jing Xiangfeng wrote: > The variable ret is being initialized with '-ENOMEM' that is meaningless. > So remove it. > > Signed-off-by: Jing Xiangfeng Thanks, applied. Paul.

Re: [PATCH -next] powerpc/kvm/books: Fix symbol undeclared warnings

2020-09-22 Thread Paul Mackerras
On Mon, Sep 21, 2020 at 11:22:11AM +, Wang Wensheng wrote: > Build the kernel with `C=2`: > arch/powerpc/kvm/book3s_hv_nested.c:572:25: warning: symbol > 'kvmhv_alloc_nested' was not declared. Should it be static? > arch/powerpc/kvm/book3s_64_mmu_radix.c:350:6: warning: symbol >

Re: [PATCH] KVM: PPC: Book3S HV: Do not allocate HPT for a nested guest

2020-09-22 Thread Paul Mackerras
On Fri, Sep 11, 2020 at 01:16:07AM -0300, Fabiano Rosas wrote: > The current nested KVM code does not support HPT guests. This is > informed/enforced in some ways: > > - Hosts < P9 will not be able to enable the nested HV feature; > > - The nested hypervisor MMU capabilities will not contain >

Re: [PATCH v4 13/13] mm/debug_vm_pgtable: Avoid none pte in pte_clear_test

2020-09-22 Thread Anshuman Khandual
On 09/11/2020 10:51 AM, Aneesh Kumar K.V wrote: > Nathan Chancellor writes: > >> On Wed, Sep 02, 2020 at 05:12:22PM +0530, Aneesh Kumar K.V wrote: >>> pte_clear_tests operate on an existing pte entry. Make sure that >>> is not a none pte entry. >>> >>> Signed-off-by: Aneesh Kumar K.V >>> ---

Re: [PATCH] KVM: PPC: Don't return -ENOTSUPP to userspace in ioctls

2020-09-22 Thread Paul Mackerras
On Fri, Sep 11, 2020 at 12:53:45PM +0200, Greg Kurz wrote: > ENOTSUPP is a linux only thingy, the value of which is unknown to > userspace, not to be confused with ENOTSUP which linux maps to > EOPNOTSUPP, as permitted by POSIX [1]: > > [EOPNOTSUPP] > Operation not supported on socket. The type

Re: [PATCH -next v2] KVM: PPC: Book3S HV: XIVE: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-22 Thread Paul Mackerras
On Sat, Sep 19, 2020 at 09:29:25AM +0800, Qinglang Miao wrote: > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Qinglang Miao Thanks, applied. Paul.

Re: [PATCH v2] powerpc/pci: unmap legacy INTx interrupts when a PHB is removed

2020-09-22 Thread Qian Cai
[ 3575.155052][T151472] Padding df7d5e89: 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a ZZZZ [ 3575.155107][T151472] CPU: 7 PID: 151472 Comm: trinity-c61 Tainted: GB 5.9.0-rc6-next-20200922+ #2 [ 3575.155147][T151472] Call Trace:

Re: [patch RFC 06/15] csky/mm/highmem: Switch to generic kmap atomic

2020-09-22 Thread Guo Ren
Acked-by: Guo Ren On Sat, Sep 19, 2020 at 5:50 PM Thomas Gleixner wrote: > > Signed-off-by: Thomas Gleixner > Cc: Guo Ren > Cc: linux-c...@vger.kernel.org > --- > Note: Completely untested > --- > arch/csky/Kconfig |1 > arch/csky/include/asm/highmem.h |4 +- >

Re: [PATCH -next] powerpc/perf: Fix symbol undeclared warning

2020-09-22 Thread Athira Rajeev
> On 21-Sep-2020, at 4:55 PM, Wang Wensheng wrote: > > Build kernel with `C=2`: > arch/powerpc/perf/isa207-common.c:24:18: warning: symbol > 'isa207_pmu_format_attr' was not declared. Should it be static? > arch/powerpc/perf/power9-pmu.c:101:5: warning: symbol 'p9_dd21_bl_ev' > was not