Re: [PATCH net-next] Revert ibmvnic merge do_change_param_reset into do_reset

2020-11-06 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 6 Nov 2020 14:17:45 -0500 you wrote: > This reverts commit 16b5f5ce351f8709a6b518cc3cbf240c378305bf > where it restructures do_reset. There are patches being tested that > would require major rework if this is

[PATCH v2] powerpc/64: irq replay remove decrementer overflow check

2020-11-06 Thread Nicholas Piggin
This is way to catch some cases of decrementer overflow, when the decrementer has underflowed an odd number of times, while MSR[EE] was disabled. With a typical small decrementer, a timer that fires when MSR[EE] is disabled will be "lost" if MSR[EE] remains disabled for between 4.3 and 8.6

Re: [PATCH net-next] Revert ibmvnic merge do_change_param_reset into do_reset

2020-11-06 Thread Jakub Kicinski
On Fri, 6 Nov 2020 14:17:45 -0500 Dany Madden wrote: > This reverts commit 16b5f5ce351f8709a6b518cc3cbf240c378305bf > where it restructures do_reset. There are patches being tested that > would require major rework if this is committed first. > > We will resend this after the other patches have

[RFC PATCH] powerpc: show registers when unwinding interrupt frames

2020-11-06 Thread Nicholas Piggin
It's often useful to know the register state for interrupts in the stack frame. In the below example (with this patch applied), the important information is the state of the page fault. A blatant case like this probably rather should have the page fault regs passed down to the warning, but quite

[PATCH] powerpc: add compile-time support for lbarx, lwarx

2020-11-06 Thread Nicholas Piggin
ISA v2.06 (POWER7 and up) as well as e6500 support lbarx and lwarx. Add a compile option that allows code to use it, and add support in cmpxchg and xchg 8 and 16 bit values. Signed-off-by: Nicholas Piggin --- arch/powerpc/Kconfig | 3 + arch/powerpc/include/asm/cmpxchg.h

Re: [PATCH] powerpc: add compile-time support for lbarx, lwarx

2020-11-06 Thread Gabriel Paubert
On Sat, Nov 07, 2020 at 01:23:28PM +1000, Nicholas Piggin wrote: > ISA v2.06 (POWER7 and up) as well as e6500 support lbarx and lwarx. Hmm, lwarx exists since original Power AFAIR, s/lwarx/lharx/ perhaps? Same for the title of the patch and the CONFIG variable. Gabriel > Add a

Re: [PATCH] KVM: PPC: Book3S: Assign boolean values to a bool variable

2020-11-06 Thread Greg Kurz
On Sat, 7 Nov 2020 14:26:22 +0800 xiakaixu1...@gmail.com wrote: > From: Kaixu Xia > > Fix the following coccinelle warnings: > > ./arch/powerpc/kvm/book3s_xics.c:476:3-15: WARNING: Assignment of 0/1 to bool > variable > ./arch/powerpc/kvm/book3s_xics.c:504:3-15: WARNING: Assignment of 0/1 to

Re: [PATCH 00/36] Rid W=1 issues from TTY

2020-11-06 Thread Greg Kroah-Hartman
On Wed, Nov 04, 2020 at 07:35:13PM +, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. Many of these now applied, please update the series against my tty-testing branch

Re: [PATCH 05/11 v3] kprobes/ftrace: Add recursion protection to the ftrace callback

2020-11-06 Thread Masami Hiramatsu
On Thu, 05 Nov 2020 21:32:40 -0500 Steven Rostedt (VMware) wrote: > From: "Steven Rostedt (VMware)" > > If a ftrace callback does not supply its own recursion protection and > does not set the RECURSION_SAFE flag in its ftrace_ops, then ftrace will > make a helper trampoline to do so before

Re: [PATCH v2 00/16] PCI: dwc: Another round of clean-ups

2020-11-06 Thread Marek Szyprowski
Hi Rob, On 05.11.2020 22:11, Rob Herring wrote: > Here's another batch of DWC PCI host refactoring. This series primarily > moves more of the MSI, link up, and resource handling to the core > code. Beyond a couple of minor fixes, new in this version is runtime > detection of iATU regions instead

Re: [PATCH 03/18] powerpc: bad_page_fault, do_break get registers from regs

2020-11-06 Thread Christophe Leroy
Le 05/11/2020 à 15:34, Nicholas Piggin a écrit : This also moves the 32s DABR match to C. Is there a real benefit doing this ? Similar to the previous patch this makes interrupt handler function types more regular so they can be wrapped with the next patch. bad_page_fault and do_break

Re: [PATCH 02/18] powerpc: remove arguments from fault handler functions

2020-11-06 Thread Christophe Leroy
Le 05/11/2020 à 15:34, Nicholas Piggin a écrit : Make mm fault handlers all just take the pt_regs * argument and load DAR/DSISR from that. Make those that return a value return long. This is done to make the function signatures match other handlers, which will help with a future patch to add

[PATCH] powerpc/64s: Remove RFI

2020-11-06 Thread Christophe Leroy
Last use of RFI on PPC64 was removed by commit b8e90cb7bc04 ("powerpc/64: Convert the syscall exit path to use RFI_TO_USER/KERNEL"). Remove the macro. Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/ppc_asm.h | 1 - 1 file changed, 1 deletion(-) diff --git

Re: Kernel panic from malloc() on SUSE 15.1?

2020-11-06 Thread Michael Ellerman
Carl Jacobsen writes: > On Thu, Nov 5, 2020 at 2:19 AM Michael Ellerman wrote: > >> Carl Jacobsen writes: >> > The panic (on a call to malloc from static linked libcrypto) looks like >> > this: >> >> What hardware is this on? >> > > Thank you for looking into this. > > The system that's

Re: Kernel panic from malloc() on SUSE 15.1?

2020-11-06 Thread Michal Suchánek
On Mon, Nov 02, 2020 at 12:14:27PM -0800, Carl Jacobsen wrote: > I've got a SUSE 15.1 install (on ppc64le) that kernel panics on a very > simple > test program, built in a slightly unusual way. > > I'm compiling on SUSE 12, using gcc 4.8.3. I'm linking to a static > copy of libcrypto.a (from

Re: [PATCH 11/11 v3] ftrace: Add recording of functions that caused recursion

2020-11-06 Thread Petr Mladek
On Thu 2020-11-05 21:32:46, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > This adds CONFIG_FTRACE_RECORD_RECURSION that will record to a file > "recursed_functions" all the functions that caused recursion while a > callback to the function tracer was running. > > Changes since v2:

[PATCH] powerpc/mm: Refactor the floor/ceiling check in hugetlb range freeing functions

2020-11-06 Thread Christophe Leroy
All hugetlb range freeing functions have a verification like the following, which only differs by the mask used, depending on the page table level. start &= MASK; if (start < floor) return; if (ceiling) { ceiling &= MASK; if

Re: [PATCH 11/11 v3] ftrace: Add recording of functions that caused recursion

2020-11-06 Thread Steven Rostedt
On Fri, 6 Nov 2020 14:13:17 +0100 Petr Mladek wrote: > JFYI, the code reading and writing the cache looks good to me. > > It is still possible that some entries might stay unused (filled > with zeroes) but it should be hard to hit in practice. It > is good enough from my POV. You mean the part

Re: [PATCH 11/11 v3] ftrace: Add recording of functions that caused recursion

2020-11-06 Thread Petr Mladek
On Fri 2020-11-06 08:41:31, Steven Rostedt wrote: > On Fri, 6 Nov 2020 14:13:17 +0100 > Petr Mladek wrote: > > > JFYI, the code reading and writing the cache looks good to me. > > > > It is still possible that some entries might stay unused (filled > > with zeroes) but it should be hard to hit

[RFC PATCH 0/9] powerpc/64s: fast interrupt exit

2020-11-06 Thread Nicholas Piggin
This series attempts to improve the speed of interrupts and system calls in two major ways. Firstly, the SRR/HSRR registers do not need to be reloaded if they were not used or clobbered fur the duration of the interrupt. Secondly, an alternate return location facility is added for soft-masked

[RFC PATCH 8/9] powerpc/64s: interrupt soft-enable race fix

2020-11-06 Thread Nicholas Piggin
Prevent interrupt restore from allowing racing hard interrupts going ahead of previous soft-pending ones, by using the soft-masked restart handler to allow a store to clear the soft-mask while knowing nothing is soft-pending. This probably doesn't matter much in practice, but it's a simple

Re: [PATCH 02/29] powerpc/rtas: prevent suspend-related sys_rtas use on LE

2020-11-06 Thread Andrew Donnellan
On 30/10/20 11:10 pm, Nathan Lynch wrote: And there's a zero chance that drmgr will ever be fixed on LE? It's always used the sysfs interface on LE, and the only way to provoke it to attempt the syscalls is by doing something like this before running the migration: # echo 0 >

[RFC PATCH 3/9] powerpc/64s: introduce different functions to return from SRR vs HSRR interrupts

2020-11-06 Thread Nicholas Piggin
This makes no real difference yet except that HSRR type interrupts will use hrfid to return. This is important for the next patch. Signed-off-by: Nicholas Piggin --- arch/powerpc/kernel/entry_64.S | 58 +++-- arch/powerpc/kernel/exceptions-64s.S | 78

[RFC PATCH 1/9] powerpc/64s: syscall real mode entry use mtmsrd rather than rfid

2020-11-06 Thread Nicholas Piggin
Have the real mode system call entry handler branch to the kernel 0xc000... address and then use mtmsrd to enable the MMU, rather than use SRRs and rfid. Commit 8729c26e675c ("powerpc/64s/exception: Move real to virt switch into the common handler") implemented this style of real mode entry for

[RFC PATCH 7/9] powerpc/64s: allow alternate return locations for soft-masked interrupts

2020-11-06 Thread Nicholas Piggin
This is a variation of the exception table code which adjusts a failed page fault return location if it was taken at an address specified in an exception table, to a corresponding fixup handler address. This patch adds a similar masked interrupt restart table that is checked when when an

[RFC PATCH 4/9] powerpc/64s: avoid reloading (H)SRR registers if they are still valid

2020-11-06 Thread Nicholas Piggin
When an interrupt is taken, the SRR registers are set to return to where it left off. Unless they are modified in the meantime, or the return address or MSR are modified, there is no need to reload these registers when returning from interrupt. Introduce per-CPU flags that track the validity of

Re: [PATCH 02/29] powerpc/rtas: prevent suspend-related sys_rtas use on LE

2020-11-06 Thread Nathan Lynch
Andrew Donnellan writes: > On 30/10/20 11:10 pm, Nathan Lynch wrote: >>> And there's a zero chance that drmgr will ever be fixed on LE? >> >> It's always used the sysfs interface on LE, and the only way to provoke >> it to attempt the syscalls is by doing something like this before >> running

[RFC PATCH 5/9] powerpc/64: move interrupt return asm to interrupt_64.S

2020-11-06 Thread Nicholas Piggin
The next patch would like to move interrupt return assembly code to a low location before general text, so move it into its own file and include via head_64.S Signed-off-by: Nicholas Piggin --- arch/powerpc/include/asm/head-64.h | 2 +- arch/powerpc/kernel/entry_64.S | 601

[RFC PATCH 6/9] powerpc/64s: save one more register in the masked interrupt handler

2020-11-06 Thread Nicholas Piggin
This frees up one more register (and takes advantage of that to clean things up a little bit). This register will be used in the following patch. Signed-off-by: Nicholas Piggin --- arch/powerpc/kernel/exceptions-64s.S | 34 1 file changed, 20 insertions(+), 14

[RFC PATCH 2/9] powerpc/64s: system call avoid setting MSR[RI] until we set MSR[EE]

2020-11-06 Thread Nicholas Piggin
This extends the MSR[RI]=0 window a little further into the system call in order to pair RI and EE enabling with a single mtmsrd. XXX: May need to make this radix-only opt. - might take SLB or HPT faults on the context tracking, etc. Signed-off-by: Nicholas Piggin ---

[RFC PATCH 9/9] powerpc/64s: use interrupt restart table to speed up return from interrupt

2020-11-06 Thread Nicholas Piggin
The restart table facility is used to return from interrupt without disabling MSR[EE] or MSR[RI]. Interrupt return code is put into the low soft-masked region, and critical code that has return SRRs set, soft-masked state set with no soft-pending interrupts to replay, and no exit work, is put

Re: [PATCH net-next] Revert ibmvnic merge do_change_param_reset into do_reset

2020-11-06 Thread ljp
On 2020-11-06 13:17, Dany Madden wrote: This reverts commit 16b5f5ce351f8709a6b518cc3cbf240c378305bf where it restructures do_reset. There are patches being tested that would require major rework if this is committed first. We will resend this after the other patches have been applied. I

[PATCH v2 23/23] mtd: devices: powernv_flash: Add function names to headers and fix 'dev'

2020-11-06 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/mtd/devices/powernv_flash.c:129: warning: Cannot understand * @mtd: the device drivers/mtd/devices/powernv_flash.c:145: warning: Cannot understand * @mtd: the device drivers/mtd/devices/powernv_flash.c:161: warning: Cannot understand

[PATCH net-next] Revert ibmvnic merge do_change_param_reset into do_reset

2020-11-06 Thread Dany Madden
This reverts commit 16b5f5ce351f8709a6b518cc3cbf240c378305bf where it restructures do_reset. There are patches being tested that would require major rework if this is committed first. We will resend this after the other patches have been applied. Signed-off-by: Dany Madden ---

Re: [PATCH net-next] Revert ibmvnic merge do_change_param_reset into do_reset

2020-11-06 Thread Jakub Kicinski
On Fri, 06 Nov 2020 13:30:25 -0600 ljp wrote: > On 2020-11-06 13:17, Dany Madden wrote: > > This reverts commit 16b5f5ce351f8709a6b518cc3cbf240c378305bf > > where it restructures do_reset. There are patches being tested that > > would require major rework if this is committed first. > > > > We

Re: [PATCH net-next] Revert ibmvnic merge do_change_param_reset into do_reset

2020-11-06 Thread ljp
On 2020-11-06 13:42, Jakub Kicinski wrote: On Fri, 06 Nov 2020 13:30:25 -0600 ljp wrote: On 2020-11-06 13:17, Dany Madden wrote: > This reverts commit 16b5f5ce351f8709a6b518cc3cbf240c378305bf > where it restructures do_reset. There are patches being tested that > would require major rework if

Re: [PATCH net-next] Revert ibmvnic merge do_change_param_reset into do_reset

2020-11-06 Thread ljp
On 2020-11-06 13:42, Jakub Kicinski wrote: On Fri, 06 Nov 2020 13:30:25 -0600 ljp wrote: On 2020-11-06 13:17, Dany Madden wrote: > This reverts commit 16b5f5ce351f8709a6b518cc3cbf240c378305bf > where it restructures do_reset. There are patches being tested that > would require major rework if

[PATCH v2 00/23] Rid W=1 warnings in MTD

2020-11-06 Thread Lee Jones
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. v1 => v2: - Added tags - Satisfied Miquel's review comments Lee Jones (23): mtd: mtdpart: Fix misdocumented function parameter 'mtd' mtd: