On Wed, Apr 15, 2015 at 01:50:42PM -0700, Sukadev Bhattiprolu wrote:
SNIP
> |
> | - to blindly follow some poorly constructed vendor format with no
> |high level structure, that IMHO didn't work very well when OProfile
> |was written, and misrepresenting it as 'symbolic event names'.
On Fri, Apr 17, 2015 at 01:09:54PM -0700, Andi Kleen wrote:
> On Fri, Apr 17, 2015 at 05:31:26PM +0200, Jiri Olsa wrote:
> > On Wed, Apr 15, 2015 at 01:50:42PM -0700, Sukadev Bhattiprolu wrote:
> >
> > SNIP
> >
> > > |
> > > | - to blindly follow
On Wed, Apr 15, 2015 at 01:50:42PM -0700, Sukadev Bhattiprolu wrote:
SNIP
>
> |
> | - to add an ABI to support those vendor files
> |
> | And those are IMHO five good technical reasons to disagree with your
> | approach.
> |
> | My suggestion to resolve the technical objections and lift the
On Fri, May 01, 2015 at 12:05:41AM -0700, Sukadev Bhattiprolu wrote:
SNIP
> +
> +static int pmu_add_cpu_aliases(char *cpustr, void *data)
> +{
> + struct list_head *head = (struct list_head *)data;
> + struct perf_pmu_alias *alias;
> + int i;
> + struct perf_pmu_event *events_tabl
On Tue, May 19, 2015 at 05:02:08PM -0700, Sukadev Bhattiprolu wrote:
SNIP
> ---
> tools/perf/Build |1 +
> tools/perf/Makefile.perf |4 +-
> tools/perf/pmu-events/Build| 38 ++
> tools/perf/pmu-events/README | 67
> tools/perf/pmu-events
On Tue, May 19, 2015 at 05:02:08PM -0700, Sukadev Bhattiprolu wrote:
SNIP
> +int main(int argc, char *argv[])
> +{
> + int rc;
> + int flags;
SNIP
> +
> + rc = uname(&uts);
> + if (rc < 0) {
> + printf("%s: uname() failed: %s\n", argv[0], strerror(errno));
> +
On Fri, May 22, 2015 at 08:58:22AM -0700, Sukadev Bhattiprolu wrote:
SNIP
> |
> | there's no concetion (yet) in the new build system to trigger
> | another binery build as a dependency for object file.. I'd
> | rather do this the framework way, please check attached patch
> |
> | also currently
n perf (although jevents try to recover from
> some and continue the build by leaving out event aliases).
>
> - For architectures that don't have any JSON files, an empty mapping
> table is created and they should continue to build)
>
> Thanks to
perf (although jevents try to recover from
> some and continue the build by leaving out event aliases).
>
> - For architectures that don't have any JSON files, an empty mapping
> table is created and they should continue to build)
>
> Thanks to inpu
On Wed, May 27, 2015 at 11:59:04PM +0900, Namhyung Kim wrote:
> Hi Andi,
>
> On Wed, May 27, 2015 at 11:40 PM, Andi Kleen wrote:
> >> So we build tables of all models in the architecture, and choose
> >> matching one when compiling perf, right? Can't we do that when
> >> building the tables? IO
On Wed, May 27, 2015 at 02:23:21PM -0700, Sukadev Bhattiprolu wrote:
SNIP
>
> diff --git a/tools/perf/pmu-events/Build b/tools/perf/pmu-events/Build
> new file mode 100644
> index 000..7e0c85c
> --- /dev/null
> +++ b/tools/perf/pmu-events/Build
> @@ -0,0 +1,10 @@
> +jevents-y+= json.o j
On Wed, May 27, 2015 at 02:23:21PM -0700, Sukadev Bhattiprolu wrote:
SNIP
>
> $(PERF_IN): $(OUTPUT)PERF-VERSION-FILE $(OUTPUT)common-cmds.h FORCE
> $(Q)$(MAKE) $(build)=perf
>
> -$(OUTPUT)perf: $(PERFLIBS) $(PERF_IN)
> - $(QUIET_LINK)$(CC) $(CFLAGS) $(LDFLAGS) $(PERF_IN) $(LIBS) -o
On Wed, May 27, 2015 at 02:23:28PM -0700, Sukadev Bhattiprolu wrote:
> From: Andi Kleen
>
> Add a --no-desc flag to perf list to not print the event descriptions
> that were earlier added for JSON events. This may be useful to
> get a less crowded listing.
>
> It's still default to print descrip
On Wed, May 27, 2015 at 02:23:23PM -0700, Sukadev Bhattiprolu wrote:
> From: Andi Kleen
>
> Support a header line in the mapfile.csv, to match the existing
> mapfiles
>
> Signed-off-by: Andi Kleen
> ---
> tools/perf/pmu-events/jevents.c |2 ++
> 1 file changed, 2 insertions(+)
>
> diff --
On Thu, May 28, 2015 at 01:42:06PM +0200, Jiri Olsa wrote:
SNIP
> > g...@github.com:sukadev/linux.git #branch json-v11
>
> could you please also pull in Andi's changes with x86 events?
> it seems to be under his tree branch perf/builtin-json-2,
> follwing commits:
On Wed, May 27, 2015 at 02:23:22PM -0700, Sukadev Bhattiprolu wrote:
> At run time, (i.e when perf is starting up), locate the specific events
> table for the current CPU and create event aliases for each of the events.
>
> Use these aliases to parse user's specified perf event.
>
> Signed-off-by
On Thu, May 28, 2015 at 10:45:06PM -0700, Sukadev Bhattiprolu wrote:
> Jiri Olsa [jo...@redhat.com] wrote:
> | > if (line[0] == '#' || line[0] == '\n')
> | > continue;
> | > + if (!strncmp(line, "Family", 6))
&g
On Fri, May 29, 2015 at 10:49:27PM -0700, Andi Kleen wrote:
> On Fri, May 29, 2015 at 11:13:15AM +0200, Jiri Olsa wrote:
> > On Thu, May 28, 2015 at 10:45:06PM -0700, Sukadev Bhattiprolu wrote:
> > > Jiri Olsa [jo...@redhat.com] wrote:
> > > | > if (li
On Tue, Jun 02, 2015 at 10:12:03AM -0700, Sukadev Bhattiprolu wrote:
SNIP
> +
> +/*
> + * From the pmu_events_map, find the table of PMU events that corresponds
> + * to the current running CPU. Then, add all PMU events from that table
> + * as aliases.
> + */
> +static int pmu_add_cpu_aliases(vo
On Tue, Jun 02, 2015 at 10:12:02AM -0700, Sukadev Bhattiprolu wrote:
SNIP
> +
> +static char *file_name_to_table_name(char *fname)
> +{
> + unsigned int i, j;
> + int c;
> + int n = 1024; /* use max variable length? */
I think this should be at least PATH_MAX, or you might
On Tue, Jun 02, 2015 at 10:12:03AM -0700, Sukadev Bhattiprolu wrote:
SNIP
>
> +/*
> + * Return the CPU id as a raw string.
> + *
> + * Each architecture should provide a more precise id string that
> + * can be use to match the architecture's "mapfile".
> + */
> +char *__attribute__((weak))get_
.
>
> Signed-off-by: Sukadev Bhattiprolu
>
> Changelog[v3]
> [Jiri Olsa] Fix a memory leak with cpuid.
>
> Changelog[v2]
> [Andi Kleen] Replace the pmu_events_map->vfm field with a simple
> generic "cpuid" string and use that
On Tue, Jun 02, 2015 at 10:12:02AM -0700, Sukadev Bhattiprolu wrote:
SNIP
> + * If we fail to locate/process JSON and map files, create a NULL mapping
> + * table. This would at least allow perf to build even if we can't find/use
> + * the aliases.
> + */
> +static void create_empty_mapping(const
On Tue, Jun 02, 2015 at 10:12:03AM -0700, Sukadev Bhattiprolu wrote:
SNIP
> @@ -225,26 +221,47 @@ static int perf_pmu__new_alias(struct list_head *list,
> char *dir, char *name, FI
> alias->unit[0] = '\0';
> alias->per_pkg = false;
>
> - ret = parse_events_terms(&alias->terms,
On Tue, Jun 02, 2015 at 10:12:06AM -0700, Sukadev Bhattiprolu wrote:
SNIP
> @@ -1033,37 +1064,49 @@ void print_pmu_events(const char *event_glob, bool
> name_only)
> event_glob
> continue;
>
> -
On Tue, Jun 02, 2015 at 10:12:04AM -0700, Sukadev Bhattiprolu wrote:
> From: Andi Kleen
>
> The Intel events use a dot to separate event name and unit mask.
> Allow dot in names in the scanner, and remove special handling
> of dot as EOF. Also remove the hack in jevents to replace dot
> with unde
On Tue, Jun 02, 2015 at 10:12:11AM -0700, Sukadev Bhattiprolu wrote:
> From: Andi Kleen
>
> Previously we were dropping the useful longer descriptions that some
> events have in the event list completely. This patch makes them appear with
> perf list.
>
> Old perf list:
>
> baclears:
> baclea
On Tue, Jun 02, 2015 at 12:16:41PM -0700, Sukadev Bhattiprolu wrote:
SNIP
>[Speculative and retired macro-conditional branches]
> br_inst_exec.all_direct_jmp
>[Speculative and retired macro-unconditional branches excluding calls
> and indirects]
> br_inst_exec.all_direct_near
On Tue, Jun 02, 2015 at 10:12:13AM -0700, Sukadev Bhattiprolu wrote:
> From: Andi Kleen
>
> Support a header line in the mapfile.csv, to match the existing
> mapfiles
'Suport' means 'skip' in here
jirka
>
> Signed-off-by: Andi Kleen
> Signed-off-by: Sukadev Bhattiprolu
>
> Changelog[v2]
>
On Tue, Jun 02, 2015 at 10:12:02AM -0700, Sukadev Bhattiprolu wrote:
SNIP
> +
> +static int process_mapfile(FILE *outfp, char *fpath)
> +{
> + int n = 16384;
> + FILE *mapfp;
> + char *save;
> + char *line, *p;
> + int line_num;
> + char *tblname;
> +
> + pr_info("%s:
On Wed, Jun 03, 2015 at 05:57:33AM -0700, Andi Kleen wrote:
> > please split at least the jevents Topic parsing from the rest
> > idelay also the alias update and the display change
>
> What's the point of all these splits? It's already one logical unit,
> not too large, and is bisectable.
splitt
27; ...
>
> Changelog[v3]
> - [Jiri Olsa] Changed the event parameters are specified. If
> event file specifes 'param=val' make the usage 'param=123'
> rather than 'val=123'. (patch 1,2/10)
> - Shortened event names usi
On Tue, Sep 23, 2014 at 12:33:45AM +0300, Aaro Koskinen wrote:
> Hi,
>
> On Wed, Jun 25, 2014 at 08:49:03AM -0700, Sukadev Bhattiprolu wrote:
> > powerpc/perf: Adjust callchain based on DWARF debug info
> >
> > When saving the callchain on Power, the kernel conservatively saves excess
> > entries
On Wed, Sep 24, 2014 at 12:27:15PM -0700, Sukadev Bhattiprolu wrote:
> From: Cody P Schafer
>
> Enable event specification like:
>
> pmu/event_name,param1=0x1,param2=0x4/
>
> Assuming that
>
> /sys/bus/event_source/devices/pmu/events/event_name
>
> Contains something like
>
>
On Thu, Sep 25, 2014 at 07:25:20PM -0700, Sukadev Bhattiprolu wrote:
> Jiri Olsa [jo...@redhat.com] wrote:
> | On Wed, Sep 24, 2014 at 12:27:15PM -0700, Sukadev Bhattiprolu wrote:
> | > From: Cody P Schafer
> | >
> | > Enable event specification like:
> | >
>
On Tue, Dec 02, 2014 at 06:09:35PM -0800, Sukadev Bhattiprolu wrote:
> From: Cody P Schafer
>
> Enable event specification like:
>
> pmu/event_name,param1=0x1,param2=0x4/
>
> Assuming that
>
> /sys/bus/event_source/devices/pmu/events/event_name
>
> Contains something like
>
>
On Fri, Dec 05, 2014 at 06:05:26PM -0500, Cody P Schafer wrote:
> On Thu, Dec 4, 2014 at 7:44 AM, Jiri Olsa wrote:
> > On Tue, Dec 02, 2014 at 06:09:35PM -0800, Sukadev Bhattiprolu wrote:
> >> From: Cody P Schafer
> >>
> >> Enable event specification like:
&
On Sat, Dec 06, 2014 at 11:37:24PM -0800, Sukadev Bhattiprolu wrote:
> Jiri Olsa [jo...@redhat.com] wrote:
>
> | anyway we could assign directly to the param term name as you do,
> | but I think we just need to mark the term as parametrized, like:
> |
> | in /sys/bus/event_
On Sun, Dec 21, 2014 at 11:49:24PM -0800, Sukadev Bhattiprolu wrote:
SNIP
> + }
>
> switch (format->value) {
> case PERF_PMU_FORMAT_VALUE_CONFIG:
> @@ -592,11 +629,16 @@ static int pmu_config_term(struct list_head *formats,
> }
>
> /*
> - * XXX If we ever deci
On Sun, Dec 21, 2014 at 11:49:26PM -0800, Sukadev Bhattiprolu wrote:
> From: Cody P Schafer
>
> Event parameters are a basic way for partial events to be specified in
> sysfs with per-event names given to the fields that need to be filled in
> when using a particular event.
>
> It is intended fo
On Sun, Dec 21, 2014 at 11:49:27PM -0800, Sukadev Bhattiprolu wrote:
> From: Cody P Schafer
>
> Changelog[v6]:
> - [Sukadev Bhattiprolu]: Update documentation of perf-list and
> perf-record; Added documentation for perf-stat.
>
> CC: Haren Myneni
> CC: Cody P Schafer
> Signed-off
On Mon, Dec 22, 2014 at 11:34:36AM -0800, Sukadev Bhattiprolu wrote:
> Jiri Olsa [jo...@redhat.com] wrote:
> | On Sun, Dec 21, 2014 at 11:49:26PM -0800, Sukadev Bhattiprolu wrote:
> | > From: Cody P Schafer
> | > + In the case of the last example, a value r
On Mon, Dec 22, 2014 at 11:30:45AM -0800, Sukadev Bhattiprolu wrote:
> Jiri Olsa [jo...@redhat.com] wrote:
> | On Sun, Dec 21, 2014 at 11:49:24PM -0800, Sukadev Bhattiprolu wrote:
> |
> | SNIP
> |
> | > + }
> | >
> | > switch (format->value) {
>
so now uses parameters like 'core'
> and 'vcpu' rather than 'starting_index'.
>
> Changelog[v5]
> [Jiri Olsa, Peter Zijlstra] Use '$' to prefix parameterized events.
>
> Changelog[v4]
> [Jiri Olsa] If the parameter for an even
so now uses parameters like 'core'
> and 'vcpu' rather than 'starting_index'.
>
> Changelog[v5]
> [Jiri Olsa, Peter Zijlstra] Use '$' to prefix parameterized events.
>
> Changelog[v4]
> [Jiri Olsa] If the parameter for an even
> Enable event specification like:
>
> pmu/event_name,param1=0x1,param2=0x4/
>
> Assuming that
>
> /sys/bus/event_source/devices/pmu/events/event_name
>
> Contains something like
>
> param2=?,bar=1,param1=?
>
> Changelog[v6]:
>
hv_24x7/HPM_THREAD_NAP_CCYC__PHYS_CORE,core=?/
>
> This means that when provided as an event, a value for ? must also
> be supplied. For example:
>
> perf stat -e \
> 'hv_24x7/HPM_THREAD_NAP_CCYC__PHYS_CORE,core=2&#x
On Thu, Jun 04, 2015 at 11:27:17PM -0700, Sukadev Bhattiprolu wrote:
SNIP
> ---
> tools/perf/util/pmu.c | 80
> +++--
> tools/perf/util/pmu.h |1 +
> 2 files changed, 66 insertions(+), 15 deletions(-)
>
> diff --git a/tools/perf/util/pmu.c b/to
On Thu, Jun 04, 2015 at 11:27:23PM -0700, Sukadev Bhattiprolu wrote:
SNIP
> ---
> tools/perf/builtin-list.c | 11 ---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c
> index 3f058f7..d0f7a18 100644
> --- a/tools/
ated and they should continue to build)
>
> Thanks to input from Andi Kleen, Jiri Olsa, Namhyung Kim and Ingo Molnar.
>
> These patches are available from:
>
> https://github.com:sukadev/linux.git
>
>
On Fri, Jun 05, 2015 at 11:16:45AM -0700, Sukadev Bhattiprolu wrote:
SNIP
> | > hum, it should be 'v' , right?
>
> Good catch. Fixed.
> |
> | Yes that's right.
> |
> | Also BTW need to add the new option to the usage line a few lines below.
>
> How about we do this for consistency with 'perf
On Tue, Dec 18, 2012 at 11:28:02PM -0800, Sukadev Bhattiprolu wrote:
>
> Rename EVENT_ATTR() and EVENT_PTR() PMU_EVENT_ATTR() and PMU_EVENT_PTR().
> Make them global so they are available to all architectures.
>
> Further to allow architectures flexibility, have PMU_EVENT_PTR() pass in the
> vari
On Tue, Jan 15, 2013 at 03:57:59PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Jan 09, 2013 at 05:07:03PM -0800, Sukadev Bhattiprolu escreveu:
> > [PATCH 6/6][v3] perf: Document the ABI of perf sysfs entries
> >
> > This patchset addes two new sets of files to sysfs:
> >
> > - generic an
On Wed, Jan 16, 2013 at 10:58:16AM -0800, Sukadev Bhattiprolu wrote:
> Jiri Olsa [jo...@redhat.com] wrote:
> | On Tue, Jan 15, 2013 at 03:57:59PM -0300, Arnaldo Carvalho de Melo wrote:
> | > Em Wed, Jan 09, 2013 at 05:07:03PM -0800, Sukadev Bhattiprolu escreveu:
> | > >
util/pmu.c
> +++ b/tools/perf/util/pmu.c
> @@ -548,7 +548,7 @@ void perf_pmu__set_format(unsigned long *bits, long from,
> long to)
> if (!to)
> to = from;
>
> - memset(bits, 0, BITS_TO_LONGS(PERF_PMU_FORMAT_BITS));
> + memset(bits, 0, BITS_TO_B
On Fri, Jan 18, 2013 at 05:30:52PM -0800, Sukadev Bhattiprolu wrote:
> From 4d266e5040c33103f5d226b0d16b89f8ef79e3ad Mon Sep 17 00:00:00 2001
> From: Sukadev Bhattiprolu
> Date: Fri, 18 Jan 2013 11:14:28 -0800
> Subject: [PATCH] perf: Fix compile warnings in tests/attr.c
>
> Replace '%llu' in pri
On Mon, Jan 21, 2013 at 01:38:23PM -0800, Sukadev Bhattiprolu wrote:
> Jiri Olsa [jo...@redhat.com] wrote:
> | On Fri, Jan 18, 2013 at 05:30:52PM -0800, Sukadev Bhattiprolu wrote:
SNIP
> __u64 is 'unsigned long long' on x86 and PRIu64 is 'llu' which is fine.
>
On Fri, Jan 18, 2013 at 09:46:54AM -0800, Sukadev Bhattiprolu wrote:
> Jiri Olsa [jo...@redhat.com] wrote:
SNIP
> +
> +Contact: Linux kernel mailing list
> + Linux Powerpc mailing list
> +
> +Description: POWER-systems specific performance
On Tue, May 20, 2014 at 06:26:44PM -0700, Sukadev Bhattiprolu wrote:
SNIP
> + *
> + * The value in LR is only needed when it holds a return address. If the
> + * return address is on the stack, we should ignore the LR value.
> + *
> + * Further, when the return address is in the LR, if a new fram
On Tue, May 20, 2014 at 06:26:44PM -0700, Sukadev Bhattiprolu wrote:
SNIP
> + * TODO:
> + * Rather than returning an index into the callchain and have the
> + * caller skip that entry, we could modify the callchain in-place
> + * by putting a PERF_CONTEXT_IGNORE marker in the affected entry
On Thu, Jun 05, 2014 at 08:21:09PM -0700, Sukadev Bhattiprolu wrote:
SNIP
> index 7409ac8..3f97cf2 100644
> --- a/tools/perf/util/machine.c
> +++ b/tools/perf/util/machine.c
> @@ -1288,8 +1288,10 @@ static int machine__resolve_callchain_sample(struct
> machine *machine,
> {
> u8 cpumode =
On Tue, Jun 24, 2014 at 05:00:52PM -0700, Sukadev Bhattiprolu wrote:
> [PATCH v5 1/1] powerpc/perf: Adjust callchain based on DWARF debug info
superflous ^^^
>
> When saving the callchain on Power, the kernel conservatively saves excess
> entries in the callchain. A few of these entries are need
On Fri, Aug 15, 2014 at 12:26:09AM -0700, Sukadev Bhattiprolu wrote:
> From: Cody P Schafer
>
> What this patchset does:
>
> - the first patch (override sysfs in tools/perf via SYSFS_PATH) was sent out
>previously, but needed a resend anyhow. Having it is useful for testing the
>later c
On Wed, Mar 05, 2014 at 08:41:56PM -0800, Sukadev Bhattiprolu wrote:
> When we try to create backtraces (call-graphs) with the perf tool
>
> perf record -g /tmp/sprintft
>
> we get backtraces with duplicate arcs for sprintft[1]:
>
> 14.61% sprintft libc-2.18.so [.] __random
On Thu, Mar 06, 2014 at 12:33:32PM +0100, Gabriel Paubert wrote:
> On Thu, Mar 06, 2014 at 09:44:47AM +, David Laight wrote:
> > From: Sukadev Bhattiprolu
> > > When checking whether a bit representing a register is set in
> > > sample_regs, a 64-bit mask, use 64-bit value (1LL).
> > >
> > > S
On Sun, Dec 21, 2014 at 11:48:46PM -0800, Sukadev Bhattiprolu wrote:
> From: Cody P Schafer
>
> (struct perf_pmu_events_attr) is defined in include/linux/perf_event.h,
> but the only "show" for it is in x86 and contains x86 specific stuff.
>
> Make a generic one for those of us who are just usin
On Mon, Jan 26, 2015 at 05:43:03PM -0800, Sukadev Bhattiprolu wrote:
SNIP
>
>
> Cody P Schafer (6):
> perf: provide sysfs_show for struct perf_pmu_events_attr
> perf: add PMU_EVENT_ATTR_STRING() helper
> powerpc/perf/hv-24x7: parse catalog and populate sysfs with events
> powerpc/perf/{
On Wed, Jan 28, 2015 at 11:54:38AM +1100, Michael Ellerman wrote:
> On Tue, 2015-01-27 at 11:02 +0100, Jiri Olsa wrote:
> > On Mon, Jan 26, 2015 at 05:43:03PM -0800, Sukadev Bhattiprolu wrote:
> >
> > SNIP
> >
> > >
> > >
> > > Cody P Sc
On Mon, Feb 09, 2015 at 11:07:38AM +0100, Ingo Molnar wrote:
>
> * Peter Zijlstra wrote:
>
> > On Fri, Feb 06, 2015 at 04:43:54PM -0600, Tom Huynh wrote:
> > > arch/powerpc/perf/e6500-events-list.h | 289
> > > ++
> >
> > That's a lot of events to stuff in the k
On Sat, Mar 26, 2016 at 11:01:47AM -0700, Sukadev Bhattiprolu wrote:
> From 502e8236082412db1d33abfad95aaf14b539502e Mon Sep 17 00:00:00 2001
> From: Sukadev Bhattiprolu
> Date: Sat, 26 Mar 2016 17:31:39 -0400
> Subject: [PATCH 1/1] perf tools: Fix build break on powerpc
> MIME-Version: 1.0
> Cont
json-v16Source Code only
> | json-files-7x86 and Powerpc datafiles only
> | json-v16.1-with-dataBoth code and data (for build/test)
>
> Arnaldo, Ingo,
>
> I have not received any comments on this patch set since it was Acked by
> Jiri Olsa
On Tue, Sep 29, 2015 at 11:06:17AM +0530, Naveen N. Rao wrote:
> On 2015/09/24 10:15PM, Naveen N Rao wrote:
> > On 2015/09/24 08:32AM, Stephane Eranian wrote:
> > > On Thu, Sep 24, 2015 at 5:57 AM, Jiri Olsa wrote:
> > > >
> > > > On Thu, Sep 24, 201
On Tue, Sep 29, 2015 at 01:30:10PM +0530, Naveen N. Rao wrote:
SNIP
> > > Suka has also posted a fix for this with a different approach [1]. Can
> > > you please ack/pull one of these versions? Building perf is broken on
> > > v4.3-rc due to this.
> >
> > I did not get any answer for additiona
On Tue, Sep 29, 2015 at 10:01:36PM +0530, Naveen N. Rao wrote:
> On 2015/09/29 12:47PM, Jiri Olsa wrote:
> > On Tue, Sep 29, 2015 at 01:30:10PM +0530, Naveen N. Rao wrote:
> >
> > SNIP
> >
> > > > > Suka has also posted a fix for this with a different a
On Tue, Sep 29, 2015 at 11:10:02AM -0700, Sukadev Bhattiprolu wrote:
SNIP
>
> diff --git a/tools/perf/util/perf_regs.c b/tools/perf/util/perf_regs.c
> index 885e8ac..6b8eb13 100644
> --- a/tools/perf/util/perf_regs.c
> +++ b/tools/perf/util/perf_regs.c
> @@ -6,6 +6,7 @@ const struct sample_reg
)' function (due to the static inline version
> in util/perf_regs.h). So use #ifdef HAVE_PERF_REGS_SUPPORT' around that
> function.
>
> Signed-off-by: Sukadev Bhattiprolu
Acked-by: Jiri Olsa
thanks,
jirka
___
Linuxppc-dev mail
perf. So I separate
> them into 3 patches. Please help me test it on PowerPC.
>
> Cc: Arnaldo Carvalho de Melo
> Cc: Jiri Olsa
> Cc: Naveen N. Rao
> Cc: Sukadev Bhattiprolu
>
> Naveen N. Rao (1):
> perf: bpf: Fix build breakage due to libbpf
>
> Wang Nan (2)
On Wed, Jan 06, 2016 at 03:15:50PM +0530, Anju T wrote:
SNIP
> + [PERF_REG_POWERPC_GPR28] = "gpr28",
> + [PERF_REG_POWERPC_GPR29] = "gpr29",
> + [PERF_REG_POWERPC_GPR30] = "gpr30",
> + [PERF_REG_POWERPC_GPR31] = "gpr31",
> + [PERF_REG_POWERPC_NIP] = "nip",
> + [PERF_REG_PO
On Fri, Jan 08, 2016 at 02:32:30PM +0530, Anju T wrote:
SNIP
> +#endif /* ARCH_PERF_REGS_H */
> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> index 38a0853..acf0302 100644
> --- a/tools/perf/config/Makefile
> +++ b/tools/perf/config/Makefile
> @@ -23,6 +23,11 @@ $(call de
On Thu, Jan 07, 2016 at 06:23:03PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Jan 07, 2016 at 05:39:57PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Thu, Jan 07, 2016 at 12:28:15PM +0530, Naveen N. Rao escreveu:
> > > Can you please push at least the initial 3 patches of this for v4.4?
On Sat, Feb 29, 2020 at 03:11:57PM +0530, Kajol Jain wrote:
SNIP
> + *dst++ = paramval[i++];
> + free(paramval);
> + }
> + }
> else
> *dst++ = *str;
>
On Sat, Feb 29, 2020 at 03:11:57PM +0530, Kajol Jain wrote:
SNIP
> diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
> index 02aee946b6c1..f629828cc0de 100644
> --- a/tools/perf/util/metricgroup.c
> +++ b/tools/perf/util/metricgroup.c
> @@ -399,6 +399,11 @@ void metricgro
On Sat, Feb 29, 2020 at 03:11:57PM +0530, Kajol Jain wrote:
SNIP
> #define PVR_VER(pvr)(((pvr) >> 16) & 0x) /* Version field */
> #define PVR_REV(pvr)(((pvr) >> 0) & 0x) /* Revison field */
>
> +#define SOCKETS_INFO_FILE_PATH "/devices/hv_24x7/interface/"
> +
> int
> get_
On Mon, Mar 09, 2020 at 11:55:44AM +0530, Kajol Jain wrote:
> First patch of the patchset fix inconsistent results we are getting when
> we run multiple 24x7 events.
>
> Patchset adds json file metric support for the hv_24x7 socket/chip level
> events. "hv_24x7" pmu interface events needs system d
On Tue, Mar 10, 2020 at 03:18:36PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Mar 09, 2020 at 10:35:06AM +0100, Jiri Olsa escreveu:
> > On Mon, Mar 09, 2020 at 11:55:44AM +0530, Kajol Jain wrote:
> > > First patch of the patchset fix inconsistent results we are getting
On Mon, Mar 09, 2020 at 11:55:50AM +0530, Kajol Jain wrote:
SNIP
> diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
> index c3a8c701609a..11eeeb929b91 100644
> --- a/tools/perf/util/metricgroup.c
> +++ b/tools/perf/util/metricgroup.c
> @@ -474,6 +474,98 @@ static bool me
On Mon, Mar 09, 2020 at 11:55:50AM +0530, Kajol Jain wrote:
SNIP
> diff --git a/tools/perf/util/expr.l b/tools/perf/util/expr.l
> index 1928f2a3dddc..ec4b00671f67 100644
> --- a/tools/perf/util/expr.l
> +++ b/tools/perf/util/expr.l
> @@ -45,6 +45,21 @@ static char *normalize(char *str)
>
On Tue, Mar 10, 2020 at 03:34:55PM -0300, Arnaldo Carvalho de Melo wrote:
SNIP
> > diff --git a/tools/perf/arch/powerpc/util/header.c
> > b/tools/perf/arch/powerpc/util/header.c
> > index 3b4cdfc5efd6..036f6b2ce202 100644
> > --- a/tools/perf/arch/powerpc/util/header.c
> > +++ b/tools/perf/arch/
On Mon, Mar 09, 2020 at 11:55:50AM +0530, Kajol Jain wrote:
SNIP
> +static int metricgroup__add_metric_runtime_param(struct strbuf *events,
> + struct list_head *group_list, struct pmu_event *pe)
> +{
> + int i, count;
> + int ret = -EINVAL;
> +
> + count = arch_ge
On Mon, Mar 09, 2020 at 11:55:50AM +0530, Kajol Jain wrote:
SNIP
> diff --git a/tools/perf/util/expr.h b/tools/perf/util/expr.h
> index 9377538f4097..d17664e628db 100644
> --- a/tools/perf/util/expr.h
> +++ b/tools/perf/util/expr.h
> @@ -15,6 +15,7 @@ struct parse_ctx {
> struct parse_id id
On Tue, Mar 17, 2020 at 11:53:31AM +0530, Kajol Jain wrote:
SNIP
> diff --git a/tools/perf/util/expr.h b/tools/perf/util/expr.h
> index 0938ad166ece..7786829b048b 100644
> --- a/tools/perf/util/expr.h
> +++ b/tools/perf/util/expr.h
> @@ -17,12 +17,13 @@ struct expr_parse_ctx {
>
> struct expr_
On Tue, Mar 17, 2020 at 11:53:31AM +0530, Kajol Jain wrote:
SNIP
> diff --git a/tools/perf/arch/powerpc/util/header.c
> b/tools/perf/arch/powerpc/util/header.c
> index 3b4cdfc5efd6..dcc3c6ab2e67 100644
> --- a/tools/perf/arch/powerpc/util/header.c
> +++ b/tools/perf/arch/powerpc/util/header.c
>
On Tue, Mar 17, 2020 at 11:53:30AM +0530, Kajol Jain wrote:
> This patch refactor metricgroup__add_metric function where
> some part of it move to function metricgroup__add_metric_param.
> No logic change.
can't compile this change:
[jolsa@krava perf]$ make JOBS=1
BUILD: Doing 'make -j1' para
On Tue, Mar 17, 2020 at 11:53:30AM +0530, Kajol Jain wrote:
> This patch refactor metricgroup__add_metric function where
> some part of it move to function metricgroup__add_metric_param.
> No logic change.
>
> Signed-off-by: Kajol Jain
> ---
> tools/perf/util/metricgroup.c | 63 +
On Tue, Mar 17, 2020 at 11:53:30AM +0530, Kajol Jain wrote:
> This patch refactor metricgroup__add_metric function where
> some part of it move to function metricgroup__add_metric_param.
> No logic change.
>
> Signed-off-by: Kajol Jain
> ---
> tools/perf/util/metricgroup.c | 63 +
On Tue, Mar 17, 2020 at 11:53:31AM +0530, Kajol Jain wrote:
SBIP
> +static int metricgroup__add_metric_runtime_param(struct strbuf *events,
> + struct list_head *group_list, struct pmu_event *pe)
> +{
> + int i, count;
> + int ret = -EINVAL;
> +
> + count = arch_ge
On Fri, Mar 20, 2020 at 06:24:04PM +0530, Kajol Jain wrote:
SNIP
> diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
> index 52fb119d25c8..b4b91d8ad5be 100644
> --- a/tools/perf/util/metricgroup.c
> +++ b/tools/perf/util/metricgroup.c
> @@ -474,8 +474,13 @@ static bool me
On Fri, Mar 20, 2020 at 06:24:04PM +0530, Kajol Jain wrote:
> Patch enhances current metric infrastructure to handle "?" in the metric
> expression. The "?" can be use for parameters whose value not known while
> creating metric events and which can be replace later at runtime to
> the proper value
On Fri, Mar 27, 2020 at 03:55:26PM +0530, Kajol Jain wrote:
SNIP
> diff --git a/tools/perf/tests/expr.c b/tools/perf/tests/expr.c
> index ea10fc4412c4..516504cf0ea5 100644
> --- a/tools/perf/tests/expr.c
> +++ b/tools/perf/tests/expr.c
> @@ -10,7 +10,7 @@ static int test(struct expr_parse_ctx *ct
On Fri, Mar 27, 2020 at 03:55:26PM +0530, Kajol Jain wrote:
SNIP
>
> %%
> struct expr_scanner_ctx *sctx = expr_get_extra(yyscanner);
> @@ -93,7 +106,7 @@ if { return IF; }
> else { return ELSE; }
> #smt_on { return SMT_ON; }
> {number} { return value(y
1 - 100 of 173 matches
Mail list logo
