Re: [PATCH] powerpc/kprobes: Fix trap address when trap happened in real mode

Masami, Christophe, Apologies for pitching in late here... Masami Hiramatsu wrote: On Tue, 18 Feb 2020 12:04:41 +0100 Christophe Leroy wrote: >> Nevertheless, if one symbol has been forgotten in the blacklist, I think >> it is a problem if it generate Oopses. > > There is a long history

Re: [PATCH] powerpc/kprobes: Fix trap address when trap happened in real mode

Le 18/02/2020 à 13:33, Masami Hiramatsu a écrit : On Tue, 18 Feb 2020 12:04:41 +0100 Christophe Leroy wrote: Nevertheless, if one symbol has been forgotten in the blacklist, I think it is a problem if it generate Oopses. There is a long history also on x86 to make a blacklist. Anyway,

Re: [PATCH] powerpc/kprobes: Fix trap address when trap happened in real mode

On Tue, 18 Feb 2020 12:04:41 +0100 Christophe Leroy wrote: > >> Nevertheless, if one symbol has been forgotten in the blacklist, I think > >> it is a problem if it generate Oopses. > > > > There is a long history also on x86 to make a blacklist. Anyway, how did > > you get this error on PPC32?

Re: [PATCH] powerpc/kprobes: Fix trap address when trap happened in real mode

Le 18/02/2020 à 11:29, Masami Hiramatsu a écrit : On Tue, 18 Feb 2020 06:58:06 +0100 Christophe Leroy wrote: What do you mean by 'there' ? At the entry of kprobe_handler() ? That's what my patch does, it checks whether MMU is disabled or not. If it is, it converts the address to a

Re: [PATCH] powerpc/kprobes: Fix trap address when trap happened in real mode

On Tue, 18 Feb 2020 06:58:06 +0100 Christophe Leroy wrote: > > What do you mean by 'there' ? At the entry of kprobe_handler() ? > > That's what my patch does, it checks whether MMU is disabled or not. If > it is, it converts the address to a virtual address. > >

Re: [PATCH] powerpc/kprobes: Fix trap address when trap happened in real mode

Le 18/02/2020 à 01:44, Masami Hiramatsu a écrit : On Mon, 17 Feb 2020 16:38:50 +0100 Christophe Leroy wrote: Le 17/02/2020 à 11:27, Masami Hiramatsu a écrit : On Mon, 17 Feb 2020 10:03:22 +0100 Christophe Leroy wrote: Le 16/02/2020 à 13:34, Masami Hiramatsu a écrit : On Sat, 15

Re: [PATCH] powerpc/kprobes: Fix trap address when trap happened in real mode

On Mon, 17 Feb 2020 16:38:50 +0100 Christophe Leroy wrote: > > > Le 17/02/2020 à 11:27, Masami Hiramatsu a écrit : > > On Mon, 17 Feb 2020 10:03:22 +0100 > > Christophe Leroy wrote: > > > >> > >> > >> Le 16/02/2020 à 13:34, Masami Hiramatsu a écrit : > >>> On Sat, 15 Feb 2020 11:28:49 +0100

Re: [PATCH] powerpc/kprobes: Fix trap address when trap happened in real mode

On 02/17/2020 03:38 PM, Christophe Leroy wrote: Le 17/02/2020 à 11:27, Masami Hiramatsu a écrit : On Mon, 17 Feb 2020 10:03:22 +0100 Christophe Leroy wrote: Le 16/02/2020 à 13:34, Masami Hiramatsu a écrit : On Sat, 15 Feb 2020 11:28:49 +0100 Christophe Leroy wrote: Hi, Le

Re: [PATCH] powerpc/kprobes: Fix trap address when trap happened in real mode

Le 17/02/2020 à 11:27, Masami Hiramatsu a écrit : On Mon, 17 Feb 2020 10:03:22 +0100 Christophe Leroy wrote: Le 16/02/2020 à 13:34, Masami Hiramatsu a écrit : On Sat, 15 Feb 2020 11:28:49 +0100 Christophe Leroy wrote: Hi, Le 14/02/2020 à 14:54, Masami Hiramatsu a écrit : Hi, On

Re: [PATCH] powerpc/kprobes: Fix trap address when trap happened in real mode

On Mon, 17 Feb 2020 10:03:22 +0100 Christophe Leroy wrote: > > > Le 16/02/2020 à 13:34, Masami Hiramatsu a écrit : > > On Sat, 15 Feb 2020 11:28:49 +0100 > > Christophe Leroy wrote: > > > >> Hi, > >> > >> Le 14/02/2020 à 14:54, Masami Hiramatsu a écrit : > >>> Hi, > >>> > >>> On Fri, 14 Feb

Re: [PATCH] powerpc/kprobes: Fix trap address when trap happened in real mode

Le 16/02/2020 à 13:34, Masami Hiramatsu a écrit : On Sat, 15 Feb 2020 11:28:49 +0100 Christophe Leroy wrote: Hi, Le 14/02/2020 à 14:54, Masami Hiramatsu a écrit : Hi, On Fri, 14 Feb 2020 12:47:49 + (UTC) Christophe Leroy wrote: When a program check exception happens while MMU

Re: [PATCH] powerpc/kprobes: Fix trap address when trap happened in real mode

On Sat, 15 Feb 2020 11:28:49 +0100 Christophe Leroy wrote: > Hi, > > Le 14/02/2020 à 14:54, Masami Hiramatsu a écrit : > > Hi, > > > > On Fri, 14 Feb 2020 12:47:49 + (UTC) > > Christophe Leroy wrote: > > > >> When a program check exception happens while MMU translation is > >> disabled,

Re: [PATCH] powerpc/kprobes: Fix trap address when trap happened in real mode

Hi, Le 14/02/2020 à 14:54, Masami Hiramatsu a écrit : Hi, On Fri, 14 Feb 2020 12:47:49 + (UTC) Christophe Leroy wrote: When a program check exception happens while MMU translation is disabled, following Oops happens in kprobe_handler() in the following test: } else if

Re: [PATCH] powerpc/kprobes: Fix trap address when trap happened in real mode

Le 14/02/2020 à 13:47, Christophe Leroy a écrit : When a program check exception happens while MMU translation is disabled, following Oops happens in kprobe_handler() in the following test: } else if (*addr != BREAKPOINT_INSTRUCTION) { [ 33.098554] BUG: Unable to handle

Re: [PATCH] powerpc/kprobes: Fix trap address when trap happened in real mode

Hi, On Fri, 14 Feb 2020 12:47:49 + (UTC) Christophe Leroy wrote: > When a program check exception happens while MMU translation is > disabled, following Oops happens in kprobe_handler() in the following > test: > > } else if (*addr != BREAKPOINT_INSTRUCTION) { Thanks for the

[PATCH] powerpc/kprobes: Fix trap address when trap happened in real mode

When a program check exception happens while MMU translation is disabled, following Oops happens in kprobe_handler() in the following test: } else if (*addr != BREAKPOINT_INSTRUCTION) { [ 33.098554] BUG: Unable to handle kernel data access on read at 0xe268 [ 33.105091]