Thanks for the feedback Mpe,
I have sent-out a new patch incorporating your review comments at
http://patchwork.ozlabs.org/patch/877792/
--
Vaibhav Jain
Linux Technology Center, IBM India Pvt. Ltd.
Vaibhav Jain writes:
> Michael Ellerman writes:
>>
>>
>> What would be nice is if we keep that behaviour, but any action you take
>> in xmon that requires xmon to remain resident, ie. setting a breakpoint,
>> calls a function which makes sure xmon_on = true and if it wasn't prints
>> a nice mes
Thanks for looking into this patch Mpe.
Michael Ellerman writes:
>
>
> But the same crash happens with XMON_DEFAULT=n and nothing on the
> command line.
Yes, XMON_DEFAULT=n and empty boot command line implies xmon=off hence
you will see the same issue and this patch should fix that issue too.
>
Vaibhav Jain writes:
> Thanks for reviewing this patch Balbir
>
> Balbir Singh writes:
>
>> Any specific issue you've run into without this patch?
> Without this patch since xmon is still accessible via sysrq and there is
> no indication/warning on the xmon console mentioning that its is not
>
On Mon, Feb 12, 2018 at 11:35 PM, Vaibhav Jain
wrote:
> Thanks for reviewing this patch Balbir
>
> Balbir Singh writes:
>
>> Any specific issue you've run into without this patch?
> Without this patch since xmon is still accessible via sysrq and there is
> no indication/warning on the xmon consol
Thanks for reviewing this patch Balbir
Balbir Singh writes:
> Any specific issue you've run into without this patch?
Without this patch since xmon is still accessible via sysrq and there is
no indication/warning on the xmon console mentioning that its is not
fully functional. Specifically xmon-
On Mon, Feb 12, 2018 at 7:59 PM, Vaibhav Jain
wrote:
> Presently sysrq key for xmon('x') is registered during kernel init
> irrespective of the value of kernel param 'xmon'. Thus xmon is enabled
> even if 'xmon=off' is passed on the kernel command line.
>
> This minor patch updates setup_xmon_sysr
Presently sysrq key for xmon('x') is registered during kernel init
irrespective of the value of kernel param 'xmon'. Thus xmon is enabled
even if 'xmon=off' is passed on the kernel command line.
This minor patch updates setup_xmon_sysrq() to register
'sysrq_xmon_op' only when variable 'xmon_on' is
