s/same/some/g
sorry
Il giorno ven 18 nov 2022 alle ore 08:43 Luigi Mantellini <
luigi.mantell...@gmail.com> ha scritto:
> From: Luigi Mantellini
>
> The PortId is defined as a couple of ClockId (an 8-bytes opaque) and the
> PortNumber (UInterger16).
>
> The current implementation compares the e
From: Luigi Mantellini
The PortId is defined as a couple of ClockId (an 8-bytes opaque) and the
PortNumber (UInterger16).
The current implementation compares the entire PortId, consisting of ClockId
and PortNumber, using a byte-to-byte comparison (memcmp).
This way doesn't consider the HOST's
On 11/17/2022 1:34 PM, Geva, Erez wrote:
On Thu, 2022-11-17 at 18:27 +, Keller, Jacob E wrote:
-Original Message-
From: Geva, Erez
Sent: Thursday, November 17, 2022 9:13 AM
To: Keller, Jacob E ; linuxptp-
de...@lists.sourceforge.net
Subject: Re: [Linuxptp-devel] [PATCH 2/2] phc_c
On Thu, 2022-11-17 at 18:27 +, Keller, Jacob E wrote:
>
>
> > -Original Message-
> > From: Geva, Erez
> > Sent: Thursday, November 17, 2022 9:13 AM
> > To: Keller, Jacob E ; linuxptp-
> > de...@lists.sourceforge.net
> > Subject: Re: [Linuxptp-devel] [PATCH 2/2] phc_ctl: use
> > PTP_C
On Thu, Nov 17, 2022 at 07:38:02PM +0100, luigi.mantell...@gmail.com wrote:
> Suppose to have the PortNumber_a=0x1234 and PortNumber_b=4512. On a
> LittleEndian CPU, you will have the following memory streams:
>
> a) 0x34 0x12
> b) 0x12 0x45
>
> Using a raw memory compare the a) will be erroneou
Dear Erez,
Dear All,
I'm sorry, but I tried to reply using my mobile.
I will prefer to give a better rationale.
Suppose to have the PortNumber_a=0x1234 and PortNumber_b=4512. On a
LittleEndian CPU, you will have the following memory streams:
a) 0x34 0x12
b) 0x12 0x45
Using a raw memory compare
> -Original Message-
> From: Geva, Erez
> Sent: Thursday, November 17, 2022 9:21 AM
> To: Keller, Jacob E ; linuxptp-
> de...@lists.sourceforge.net
> Subject: Re: [Linuxptp-devel] [PATCH 1/2] phc_ctl: explicitly check for
> adjust_phase definition
>
> On Tue, 2022-11-15 at 16:43 -0800,
> -Original Message-
> From: Geva, Erez
> Sent: Thursday, November 17, 2022 9:13 AM
> To: Keller, Jacob E ; linuxptp-
> de...@lists.sourceforge.net
> Subject: Re: [Linuxptp-devel] [PATCH 2/2] phc_ctl: use PTP_CLOCK_GETCAPS2
> ioctl if available
>
> On Tue, 2022-11-15 at 16:43 -0800, Jac
On Mon, 2022-11-14 at 14:25 +0100, Luigi Mantellini wrote:
> The PortId is defined as a couple of ClockId (an 8-bytes opaque) and
> the PortNumber (UInterger16).
> In order to correctly handle the PortId endianess, the comparison has
> been split in the ClockIds comparison (using memcmp) and PortNu
The struct is not in network order because it is already converted to
cpu's endianess before to call the bmca.
The patch works in my setup.
Ciao
Luigi
Il gio 17 nov 2022, 19:04 Geva, Erez ha scritto:
> On Mon, 2022-11-14 at 14:25 +0100, Luigi Mantellini wrote:
> > The PortId is defined as a
On Thu, 2022-11-17 at 08:02 +, Magnus Armholt via Linuxptp-devel
wrote:
> Nothing to complain about the patch, thanks for looking after the
> code base!
>
> > LinuxPTP source still prefers to keep with the GNU C89 convention
> > of
> > variables being at the top of the function. Newer versions
On Tue, 2022-11-15 at 16:43 -0800, Jacob Keller wrote:
> The PTP_CLOCK_GETCAPS ioctl call in phc_ctl has a conditional check
> for
> whether to report the caps.adjust_phase bit. This is always set for
> both
> PTP_CLOCK_GETCAPS and PTP_CLOCK_GETCAPS2, and was always zero before
> the
> bit was move
On Thu, 2022-11-17 at 13:43 +0200, Magnus Armholt wrote:
> Add possibility to configure VLAN tags for ethernet.
>
> We mainly use PTP in slave mode so this has been developed
> primarly for the sync request.
> The raw_send function is used by a lot of functionality, so input
> on what we could h
On Tue, 2022-11-15 at 16:43 -0800, Jacob Keller wrote:
> The PTP_CLOCK_GETCAPS2 ioctl is provided by kernel as a replacement
> for the
> original PTP_CLOCK_GETCAPS ioctl. This was done in order to provide
> ioctls
> which guarantee reserved fields are properly initialized. In practice
> the
> PTP_C
Hi,
On Thu Nov 17 2022, Magnus Armholt wrote:
> From: Mika Paulamäki
>
> Add option to include and configure VLAN tags
> when using transport type IEEE 802.3 (Ethernet).
Instead of patching this to linuxptp, can't you make use of Linux VLAN
interfaces and point ptp4l to it using -i option? Also
Add possibility to configure VLAN tags for ethernet.
We mainly use PTP in slave mode so this has been developed
primarly for the sync request.
The raw_send function is used by a lot of functionality, so input
on what we could have missed (especially from master point of view)
is appreciated.
Mi
From: Mika Paulamäki
Add option to include and configure VLAN tags
when using transport type IEEE 802.3 (Ethernet).
Configurable via configuration file using new parameters:
- "raw_send_vlan_enable", default = 0 (off), range = 0..1
- "raw_send_vlan_id" default = 0, range = 0..4095
- "raw_send
Nothing to complain about the patch, thanks for looking after the code base!
> LinuxPTP source still prefers to keep with the GNU C89 convention of
> variables being at the top of the function. Newer versions of GCC have
> begun defaulting to a newer C standard, which explains how these slipped in
18 matches
Mail list logo
