Re: [Linuxptp-devel] [PATCH] Resolve false hybrid_e2e warning

2023-06-20 Thread Jacob Keller
On 5/1/2023 4:22 AM, Eyal Itkin via Linuxptp-devel wrote: > When delay_mechanism is set to "E2E" mode in the [global] section, > it is applied only to non-UDS ports as UDS ports will override the > delay_mechanism with "DM_AUTO". Still the UDS ports will be checked > for hybrid_e2e and generate

Re: [Linuxptp-devel] [PATCH 0/5] General improvements for linuxptp focused around phase adjustment

2023-06-20 Thread Richard Cochran
On Tue, Jun 20, 2023 at 04:13:18PM -0700, Rahul Rameshbabu via Linuxptp-devel wrote: > > I think Richard wanted to close version 4 first. > > Sure, that makes sense. I am hoping RFC patches are not considered for > merging into releases or the default branch of the project. At the time, > the ne

Re: [Linuxptp-devel] [PATCH 0/5] General improvements for linuxptp focused around phase adjustment

2023-06-20 Thread Rahul Rameshbabu via Linuxptp-devel
Hi Erez, On Wed, 21 Jun, 2023 00:33:28 +0200 Erez wrote: > Hi, > > You already submitted the patch seria. > Has it changed? Yes, I took feedback from the RFC (request for comments) I sent out and applied it in this submission. In the git notes field in the first patch of the series, I document t

Re: [Linuxptp-devel] [PATCH 0/5] General improvements for linuxptp focused around phase adjustment

2023-06-20 Thread Erez
Hi, You already submitted the patch seria. Has it changed? If so, please mark it with version 2. "git format-patch -v 2". If not, why do you send it again? I think Richard wanted to close version 4 first. Erez On Tue, 20 Jun 2023 at 19:39, Rahul Rameshbabu via Linuxptp-devel < linuxptp-devel

[Linuxptp-devel] [PATCH 5/5] phc_ctl: Handle errors returned by various clockadj helpers

2023-06-20 Thread Rahul Rameshbabu via Linuxptp-devel
Do not print success notices if clockadj operation fails using return values provided by the clockadj helpers. Signed-off-by: Rahul Rameshbabu --- phc_ctl.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/phc_ctl.c b/phc_ctl.c index 34d9e0c..e174189 100644 --

[Linuxptp-devel] [PATCH 1/5] Rename NSEC2SEC as NSEC_PER_SEC and refactor to util.h

2023-06-20 Thread Rahul Rameshbabu via Linuxptp-devel
The name NSEC2SEC implies converting nanoseconds to seconds, but the value used for the macro converts seconds to nanoseconds. NSEC_PER_SEC is the accurate name for this macro. Move macro to common location in util.h. Signed-off-by: Rahul Rameshbabu --- Notes: Changes since RFC: *

[Linuxptp-devel] [PATCH 0/5] General improvements for linuxptp focused around phase adjustment

2023-06-20 Thread Rahul Rameshbabu via Linuxptp-devel
The main focus of this submission is adding support for testing ADJ_OFFSET with phc_ctl and querying the maximum supported ADJ_OFFSET adjustment that a device is capable of. Some other minor cleanups are also included in the submission. That patch the introduces support for querying the maximum of

[Linuxptp-devel] [PATCH 2/5] phc_ctl: Add phase command to support ADJ_OFFSET

2023-06-20 Thread Rahul Rameshbabu via Linuxptp-devel
Take double precision floating point representation of an offset value in seconds. Feed this value to the PHC's phase control keyword. Signed-off-by: Rahul Rameshbabu --- phc_ctl.8 | 4 phc_ctl.c | 55 --- 2 files changed, 52 insertions(+

[Linuxptp-devel] [PATCH 3/5] phc_ctl: Add maximum offset capability

2023-06-20 Thread Rahul Rameshbabu via Linuxptp-devel
Advertise the maximum offset that can be fed to the PHC phase control keyword. Signed-off-by: Rahul Rameshbabu --- missing.h | 9 + phc_ctl.c | 4 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/missing.h b/missing.h index 79a87d4..165a297 100644 --- a/missing.h +++ b

[Linuxptp-devel] [PATCH 4/5] phc_ctl: Use pr_notice instead of pr_err for displaying adjusted frequency

2023-06-20 Thread Rahul Rameshbabu via Linuxptp-devel
Adjusted frequency value displayed by do_freq is not an error, but a notication to the user. pr_err should not be used for providing notices with information about successful operations. Fixes: bdb6a35883b0 ("linuxptp: add phc_ctl program to help debug PHC devices") Signed-off-by: Rahul Rameshbabu