Re: [Linuxptp-devel] [PATCH] phc2sys: Avoid segfault with default UDS address.

2023-09-04 Thread Miroslav Lichvar
On Mon, Sep 04, 2023 at 11:20:57AM -0700, Richard Cochran wrote: > The recently added phc2sys multi-domain mode introduced a regression. > In the non-automatic mode (using flag -w to wait for ptp4l) the code > will attempt to set the UDS address using an uninitialized pointer, > unless the -z flag

Re: [Linuxptp-devel] bug in phc2sys.c

2023-09-04 Thread Trey Harrison
I have long since forgotten how to make a pull request - of course I could figure it out but thanks for saving me the time =) Best, Trey On Mon, Sep 4, 2023 at 11:22 AM Richard Cochran wrote: > > On Mon, Sep 04, 2023 at 01:24:50PM +0200, Miroslav Lichvar wrote: > > Will you submit it as a

Re: [Linuxptp-devel] bug in phc2sys.c

2023-09-04 Thread Richard Cochran
On Mon, Sep 04, 2023 at 01:24:50PM +0200, Miroslav Lichvar wrote: > Will you submit it as a git-formatted patch with subject and commit > message, or would you prefer me to do it? I made a patch so we can get this fix into the Sept 5 quarterly release. Please take a look. Thanks, Richard

[Linuxptp-devel] [PATCH] phc2sys: Avoid segfault with default UDS address.

2023-09-04 Thread Richard Cochran
The recently added phc2sys multi-domain mode introduced a regression. In the non-automatic mode (using flag -w to wait for ptp4l) the code will attempt to set the UDS address using an uninitialized pointer, unless the -z flag is also specified. Fix the issue by testing whether the -z flag was

Re: [Linuxptp-devel] bug in phc2sys.c

2023-09-04 Thread Miroslav Lichvar
On Thu, Aug 31, 2023 at 01:40:13PM -0700, Trey Harrison wrote: > So this morning I downloaded and built the latest code from github and > found that phc2sys would occasionally segfault on startup, due to the > following: > > phc2sys.c line 1481: > config_set_string(cfg, "uds_address",

Re: [Linuxptp-devel] [RESEND v5 2/2] ts2phc: Add PTP as a source of ToD

2023-09-04 Thread Maciek Machnikowski
On 9/4/2023 1:01 AM, Richard Cochran wrote: > On Tue, Aug 08, 2023 at 11:36:52AM +0200, Maciek Machnikowski wrote: > >> v2: changed pmc_agent implementation to not use a separate callback >> v3: updated poll thread to use less CPU >> v4: changed sleep routine to usleep, simplified poll thread >