Re: [Linuxptp-devel] [PATCH] Add support for DELAY_REQ and SYNC packets rx_filter

2023-11-20 Thread Miroslav Lichvar
On Tue, Nov 14, 2023 at 06:50:26PM +0300, IlorDash wrote: > Honestly, I don't know, is it necessary to dynamically switch RX filters, > If the device supports EVENT RX filters, because with EVENT RX filters it > can handle all PTP messages. Maybe you could suggest appropriate behaviour > for

Re: [Linuxptp-devel] [PATCH] Add support for DELAY_REQ and SYNC packets rx_filter

2023-11-15 Thread IlorDash
> > >> Device driver can only get info about the current PTP port state >> from ptp4l, because it doesn’t have direct access to it. >> > > And this helps? > Yes, with dynamically switching RX filters I was able to change my Ethernet controller state from Master to Slave and vice versa. I meant a

Re: [Linuxptp-devel] [PATCH] Add support for DELAY_REQ and SYNC packets rx_filter

2023-11-14 Thread Erez
On Mon, 13 Nov 2023 at 18:49, IlorDash wrote: > From: Ilya Orazov > > Added adv_rx_filter config that allows to send SIOCSHWTSTAMP ioctl with > HWTSTAMP_FILTER_PTP_XXX_SYNC or HWTSTAMP_FILTER_PTP_XXX_DELAY_REQ > rx filters based on whether the Device is Slave or Master respectively. > This

Re: [Linuxptp-devel] [PATCH] Add support for DELAY_REQ and SYNC packets rx_filter

2023-11-14 Thread IlorDash
Honestly, I don't know, is it necessary to dynamically switch RX filters, If the device supports EVENT RX filters, because with EVENT RX filters it can handle all PTP messages. Maybe you could suggest appropriate behaviour for utility in that case? Yes, I agree that it can be added as a new enum

Re: [Linuxptp-devel] [PATCH] Add support for DELAY_REQ and SYNC packets rx_filter

2023-11-14 Thread Miroslav Lichvar
On Mon, Nov 13, 2023 at 08:47:48PM +0300, IlorDash wrote: > I assumed, if these filters are defined in Kernel, they might be used in > ptp4l utility to fix this. So I added adv_rx_filter config that allows > to send SIOCSHWTSTAMP ioctl with HWTSTAMP_FILTER_PTP_XXX_SYNC or >

[Linuxptp-devel] [PATCH] Add support for DELAY_REQ and SYNC packets rx_filter

2023-11-13 Thread IlorDash
From: Ilya Orazov Added adv_rx_filter config that allows to send SIOCSHWTSTAMP ioctl with HWTSTAMP_FILTER_PTP_XXX_SYNC or HWTSTAMP_FILTER_PTP_XXX_DELAY_REQ rx filters based on whether the Device is Slave or Master respectively. This Feature is added for all transport levels. I’m using Ethernet