Re: [Linuxptp-devel] [PATCH] The daemon should not downgrade the RX filter. An AVB/TSN application may use it. Follow Cliff Spradlin recommendation and add a configuration option.

2018-06-13 Thread Cliff Spradlin via Linuxptp-devel
On Wed, Jun 13, 2018 at 8:39 PM Richard Cochran wrote: > 1. normal - current code > 2. check - read only ioctl; quit if setting not rich enough for the HW time stamping mode Yeah, I'd suggest naming these modes 'overwrite' and 'check'. On Tue, Jun 12, 2018 at 12:40:06PM +, Geva, Erez

Re: [Linuxptp-devel] [PATCH] The daemon should not downgrade the RX filter. An AVB/TSN application may use it. Follow Cliff Spradlin recommendation and add a configuration option.

2018-06-13 Thread Richard Cochran
On Tue, Jun 12, 2018 at 12:40:06PM +, Geva, Erez wrote: > Signed-off-by: Erez Geva Please write a proper commit message with a succinct subject line. > +static struct config_enum hwts_filter_enu[] = { > + { "default", HWTS_FILTER_DEF }, "DEF" looks silly. Please spell out

[Linuxptp-devel] [PATCH] The daemon should not downgrade the RX filter. An AVB/TSN application may use it. Follow Cliff Spradlin recommendation and add a configuration option.

2018-06-12 Thread Geva, Erez
Signed-off-by: Erez Geva --- config.c| 9 + ptp4l.8 | 8 raw.c | 6 -- sk.c| 38 -- sk.h| 14 +- transport.c | 11 ++- transport_private.h