On 6/22/2023 8:49 PM, Richard Cochran wrote:
> On Mon, Jun 12, 2023 at 10:18:07AM +0200, Jakub Raczyński wrote:
>> In master version and 4.0 this patch was not applied. Please apply this when
>> possible.
>
> That patch does not apply (as I said back on 07 Dec 2022)
>
> If you want to have it,
On 12/7/2022 6:43 AM, Richard Cochran wrote:
> On Wed, Nov 16, 2022 at 11:48:32AM -0800, Jacob Keller wrote:
>> When building the tlv.c file, the following warning may occur when
>> operating in C89 mode:
>
> Jacob, this patch doesn't apply any more. Can you rebase it please?
>
> Thanks,
> Ri
On Mon, Jun 12, 2023 at 10:18:07AM +0200, Jakub Raczyński wrote:
> In master version and 4.0 this patch was not applied. Please apply this when
> possible.
That patch does not apply (as I said back on 07 Dec 2022)
If you want to have it, then please clean it up and re-submit.
Thanks,
Richard
Greetings,
In master version and 4.0 this patch was not applied. Please apply this when
possible.
Best regards
Jakub Raczynski
> 16.11.2022 20:48 Jacob Keller wrote:
>
>
> When building the tlv.c file, the following warning may occur when
> operating in C89 mode:
>
> $make EXTRA_CFLAGS=-
On Wed, Nov 16, 2022 at 11:48:32AM -0800, Jacob Keller wrote:
> When building the tlv.c file, the following warning may occur when
> operating in C89 mode:
Jacob, this patch doesn't apply any more. Can you rebase it please?
Thanks,
Richard
___
Linuxp
On Thu, 2022-11-17 at 08:02 +, Magnus Armholt via Linuxptp-devel
wrote:
> Nothing to complain about the patch, thanks for looking after the
> code base!
>
> > LinuxPTP source still prefers to keep with the GNU C89 convention
> > of
> > variables being at the top of the function. Newer versions
Nothing to complain about the patch, thanks for looking after the code base!
> LinuxPTP source still prefers to keep with the GNU C89 convention of
> variables being at the top of the function. Newer versions of GCC have
> begun defaulting to a newer C standard, which explains how these slipped in
When building the tlv.c file, the following warning may occur when
operating in C89 mode:
$make EXTRA_CFLAGS=-std=gnu89
tlv.c: In function ‘mgt_post_recv’:
tlv.c:374:17: error: ‘for’ loop initial declarations are only allowed in C99
or C11 mode
374 | for (int i = 0; i <