Re: [Linuxptp-devel] [PATCH 3/3] [Interface Rate TLV] adding TLV support

2022-10-08 Thread Richard Cochran
On Tue, Jul 26, 2022 at 06:26:46PM +0530, Devasish Dey wrote: > > > + GLOB_ITEM_INT("interface_rate_tlv", 0, 0, 1), > > > > Why is it not a port-specific option? If you reject a suggestion, it's > > a good practice to explain your reasoning. > > > [Devasish]: It is for TLV support and this see

Re: [Linuxptp-devel] [PATCH 3/3] [Interface Rate TLV] adding TLV support

2022-07-26 Thread Devasish Dey
Hi Miroslav, Please find the answers to the queries. Thanks, Devasish Dey SyncMonk Technologies. www.syncmonk.net > > --- a/config.c > > +++ b/config.c > > @@ -240,6 +240,7 @@ struct config_item config_tab[] = { > > GLOB_ITEM_ENU("clock_type", CLOCK_TYPE_ORDINARY, clock_type_enu), > >

Re: [Linuxptp-devel] [PATCH 3/3] [Interface Rate TLV] adding TLV support

2022-06-23 Thread Miroslav Lichvar
On Wed, Jun 22, 2022 at 12:47:55PM +0530, SyncMonk Technologies wrote: > - adding organizational TLV support for interface rate > - delay asymmetry calculation for master and slave So it could be split into two or three patches? > --- a/config.c > +++ b/config.c > @@ -240,6 +240,7 @@ struct confi

[Linuxptp-devel] [PATCH 3/3] [Interface Rate TLV] adding TLV support

2022-06-22 Thread SyncMonk Technologies
- adding organizational TLV support for interface rate - delay asymmetry calculation for master and slave Signed-off-by: Greg Armstrong Signed-off-by: Leon Goldin Signed-off-by: Devasish Dey Signed-off-by: Vipin Sharma --- clock.c | 12 clock.h | 14 ++