Re: [Linuxptp-devel] [RFC PATCH v1 2/8] Add configuration options for CMLDS

2023-03-22 Thread Andrew Zaborowski
On Wed, 22 Mar 2023 at 05:17, Richard Cochran wrote: > On Mon, Mar 20, 2023 at 09:04:59PM -0700, Kishen Maloor wrote: > > Yes, we would configure CMLDS just once per physical port on a PTP node. > > Okay, so the code should check this. > > (Haven't reviewed yet, maybe you handle that already?) We

Re: [Linuxptp-devel] [RFC PATCH v1 2/8] Add configuration options for CMLDS

2023-03-21 Thread Richard Cochran
On Mon, Mar 20, 2023 at 09:04:59PM -0700, Kishen Maloor wrote: > Yes, we would configure CMLDS just once per physical port on a PTP node. Okay, so the code should check this. (Haven't reviewed yet, maybe you handle that already?) Thanks, Richard ___

Re: [Linuxptp-devel] [RFC PATCH v1 2/8] Add configuration options for CMLDS

2023-03-20 Thread Kishen Maloor
On 3/20/23 8:10 PM, Richard Cochran wrote: > On Mon, Mar 20, 2023 at 02:40:30PM -0700, Kishen Maloor wrote: >> On 3/20/23 12:31 PM, Richard Cochran wrote: >>> On Sun, Mar 19, 2023 at 10:36:48PM -0400, Kishen Maloor wrote: >>> 'run_cmlds': This per-port setting (0/1) declares that a port w

Re: [Linuxptp-devel] [RFC PATCH v1 2/8] Add configuration options for CMLDS

2023-03-20 Thread Richard Cochran
On Mon, Mar 20, 2023 at 02:40:30PM -0700, Kishen Maloor wrote: > On 3/20/23 12:31 PM, Richard Cochran wrote: > > On Sun, Mar 19, 2023 at 10:36:48PM -0400, Kishen Maloor wrote: > > > >> 'run_cmlds': This per-port setting (0/1) declares that a port > >> will perform the role of a CMLDS Link Port (IE

Re: [Linuxptp-devel] [RFC PATCH v1 2/8] Add configuration options for CMLDS

2023-03-20 Thread Kishen Maloor
On 3/20/23 12:31 PM, Richard Cochran wrote: > On Sun, Mar 19, 2023 at 10:36:48PM -0400, Kishen Maloor wrote: > >> 'run_cmlds': This per-port setting (0/1) declares that a port >> will perform the role of a CMLDS Link Port (IEEE 1588, clause 16.6.1) >> and execute CMLDS Pdelay transactions > > How

Re: [Linuxptp-devel] [RFC PATCH v1 2/8] Add configuration options for CMLDS

2023-03-20 Thread Richard Cochran
On Sun, Mar 19, 2023 at 10:36:48PM -0400, Kishen Maloor wrote: > 'run_cmlds': This per-port setting (0/1) declares that a port > will perform the role of a CMLDS Link Port (IEEE 1588, clause 16.6.1) > and execute CMLDS Pdelay transactions How many ports may have run_cmlds == 1 ? Thanks, Richard

[Linuxptp-devel] [RFC PATCH v1 2/8] Add configuration options for CMLDS

2023-03-19 Thread Kishen Maloor
This change adds cofig file parameters to configure CMLDS support and access in PTP instances. 'cmlds_clockIdentity': This global setting assigns a CMLDS clockIdentity to be used by a PTP instance on a PTP node that exposes CMLDS over one or more links. 'run_cmlds': This per-port setting (0/1) de