Re: [Linuxptp-devel] Announce message generates SDE on MasterOnly port

2021-05-04 Thread Richard Cochran
On Tue, May 04, 2021 at 02:24:07PM +0200, Luigi 'Comio' Mantellini wrote: > As side note, In my testing scenario the master-only ports receive > announce messages and when the slave port loses the signal the node > evolves in grand-master flooding the log with "assuming the grand > master role" mes

Re: [Linuxptp-devel] Announce message generates SDE on MasterOnly port

2021-05-04 Thread Luigi 'Comio' Mantellini
Just like other process_*() that quickly return when the port state doesn't require to process the incoming message, we can add a test into process_announce() in order to avoid wasting the cpu. This is not a special case, the announce messages should be ignored on Master-only ports and the ports st

Re: [Linuxptp-devel] Announce message generates SDE on MasterOnly port

2021-05-04 Thread Richard Cochran
On Mon, May 03, 2021 at 06:52:02PM +0200, Luigi 'Comio' Mantellini wrote: > I noticed that the Announce messages received on MasterOnly ports > generate a SDE condition in bc_event(). and so what? What is the problem? > I think that we can return > EV_NONE when the port is a master_only (or we c

[Linuxptp-devel] Announce message generates SDE on MasterOnly port

2021-05-03 Thread Luigi 'Comio' Mantellini
Hi Richard, Hi All, (I'm investigating the SDE behavior...) In my setup I have a couple of MasterOnly ports and we tries to kill (and recover) the SLAVE port's link in order to measure the performance. I noticed that the Announce messages received on MasterOnly ports generate a SDE condition in