Re: [Linuxptp-devel] PORT_STATS_NP management TLV message

2021-03-10 Thread Keller, Jacob E
> -Original Message- > From: Richard Cochran > Sent: Wednesday, March 10, 2021 6:58 AM > To: Geva, Erez > Cc: linuxptp-devel@lists.sourceforge.net > Subject: Re: [Linuxptp-devel] PORT_STATS_NP management TLV message > > On Tue, Mar 09, 2021 at 10:28:48PM

Re: [Linuxptp-devel] PORT_STATS_NP management TLV message

2021-03-10 Thread Keller, Jacob E
> -Original Message- > From: Richard Cochran > Sent: Wednesday, March 10, 2021 6:54 AM > To: Keller, Jacob E > Cc: Geva, Erez ; linuxptp- > de...@lists.sourceforge.net > Subject: Re: [Linuxptp-devel] PORT_STATS_NP management TLV message > > On Tue, Mar 0

Re: [Linuxptp-devel] PORT_STATS_NP management TLV message

2021-03-10 Thread Richard Cochran
On Tue, Mar 09, 2021 at 10:28:48PM +, Geva, Erez wrote: > However with the current code the endian depends on machine. > So a linuxptp daemon that runs on a big endian (there are yet some) will send > the message in big endian. Yeah, so at the very minimum, we should: 1. document the oversig

Re: [Linuxptp-devel] PORT_STATS_NP management TLV message

2021-03-10 Thread Richard Cochran
On Tue, Mar 09, 2021 at 11:34:01PM +, Keller, Jacob E wrote: > Can this message be sent or processed over the network? Or do the _NP > messages always get restricted to the local socket only? Network, too. ___ Linuxptp-devel mailing list Linuxptp-

Re: [Linuxptp-devel] PORT_STATS_NP management TLV message

2021-03-10 Thread Geva, Erez
On 10/03/2021 00:38, Keller, Jacob E wrote: >> -Original Message- >> From: Geva, Erez >> Sent: Tuesday, March 09, 2021 2:29 PM >> To: Richard Cochran >> Cc:linuxptp-devel@lists.sourceforge.net >> Subject: Re: [Linuxptp-devel] PORT_STATS_NP management

Re: [Linuxptp-devel] PORT_STATS_NP management TLV message

2021-03-09 Thread Keller, Jacob E
> -Original Message- > From: Geva, Erez > Sent: Tuesday, March 09, 2021 2:29 PM > To: Richard Cochran > Cc: linuxptp-devel@lists.sourceforge.net > Subject: Re: [Linuxptp-devel] PORT_STATS_NP management TLV message > > Hi, > > I can be live with using li

Re: [Linuxptp-devel] PORT_STATS_NP management TLV message

2021-03-09 Thread Keller, Jacob E
> -Original Message- > From: Richard Cochran > Sent: Tuesday, March 09, 2021 8:57 AM > To: Geva, Erez > Cc: linuxptp-devel@lists.sourceforge.net > Subject: Re: [Linuxptp-devel] PORT_STATS_NP management TLV message > > On Tue, Mar 09, 2021 at 01:59:33PM +,

Re: [Linuxptp-devel] PORT_STATS_NP management TLV message

2021-03-09 Thread Geva, Erez
Hi, I can be live with using little endian. This is not the first time I see using little endian with IEEE. However with the current code the endian depends on machine. So a linuxptp daemon that runs on a big endian (there are yet some) will send the message in big endian. May be we should limi

[Linuxptp-devel] PORT_STATS_NP management TLV message

2021-03-09 Thread Geva, Erez
Hi, I am about to release a first version of a new libpmc library under LGPL for all the guys who "parse" pmc output. As I add the PORT_STATS_NP message, I notice that the statistics is stored in unsigned integer 64 bits values, but using host order instead of network order. As I know you fol

Re: [Linuxptp-devel] PORT_STATS_NP management TLV message

2021-03-09 Thread Richard Cochran
On Tue, Mar 09, 2021 at 01:59:33PM +, Geva, Erez wrote: > As I add the PORT_STATS_NP message, > I notice that the statistics is stored in unsigned integer 64 bits values, > but using host order instead of network order. Oops, that was an oversight. > As I know you follow the IEEE standard,