Re: [Linuxptp-devel] [PATCH 3/7] pmc_agent: Simplify the update method.

2020-11-27 Thread Richard Cochran
On Sat, Nov 14, 2020 at 10:12:30PM +0200, Vladimir Oltean wrote: > But another question: when ptp4l calls clock_prune_subscriptions(), our > node->subscription_active will remain 1, right? That's confusing. > "Active" might not be the right word, how about "using_subscriptions"? Point taken. I'l

Re: [Linuxptp-devel] [PATCH 3/7] pmc_agent: Simplify the update method.

2020-11-14 Thread Vladimir Oltean
On Tue, Nov 10, 2020 at 02:21:38PM -0800, Richard Cochran wrote: > The main method that causes the PMC agent to update its status takes a flag > that results in different behavior when push notifications are active. > This patch simplifies the interface by letting the agent remember whether > or no

Re: [Linuxptp-devel] [PATCH 3/7] pmc_agent: Simplify the update method.

2020-11-11 Thread Richard Cochran
On Wed, Nov 11, 2020 at 10:43:40AM -0800, Jacob Keller wrote: > Ok, so now the node/agent tracks the subscriptions automatically. So > someone else needs to call renew_subscription first. Right, actually the user needs to call pmc_agent_subscribe()... > Patch context alone isn't enough to follow

Re: [Linuxptp-devel] [PATCH 3/7] pmc_agent: Simplify the update method.

2020-11-11 Thread Jacob Keller
On 11/10/2020 2:21 PM, Richard Cochran wrote: > The main method that causes the PMC agent to update its status takes a flag > that results in different behavior when push notifications are active. > This patch simplifies the interface by letting the agent remember whether > or not the caller sub