Re: [Linuxptp-devel] Setting DSCP values in PTP messages

2016-07-07 Thread Richard Cochran
Henry, This is patch is *almost* ready for merging... This patch causes a build failure: gcc phc_ctl.o phc.o sk.o util.o clockadj.o sysoff.o print.o version.o -lm -lrt -o phc_ctl sk.o: In function `sk_set_priority': sk.c:(.text+0x26e): undefined reference to `config_get_int' sk.

Re: [Linuxptp-devel] Setting DSCP values in PTP messages

2016-07-07 Thread Jesuiter, Henry (ALC NetworX GmbH)
In the last years there are several media streaming standards evolving that are relying on PTP. These standards make requirements about the DSCP priority of PTP messages. This patch introduces two new configuration options 'tos_event' and 'tos_general' to address that issue and to be able to set

Re: [Linuxptp-devel] Setting DSCP values in PTP messages

2016-07-07 Thread Jesuiter, Henry (ALC NetworX GmbH)
In the last years there are several media standards evolving that are relying on PTP. These standards make requirements about the DSCP priority of PTP messages. This patch introduces two new configuration options 'tos_event' and 'tos_general' to address that issue and to be able to set the DSCP

Re: [Linuxptp-devel] Setting DSCP values in PTP messages

2016-07-07 Thread Richard Cochran
On Wed, Jul 06, 2016 at 03:15:29PM +, Jesuiter, Henry (ALC NetworX GmbH) wrote: > Thank you very much for your fast reply and the notes. Please find below a > modified patch according to your annotations: The patch also needs a proper commit message explaining how these new options are usefu

Re: [Linuxptp-devel] Setting DSCP values in PTP messages

2016-07-06 Thread Jesuiter, Henry (ALC NetworX GmbH)
Thank you very much for your fast reply and the notes. Please find below a modified patch according to your annotations: --- diff -rwbBu a/config.c b/config.c --- a/config.c 2015-09-19 16:25:11.0 +0200 +++ b/config.c 2016-07-06 17:07:38.176449373 +0200 @@ -226,6 +226,8 @@ PORT_IT

Re: [Linuxptp-devel] Setting DSCP values in PTP messages

2016-07-06 Thread Richard Cochran
On Wed, Jul 06, 2016 at 03:58:59PM +0200, Richard Cochran wrote: > On Wed, Jul 06, 2016 at 01:32:26PM +, Jesuiter, Henry (ALC NetworX GmbH) > wrote: > > Oh yes, my fault. Please find it below: > > > > --- > > Index: config.c > >

Re: [Linuxptp-devel] Setting DSCP values in PTP messages

2016-07-06 Thread Richard Cochran
On Wed, Jul 06, 2016 at 01:32:26PM +, Jesuiter, Henry (ALC NetworX GmbH) wrote: > Oh yes, my fault. Please find it below: > > --- > Index: config.c > === > --- config.c (Revision 827) > +++ config.c (Revision 830) > @@ -236,6 +

Re: [Linuxptp-devel] Setting DSCP values in PTP messages

2016-07-06 Thread Richard Cochran
On Wed, Jul 06, 2016 at 09:21:45AM +, Jesuiter, Henry (ALC NetworX GmbH) wrote: > sorry, the last patch contained a bug, on setting the DSCP value on the > correct sockets. So please use the newly attached one here. Please resend with the patch in line (not as an attachment). Thanks, Richar

Re: [Linuxptp-devel] Setting DSCP values in PTP messages

2016-07-06 Thread Jesuiter, Henry (ALC NetworX GmbH)
Hi, sorry, the last patch contained a bug, on setting the DSCP value on the correct sockets. So please use the newly attached one here. Best regards Henry Jesuiter Von: Jesuiter, Henry (ALC NetworX GmbH) Gesendet: Mittwoch, 6. Juli 2016 11:11 An: 'linuxptp-devel@lists.sourceforge.net' Betreff