Re: [Linuxptp-devel] [PATCH] Add reverse sync measurement method.

2018-08-17 Thread Richard Cochran
On Tue, Aug 14, 2018 at 02:56:44PM +0200, Michael Walle wrote: > AVnu specifies a measurement method to remotely measure the clock > quality. Basically, this method sends Sync and/or Follow-up messages on > a slave towards the master, which can capture them and measure the > quality. We already ha

Re: [Linuxptp-devel] [PATCH] Add reverse sync measurement method.

2018-08-17 Thread Michael Walle
Am 17. August 2018 18:07:30 MESZ schrieb Richard Cochran : >On Tue, Aug 14, 2018 at 02:56:44PM +0200, Michael Walle wrote: >> AVnu specifies a measurement method to remotely measure the clock >> quality. Basically, this method sends Sync and/or Follow-up messages >on >> a slave towards the master,

Re: [Linuxptp-devel] [PATCH] Add reverse sync measurement method.

2018-08-17 Thread Richard Cochran
On Sat, Aug 18, 2018 at 01:08:27AM +0200, Michael Walle wrote: > calnex and ixia (and i guess spirent too) support reverse sync to measure the > clock accuracy. Those two have showed zero interest in helping linuxptp. Why should we help them? If this reverse sync thingy makes it into 1558 v2.1

Re: [Linuxptp-devel] [RFC v2 0/5] Adding support for AVnu Automotive Profile

2018-08-17 Thread Richard Cochran
On Thu, Aug 16, 2018 at 10:42:10AM -0700, Vedang Patel wrote: > > Changes in V2: > ~~~ This looks a lot better, thanks! I'll have a few small comments on the patches... > Some Opens: > - Currently, we are using masterOnly (a per-port config option) and slaveOnly > (a global config o

Re: [Linuxptp-devel] [PATCH] Add reverse sync measurement method.

2018-08-17 Thread Richard Cochran
On Fri, Aug 17, 2018 at 07:39:15PM -0400, Richard Cochran wrote: > If this reverse sync thingy makes it into 1558 v2.1 or the next > 802.1-AS revision, then we can consider supporting it. BTW, is this reverse sync present in the current drafts for either standard? I don't recall seeing it, but if

Re: [Linuxptp-devel] [RFC v2 0/5] Adding support for AVnu Automotive Profile

2018-08-17 Thread Richard Cochran
On Thu, Aug 16, 2018 at 10:42:10AM -0700, Vedang Patel wrote: > - In port_p2p_transition(), we are setting up the delay timer when BMCA is set > as ‘noop’. Usually it is initialized then the device transitions to > PS_LISTENING. But, we are skipping the LISTENING state. Another alternative >

Re: [Linuxptp-devel] [RFC v2 0/5] Adding support for AVnu Automotive Profile

2018-08-17 Thread Richard Cochran
On Thu, Aug 16, 2018 at 10:42:10AM -0700, Vedang Patel wrote: > - In port_p2p_transition(), we are setting up the delay timer when BMCA is set > as ‘noop’. Usually it is initialized then the device transitions to > PS_LISTENING. But, we are skipping the LISTENING state. Another alternative >

Re: [Linuxptp-devel] [RFC v2 2/5] Add BMCA config option.

2018-08-17 Thread Richard Cochran
On Thu, Aug 16, 2018 at 10:42:12AM -0700, Vedang Patel wrote: > diff --git a/fsm.c b/fsm.c > index ce6efad30937..a0c98891e39f 100644 > --- a/fsm.c > +++ b/fsm.c > @@ -335,3 +335,103 @@ enum port_state ptp_slave_fsm(enum port_state state, > enum fsm_event event, > > return next; > } > + >

Re: [Linuxptp-devel] [RFC v2 4/5] Add ignore_source_id config option.

2018-08-17 Thread Richard Cochran
On Thu, Aug 16, 2018 at 10:42:14AM -0700, Vedang Patel wrote: > +static int check_source_identity(struct port *p, struct ptp_message *m) > +{ > + struct PortIdentity master; > + > + if (!p->ignore_source_id) { > + master = clock_parent_identity(p->clock); > + if (!p

Re: [Linuxptp-devel] [RFC v2 5/5] Add example configuration for AVnu Automotive Profile.

2018-08-17 Thread Richard Cochran
On Thu, Aug 16, 2018 at 10:42:15AM -0700, Vedang Patel wrote: > create mode 100644 configs/AVnu-master.cfg > create mode 100644 configs/AVnu-slave.cfg IIRC, AVnu had some earlier best practice paper about using 802.1-AS. So maybe these file names should include the word "automotive" in them. Ac