Re: [Linuxptp-devel] [PATCH RFC v3 02/10] Introduce the power profile.

2021-11-15 Thread Olivier Dautricourt
Hi, The 11/10/2021 06:42, Richard Cochran wrote: > > On Wed, Nov 10, 2021 at 12:59:33PM +0100, Olivier Dautricourt wrote: > > > I had the feeling that power profiles attributes such as > > totalTimeInaccuracy should be properties of the clock. > > In case of a simple BC or jbod, all the ports ne

Re: [Linuxptp-devel] [PATCH RFC v3 02/10] Introduce the power profile.

2021-11-15 Thread Richard Cochran
On Mon, Nov 15, 2021 at 10:38:53AM +0100, Olivier Dautricourt wrote: > > This series treats the values as static. There is no automatic > > update. The profile does not specify how to automatically calculate > > the values. On the contrary, it recommends a one time calibration > > "during netwo

Re: [Linuxptp-devel] [PATCH v2 1/2] phc2sys: move read_phc into clock_adj.c

2021-11-15 Thread Richard Cochran
On Fri, Oct 22, 2021 at 03:03:58PM -0700, Jacob Keller wrote: > Notice that read_phc returned 0 on failure and 1 on success. This is > fairly non-standard, so lets update clockadj_compare to return 0 on > success and -1 on failure. Fix the call sites to check correctly and > report an error. +1 >

Re: [Linuxptp-devel] [RFC PATCH 10/10] checksync: new program to wait for a local or remote clock to synchronize

2021-11-15 Thread Richard Cochran
On Fri, Oct 15, 2021 at 10:48:28PM +, Geva, Erez wrote: > Although, I am not oppose your patch. I just find it useless, as I perform > the same result in a Perl script. > And with a much higher flexibility and a better performance. Can you share the equivalent script? It would be interestin

Re: [Linuxptp-devel] [PATCH v4 2/9] ts2phc: instantiate a full clock structure for every slave PHC

2021-11-15 Thread Richard Cochran
On Sat, Oct 09, 2021 at 05:11:53PM +0300, Vladimir Oltean wrote: > diff --git a/ts2phc.c b/ts2phc.c > index 67df5a532559..ca7684b314a4 100644 > --- a/ts2phc.c > +++ b/ts2phc.c > @@ -7,9 +7,14 @@ > * @note SPDX-License-Identifier: GPL-2.0+ > */ > #include > +#include > +#include > +#include

Re: [Linuxptp-devel] [PATCH v4 0/9] Dynamic sync direction for ts2phc

2021-11-15 Thread Richard Cochran
On Sat, Oct 09, 2021 at 05:11:51PM +0300, Vladimir Oltean wrote: > The overall board design for my use case is that there's an SoC with an > embedded DSA switch, and hanging off of 3 ports of that embedded switch > are 3 external switches. Every networking device (the DSA master for the > embedded

Re: [Linuxptp-devel] [PATCH v4 2/9] ts2phc: instantiate a full clock structure for every slave PHC

2021-11-15 Thread Vladimir Oltean
On Mon, Nov 15, 2021 at 06:06:48AM -0800, Richard Cochran wrote: > On Sat, Oct 09, 2021 at 05:11:53PM +0300, Vladimir Oltean wrote: > > > diff --git a/ts2phc.c b/ts2phc.c > > index 67df5a532559..ca7684b314a4 100644 > > --- a/ts2phc.c > > +++ b/ts2phc.c > > @@ -7,9 +7,14 @@ > > * @note SPDX-Licen

Re: [Linuxptp-devel] [PATCH v4 0/9] Dynamic sync direction for ts2phc

2021-11-15 Thread Vladimir Oltean
On Mon, Nov 15, 2021 at 06:15:08AM -0800, Richard Cochran wrote: > On Sat, Oct 09, 2021 at 05:11:51PM +0300, Vladimir Oltean wrote: > > > The overall board design for my use case is that there's an SoC with an > > embedded DSA switch, and hanging off of 3 ports of that embedded switch > > are 3 ex

Re: [Linuxptp-devel] [PATCH v4 0/9] Dynamic sync direction for ts2phc

2021-11-15 Thread Richard Cochran
On Mon, Nov 15, 2021 at 04:28:07PM +0200, Vladimir Oltean wrote: > So we'd have a PPS source, PPS sink, source clock and destination clock, > right? In the code, would "master" become simply "source" or "pps_source"? yes > > I'm not asking you to rename everything, but if you have the time and >