Re: [Linuxptp-devel] [PATCH 01/11] synce4l: add config knobs for SyncE

2022-05-03 Thread Miroslav Lichvar
Thanks for your work on this feature. I don't have hardware to test it. Just some comments on the code. On Mon, May 02, 2022 at 11:05:55AM +0200, Arkadiusz Kubalewski wrote: > Allow config interface to parse SyncE related config files. > > + if (type == PTP) { > + ci_tab = &confi

Re: [Linuxptp-devel] [PATCH 03/11] synce4l: add esmc_socket interface

2022-05-03 Thread Miroslav Lichvar
On Mon, May 02, 2022 at 11:05:57AM +0200, Arkadiusz Kubalewski wrote: > Add interface for sending and receiving ESMC frames. > Ethernet Synchronization Messaging Channel (ESMC) requires > to operate on multicast raw L2 socket. This patch adds features > to open socket, send and receive ESMC frames.

Re: [Linuxptp-devel] [PATCH 08/11] synce4l: add synce_port_ctrl interface

2022-05-03 Thread Miroslav Lichvar
On Mon, May 02, 2022 at 11:06:02AM +0200, Arkadiusz Kubalewski wrote: > Used by synce_port to create, control and destroy RX/TX threads. > Ports in sync mode can use only TX thread (device in external input > mode) or both RX and TX threads (device in internal input mode). > +++ b/synce_port_ctrl.

Re: [Linuxptp-devel] [PATCH 10/11] synce4l: add synce_transport interface

2022-05-03 Thread Miroslav Lichvar
On Mon, May 02, 2022 at 11:06:04AM +0200, Arkadiusz Kubalewski wrote: > Interface is used to create and store an opened socket for sending and > receiving SyncE PDU's on a given NIC interface. > +++ b/synce_transport.c > +struct synce_transport *synce_transport_create(const char *iface) > +{ ...

Re: [Linuxptp-devel] [PATCH 11/11] synce4l: add synce4l application

2022-05-03 Thread Miroslav Lichvar
On Mon, May 02, 2022 at 11:06:05AM +0200, Arkadiusz Kubalewski wrote: > Add main code of synce4l - user space application implementing > standard - Recommendation ITU-T G.8264/Y.1364. > On init the application parses SyncE config file and initializes > a synce_clock with SyncE devices and configure

Re: [Linuxptp-devel] [PATCH 03/11] synce4l: add esmc_socket interface

2022-05-03 Thread Erez
On Tue, 3 May 2022 at 11:25, Miroslav Lichvar wrote: > On Mon, May 02, 2022 at 11:05:57AM +0200, Arkadiusz Kubalewski wrote: > > Add interface for sending and receiving ESMC frames. > > Ethernet Synchronization Messaging Channel (ESMC) requires > > to operate on multicast raw L2 socket. This patc