Re: [Linuxptp-devel] [PATCH 04/11] uds: Convey transmit path errors to the caller.

2020-05-18 Thread Jacob Keller
On 5/18/2020 4:24 PM, Richard Cochran wrote: > On Mon, May 18, 2020 at 04:17:34PM -0700, Jacob Keller wrote: >>> @@ -119,8 +119,8 @@ static int uds_send(struct transport *t, struct fdarray >>> *fda, >>> addr = &uds->address; >>> >>> cnt = sendto(fd, buf, buflen, 0, &addr->sa,

Re: [Linuxptp-devel] [RFC PATCH 3/3] phc2pwm: Introduce an utility to sync pwm with PTP clock

2020-05-18 Thread Jacob Keller
On 5/16/2020 11:22 AM, Lokesh Vutla via Linuxptp-devel wrote: > Hi Richard, > > On 16/05/20 10:44 PM, Richard Cochran wrote: >> On Sat, May 16, 2020 at 10:35:33PM +0530, Lokesh Vutla wrote: >>> Hi Richard, >>> >>> On 16/05/20 10:24 PM, Richard Cochran wrote: On Fri, Apr 17, 2020 at 10:00:09

Re: [Linuxptp-devel] [PATCH 04/11] uds: Convey transmit path errors to the caller.

2020-05-18 Thread Richard Cochran
On Mon, May 18, 2020 at 04:17:34PM -0700, Jacob Keller wrote: > > @@ -119,8 +119,8 @@ static int uds_send(struct transport *t, struct fdarray > > *fda, > > addr = &uds->address; > > > > cnt = sendto(fd, buf, buflen, 0, &addr->sa, addr->len); > > - if (cnt <= 0 && errno != ECONN

Re: [Linuxptp-devel] [PATCH 11/11] Reject path trace TLVs with excessive elements.

2020-05-18 Thread Jacob Keller
Reviewed-by: Jacob Keller On 5/16/2020 8:03 AM, Richard Cochran wrote: > The current code truncates the size of path trace TLVs which exceed the > expected maximum based on the largest possible message size. However if > another TLV follows, then a gap would appear, that is, an area in the > m

Re: [Linuxptp-devel] [PATCH 10/11] port: Publish the method for creating signaling messages.

2020-05-18 Thread Jacob Keller
Reviewed-by: Jacob Keller On 5/16/2020 8:03 AM, Richard Cochran wrote: > Signed-off-by: Richard Cochran > --- > port.h | 3 +++ > port_signaling.c | 4 ++-- > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/port.h b/port.h > index 80c543e..0b07d55 100644 > --- a/p

Re: [Linuxptp-devel] [PATCH 09/11] port: Export the value of the wildcard port identity.

2020-05-18 Thread Jacob Keller
Reviewed-by: Jacob Keller On 5/16/2020 8:03 AM, Richard Cochran wrote: > Code in other modules will need this special port ID value. This patch > makes it available through the port header file. > > Signed-off-by: Richard Cochran > --- > port.h | 3 +++ > port_signaling.c | 4 ++--

Re: [Linuxptp-devel] [PATCH 07/11] port: Convey targeted forwarding errors to the caller.

2020-05-18 Thread Jacob Keller
Reviewed-by: Jacob Keller On 5/16/2020 8:03 AM, Richard Cochran wrote: > The port_forward_to() method clobbers the specific error code returned > by the transport layer with -1. This patch lets the code preserve the > specific error in question. > > Signed-off-by: Richard Cochran > --- > po

Re: [Linuxptp-devel] [PATCH 08/11] util: Mark port identity comparisons as const.

2020-05-18 Thread Jacob Keller
Reviewed-by: Jacob Keller On 5/16/2020 8:03 AM, Richard Cochran wrote: > The utility function to compare port IDs takes pointers, but it only needs > to read the referenced data. This patch marks the parameters as const, > allowing passing constants in the future. > > Signed-off-by: Richard C

Re: [Linuxptp-devel] [PATCH 06/11] sk: Convey transmit path errors to the caller.

2020-05-18 Thread Jacob Keller
Reviewed-by: Jacob Keller On 5/16/2020 8:03 AM, Richard Cochran wrote: > The transport layer's functional interface foresees having error codes > percolate back up to the caller. However, up until now, the sk module > simply returned -1 for any error. This patch lets the code return the > speci

Re: [Linuxptp-devel] [PATCH 05/11] raw: Convey transmit path errors to the caller.

2020-05-18 Thread Jacob Keller
Reviewed-by: Jacob Keller This one is even easier to tell it is correct. On 5/16/2020 8:03 AM, Richard Cochran wrote: > The transport layer's functional interface foresees having error codes > percolate back up to the caller. However, up until now, the raw module > simply returned -1 for any

Re: [Linuxptp-devel] [PATCH 04/11] uds: Convey transmit path errors to the caller.

2020-05-18 Thread Jacob Keller
Reviewed-by: Jacob Keller On 5/16/2020 8:03 AM, Richard Cochran wrote: > The transport layer's functional interface foresees having error codes > percolate back up to the caller. However, up until now, the uds module > simply returned -1 for any error. This patch lets the code return the > sp

Re: [Linuxptp-devel] [PATCH V1 1/2] Decouple servo state from automotive profile.

2020-05-18 Thread Richard Cochran
On Mon, May 18, 2020 at 04:12:52PM -0700, Jacob Keller wrote: > > +.B msg_interval_request > > +This will enable sending message interval request when servo transitions > > to > > +SERVO_LOCKED_STABLE state. If msg_interval_request is set, entry into > > +SERVO_LOCKED_STABLE state triggers the s

Re: [Linuxptp-devel] [PATCH 02/11] udp: Convey transmit path errors to the caller.

2020-05-18 Thread Jacob Keller
Reviewed-by: Jacob Keller On 5/16/2020 8:03 AM, Richard Cochran wrote: > The transport layer's functional interface foresees having error codes > percolate back up to the caller. However, up until now, the udp module > simply returned -1 for any error. This patch lets the code return the > sp

Re: [Linuxptp-devel] [PATCH 03/11] udp6: Convey transmit path errors to the caller.

2020-05-18 Thread Jacob Keller
Reviewed-by: Jacob Keller On 5/16/2020 8:03 AM, Richard Cochran wrote: > The transport layer's functional interface foresees having error codes > percolate back up to the caller. However, up until now, the udp6 module > simply returned -1 for any error. This patch lets the code return the > s

Re: [Linuxptp-devel] [PATCH 01/11] transport: Correct grammar in the doxygen comments.

2020-05-18 Thread Jacob Keller
Reviewed-by: Jacob Keller On 5/16/2020 8:03 AM, Richard Cochran wrote: > Signed-off-by: Richard Cochran > --- > transport.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/transport.h b/transport.h > index 5b8c413..7a7f87b 100644 > --- a/transport.h > +++ b/tra

Re: [Linuxptp-devel] [PATCH V1 1/2] Decouple servo state from automotive profile.

2020-05-18 Thread Jacob Keller
On 5/16/2020 7:42 AM, Richard Cochran wrote: > From: Vincent Cheng > > The logic for the Automotive Profile added a message interval update > mechanism that triggers whenever the servo enters the "stable locked" > state. This SERVO_LOCKED_STABLE state is active when the > configuration option

Re: [Linuxptp-devel] [PATCH V1 2/2] Add support for write phase mode.

2020-05-18 Thread FUSTE Emmanuel
Le 16/05/2020 à 16:42, Richard Cochran a écrit : > Recently the Linux kernel's PTP Hardware Clock interface was expanded > to include a "write phase" mode where the clock servo in implemented > in hardware. This mode hearkens back to the tradition ntp_adjtime > interface, passing a measured offset

Re: [Linuxptp-devel] [PATCH V1 2/2] Add support for write phase mode.

2020-05-18 Thread Miroslav Lichvar
On Sat, May 16, 2020 at 07:42:26AM -0700, Richard Cochran wrote: > Recently the Linux kernel's PTP Hardware Clock interface was expanded > to include a "write phase" mode where the clock servo in implemented > in hardware. This mode hearkens back to the tradition ntp_adjtime > interface, passing a