Re: [Linuxptp-devel] [PATCH] The daemon should not downgrade the RX filter. An AVB/TSN application may use it. Follow Cliff Spradlin recommendation and add a configuration option.

2018-06-13 Thread Cliff Spradlin via Linuxptp-devel
On Wed, Jun 13, 2018 at 8:39 PM Richard Cochran wrote: > 1. normal - current code > 2. check - read only ioctl; quit if setting not rich enough for the HW time stamping mode Yeah, I'd suggest naming these modes 'overwrite' and 'check'. On Tue, Jun 12, 2018 at 12:40:06PM +, Geva, Erez

Re: [Linuxptp-devel] [PATCH] The daemon should not downgrade the RX filter. An AVB/TSN application may use it. Follow Cliff Spradlin recommendation and add a configuration option.

2018-06-13 Thread Richard Cochran
On Tue, Jun 12, 2018 at 12:40:06PM +, Geva, Erez wrote: > Signed-off-by: Erez Geva Please write a proper commit message with a succinct subject line. > +static struct config_enum hwts_filter_enu[] = { > + { "default", HWTS_FILTER_DEF }, "DEF" looks silly. Please spell out

[Linuxptp-devel] [PATCH] The daemon should not downgrade the RX filter. An AVB/TSN application may use it. Follow Cliff Spradlin recommendation and add a configuration option.

2018-06-12 Thread Geva, Erez
Signed-off-by: Erez Geva --- config.c| 9 + ptp4l.8 | 8 raw.c | 6 -- sk.c| 38 -- sk.h| 14 +- transport.c | 11 ++- transport_private.h

Re: [Linuxptp-devel] [PATCH] The daemon should not downgrade the RX filter. An AVB/TSN application may use it.

2018-06-11 Thread Richard Cochran
On Mon, Jun 11, 2018 at 11:26:25AM -0700, Cliff Spradlin via Linuxptp-devel wrote: > I feel like this would be better implemented as a config option - for > example, an option to not adjust SIOCSHWTSTAMP at all, or to have an > explicit value to set it to. > > My preference would be to have an

Re: [Linuxptp-devel] [PATCH] The daemon should not downgrade the RX filter. An AVB/TSN application may use it.

2018-06-11 Thread Cliff Spradlin via Linuxptp-devel
I feel like this would be better implemented as a config option - for example, an option to not adjust SIOCSHWTSTAMP at all, or to have an explicit value to set it to. My preference would be to have an option to not adjust it. Then you could use hwstamp_ctl or another program before running ptp4l

[Linuxptp-devel] [PATCH] The daemon should not downgrade the RX filter. An AVB/TSN application may use it.

2018-06-11 Thread Geva, Erez
Signed-off-by: Erez Geva --- sk.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/sk.c b/sk.c index f18b2bf..de8bf58 100644 --- a/sk.c +++ b/sk.c @@ -55,8 +55,17 @@ static int hwts_init(int fd, const char *device, int rx_filter, int tx_type)