Re: [Linuxptp-devel] [PATCH V1 1/2] Decouple servo state from automotive profile.

2020-05-26 Thread Patel, Vedang
Hi Richard, On May 26, 2020, at 2:04 PM, Richard Cochran mailto:richardcoch...@gmail.com>> wrote: On Tue, May 26, 2020 at 05:04:14PM +, Patel, Vedang wrote: Yes, I think it is remnant from the earlier version of the patch set which was implementing message interval request mechanism inside

Re: [Linuxptp-devel] [PATCH V1 1/2] Decouple servo state from automotive profile.

2020-05-26 Thread Richard Cochran
On Tue, May 26, 2020 at 05:04:14PM +, Patel, Vedang wrote: > Yes, I think it is remnant from the earlier version of the patch set > which was implementing message interval request mechanism inside the > FSM for the ’noop' BMCA. I think it should be safe to remove this. I > will submit a patch

Re: [Linuxptp-devel] [PATCH V1 1/2] Decouple servo state from automotive profile.

2020-05-26 Thread Patel, Vedang
On May 26, 2020, at 10:04 AM, Patel, Vedang mailto:vedang.pa...@intel.com>> wrote: Hi Richard, Jacob, On May 18, 2020, at 4:17 PM, Richard Cochran mailto:richardcoch...@gmail.com>> wrote: On Mon, May 18, 2020 at 04:12:52PM -0700, Jacob Keller wrote: +.B msg_interval_request +This will enable

Re: [Linuxptp-devel] [PATCH V1 1/2] Decouple servo state from automotive profile.

2020-05-26 Thread Patel, Vedang
Hi Richard, Jacob, > On May 18, 2020, at 4:17 PM, Richard Cochran wrote: > > On Mon, May 18, 2020 at 04:12:52PM -0700, Jacob Keller wrote: >>> +.B msg_interval_request >>> +This will enable sending message interval request when servo transitions >>> to >>> +SERVO_LOCKED_STABLE state. If msg_in

Re: [Linuxptp-devel] [PATCH V1 1/2] Decouple servo state from automotive profile.

2020-05-18 Thread Richard Cochran
On Mon, May 18, 2020 at 04:12:52PM -0700, Jacob Keller wrote: > > +.B msg_interval_request > > +This will enable sending message interval request when servo transitions > > to > > +SERVO_LOCKED_STABLE state. If msg_interval_request is set, entry into > > +SERVO_LOCKED_STABLE state triggers the s

Re: [Linuxptp-devel] [PATCH V1 1/2] Decouple servo state from automotive profile.

2020-05-18 Thread Jacob Keller
On 5/16/2020 7:42 AM, Richard Cochran wrote: > From: Vincent Cheng > > The logic for the Automotive Profile added a message interval update > mechanism that triggers whenever the servo enters the "stable locked" > state. This SERVO_LOCKED_STABLE state is active when the > configuration option

[Linuxptp-devel] [PATCH V1 1/2] Decouple servo state from automotive profile.

2020-05-16 Thread Richard Cochran
From: Vincent Cheng The logic for the Automotive Profile added a message interval update mechanism that triggers whenever the servo enters the "stable locked" state. This SERVO_LOCKED_STABLE state is active when the configuration option servo_offset_threshold is non-zero and servo_offset_thresho