Hi Richard, Jacob, > On May 18, 2020, at 4:17 PM, Richard Cochran <richardcoch...@gmail.com> wrote: > > On Mon, May 18, 2020 at 04:12:52PM -0700, Jacob Keller wrote: >>> +.B msg_interval_request >>> +This will enable sending message interval request when servo transitions >>> to >>> +SERVO_LOCKED_STABLE state. If msg_interval_request is set, entry into >>> +SERVO_LOCKED_STABLE state triggers the sending of message interval request >>> to >>> +adjust the intervals for Sync and Pdelay request messages. The Sync >>> interval >>> +is adjusted via the signaling mechanism and the pdelay request interval is >>> just >>> +adjusted locally. The new values to use for sync message intervals and >>> pdelay >>> +request intervals can be indicated by operLogSyncInterval and >>> +operLogPdelayReqInterval respectively. This mechanism is currently only >>> +supported when BMCA == 'noop'. The default value of msg_interval_request >>> is 0 >>> +(disabled). >> >> This claims that this option only is supported in BMCA == noop, but I >> don't see how that's enforced.. unless it is buried underneath the other >> functions? > > Yeah, I think you are right. The text about BMCA==noop appears to be > a Red Herring, even before this patch. > Yes, I think it is remnant from the earlier version of the patch set which was implementing message interval request mechanism inside the FSM for the ’noop' BMCA. I think it should be safe to remove this. I will submit a patch to do it.
Thanks, Vedang > Thanks, > Richard > > > _______________________________________________ > Linuxptp-devel mailing list > Linuxptp-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linuxptp-devel _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
