Re: [Linuxptp-devel] [PATCH v2 6/7] Add ignore_source_id config option.

2018-10-01 Thread Patel, Vedang
On Mon, 2018-10-01 at 21:32 +, Keller, Jacob E wrote: > > > > > -Original Message- > > From: Vedang Patel [mailto:vedang.pa...@intel.com] > > Sent: Wednesday, September 26, 2018 2:58 PM > > To: linuxptp-devel@lists.sourceforge.net > > Cc: Gomes, Vinicius ; Sanchez-Palencia, > > Jesus

Re: [Linuxptp-devel] [PATCH v2 4/7] Add BMCA config option.

2018-10-01 Thread Richard Cochran
On Mon, Oct 01, 2018 at 05:24:48PM +, Patel, Vedang wrote: > I will add the comment for clearing the SYNC_RX_TIMER. It is basically > to clear out the event returned by poll(). But why? Does the original code have a bug? Please explain. > But, I don't understand how moving the

Re: [Linuxptp-devel] [PATCH v2 4/7] Add BMCA config option.

2018-10-01 Thread Patel, Vedang
Hi Richard, On Sun, 2018-09-30 at 20:02 -0700, Richard Cochran wrote: > On Sun, Sep 30, 2018 at 08:00:51PM -0700, Richard Cochran wrote: > > > > On Wed, Sep 26, 2018 at 02:57:36PM -0700, Vedang Patel wrote: > > > > > > @@ -2472,6 +2480,7 @@ static enum fsm_event bc_event(struct port > > > *p,

Re: [Linuxptp-devel] [PATCH v2 4/7] Add BMCA config option.

2018-10-01 Thread Patel, Vedang
On Mon, 2018-10-01 at 10:59 -0700, Richard Cochran wrote: > On Mon, Oct 01, 2018 at 05:24:48PM +, Patel, Vedang wrote: > > > > I will add the comment for clearing the SYNC_RX_TIMER. It is > > basically > > to clear out the event returned by poll(). > But why?  Does the original code have a

Re: [Linuxptp-devel] [PATCH v2 6/7] Add ignore_source_id config option.

2018-10-01 Thread Keller, Jacob E
> -Original Message- > From: Vedang Patel [mailto:vedang.pa...@intel.com] > Sent: Wednesday, September 26, 2018 2:58 PM > To: linuxptp-devel@lists.sourceforge.net > Cc: Gomes, Vinicius ; Sanchez-Palencia, Jesus > > Subject: [Linuxptp-devel] [PATCH v2 6/7] Add ignore_source_id config