Re: [Linuxptp-devel] [PATCH] Adding following features to support Telecom profile G.8275.2
On Thu, May 19, 2022 at 10:57:06AM +0530, Devasish Dey wrote: > We are in the process of making the changes in small multiple patches so > that they can be easily acceptable by the community. I suggest starting with the easy stuff: 4. Delay mechanism As per IEEE1588-2019, Table 21 adding NO_MECHANISM support. In this case port does not implement the delay mechanism. (I think we already have this with the 'inhibit_delay_req' option) 2. Alternate master support (G.8275.2 Section 6.9 and G.8275.2 Appendix III) Please make sure that your patch also supports plain old 1588 (assuming there are differences to G.8275.x) Thanks, Richard ___ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
Re: [Linuxptp-devel] [PATCH] Adding following features to support Telecom profile G.8275.2
Hi Petr, Seems it was misinterpreted, it was just a suggestion from our end if the patch can be taken as a full for G.8275.2 functionality. We are in the process of making the changes in small multiple patches so that they can be easily acceptable by the community. Thanks, Devasish On Wed, 18 May 2022 at 21:32, Petr Machata wrote: > > Devasish Dey writes: > > > 1. We have invested time in development and have been verified by the > > team as a complete solution which is addressing the requirements of > > G.8275.2 > > It's good to know that you have taken time to make sure the changes > actually work. But you still need to present them in a way that is > possible to review and evaluate by the community. > > That means splitting the overall work into some number of topical > patchsets, contributing one at a time, working with the community until > it is acceptable, and then following up with the next patchset. > > This project broadly adheres to the same process as the Linux kernel > uses, so you can use the following as a guide: > > https://www.kernel.org/doc/html/latest/process/submitting-patches.html > > > Breaking the changes into small patches may lead to intermediate > > functionality breaks. So we strongly feel this should be taken as a > > single patch which addresses the complete G.8275.2 requirements. > > You have to make sure it doesn't. It should build cleanly and work after > every patch in the series. This is important for bisecting and > reverting. > ___ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
Re: [Linuxptp-devel] [PATCH] Adding following features to support Telecom profile G.8275.2
On Wed, May 18, 2022 at 11:27:08AM +0530, Devasish Dey wrote: > That's why we have added, "> + * @note Copyright (C) 2022 SyncMonk > Technologies " in all the files modified by SyncMonk > Technologies. And we recommend that this practice should be adopted by > community members. Good luck with that. ___ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
Re: [Linuxptp-devel] [PATCH] Adding following features to support Telecom profile G.8275.2
On Wed, May 18, 2022 at 11:27:08AM +0530, Devasish Dey wrote: > 1. We have invested time in development and have been verified by the team > as a complete solution which is addressing the requirements of G.8275.2 > Breaking the changes into small patches may lead to intermediate > functionality breaks. So we strongly feel this should be taken as a single > patch which addresses the complete G.8275.2 requirements. Okay, then I won't be taking this patch. Sorry, Richard ___ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
Re: [Linuxptp-devel] [PATCH] Adding following features to support Telecom profile G.8275.2
Hi Richard, Thanks for your response. We have reviewed the patch again as per your suggestion. 1. We have invested time in development and have been verified by the team as a complete solution which is addressing the requirements of G.8275.2 Breaking the changes into small patches may lead to intermediate functionality breaks. So we strongly feel this should be taken as a single patch which addresses the complete G.8275.2 requirements. 2. GPL2.0 License mandates that If the software is modified by someone then recipients should know that what they have is not the original so that any problems introduced by others will not reflect on the original authors' reputations. *"Also, for each author's protection and ours, we want to make certain that everyone understands that there is no warranty for this free software. If the software is modified by someone else and passed on, we want its recipients to know that what they have is not the original, so that any problems introduced by others will not reflect on the original authors' reputations."* That's why we have added, "> + * @note Copyright (C) 2022 SyncMonk Technologies " in all the files modified by SyncMonk Technologies. And we recommend that this practice should be adopted by community members. Thanks, Devasish Dey Vice President Engineering Product Development | SyncMonk Technologies Pvt Limited +91-783-8079202 devasish@syncmonk.net www.syncmonk.net 367, KPC Layout, Bangalore-560035 On Mon, 16 May 2022 at 19:55, Richard Cochran wrote: > On Mon, May 16, 2022 at 02:08:06PM +0530, SyncMonk Technologies wrote: > > From: SyncMonk > > > > 1. Inclusion of virtual PTP port on a PTP clock. (G.8275 Annex B) > > 2. Alternate master support (G.8275.2 Section 6.9 and G.8275.2 Appendix > III) > > 3. TLV support for interface rate (G.8275.2 Annex D) > >When master and slave instance interacting with each other operating > >at different interface speed, delay assymetry needs to be compensated > >as described in G.8271 appendix V. > > 4. Delay mechanism > >As per IEEE1588-2019, Table 21 adding NO_MECHANISM support. In this > >case port does not implement the delay mechanism. > > 5. Packet Timing Signal Fail (PTSF)(G.8275.2 Section 6.7.11) > > - PTSF-lossSync > > signal raised due to lack of reception of PTP Sycn, Followup or > > delay response messages > > - PTSF-unusable > > unusable PTP packet timing signal received by the request-port, > > exceeding the input tolerance of the request-port > > 6. Dynamic data set updates for external servo. > > - defaultDS.clockQuality.clockClass > > To support holdover in the T-BC-P/A and T-GM. > > - timePropertiesDS.frequencyTraceable > > To support availability of a PRC-traceable physical layer > > frequency input signal > > - PTSF Unusable. > > > Wow, that is a massive set of changes. > > > 38 files changed, 1530 insertions(+), 54 deletions(-) > > This is WAY too big for one commit. I need to see small, granular > changes. I guess your list of 6 new features would be 6 patch series > of 3-4 patches each. > > > @@ -15,6 +15,14 @@ > > * You should have received a copy of the GNU General Public License > along > > * with this program; if not, write to the Free Software Foundation, > Inc., > > * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > > + * > > + * @note Copyright (C) 2022 SyncMonk Technologies < > servi...@syncmonk.net> > > + * Also, for each author's protection and ours, we want to make certain > that > > + * everyone understands that there is no warranty for this free > software. > > + * If the software is modified by someone else and passed on, we want > its > > + * recipients to know that what they have is not the original, so that > any > > + * problems introduced by others will not reflect on the original > authors' > > + * reputations. > > Please drop this extra legalese. > > Thanks, > Richard > > > ___ > Linuxptp-devel mailing list > Linuxptp-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linuxptp-devel > -- ___ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
Re: [Linuxptp-devel] [PATCH] Adding following features to support Telecom profile G.8275.2
On Mon, May 16, 2022 at 02:08:06PM +0530, SyncMonk Technologies wrote: > From: SyncMonk > > 1. Inclusion of virtual PTP port on a PTP clock. (G.8275 Annex B) > 2. Alternate master support (G.8275.2 Section 6.9 and G.8275.2 Appendix III) > 3. TLV support for interface rate (G.8275.2 Annex D) >When master and slave instance interacting with each other operating >at different interface speed, delay assymetry needs to be compensated >as described in G.8271 appendix V. > 4. Delay mechanism >As per IEEE1588-2019, Table 21 adding NO_MECHANISM support. In this >case port does not implement the delay mechanism. > 5. Packet Timing Signal Fail (PTSF)(G.8275.2 Section 6.7.11) > - PTSF-lossSync > signal raised due to lack of reception of PTP Sycn, Followup or > delay response messages > - PTSF-unusable > unusable PTP packet timing signal received by the request-port, > exceeding the input tolerance of the request-port > 6. Dynamic data set updates for external servo. > - defaultDS.clockQuality.clockClass > To support holdover in the T-BC-P/A and T-GM. > - timePropertiesDS.frequencyTraceable > To support availability of a PRC-traceable physical layer > frequency input signal > - PTSF Unusable. Wow, that is a massive set of changes. > 38 files changed, 1530 insertions(+), 54 deletions(-) This is WAY too big for one commit. I need to see small, granular changes. I guess your list of 6 new features would be 6 patch series of 3-4 patches each. > @@ -15,6 +15,14 @@ > * You should have received a copy of the GNU General Public License along > * with this program; if not, write to the Free Software Foundation, Inc., > * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > + * > + * @note Copyright (C) 2022 SyncMonk Technologies > + * Also, for each author's protection and ours, we want to make certain that > + * everyone understands that there is no warranty for this free software. > + * If the software is modified by someone else and passed on, we want its > + * recipients to know that what they have is not the original, so that any > + * problems introduced by others will not reflect on the original authors' > + * reputations. Please drop this extra legalese. Thanks, Richard ___ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
