Re: [Linuxptp-devel] [PATCH RFC V2 08/11] port: Implement the NetSync Monitor protocol.

2018-03-08 Thread Richard Cochran
On Thu, Mar 08, 2018 at 08:07:26AM +, Anders Selhammer wrote: > I reviewed it in outlook, but now when I open it in windows 10 built in > client, it all look as it should. I strongly suggest getting a different email client. If your MTA is exchange, then you will have to create an outside

Re: [Linuxptp-devel] [PATCH RFC V2 08/11] port: Implement the NetSync Monitor protocol.

2018-03-06 Thread Anders Selhammer
>I appreciate your taking the effort to review the series. However, in the >future, please do not top-post! >Instead, comment directly in-line, and trim the reply to remove any patch >hunks that are not being commented upon. Ok, I will comment inline in the future, sorry about that. >>

Re: [Linuxptp-devel] [PATCH RFC V2 08/11] port: Implement the NetSync Monitor protocol.

2018-03-05 Thread Richard Cochran
On Mon, Mar 05, 2018 at 12:41:56PM +, Anders Selhammer wrote: > We are programming C, not Java, and so opening braces of a function belong on > a line all by themselves. And they all are. Where is the problem? > +static void extract_address(struct ptp_message *m, struct PortAddress >

Re: [Linuxptp-devel] [PATCH RFC V2 08/11] port: Implement the NetSync Monitor protocol.

2018-03-05 Thread Anders Selhammer
We are programming C, not Java, and so opening braces of a function belong on a line all by themselves.  +static void extract_address(struct ptp_message *m, struct PortAddress *paddr) { static int msg_current(struct ptp_message *m, struct timespec now) { static struct follow_up_info_tlv