Re: [Linuxwacom-devel] Feature request: inverting parameters

2011-03-02 Thread Pander
On 2011-03-01 18:36, Jason Gerecke wrote: On Mon, Feb 28, 2011 at 3:45 AM, Pander pan...@users.sourceforge.net wrote: Hi all, I would like to make the following feature request for inverting/toggling parameters. Please extend values for the following parameters with invert: touch:

Re: [Linuxwacom-devel] Patches for supporting Wacom Bamboo Fun CTH-661SE-NL

2011-03-02 Thread Ping Cheng
On Sun, Feb 27, 2011 at 12:16 PM, Pander pan...@users.sourceforge.netwrote: Hi all, Here are some patches for supporting Wacom Bamboo Fun CTH-661SE-NL. These are created on a system with Ubuntu 10.10 Maverick. The USB ID has been added to the USB ID Repository at

Re: [Linuxwacom-devel] Sample xsetwacom scripts vetting

2011-03-02 Thread Peter Hutterer
On Tue, Mar 01, 2011 at 12:19:42PM -0600, Favux ... wrote: Xorg.conf.d is finished. Please review it when you get a chance. Done, I think. Please let me know if I culled too much. IMO, one example is enough and we should rely on our users being smart enough to interpolate from the examples.

Re: [Linuxwacom-devel] Small patch to improve comment

2011-03-02 Thread Peter Hutterer
On Tue, Mar 01, 2011 at 09:58:40AM +0100, Pander wrote: Hi all, Small patch to improve comment in src/wcmUSB.c line 200 CTH-661 - Bamboo Fun CTH-661SE-NL See attachment. Can someone take this patch under consideration? I also have a question related to this model. Is it correct that

Re: [Linuxwacom-devel] Feature request: inverting parameters

2011-03-02 Thread Peter Hutterer
On Tue, Mar 01, 2011 at 09:52:27AM +0100, Pander wrote: On 2011-02-28 12:45, Pander wrote: Hi all, I would like to make the following feature request for inverting/toggling parameters. Please extend values for the following parameters with invert: touch: on, off,

[Linuxwacom-devel] [PATCH] Move VCOPY storage out of the function.

2011-03-02 Thread Peter Hutterer
Not 100% sure why this is needed but it looks like the returned address is invalid, causing memory corruption. Simply moving the variable into a global scope fixes this issue. Fixes crash with server 1.7. Reported-by: Vu Ngoc San san.vu-n...@laposte.net Signed-off-by: Peter Hutterer

[Linuxwacom-devel] [PATCH 1/3] test: add ifdefs to allow running tests against 1.7

2011-03-02 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/fake-symbols.c | 10 -- test/fake-symbols.h |9 - 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/test/fake-symbols.c b/test/fake-symbols.c index b0af219..9d00d2d 100644 --- a/test/fake-symbols.c

Re: [Linuxwacom-devel] Sample xsetwacom scripts vetting

2011-03-02 Thread Favux ...
Alright, looks good. I think I like the new tip appearance. Intriguing anyway. If we do a separate Bamboo page do we pull the examples along and put new examples in the Xorg.conf.d? Favux On Tue, Mar 1, 2011 at 5:36 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Mar 01, 2011 at

Re: [Linuxwacom-devel] Feature request: inverting parameters

2011-03-02 Thread Peter Hutterer
On Mon, Feb 28, 2011 at 12:45:35PM +0100, Pander wrote: I would like to make the following feature request for inverting/toggling parameters. Please extend values for the following parameters with invert: touch: on, off, invert (toggle) gesture:on, off, invert (toggle)

[Linuxwacom-devel] [PATCH] xsetwacom.c: Fix a typo preventing Rotate ccw from working

2011-03-02 Thread Timo Aaltonen
Introduced in ac821ba29a828fb9bb531243d0a226a7fe494504 Signed-off-by: Timo Aaltonen timo.aalto...@canonical.com --- tools/xsetwacom.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c index 6713a97..fa98e3e 100644 ---

Re: [Linuxwacom-devel] Sample xsetwacom scripts vetting

2011-03-02 Thread Chris Bagwell
On Tue, Mar 1, 2011 at 7:42 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Mar 01, 2011 at 07:35:02PM -0600, Favux ... wrote: Alright, looks good.  I think I like the new tip appearance.  Intriguing anyway. If we do a separate Bamboo page do we pull the examples along and put

Re: [Linuxwacom-devel] Small patch to improve comment

2011-03-02 Thread Favux ...
Hi, I'm not sure that follows our little naming convention for wcmUSB.c. I believe that model was first reported by Tobias Verbeke (12-4-10) as the Bamboo PT Special Edition medium CTH-661/L. Tobias is also the tested-by on at least the linux-input patch. If we change it we should change it to:

Re: [Linuxwacom-devel] Small patch to improve comment

2011-03-02 Thread Chris Bagwell
Dave, can you comment on this? I tend to rely on the information you've collected in Ubuntu forum (probably its in wiki now?). See below. On Tue, Mar 1, 2011 at 4:32 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Mar 01, 2011 at 09:58:40AM +0100, Pander wrote: Hi all, Small

Re: [Linuxwacom-devel] Small patch to improve comment

2011-03-02 Thread Ping Cheng
On Tue, Mar 1, 2011 at 2:32 PM, Peter Hutterer peter.hutte...@who-t.netwrote: On Tue, Mar 01, 2011 at 09:58:40AM +0100, Pander wrote: Hi all, Small patch to improve comment in src/wcmUSB.c line 200 CTH-661 - Bamboo Fun CTH-661SE-NL See attachment. Can someone take this patch under

Re: [Linuxwacom-devel] Sample xsetwacom scripts vetting

2011-03-02 Thread Ping Cheng
On Tue, Mar 1, 2011 at 5:42 PM, Peter Hutterer peter.hutte...@who-t.netwrote: On Tue, Mar 01, 2011 at 07:35:02PM -0600, Favux ... wrote: Alright, looks good. I think I like the new tip appearance. Intriguing anyway. If we do a separate Bamboo page do we pull the examples along and put

Re: [Linuxwacom-devel] Small patch to improve comment

2011-03-02 Thread Pander
On 2011-03-02 16:17, Chris Bagwell wrote: Dave, can you comment on this? I tend to rely on the information you've collected in Ubuntu forum (probably its in wiki now?). See below. On Tue, Mar 1, 2011 at 4:32 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Mar 01, 2011 at

Re: [Linuxwacom-devel] [PATCH] Move VCOPY storage out of the function.

2011-03-02 Thread Ping Cheng
On Tue, Mar 1, 2011 at 4:33 PM, Peter Hutterer peter.hutte...@who-t.netwrote: Not 100% sure why this is needed but it looks like the returned address is invalid, causing memory corruption. Simply moving the variable into a global scope fixes this issue. Fixes crash with server 1.7.

Re: [Linuxwacom-devel] Heading towards regular releases

2011-03-02 Thread Ping Cheng
On Tue, Mar 1, 2011 at 5:55 PM, Peter Hutterer peter.hutte...@who-t.netwrote: Following up on this, I just bumped the version in git to 0.10.99. New release versioning scheme until we settle on a stable 1.0: - 0.x.99 is the version number in-between releases - 0.x.99.901 is the first RC -

Re: [Linuxwacom-devel] Small patch to improve comment

2011-03-02 Thread Favux ...
Hi Chris, We got it from the label on the back of the tablet to start distinguishing them from the previous 5 models. Because some of the Bamboo models were overlapping. Pander, the Ubuntu community wikis are maintained by Ubuntu users, not the linux wacom project. Loic2 is no longer

Re: [Linuxwacom-devel] Small patch to improve comment

2011-03-02 Thread Pander
On 2011-03-02 22:24, Favux ... wrote: Hi Chris, We got it from the label on the back of the tablet to start distinguishing them from the previous 5 models. Because some of the Bamboo models were overlapping. See below for extra data on my tablet. Pander, the Ubuntu community wikis are

Re: [Linuxwacom-devel] [PATCH] Move VCOPY storage out of the function.

2011-03-02 Thread Peter Hutterer
On Wed, Mar 02, 2011 at 10:43:34AM -0800, Ping Cheng wrote: On Tue, Mar 1, 2011 at 4:33 PM, Peter Hutterer peter.hutte...@who-t.netwrote: Not 100% sure why this is needed but it looks like the returned address is invalid, causing memory corruption. Simply moving the variable into a

Re: [Linuxwacom-devel] [PATCH] xsetwacom.c: Fix a typo preventing Rotate ccw from working

2011-03-02 Thread Peter Hutterer
On Wed, Mar 02, 2011 at 07:09:27PM +0200, Timo Aaltonen wrote: Introduced in ac821ba29a828fb9bb531243d0a226a7fe494504 Signed-off-by: Timo Aaltonen timo.aalto...@canonical.com --- tools/xsetwacom.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/xsetwacom.c

Re: [Linuxwacom-devel] Patches for supporting Wacom Bamboo Fun CTH-661SE-NL

2011-03-02 Thread Favux ...
On Wed, Mar 2, 2011 at 4:22 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Mar 01, 2011 at 01:41:54PM -0800, Ping Cheng wrote: On Sun, Feb 27, 2011 at 12:16 PM, Pander pan...@users.sourceforge.netwrote: Please let me know what to add to  

[Linuxwacom-devel] [PATCH 1/2] Don't discard the first 2 USB events

2011-03-02 Thread Ping Cheng
It was an issue with older kernels. This driver only supports kernels 2.6.26 and later. No need to do that any more. There is a special case that this code may have helped though. If tool is on the tablet while driver started, waiting for more events before processing them would fill some

[Linuxwacom-devel] [PATCH 2/2] Set ISDV4 to PROTOCOL_GENERIC in isdv4ProbeKeys

2011-03-02 Thread Ping Cheng
isdv4ProbeKeys is the place we set all tool types and other keys. Reset the ProtocolLevel to PROTOCOL_GENERIC here as well. Otherwise, it would be overwrote by the default. Signed-off-by: Ping Cheng pingli...@gmail.com --- src/wcmISDV4.c |5 +++-- 1 files changed, 3 insertions(+), 2

Re: [Linuxwacom-devel] Patches for supporting Wacom Bamboo Fun CTH-661SE-NL

2011-03-02 Thread Peter Hutterer
On Wed, Mar 02, 2011 at 05:07:37PM -0600, Favux ... wrote: On Wed, Mar 2, 2011 at 4:22 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Mar 01, 2011 at 01:41:54PM -0800, Ping Cheng wrote: On Sun, Feb 27, 2011 at 12:16 PM, Pander pan...@users.sourceforge.netwrote: Please let

Re: [Linuxwacom-devel] Heading towards regular releases

2011-03-02 Thread Peter Hutterer
On Wed, Mar 02, 2011 at 11:44:09AM -0800, Ping Cheng wrote: On Tue, Mar 1, 2011 at 5:55 PM, Peter Hutterer peter.hutte...@who-t.netwrote: Following up on this, I just bumped the version in git to 0.10.99. New release versioning scheme until we settle on a stable 1.0: - 0.x.99 is the

Re: [Linuxwacom-devel] Heading towards regular releases

2011-03-02 Thread Ping Cheng
On Wed, Mar 2, 2011 at 4:24 PM, Peter Hutterer peter.hutte...@who-t.netwrote: the problem with that patch was IIRC that it was based on some mistaken assumptions. e.g. the refcounting was working completely different to what you tried to do. so it was more a problem with the patch itself than

Re: [Linuxwacom-devel] [PATCH 1/2] Don't discard the first 2 USB events

2011-03-02 Thread Chris Bagwell
On Wed, Mar 2, 2011 at 5:16 PM, Ping Cheng pingli...@gmail.com wrote: It was an issue with older kernels. This driver only supports kernels 2.6.26 and later. No need to do that any more. There is a special case that this code may have helped though. If tool is on the tablet while driver

Re: [Linuxwacom-devel] Heading towards regular releases

2011-03-02 Thread Ping Cheng
On Wed, Mar 2, 2011 at 5:31 PM, Ping Cheng pingli...@gmail.com wrote: On Wed, Mar 2, 2011 at 4:24 PM, Peter Hutterer peter.hutte...@who-t.netwrote: the problem with that patch was IIRC that it was based on some mistaken assumptions. e.g. the refcounting was working completely different

Re: [Linuxwacom-devel] [PATCH 2/2] Set ISDV4 to PROTOCOL_GENERIC in isdv4ProbeKeys

2011-03-02 Thread Chris Bagwell
Setting it in probeKeys() is consistent with wcmUSB... Can't think of any issues offhand. Acked-by: Chris Bagwell ch...@cnpbagwell.com Chris On Wed, Mar 2, 2011 at 5:16 PM, Ping Cheng pingli...@gmail.com wrote: isdv4ProbeKeys is the place we set all tool types and other keys. Reset the

Re: [Linuxwacom-devel] Heading towards regular releases

2011-03-02 Thread Peter Hutterer
On Wed, Mar 02, 2011 at 05:58:37PM -0800, Ping Cheng wrote: On Wed, Mar 2, 2011 at 5:31 PM, Ping Cheng pingli...@gmail.com wrote: On Wed, Mar 2, 2011 at 4:24 PM, Peter Hutterer peter.hutte...@who-t.netwrote: the problem with that patch was IIRC that it was based on some mistaken

Re: [Linuxwacom-devel] Making sense of suppress

2011-03-02 Thread Peter Hutterer
On Thu, Mar 03, 2011 at 01:35:20PM +1000, Peter Hutterer wrote: I'm trying to make sense of the suppress handling in the code and it's confusing me. In wcmEvent() we call wcmCheckSuppress() which compares old and new state against the suppress value and then returns: 0 if the event is to be

Re: [Linuxwacom-devel] [PATCH 1/2] Don't discard the first 2 USB events

2011-03-02 Thread Peter Hutterer
On Wed, Mar 02, 2011 at 03:16:15PM -0800, Ping Cheng wrote: It was an issue with older kernels. This driver only supports kernels 2.6.26 and later. No need to do that any more. There is a special case that this code may have helped though. If tool is on the tablet while driver started,

[Linuxwacom-devel] [PATCH 4/4] Add a fixme about tool handling.

2011-03-02 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/wcmConfig.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/src/wcmConfig.c b/src/wcmConfig.c index 7863167..bd37659 100644 --- a/src/wcmConfig.c +++ b/src/wcmConfig.c @@ -340,6 +340,11 @@ static Bool

[Linuxwacom-devel] [PATCH 3/4] Keep an enabled flag in the tool to avoid racy startup.

2011-03-02 Thread Peter Hutterer
There is a small time window where a device may try to send an event even though it is not fully setup to send events yet, causing a server crash. This window opens when the tool is added to the list of devices in wcmParseOptions() and closes with the server calling xf86ActivateDevice(). If an