Re: [Linuxwacom-devel] Intuos4 L on Ubuntu 10.04

2011-03-09 Thread Chris Bagwell
Cool. Thanks for solving the mystery. Chris On Wed, Mar 9, 2011 at 1:50 AM, Eduard Hasenleithner ehase...@gmail.com wrote: 2011/3/6 Chris Bagwell ch...@cnpbagwell.com: Did you see in this weeks git that a VCOPY bugfix was submitted that stops crashes on xorg 1.7 servers?  It so happens that

[Linuxwacom-devel] [PATCH 4/4 v2] Perform bounds checking on RawSample

2011-03-09 Thread Jason Gerecke
I made the mistake of setting this to zero and then bringing my pen into proximity. Ooops. X crashed. Looks like mathematics still can't handle getting the average of zero things ;) Signed-off-by: Jason Gerecke killert...@gmail.com --- Changes in v2: - Modified patch subject to better match 2nd

Re: [Linuxwacom-devel] [PATCH] remove per-device filter function

2011-03-09 Thread Ping Cheng
On Wed, Mar 9, 2011 at 9:27 AM, ch...@cnpbagwell.com wrote: From: Chris Bagwell ch...@cnpbagwell.com Over time, we've merged device specific filter routines into single version. So there is no need for historic hook to register at runtime. ISDv4 devices never registered any filter which

[Linuxwacom-devel] [PATCH] Re-vamp source inclusion for test build suite.

2011-03-09 Thread Peter Hutterer
test/Makefile.am included src/Makefile.am for the driver sources. However, that also lead to the driver being built twice, once in src/ and once in test/. On make install, test/wacom_drv.so would overwrite the src/wacom_drv.so and thus install a driver with all static symbols compiled as

[Linuxwacom-devel] [PATCH] Use xf86ScaleAxis for pressure normalization.

2011-03-09 Thread Peter Hutterer
And copy the server's xf86ScaleAxis for the test. Not ideal, I guess but oh well. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/wcmCommon.c |8 +--- test/fake-symbols.c | 19 ++- 2 files changed, 23 insertions(+), 4 deletions(-) diff --git

[Linuxwacom-devel] [PATCH 2/7] test: write a non-test for wcmTilt2R

2011-03-09 Thread Peter Hutterer
It's non-transparent what wcmTilt2R actually does at the moment, so generate a test table from the current code and test against that. This way we at least know when we're breaking something. Exception: wraparound value generates +900 instead of -900. We must not send +900, our max range is 899,

[Linuxwacom-devel] [PATCH 4/7] Fix wcmTilt2R so it uses defines instead of hardcoded numbers.

2011-03-09 Thread Peter Hutterer
Every time number is hardcoded deep inside the driver, god kills a kitten and a little part of me dies (unrelated to the kitten death). Use the defines already. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/wcmFilter.c | 11 ++- 1 files changed, 6 insertions(+), 5

[Linuxwacom-devel] [PATCH 3/7] Document wcmTilt2R (and add a fixme)

2011-03-09 Thread Peter Hutterer
Because not everyone has hours to figure out what each function does. Come to think of it, I don't actually either... Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/wcmFilter.c | 34 +- 1 files changed, 29 insertions(+), 5 deletions(-) diff

[Linuxwacom-devel] [PATCH 5/7] Add a offset paramater value to wcmTilt2R

2011-03-09 Thread Peter Hutterer
Say No To Hardcoding. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/wcmCommon.c |2 +- src/wcmFilter.c | 12 src/xf86Wacom.h |2 +- src/xf86WacomDefs.h |3 +++ test/wacom-tests.c |2 +- 5 files changed, 14 insertions(+), 7 deletions(-)