Re: [Linuxwacom-devel] Graphire's and PAD issues

2011-03-14 Thread Ping Cheng
On Tue, Mar 15, 2011 at 2:31 AM, Chris Bagwell > > Hmmm. There is an issue there when we convert to generic, huh? Well, > we can squeak by if we continue to use BTN_LEFT/RIGHT/MIDDLE for mouse > and BTN_0/1/4/5 for PAD. > > I keep this in mind as I make updates to see if I can resolve some of >

Re: [Linuxwacom-devel] Graphire's and PAD issues

2011-03-14 Thread Chris Bagwell
On Mon, Mar 14, 2011 at 5:13 PM, Ping Cheng wrote: > On Mon, Mar 14, 2011 at 2:54 PM, Ping Cheng wrote: >> >> On Mon, Mar 14, 2011 at 2:08 PM, Chris Bagwell >> wrote: >>> >>> >>> >>> I obviously need some help here since I'm flying blind without the >>> problem device.  I can make a kernel patch

Re: [Linuxwacom-devel] Graphire's and PAD issues

2011-03-14 Thread Chris Bagwell
On Mon, Mar 14, 2011 at 4:54 PM, Ping Cheng wrote: > On Mon, Mar 14, 2011 at 2:08 PM, Chris Bagwell wrote: >> >> Hi all, >> >> This is related to thread on linuxwacom-discuss about older Bamboo's >> PAD not working right with recent xf86-input-wacom's.  This device is >> handled by Graphire drive

Re: [Linuxwacom-devel] [PATCH v3 5/5] Add tests for convert_value_from_user

2011-03-14 Thread Peter Hutterer
On Tue, Mar 15, 2011 at 11:36:26AM +1000, Peter Hutterer wrote: > On Mon, Mar 14, 2011 at 04:10:59PM -0700, Jason Gerecke wrote: > > Some basic tests to ensure booleans and non-booleans act like we > > want them to. > > > > Signed-off-by: Jason Gerecke > > --- > > Changes from v2: > > > > * Us

[Linuxwacom-devel] [PATCH] Add fake symbols for serverClient and QueueWorkProc

2011-03-14 Thread Peter Hutterer
Broke linking of unit tests in 94a8eabadd062de6ceed8563089b863d887f8770. Signed-off-by: Peter Hutterer --- test/fake-symbols.c | 11 ++- test/fake-symbols.h |5 + 2 files changed, 15 insertions(+), 1 deletions(-) diff --git a/test/fake-symbols.c b/test/fake-symbols.c index 8f6

Re: [Linuxwacom-devel] [PATCH v4 1/5] Change signature of convert_value_from_user

2011-03-14 Thread Peter Hutterer
On Mon, Mar 14, 2011 at 04:19:24PM -0700, Jason Gerecke wrote: > Have it return true/false to indicate conversion success/failure. > Note that in its current state the function cannot tell if there > was a conversion failure... > > Signed-off-by: Jason Gerecke > --- > Changes from v3: > > * Le

Re: [Linuxwacom-devel] [PATCH v3 5/5] Add tests for convert_value_from_user

2011-03-14 Thread Peter Hutterer
On Mon, Mar 14, 2011 at 04:10:59PM -0700, Jason Gerecke wrote: > Some basic tests to ensure booleans and non-booleans act like we > want them to. > > Signed-off-by: Jason Gerecke > --- > Changes from v2: > > * Use &val instead of allocating memory > > tools/xsetwacom.c | 38 +++

Re: [Linuxwacom-devel] [PATCH] Initialize USB pad device once up front

2011-03-14 Thread Peter Hutterer
On Sun, Mar 13, 2011 at 10:27:44PM -0500, ch...@cnpbagwell.com wrote: > From: Chris Bagwell > > Streamlines normal execution some but also resolves an issue reported > for older Bamboo's since its now executed for all protocol types > and not just generic protocols. > > Older Bamboo's and Graphi

[Linuxwacom-devel] [PATCH v4 1/5] Change signature of convert_value_from_user

2011-03-14 Thread Jason Gerecke
Have it return true/false to indicate conversion success/failure. Note that in its current state the function cannot tell if there was a conversion failure... Signed-off-by: Jason Gerecke --- Changes from v3: * Less PEBKAC. (no default needed on our int val...) tools/xsetwacom.c | 36 +

[Linuxwacom-devel] [PATCH v3 5/5] Add tests for convert_value_from_user

2011-03-14 Thread Jason Gerecke
Some basic tests to ensure booleans and non-booleans act like we want them to. Signed-off-by: Jason Gerecke --- Changes from v2: * Use &val instead of allocating memory tools/xsetwacom.c | 38 ++ 1 files changed, 38 insertions(+), 0 deletions(-) diff --

[Linuxwacom-devel] [PATCH v3 1/5] Change signature of convert_value_from_user

2011-03-14 Thread Jason Gerecke
Have it return true/false to indicate conversion success/failure. Note that in its current state the function cannot tell if there was a conversion failure... Signed-off-by: Jason Gerecke --- Changes from v2: * Use &val instead of allocating memory tools/xsetwacom.c | 36 +++

Re: [Linuxwacom-devel] [PATCH] Fix button assignment bug introduced in 22bc3028

2011-03-14 Thread Jason Gerecke
On Sun, Mar 13, 2011 at 11:00 PM, Peter Hutterer wrote: > On Fri, Mar 11, 2011 at 04:02:56PM -0800, Jason Gerecke wrote: >> I just noticed I was unable to map button presses to keys and after >> some investigation (yay git bisect!) found the following commit >> caused the bug: >> >> 22bc3028effbdc

Re: [Linuxwacom-devel] Graphire's and PAD issues

2011-03-14 Thread Ping Cheng
On Mon, Mar 14, 2011 at 2:54 PM, Ping Cheng wrote: > On Mon, Mar 14, 2011 at 2:08 PM, Chris Bagwell wrote: > >> > > I obviously need some help here since I'm flying blind without the >> problem device. I can make a kernel patch but can't test it. >> >> Part of this email is also to make sure n

Re: [Linuxwacom-devel] Graphire's and PAD issues

2011-03-14 Thread Ping Cheng
On Mon, Mar 14, 2011 at 2:08 PM, Chris Bagwell wrote: > Hi all, > > This is related to thread on linuxwacom-discuss about older Bamboo's > PAD not working right with recent xf86-input-wacom's. This device is > handled by Graphire driver in kernel. The reason is related to interaction of multipl

[Linuxwacom-devel] Graphire's and PAD issues

2011-03-14 Thread Chris Bagwell
Hi all, This is related to thread on linuxwacom-discuss about older Bamboo's PAD not working right with recent xf86-input-wacom's. This device is handled by Graphire driver in kernel. The reason is related to interaction of multiple recent code submissions. But the root issue to me is a kernel

Re: [Linuxwacom-devel] [PATCH v2 5/5] Add tests for convert_value_from_user

2011-03-14 Thread Chris Bagwell
On Mon, Mar 14, 2011 at 1:09 AM, Peter Hutterer wrote: > On Fri, Mar 11, 2011 at 03:13:55PM -0800, Jason Gerecke wrote: >> Some basic tests to ensure booleans and non-booleans act like we >> want them to. >> >> Signed-off-by: Jason Gerecke >> --- >>  tools/xsetwacom.c |   43 +