Re: [Linuxwacom-devel] [PATCH v2 2/5] Detect boolean conversion failure in convert_value_from_user

2011-03-14 Thread Peter Hutterer
On Fri, Mar 11, 2011 at 03:13:52PM -0800, Jason Gerecke wrote: Properties with PROP_FLAG_BOOLEAN set can only take on a restricted set of values. We detect if the string matches any of the allowed values and convert if possible. If not possible, the caller is notified. Signed-off-by: Jason

Re: [Linuxwacom-devel] [PATCH v2 3/5] Use strtol instead of atoi in convert_value_from_user

2011-03-14 Thread Peter Hutterer
On Fri, Mar 11, 2011 at 03:13:53PM -0800, Jason Gerecke wrote: atoi provides only the most basic string conversion capabilities, and makes determining if conversion was successful difficult (both abc and 0 would return 0). We use strtol and checks to ensure that it converted the entire string

Re: [Linuxwacom-devel] [PATCH v2 4/5] Expand recognized boolean input for convert_value_from_user

2011-03-14 Thread Peter Hutterer
On Fri, Mar 11, 2011 at 03:13:54PM -0800, Jason Gerecke wrote: We remove the case sensitivity requirement for off/on and also allow the use of true and false Signed-off-by: Jason Gerecke killert...@gmail.com --- tools/xsetwacom.c |6 +++--- 1 files changed, 3 insertions(+), 3

Re: [Linuxwacom-devel] [PATCH v2 5/5] Add tests for convert_value_from_user

2011-03-14 Thread Chris Bagwell
On Mon, Mar 14, 2011 at 1:09 AM, Peter Hutterer peter.hutte...@who-t.net wrote: On Fri, Mar 11, 2011 at 03:13:55PM -0800, Jason Gerecke wrote: Some basic tests to ensure booleans and non-booleans act like we want them to. Signed-off-by: Jason Gerecke killert...@gmail.com ---  

Re: [Linuxwacom-devel] Graphire's and PAD issues

2011-03-14 Thread Ping Cheng
On Mon, Mar 14, 2011 at 2:08 PM, Chris Bagwell ch...@cnpbagwell.com wrote: Hi all, This is related to thread on linuxwacom-discuss about older Bamboo's PAD not working right with recent xf86-input-wacom's. This device is handled by Graphire driver in kernel. The reason is related to

Re: [Linuxwacom-devel] Graphire's and PAD issues

2011-03-14 Thread Ping Cheng
On Mon, Mar 14, 2011 at 2:54 PM, Ping Cheng pingli...@gmail.com wrote: On Mon, Mar 14, 2011 at 2:08 PM, Chris Bagwell ch...@cnpbagwell.comwrote: I obviously need some help here since I'm flying blind without the problem device. I can make a kernel patch but can't test it. Part of this

Re: [Linuxwacom-devel] [PATCH] Fix button assignment bug introduced in 22bc3028

2011-03-14 Thread Jason Gerecke
On Sun, Mar 13, 2011 at 11:00 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Fri, Mar 11, 2011 at 04:02:56PM -0800, Jason Gerecke wrote: I just noticed I was unable to map button presses to keys and after some investigation (yay git bisect!) found the following commit caused the bug:

[Linuxwacom-devel] [PATCH v3 1/5] Change signature of convert_value_from_user

2011-03-14 Thread Jason Gerecke
Have it return true/false to indicate conversion success/failure. Note that in its current state the function cannot tell if there was a conversion failure... Signed-off-by: Jason Gerecke killert...@gmail.com --- Changes from v2: * Use val instead of allocating memory tools/xsetwacom.c | 36

[Linuxwacom-devel] [PATCH v3 5/5] Add tests for convert_value_from_user

2011-03-14 Thread Jason Gerecke
Some basic tests to ensure booleans and non-booleans act like we want them to. Signed-off-by: Jason Gerecke killert...@gmail.com --- Changes from v2: * Use val instead of allocating memory tools/xsetwacom.c | 38 ++ 1 files changed, 38 insertions(+), 0

Re: [Linuxwacom-devel] [PATCH v4 1/5] Change signature of convert_value_from_user

2011-03-14 Thread Peter Hutterer
On Mon, Mar 14, 2011 at 04:19:24PM -0700, Jason Gerecke wrote: Have it return true/false to indicate conversion success/failure. Note that in its current state the function cannot tell if there was a conversion failure... Signed-off-by: Jason Gerecke killert...@gmail.com --- Changes from

[Linuxwacom-devel] [PATCH] Add fake symbols for serverClient and QueueWorkProc

2011-03-14 Thread Peter Hutterer
Broke linking of unit tests in 94a8eabadd062de6ceed8563089b863d887f8770. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/fake-symbols.c | 11 ++- test/fake-symbols.h |5 + 2 files changed, 15 insertions(+), 1 deletions(-) diff --git a/test/fake-symbols.c

Re: [Linuxwacom-devel] [PATCH v3 5/5] Add tests for convert_value_from_user

2011-03-14 Thread Peter Hutterer
On Tue, Mar 15, 2011 at 11:36:26AM +1000, Peter Hutterer wrote: On Mon, Mar 14, 2011 at 04:10:59PM -0700, Jason Gerecke wrote: Some basic tests to ensure booleans and non-booleans act like we want them to. Signed-off-by: Jason Gerecke killert...@gmail.com --- Changes from v2:

Re: [Linuxwacom-devel] Graphire's and PAD issues

2011-03-14 Thread Chris Bagwell
On Mon, Mar 14, 2011 at 4:54 PM, Ping Cheng pingli...@gmail.com wrote: On Mon, Mar 14, 2011 at 2:08 PM, Chris Bagwell ch...@cnpbagwell.com wrote: Hi all, This is related to thread on linuxwacom-discuss about older Bamboo's PAD not working right with recent xf86-input-wacom's.  This device is