Hi,
On Thu, Mar 8, 2018 at 7:15 PM, Aaron Armstrong Skomra <sko...@gmail.com> wrote:
>
>
> On Mon, Mar 5, 2018 at 10:32 AM, Benjamin Tissoires
> <benjamin.tissoi...@redhat.com> wrote:
>>
>> We take the same checks for the powersupply API than the one in
This will allow to autodetect it in case someone decides to backport
the new powersupply API in an old kernel...
Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com>
---
3.17/wacom.h | 10 +-
3.17/wacom_sys.c | 18 +-
2 files changed, 14 insertions(
If I am not wrong, struct power_supply_desc is part of the new API.
So check if we can include it in a module and decide based on the
result.
Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com>
---
3.17/wacom.h | 5 +---
3.7/wacom.h | 1 +
configure.a
Patches 1 to 6 are some cleanups that I wrote before being
able to focus on the upcoming RHEL 7.5 release.
The last two patches allows the branches 3.7 and 3.17 to compile
with the new powersupply backports included in 7.5 beta.
Cheers,
Benjamin
Benjamin Tissoires (8):
3.17: add to_hid_device
Allows to have the 3.17 code closer to upstream
Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com>
---
3.17/wacom.h | 6 ++
3.17/wacom_sys.c | 16
2 files changed, 14 insertions(+), 8 deletions(-)
diff --git a/3.17/wacom.h b/3.17/wacom.h
index 0
removes one #ifdef in the code, but it all makes it closer to upstream
Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com>
---
4.5/wacom_sys.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/4.5/wacom_sys.c b/4.5/wacom_sys.c
index e361960..7b6c5d8
There is no real point crippling the file with #ifdef.
I chose to keep the wacom_ prefix to show that this may be overloaded
depending of the context
Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com>
---
3.17/wacom_sys.c | 14 ++
1 file changed, 2 insertions(
The group opened is referenced by the battery description, not the
battery itself.
Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com>
---
3.17/wacom_sys.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/3.17/wacom_sys.c b/3.17/wacom_sys.c
index e
We take the same checks for the powersupply API than the one in the 3.17
branch
Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com>
---
3.7/wacom.h | 18 -
3.7/wacom_sys.c | 113
3.7/wacom_wac.c | 10 ++
kobj_to_dev has been around since 3.6, so there is no point not having
it in the 3.17 code
Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com>
---
3.17/wacom_sys.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/3.17/wacom_sys.c b/3.17/wacom_sys.c
The touchscreen part is not from Wacom, so we need to
teach libwacom and libinput that both are part of the
same device group for them to do touch arbitration.
Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@gmail.com>
---
changes in v2:
- dropped the work around for user space
dat
On Fri, Nov 3, 2017 at 9:15 PM, Aaron Armstrong Skomra <sko...@gmail.com> wrote:
>
>
> On Fri, Nov 3, 2017 at 7:19 AM, Benjamin Tissoires
> <benjamin.tissoi...@gmail.com> wrote:
>>
>> The Dell canvas 27 is an external monitor with pen and touch, but the
>&g
The Dell canvas 27 is an external monitor with pen and touch, but the
pen is provided by Wacom, and the touch by Advanced Silicon.
To have proper touch arbitration, we need to force xf86-input-wacom
to also handle the touch part.
Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@gmail.
The touchscreen part is not from Wacom, so we need to
teach libwacom and libinput that both are part of the
same device group for them to do touch arbitration.
Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@gmail.com>
---
data/dell-canvas-27.table
also make sure g-s-d updates the mode according
to what the hardware provides.
Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com>
---
data/ek-remote.tablet | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/data/ek-remote.tablet b/data/ek-remote.tablet
If g-s-d is to rely on the actual anchor position and orientation of the
labels, we need to make sure our labels are correct.
Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com>
---
new in v2
data/layouts/dtu-1031.svg | 8
data/layouts/intuos-m-p.svg | 4 ++--
The SVG has been squared a bit and aligned properly.
g-s-d still needs fixes to rely on the actual anchors of the SVG,
but this will come later.
Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com>
---
changes in v2:
- fixed to make "make check" happy
data/layou
The ASCII art had a glitch.
The buttons are not left/right. They are all grouped into the same logical
group.
Note that g-s-d now needs to be updated to not count on the button flags
to place the label, but actually rely on the SVG position which is correct.
Signed-off-by: Benjamin Tissoires
with the same LED
notification.
I also incorporated a patch to make sure the text-anchor are properly set
as I want to force g-s-d to rely on this tag to place the text instead of
relyoing on the button group.
Cheers,
Benjamin
Benjamin Tissoires (3):
Fixes for the Wacom ExpressKey Remote SVG
layouts: fix
On Fri, Apr 1, 2016 at 12:35 AM, Aaron Armstrong Skomra
<sko...@gmail.com> wrote:
>
> On Thu, Mar 31, 2016 at 11:45 AM, Benjamin Tissoires
> <benjamin.tissoi...@gmail.com> wrote:
>>
>> On Thu, Mar 31, 2016 at 5:12 PM, Benjamin Tissoires
>> <benjamin.ti
On Thu, Mar 31, 2016 at 5:12 PM, Benjamin Tissoires
<benjamin.tissoi...@redhat.com> wrote:
> Used gnome-settings-daemon to spot few tweaks required:
> - the left and right buttons should be inverted or the
> label is misplaced
> - the SVG has been squared a bit and aligned p
Used gnome-settings-daemon to spot few tweaks required:
- the left and right buttons should be inverted or the
label is misplaced
- the SVG has been squared a bit and aligned properly
Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com>
---
Hi,
while playing with the Expr
On Sun, Mar 15, 2015 at 10:01 PM, Peter Hutterer
peter.hutte...@who-t.net wrote:
On Fri, Mar 13, 2015 at 11:24:27AM -0400, Benjamin Tissoires wrote:
commit 0cfe113 (Allow PAD only interface without setting up EV_ABS
and/or EV_X/Y) allows xf86-input-wacom to handle Pad only interface
On Mar 13 2015 or thereabouts, Bastien Nocera wrote:
On Fri, 2015-03-13 at 11:30 -0400, Benjamin Tissoires wrote:
To support generic tablets, we need to extend the matching pattern
of libwacom. The Huion tablets reuse the same VID:PID accross all of
the products. To be able
On Mar 13 2015 or thereabouts, Bastien Nocera wrote:
On Fri, 2015-03-13 at 11:30 -0400, Benjamin Tissoires wrote:
+Name=General Pen w/o Eraser
Write this spelled out. This gets in the UI...
Amended as General Pen with no Eraser locally (but I am open to any
suggestions).
Benjamin
To support generic tablets, we need to extend the matching pattern of
libwacom. The Huion tablets reuse the same VID:PID accross all of the
products. To be able to differentiate between the models, we can somewhat
rely on the name of the product. It doesn't seem very reliable (for
instance, the
---
changed in v2:
- renamed 0xd stylus in General Pen with no Eraser
data/huion-h610-pro.tablet | 23 ++
data/layouts/huion-h610-pro.svg | 153
data/libwacom.stylus| 7 ++
3 files changed, 183 insertions(+)
create mode
The match count (and update to the first correct) has to be done
in libwacom_parse_tablet_keyfile() now.
---
New in v2 (requested by Bastien)
libwacom/libwacom-database.c | 76 +---
1 file changed, 36 insertions(+), 40 deletions(-)
diff --git
To support generic tablets, we need to extend the matching pattern of
libwacom. The Huion tablets reuse the same VID:PID accross all of the
products. To be able to differentiate between the models, we can somewhat
rely on the name of the product. It doesn't seem very reliable (for
instance, the
---
no changes in v3
data/huion-h610-pro.tablet | 23 ++
data/layouts/huion-h610-pro.svg | 153
data/libwacom.stylus| 7 ++
3 files changed, 183 insertions(+)
create mode 100644 data/huion-h610-pro.tablet
create mode 100644
The match count (and update to the first correct) has to be done
in libwacom_parse_tablet_keyfile() now.
---
changes in v3:
- libwacom_matchstr_to_match now returns a gboolean
new in v2
libwacom/libwacom-database.c | 81 +---
1 file changed, 39
---
data/huion-h610-pro.tablet | 23 ++
data/layouts/huion-h610-pro.svg | 153
data/libwacom.stylus| 7 ++
3 files changed, 183 insertions(+)
create mode 100644 data/huion-h610-pro.tablet
create mode 100644
commit 0cfe113 (Allow PAD only interface without setting up EV_ABS
and/or EV_X/Y) allows xf86-input-wacom to handle Pad only interface but
such interface do not report any events.
We need to call usbWcmInitPadState() to be able to forward events.
Signed-off-by: Benjamin Tissoires benjamin.tissoi
On Fri, Feb 20, 2015 at 1:55 AM, Peter Hutterer
peter.hutte...@who-t.net wrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
Actually, the artpen we have does not report rotation on the eraser side.
So I guess we should drop the capability for them.
Cheers,
Benjamin
On Wed, Feb 11, 2015 at 8:50 PM, Peter Hutterer
peter.hutte...@who-t.net wrote:
Match string is identical to the other tags, but we only append PAD if we have
at least one button. The kernel enforces the ... Pad naming so we might as
well rely on it.
Signed-off-by: Peter Hutterer
Hi Jason,
On Mon, Jan 12, 2015 at 2:48 PM, Jason Gerecke killert...@gmail.com wrote:
The following patches have been merged by linus into his 3.19 tree and
need to be applied to input-wacom as well.
Benjamin Tissoires (1):
HID: wacom: re-add accidentally dropped Lenovo PID
Jason Gerecke
On Thu, Jan 8, 2015 at 3:55 PM, Jason Gerecke killert...@gmail.com wrote:
I do not have a Bamboo Pad, but I've heard that people have had
success getting it to work using the steps described at [1].
Unfortunately, the workaround stopped working in Linux 3.17, so please
check that first.
[1]:
PID of the
tablet connected through the wireless receiver when the following kernel
patch (or its sucessor) will be merged in 3.18:
https://patchwork.kernel.org/patch/4889811/
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
Reviewed-by: Bastien Nocera had...@hadess.net
---
Changes
On Mon, Sep 15, 2014 at 12:27 AM, Peter Hutterer
peter.hutte...@who-t.net wrote:
On Thu, Sep 11, 2014 at 03:25:45PM -0400, Benjamin Tissoires wrote:
PRODUCT attribute is set correctly for the input device, whether the
device is USB or Bluetooth. We can use a common path for those two.
uinput
PID of the
tablet connected through the wireless receiver when the following kernel
patch (or its sucessor) will be merged in 3.18:
https://patchwork.kernel.org/patch/4889811/
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
Hi,
so this is the second part of the kernel patch
PID of the
tablet connected through the wireless receiver when the following kernel
patch (or its sucessor) will be merged in 3.18:
https://patchwork.kernel.org/patch/4889811/
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
Changes in v2:
- use g_strsplit and strtol/strtoul
On Sep 11 2014 or thereabouts, Bastien Nocera wrote:
On Thu, 2014-09-11 at 14:45 -0400, Benjamin Tissoires wrote:
+ /* Parse the PRODUCT attribute (for Bluetooth and USB) */
+ retval = get_bus_vid_pid (device, bus, vendor_id, product_id,
error);
+ if (retval
PID of the
tablet connected through the wireless receiver when the following kernel
patch (or its sucessor) will be merged in 3.18:
https://patchwork.kernel.org/patch/4889811/
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
Changes in v3:
- renamed bail to out as suggested
On Thu, Sep 11, 2014 at 3:25 PM, Benjamin Tissoires
benjamin.tissoi...@redhat.com wrote:
PRODUCT attribute is set correctly for the input device, whether the
device is USB or Bluetooth. We can use a common path for those two.
uinput devices have their PRODUCT attribute set according
On Thu, Jul 10, 2014 at 8:10 PM, Jason Gerecke killert...@gmail.com wrote:
On Mon, Jun 30, 2014 at 2:26 PM, Benjamin Tissoires
benjamin.tissoi...@redhat.com wrote:
Wacom tablets can share different physical sensors on one physical device.
These are called siblings in the code. The current way
On Thu, Jul 10, 2014 at 9:09 PM, Jason Gerecke killert...@gmail.com wrote:
On Mon, Jun 30, 2014 at 2:26 PM, Benjamin Tissoires
benjamin.tissoi...@redhat.com wrote:
This removes an USB dependency and is more accurate: the computed pktlen
is the actual maximum size of the reports forwarded
On Thu, Jul 10, 2014 at 8:18 PM, Jason Gerecke killert...@gmail.com wrote:
On Mon, Jun 23, 2014 at 1:57 PM, Benjamin Tissoires
benjamin.tissoi...@redhat.com wrote:
Currently, the pad events are sent through the stylus input device
for the Intuos/Cintiqs, and through the touch input device
Hi Przemo,
On Thu, Jul 10, 2014 at 5:30 PM, Przemo Firszt prz...@firszt.eu wrote:
Hi Benjamin,
I'm having some problems to cleanly apply your patches - can you double
check that they are OK?
These patches relies on a previous patchset I sent earlier. So they do
not apply cleanly on top of
,
instead of bluetooth or usb.
This change is also required for USB if the path is taken to switch from
a plain USB driver to a HID one (https://patchwork.kernel.org/patch/4454631/)
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
changes in v2:
- add parenthesis around
,
instead of bluetooth or usb. And as a result, bluetooth devices are ignored
by libwacom.
This change is also required for USB if the path is taken to switch from
a plain USB driver to a HID one (https://patchwork.kernel.org/patch/4454631/)
Signed-off-by: Benjamin Tissoires benjamin.tissoi
Hi Przemo,
On Jul 03 2014 or thereabouts, Przemo Firszt wrote:
Quoting Benjamin Tissoires benjamin.tissoi...@redhat.com:
Removes one more dependency over USB, but requires some changes in
the user space to find the sysfs files correctly.
This patch breaks the user space. However
On Mon, Jun 30, 2014 at 5:26 PM, Benjamin Tissoires
benjamin.tissoi...@redhat.com wrote:
No Functional changes, just some reordering.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
drivers/input/tablet/wacom_wac.c | 75
1 file
HID core already retrieves the report descritor. There is no need
to ask ourself for one.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
drivers/input/tablet/wacom_sys.c | 70 ++--
1 file changed, 10 insertions(+), 60 deletions(-)
diff
. There is thus a one to one matching between the list
of supported devices before and after the switch from USB to HID.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
drivers/hid/hid-core.c | 15 ++-
drivers/hid/hid-wacom.c | 2 +-
drivers/input/tablet/wacom.h
Use the HID device as the parent for the power device when dealing with
a wireless receiver.
Removes one more usb dependency and does not break user space.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
drivers/input/tablet/wacom_sys.c | 4 ++--
1 file changed, 2 insertions
: This patch series requires the current pending wacom patches to be
applied.
I set up a tree with all the patch applied if anyone wants to give a try:
https://github.com/bentiss/linux/commits/hid-wacom-legacy-3.16-rc3
Cheers,
Benjamin
Benjamin Tissoires (15):
Input - wacom: include and use linux/hid.h
pktlen is now overwritten by the driver directly by reading the hid
report descriptor. There is no need to declare it statically.
We also move down the position of the field in the struct so that
we can keep the current declaration of Wacom devices.
Signed-off-by: Benjamin Tissoires
agnostic of the
USB layer, except for the Wireless Receiver. That means that starting
from now, we can check every changes through uhis and comparing the
resulting kernel device.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
drivers/hid/uhid.c | 2 ++
drivers
of the field in the report descriptor
- in the hid.h, those are bitmask
So add HDESC_ in their current definition.
Also, the struct hid_descriptor slightly differs from the linux/hid.h
point of view, so mark it as custom for this driver.
Signed-off-by: Benjamin Tissoires benjamin.tissoi
of
the code.
Likewise, this information is not mandatory anymore in the description
of devices in wacom_wac.c. They will be removed in a separate patch.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
drivers/input/tablet/wacom_sys.c | 58 ++--
1 file
This may infer a small difference with the previous implementation
due to the DIV_ROUND_CLOSEST() in the hid implementation.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
drivers/input/tablet/wacom_sys.c | 48
1 file changed, 9
regression tests.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
drivers/input/tablet/wacom_sys.c | 81 ++--
1 file changed, 36 insertions(+), 45 deletions(-)
diff --git a/drivers/input/tablet/wacom_sys.c b/drivers/input/tablet/wacom_sys.c
to the matched device.
To be sure that we are not associating different sensors from different
physical devices, we also check for the phys path of the hid device which
contains the USB topology.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
drivers/input/tablet/wacom_sys.c | 75
soon.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
drivers/input/tablet/wacom.h | 1 -
drivers/input/tablet/wacom_sys.c | 15 ---
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/input/tablet/wacom.h b/drivers/input/tablet/wacom.h
index
-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
drivers/input/tablet/wacom_sys.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/input/tablet/wacom_sys.c b/drivers/input/tablet/wacom_sys.c
index 3f1cee6..6f4bf6d 100644
--- a/drivers/input
Removes one more need of usb and intf.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
drivers/input/tablet/wacom_sys.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/input/tablet/wacom_sys.c b/drivers/input/tablet/wacom_sys.c
index
No Functional changes, just some reordering.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
drivers/input/tablet/wacom_wac.c | 75
1 file changed, 37 insertions(+), 38 deletions(-)
diff --git a/drivers/input/tablet/wacom_wac.c b
Hi Ping,
On Jun 23 2014 or thereabouts, Ping Cheng wrote:
Hi Benjamin,
On Mon, Jun 23, 2014 at 1:57 PM, Benjamin Tissoires
benjamin.tissoi...@redhat.com wrote:
Currently, the pad events are sent through the stylus input device
for the Intuos/Cintiqs, and through the touch input device
68 matches
Mail list logo
